Require parent when using node factory in CI config

1 files changed, 36 insertions, 7 deletions

diff --git a/spec/lib/gitlab/ci/config/node/factory_spec.rb b/spec/lib/gitlab/ci/config/node/factory_spec.rb
index c912b1b2044..bc6bf32ffbf 100644
--- a/spec/lib/gitlab/ci/config/node/factory_spec.rb
+++ b/spec/lib/gitlab/ci/config/node/factory_spec.rb
@@ -2,22 +2,40 @@ require 'spec_helper'
 
 describe Gitlab::Ci::Config::Node::Factory do
   describe '#create!' do
-    let(:factory) { described_class.new(entry_class) }
-    let(:entry_class) { Gitlab::Ci::Config::Node::Script }
+    let(:factory) { described_class.new(node) }
+    let(:node) { Gitlab::Ci::Config::Node::Script }
+    let(:parent) { double('parent') }
+    let(:global) { double('global') }
 
-    context 'when setting up a value' do
+    before do
+      allow(parent).to receive(:global).and_return(global)
+    end
+
+    context 'when setting a concrete value' do
       it 'creates entry with valid value' do
         entry = factory
           .value(['ls', 'pwd'])
+          .parent(parent)
           .create!
 
         expect(entry.value).to eq ['ls', 'pwd']
       end
 
+      it 'sets parent and global attributes' do
+        entry = factory
+          .value('ls')
+          .parent(parent)
+          .create!
+
+        expect(entry.global).to eq global
+        expect(entry.parent).to eq parent
+      end
+
       context 'when setting description' do
         it 'creates entry with description' do
           entry = factory
             .value(['ls', 'pwd'])
+            .parent(parent)
             .with(description: 'test description')
             .create!
 
@@ -30,6 +48,7 @@ describe Gitlab::Ci::Config::Node::Factory do
         it 'creates entry with custom key' do
           entry = factory
             .value(['ls', 'pwd'])
+            .parent(parent)
             .with(key: 'test key')
             .create!
 
@@ -38,20 +57,21 @@ describe Gitlab::Ci::Config::Node::Factory do
       end
 
       context 'when setting a parent' do
-        let(:parent) { Object.new }
+        let(:object) { Object.new }
 
         it 'creates entry with valid parent' do
           entry = factory
             .value('ls')
-            .with(parent: parent)
+            .parent(parent)
+            .with(parent: object)
             .create!
 
-          expect(entry.parent).to eq parent
+          expect(entry.parent).to eq object
         end
       end
     end
 
-    context 'when not setting up a value' do
+    context 'when not setting a value' do
       it 'raises error' do
         expect { factory.create! }.to raise_error(
           Gitlab::Ci::Config::Node::Factory::InvalidFactory
@@ -59,10 +79,19 @@ describe Gitlab::Ci::Config::Node::Factory do
       end
     end
 
+    context 'when not setting parent object' do
+      it 'raises error' do
+        expect { factory.value('ls').create! }.to raise_error(
+          Gitlab::Ci::Config::Node::Factory::InvalidFactory
+        )
+      end
+    end
+
     context 'when creating entry with nil value' do
       it 'creates an undefined entry' do
         entry = factory
           .value(nil)
+          .parent(parent)
           .create!
 
         expect(entry).to be_an_instance_of Gitlab::Ci::Config::Node::Undefined