diff options
| author | Mehdi Lahmam <mehdi@lahmam.com> | 2018-09-06 22:33:38 +0200 |
|---|---|---|
| committer | Mehdi Lahmam <mehdi@lahmam.com> | 2018-09-06 22:39:20 +0200 |
| commit | e39962b019dcdf675875e7cf7d62d375345b7c03 (patch) | |
| tree | f6c758cda99f5eecbb3ee917e39d414405ede87a /spec | |
| parent | 9feb145cc97856e20187122f934bd0fc6e467f55 (diff) | |
| download | gitlab-ce-e39962b019dcdf675875e7cf7d62d375345b7c03.tar.gz | |
Prefer `sign_in` over `gitlab_sign_in` as its faster
Devise helpers acts on Warden which is faster than our own helpers.
Note that `gitlab_sign_out` is still necessary due to the same issue
mentioned at 60814985e033e4941ff3eb5d33ca55e3fc81593e
Diffstat (limited to 'spec')
| -rw-r--r-- | spec/support/features/issuable_quick_actions_shared_examples.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/spec/support/features/issuable_quick_actions_shared_examples.rb b/spec/support/features/issuable_quick_actions_shared_examples.rb index fa2b3db3bdf..846e697eb96 100644 --- a/spec/support/features/issuable_quick_actions_shared_examples.rb +++ b/spec/support/features/issuable_quick_actions_shared_examples.rb @@ -309,7 +309,7 @@ shared_examples 'issuable record that supports quick actions in its description project.add_guest(guest) gitlab_sign_out - gitlab_sign_in(guest) + sign_in(guest) visit public_send("project_#{issuable_type}_path", project, issuable) end @@ -346,7 +346,7 @@ shared_examples 'issuable record that supports quick actions in its description project.add_guest(guest) gitlab_sign_out - gitlab_sign_in(guest) + sign_in(guest) visit public_send("project_#{issuable_type}_path", project, issuable) end |