Memoize non-existent custom appearancessh-strong-memoize-appearances

This saves about 5 SQL calls per page if no custom appearance is
specified.

1 files changed, 16 insertions, 0 deletions

diff --git a/spec/helpers/appearances_helper_spec.rb b/spec/helpers/appearances_helper_spec.rb
index a3511e078ce..ed3e31b3c53 100644
--- a/spec/helpers/appearances_helper_spec.rb
+++ b/spec/helpers/appearances_helper_spec.rb
@@ -8,6 +8,22 @@ describe AppearancesHelper do
     allow(helper).to receive(:current_user).and_return(user)
   end
 
+  describe '.current_appearance' do
+    it 'memoizes empty appearance' do
+      expect(Appearance).to receive(:current).once
+
+      2.times { helper.current_appearance }
+    end
+
+    it 'memoizes custom appearance' do
+      create(:appearance)
+
+      expect(Appearance).to receive(:current).once.and_call_original
+
+      2.times { helper.current_appearance }
+    end
+  end
+
   describe '#header_message' do
     it 'returns nil when header message field is not set' do
       create(:appearance)