summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorSean McGivern <sean@mcgivern.me.uk>2016-12-28 15:16:42 +0000
committerSean McGivern <sean@mcgivern.me.uk>2016-12-28 15:16:42 +0000
commitb32176bce606d2a09326f7e391942ecfb8f1a74e (patch)
tree4c68da5dbec777a72fe1b5f4d274a596a2eba438 /spec
parent0d930161525032b7289d480d3ee6924e3ef10e6f (diff)
parent7f1d954873263b5406bdd25afa02b06013cb70e3 (diff)
downloadgitlab-ce-b32176bce606d2a09326f7e391942ecfb8f1a74e.tar.gz
Merge branch 'dz-improve-admin-group-routing' into 'master'
Fix 500 error when visit group from admin area if group name contains dot See merge request !8342
Diffstat (limited to 'spec')
-rw-r--r--spec/routing/admin_routing_spec.rb10
1 files changed, 8 insertions, 2 deletions
diff --git a/spec/routing/admin_routing_spec.rb b/spec/routing/admin_routing_spec.rb
index 661b671301e..99c44bde151 100644
--- a/spec/routing/admin_routing_spec.rb
+++ b/spec/routing/admin_routing_spec.rb
@@ -122,12 +122,18 @@ describe Admin::HealthCheckController, "routing" do
end
describe Admin::GroupsController, "routing" do
+ let(:name) { 'complex.group-namegit' }
+
it "to #index" do
expect(get("/admin/groups")).to route_to('admin/groups#index')
end
it "to #show" do
- expect(get("/admin/groups/gitlab")).to route_to('admin/groups#show', id: 'gitlab')
- expect(get("/admin/groups/gitlab/subgroup")).to route_to('admin/groups#show', id: 'gitlab/subgroup')
+ expect(get("/admin/groups/#{name}")).to route_to('admin/groups#show', id: name)
+ expect(get("/admin/groups/#{name}/subgroup")).to route_to('admin/groups#show', id: "#{name}/subgroup")
+ end
+
+ it "to #edit" do
+ expect(get("/admin/groups/#{name}/edit")).to route_to('admin/groups#edit', id: name)
end
end