Refactor SessionsController

Also adds test case for providing an invalid 2FA code and then a valid
one without re-entering username and password.

1 files changed, 8 insertions, 0 deletions

diff --git a/spec/features/login_spec.rb b/spec/features/login_spec.rb
index 5ffaae54766..f1e24c54240 100644
--- a/spec/features/login_spec.rb
+++ b/spec/features/login_spec.rb
@@ -31,6 +31,14 @@ feature 'Login' do
           enter_code('foo')
           expect(page).to have_content('Invalid two-factor code')
         end
+
+        it 'allows login with invalid code, then valid code' do
+          enter_code('foo')
+          expect(page).to have_content('Invalid two-factor code')
+
+          enter_code(user.current_otp)
+          expect(current_path).to eq root_path
+        end
       end
 
       context 'using backup code' do