diff options
| author | Sytse Sijbrandij <sytse@dosire.com> | 2012-09-21 18:22:43 +0200 |
|---|---|---|
| committer | Sytse Sijbrandij <sytse@dosire.com> | 2012-09-24 16:48:10 +0200 |
| commit | f3ce02b5c944e5956eb7208506ec513623d092d8 (patch) | |
| tree | dd2af9f7083fbcb2ccb75988d31607fa7953c195 /spec | |
| parent | 8f9a450eedc5b5fc13e24788ab67f2de928dd83a (diff) | |
| download | gitlab-ce-f3ce02b5c944e5956eb7208506ec513623d092d8.tar.gz | |
Reject ssh keys that break gitolite.
Failing test.
Working check.
Diffstat (limited to 'spec')
| -rw-r--r-- | spec/factories.rb | 12 | ||||
| -rw-r--r-- | spec/models/key_spec.rb | 12 |
2 files changed, 19 insertions, 5 deletions
diff --git a/spec/factories.rb b/spec/factories.rb index 92790a3fdb7..848fc01ff1d 100644 --- a/spec/factories.rb +++ b/spec/factories.rb @@ -83,11 +83,7 @@ FactoryGirl.define do factory :key do title key do - """ - ssh-rsa AAAAB3NzaC1yc2EAAAABJQAAAIEAiPWx6WM4lhHNedGfBpPJNPpZ7yKu+dnn1SJejgt4 - 596k6YjzGGphH2TUxwKzxcKDKKezwkpfnxPkSMkuEspGRt/aZZ9wa++Oi7Qkr8prgHc4 - soW6NUlfDzpvZK2H5E7eQaSeP3SAwGmQKUFHCddNaP0L+hM7zhFNzjFvpaMgJw0= - """ + "ssh-rsa AAAAB3NzaC1yc2EAAAABJQAAAIEAiPWx6WM4lhHNedGfBpPJNPpZ7yKu+dnn1SJejgt4596k6YjzGGphH2TUxwKzxcKDKKezwkpfnxPkSMkuEspGRt/aZZ9wa++Oi7Qkr8prgHc4soW6NUlfDzpvZK2H5E7eQaSeP3SAwGmQKUFHCddNaP0L+hM7zhFNzjFvpaMgJw0=" end factory :deploy_key do @@ -97,6 +93,12 @@ FactoryGirl.define do factory :personal_key do user end + + factory :key_with_a_space_in_the_middle do + key do + "ssh-rsa AAAAB3NzaC1yc2EAAAABJQAAAIEAiPWx6WM4lhHNedGfBpPJNPpZ7yKu+dnn1SJejgt4596k6YjzGGphH2TUxwKzxcKDKKezwkpfnxPkSMkuEspGRt/aZZ9wa ++Oi7Qkr8prgHc4soW6NUlfDzpvZK2H5E7eQaSeP3SAwGmQKUFHCddNaP0L+hM7zhFNzjFvpaMgJw0=" + end + end end factory :milestone do diff --git a/spec/models/key_spec.rb b/spec/models/key_spec.rb index 85cd291d681..9bb31a16483 100644 --- a/spec/models/key_spec.rb +++ b/spec/models/key_spec.rb @@ -46,4 +46,16 @@ describe Key do end end end + + context "validate it is a fingerprintable key" do + let(:user) { Factory.create(:user) } + + it "accepts the fingerprintable key" do + build(:key, user: user).should be_valid + end + + it "rejects the unfingerprintable key" do + build(:key_with_a_space_in_the_middle).should_not be_valid + end + end end |
