diff options
author | Grzegorz Bizon <grzegorz@gitlab.com> | 2018-01-23 07:42:14 +0000 |
---|---|---|
committer | Grzegorz Bizon <grzegorz@gitlab.com> | 2018-01-23 07:42:14 +0000 |
commit | b472411efb238ae223f99ecda067fa22d25bf8bb (patch) | |
tree | d97336e5d188c0ca8110cfa21ffcb5e11d139a12 /spec | |
parent | 4bf2fded92e05420e6d103c8df63d6d83198a684 (diff) | |
parent | c414ab84608cc7f7e1f5363835a611650f3cba7d (diff) | |
download | gitlab-ce-b472411efb238ae223f99ecda067fa22d25bf8bb.tar.gz |
Merge branch '42119-non-triggered' into 'master'
Resolve ""This job has not been triggered yet" after hitting "Retry""
Closes #42119
See merge request gitlab-org/gitlab-ce!16583
Diffstat (limited to 'spec')
-rw-r--r-- | spec/features/projects/jobs_spec.rb | 20 |
1 files changed, 17 insertions, 3 deletions
diff --git a/spec/features/projects/jobs_spec.rb b/spec/features/projects/jobs_spec.rb index a5cd858b11a..e661db1809a 100644 --- a/spec/features/projects/jobs_spec.rb +++ b/spec/features/projects/jobs_spec.rb @@ -384,12 +384,12 @@ feature 'Jobs' do expect(page).to have_link('Trigger this manual action') end - it 'plays manual action', :js do + it 'plays manual action and shows pending status', :js do click_link 'Trigger this manual action' wait_for_requests - expect(page).to have_content('This job has not been triggered') - expect(page).to have_content('This job is stuck, because the project doesn\'t have any runners online assigned to it.') + expect(page).to have_content('This job has not started yet') + expect(page).to have_content('This job is in pending state and is waiting to be picked by a runner') expect(page).to have_content('pending') end end @@ -403,6 +403,20 @@ feature 'Jobs' do it 'shows empty state' do expect(page).to have_content('This job has not been triggered yet') + expect(page).to have_content('This job depends on upstream jobs that need to succeed in order for this job to be triggered') + end + end + + context 'Pending job' do + let(:job) { create(:ci_build, :pending, pipeline: pipeline) } + + before do + visit project_job_path(project, job) + end + + it 'shows pending empty state' do + expect(page).to have_content('This job has not started yet') + expect(page).to have_content('This job is in pending state and is waiting to be picked by a runner') end end end |