diff options
author | Stan Hu <stanhu@gmail.com> | 2018-06-01 18:56:21 +0000 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2018-06-01 18:56:21 +0000 |
commit | 2de002b3db1bc199755f8be212fa8804fcb80905 (patch) | |
tree | 0c4460d62cd6a0b653b2d77e29447093ccb4933e /spec | |
parent | 81e899ea7141b34a7860f308327249784fb5d6cc (diff) | |
parent | c9cf677e20737aa9f8a824ec2e51b4ed12bc8ea4 (diff) | |
download | gitlab-ce-2de002b3db1bc199755f8be212fa8804fcb80905.tar.gz |
Merge branch 'fix-feature-memoization' into 'master'
Use RequestStore to memoize Flipper features so that memoized values are cleared between requests
See merge request gitlab-org/gitlab-ce!19281
Diffstat (limited to 'spec')
-rw-r--r-- | spec/lib/feature_spec.rb | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/spec/lib/feature_spec.rb b/spec/lib/feature_spec.rb index 10020511bf8..6eb10497428 100644 --- a/spec/lib/feature_spec.rb +++ b/spec/lib/feature_spec.rb @@ -64,4 +64,28 @@ describe Feature do expect(described_class.all).to eq(features.to_a) end end + + describe '.flipper' do + shared_examples 'a memoized Flipper instance' do + it 'memoizes the Flipper instance' do + expect(Flipper).to receive(:new).once.and_call_original + + 2.times do + described_class.flipper + end + end + end + + context 'when request store is inactive' do + before do + described_class.instance_variable_set(:@flipper, nil) + end + + it_behaves_like 'a memoized Flipper instance' + end + + context 'when request store is inactive', :request_store do + it_behaves_like 'a memoized Flipper instance' + end + end end |