diff options
author | Heinrich Lee Yu <heinrich@gitlab.com> | 2019-08-06 15:33:51 +0800 |
---|---|---|
committer | Heinrich Lee Yu <heinrich@gitlab.com> | 2019-08-09 10:04:08 +0800 |
commit | b4b1f69a0bc9cc7296790ba4c777e5c953fa6ddd (patch) | |
tree | 50ae453d1e8c4cba4b0683a2b972d171919453ea /spec | |
parent | 44aa23b9ab7341836e00968ea82b6725f3318a21 (diff) | |
download | gitlab-ce-b4b1f69a0bc9cc7296790ba4c777e5c953fa6ddd.tar.gz |
Remove default relative_position value13208-epicissue-has-an-unexpected-default-relative-position-ce
This makes `epic_issues` consistent with other tables
using our `RelativePositioning` class
Diffstat (limited to 'spec')
-rw-r--r-- | spec/support/shared_examples/relative_positioning_shared_examples.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/spec/support/shared_examples/relative_positioning_shared_examples.rb b/spec/support/shared_examples/relative_positioning_shared_examples.rb index 9837ba806db..b7382cea93c 100644 --- a/spec/support/shared_examples/relative_positioning_shared_examples.rb +++ b/spec/support/shared_examples/relative_positioning_shared_examples.rb @@ -17,8 +17,8 @@ RSpec.shared_examples 'a class that supports relative positioning' do describe '.move_nulls_to_end' do it 'moves items with null relative_position to the end' do - skip("#{item1} has a default relative position") if item1.relative_position - skip("#{item2} has a default relative position") if item2.relative_position + item1.update!(relative_position: nil) + item2.update!(relative_position: nil) described_class.move_nulls_to_end([item1, item2]) @@ -28,7 +28,7 @@ RSpec.shared_examples 'a class that supports relative positioning' do end it 'moves the item near the start position when there are no existing positions' do - skip("#{item1} has a default relative position") if item1.relative_position + item1.update!(relative_position: nil) described_class.move_nulls_to_end([item1]) |