diff options
author | Douwe Maan <douwe@selenight.nl> | 2016-11-23 20:00:58 +0800 |
---|---|---|
committer | Douwe Maan <douwe@selenight.nl> | 2016-11-23 20:02:14 +0800 |
commit | f2a0c6f6bf768db8837283ad65fe6790b9105d26 (patch) | |
tree | 069462cbabd3e24e4fbd15bbfa65865a5c19c21f /spec | |
parent | d0c0c75ca9568bc3ec00c341a6053623d85e6201 (diff) | |
download | gitlab-ce-f2a0c6f6bf768db8837283ad65fe6790b9105d26.tar.gz |
Correctly determine mergeability of MR with no discussions24863-mrs-without-discussions-are-mergeable
Diffstat (limited to 'spec')
-rw-r--r-- | spec/models/merge_request_spec.rb | 54 |
1 files changed, 54 insertions, 0 deletions
diff --git a/spec/models/merge_request_spec.rb b/spec/models/merge_request_spec.rb index 0b4277b1edd..58ccd056328 100644 --- a/spec/models/merge_request_spec.rb +++ b/spec/models/merge_request_spec.rb @@ -937,6 +937,16 @@ describe MergeRequest, models: true do expect(merge_request.mergeable_discussions_state?).to be_falsey end end + + context 'with no discussions' do + before do + merge_request.notes.destroy_all + end + + it 'returns true' do + expect(merge_request.mergeable_discussions_state?).to be_truthy + end + end end context 'when project.only_allow_merge_if_all_discussions_are_resolved == false' do @@ -1198,6 +1208,50 @@ describe MergeRequest, models: true do end end end + + describe "#discussions_to_be_resolved?" do + context "when discussions are not resolvable" do + before do + allow(subject).to receive(:discussions_resolvable?).and_return(false) + end + + it "returns false" do + expect(subject.discussions_to_be_resolved?).to be false + end + end + + context "when discussions are resolvable" do + before do + allow(subject).to receive(:discussions_resolvable?).and_return(true) + + allow(first_discussion).to receive(:resolvable?).and_return(true) + allow(second_discussion).to receive(:resolvable?).and_return(false) + allow(third_discussion).to receive(:resolvable?).and_return(true) + end + + context "when all resolvable discussions are resolved" do + before do + allow(first_discussion).to receive(:resolved?).and_return(true) + allow(third_discussion).to receive(:resolved?).and_return(true) + end + + it "returns false" do + expect(subject.discussions_to_be_resolved?).to be false + end + end + + context "when some resolvable discussions are not resolved" do + before do + allow(first_discussion).to receive(:resolved?).and_return(true) + allow(third_discussion).to receive(:resolved?).and_return(false) + end + + it "returns true" do + expect(subject.discussions_to_be_resolved?).to be true + end + end + end + end end describe '#conflicts_can_be_resolved_in_ui?' do |