Merge branch '57493-add-limit-to-user-name' into 'master'

Add a length limit of 128 char to the user name field

See merge request gitlab-org/gitlab-ce!26146

2 files changed, 26 insertions, 0 deletions

diff --git a/spec/migrations/truncate_user_fullname_spec.rb b/spec/migrations/truncate_user_fullname_spec.rb
new file mode 100644
index 00000000000..17fd4d9f688
--- /dev/null
+++ b/spec/migrations/truncate_user_fullname_spec.rb
@@ -0,0 +1,21 @@
+require 'spec_helper'
+require Rails.root.join('db', 'migrate', '20190325080727_truncate_user_fullname.rb')
+
+describe TruncateUserFullname, :migration do
+  let(:users) { table(:users) }
+
+  let(:user_short) { create_user(name: 'abc', email: 'test_short@example.com') }
+  let(:user_long) { create_user(name: 'a' * 200 + 'z', email: 'test_long@example.com') }
+
+  def create_user(params)
+    users.create!(params.merge(projects_limit: 0))
+  end
+
+  it 'truncates user full name to the first 128 characters' do
+    expect { migrate! }.to change { user_long.reload.name }.to('a' * 128)
+  end
+
+  it 'does not truncate short names' do
+    expect { migrate! }.not_to change { user_short.reload.name.length }
+  end
+end
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb
index b7e36748fa2..a45a2737b13 100644
--- a/spec/models/user_spec.rb
+++ b/spec/models/user_spec.rb
@@ -98,6 +98,11 @@ describe User do
   end
 
   describe 'validations' do
+    describe 'name' do
+      it { is_expected.to validate_presence_of(:name) }
+      it { is_expected.to validate_length_of(:name).is_at_most(128) }
+    end
+
     describe 'username' do
       it 'validates presence' do
         expect(subject).to validate_presence_of(:username)