summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorSean McGivern <sean@mcgivern.me.uk>2017-04-24 17:28:39 +0000
committerSean McGivern <sean@mcgivern.me.uk>2017-04-24 17:28:39 +0000
commitce559142a64890aa18f6669bc5386509efdd4ac9 (patch)
tree7f0ef1f39016f28fdf6c1008bbd7fdd0b006098f /spec
parente79569546c59e2f634dbd190bac29c978433d256 (diff)
parent63d38a303b47d73b3d97a2c8f8ffb5271d39c13d (diff)
downloadgitlab-ce-ce559142a64890aa18f6669bc5386509efdd4ac9.tar.gz
Merge branch 'dm-fix-position-tracer-for-hidden-lines' into 'master'
Fix commenting on an existing discussion on an unchanged line that is no longer in the diff Closes #31339 See merge request !10888
Diffstat (limited to 'spec')
-rw-r--r--spec/lib/gitlab/diff/position_tracer_spec.rb9
1 files changed, 2 insertions, 7 deletions
diff --git a/spec/lib/gitlab/diff/position_tracer_spec.rb b/spec/lib/gitlab/diff/position_tracer_spec.rb
index c166f83664a..a10a251dc4a 100644
--- a/spec/lib/gitlab/diff/position_tracer_spec.rb
+++ b/spec/lib/gitlab/diff/position_tracer_spec.rb
@@ -569,13 +569,8 @@ describe Gitlab::Diff::PositionTracer, lib: true do
# 1 1 BB
# 2 2 A
- it "returns the new position" do
- expect_new_position(
- old_path: file_name,
- new_path: new_file_name,
- old_line: old_position.new_line,
- new_line: old_position.new_line
- )
+ it "returns nil since the line doesn't exist in the new diffs anymore" do
+ expect(subject).to be_nil
end
end