diff options
author | Camil Staps <info@camilstaps.nl> | 2019-08-03 12:57:33 +0200 |
---|---|---|
committer | Camil Staps <info@camilstaps.nl> | 2019-08-07 20:49:37 +0200 |
commit | e726ed5e128893158f102b87e1407ec0a36fc3ce (patch) | |
tree | 279a9ccc0f22a461da6a4298bc803d60cffc32b1 /spec | |
parent | d2b2486afb5a50ace08bc416be87a1ead12abe3c (diff) | |
download | gitlab-ce-e726ed5e128893158f102b87e1407ec0a36fc3ce.tar.gz |
Handle reviewer comments on !24690
Diffstat (limited to 'spec')
-rw-r--r-- | spec/controllers/projects/starrers_controller_spec.rb | 2 | ||||
-rw-r--r-- | spec/finders/starred_projects_finder_spec.rb | 8 | ||||
-rw-r--r-- | spec/finders/users_star_projects_finder_spec.rb | 8 |
3 files changed, 12 insertions, 6 deletions
diff --git a/spec/controllers/projects/starrers_controller_spec.rb b/spec/controllers/projects/starrers_controller_spec.rb index 2ea80da08ca..863929a2465 100644 --- a/spec/controllers/projects/starrers_controller_spec.rb +++ b/spec/controllers/projects/starrers_controller_spec.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'spec_helper' describe Projects::StarrersController do diff --git a/spec/finders/starred_projects_finder_spec.rb b/spec/finders/starred_projects_finder_spec.rb index 6bc19af7a57..7aa8251c3ab 100644 --- a/spec/finders/starred_projects_finder_spec.rb +++ b/spec/finders/starred_projects_finder_spec.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'spec_helper' describe StarredProjectsFinder do @@ -21,19 +23,19 @@ describe StarredProjectsFinder do describe 'as same user' do let(:current_user) { user } - it { is_expected.to eq([project2, project1]) } + it { is_expected.to contain_exactly(project1, project2) } end describe 'as other user' do let(:current_user) { other_user } - it { is_expected.to eq([project2, project1]) } + it { is_expected.to contain_exactly(project1, project2) } end describe 'as no user' do let(:current_user) { nil } - it { is_expected.to eq([project2, project1]) } + it { is_expected.to contain_exactly(project1, project2) } end end end diff --git a/spec/finders/users_star_projects_finder_spec.rb b/spec/finders/users_star_projects_finder_spec.rb index 4c0aa3f8f77..fb1d8088f44 100644 --- a/spec/finders/users_star_projects_finder_spec.rb +++ b/spec/finders/users_star_projects_finder_spec.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'spec_helper' describe UsersStarProjectsFinder do @@ -22,19 +24,19 @@ describe UsersStarProjectsFinder do describe 'as same user' do let(:current_user) { private_user } - it { is_expected.to eq(private_stars + public_stars) } + it { is_expected.to match_array(private_stars + public_stars) } end describe 'as other user' do let(:current_user) { other_user } - it { is_expected.to eq(public_stars) } + it { is_expected.to match_array(public_stars) } end describe 'as no user' do let(:current_user) { nil } - it { is_expected.to eq(public_stars) } + it { is_expected.to match_array(public_stars) } end end end |