diff options
author | Douwe Maan <douwe@gitlab.com> | 2017-04-19 22:12:27 +0000 |
---|---|---|
committer | Douwe Maan <douwe@gitlab.com> | 2017-04-19 22:12:27 +0000 |
commit | 3fecb4bee9702fba90f94a66e427b98f64cfe6bf (patch) | |
tree | 18c1c59da34abb0e4fb6796565259c6d60286f67 /spec | |
parent | b638e45c6b6c425deade63f0e15b320e56475890 (diff) | |
parent | 11fd2f80b0500736a9df0befbd371bfec9549138 (diff) | |
download | gitlab-ce-3fecb4bee9702fba90f94a66e427b98f64cfe6bf.tar.gz |
Merge branch 'sh-issue-29247-fix' into 'master'
Don't delete a branch involved in an open merge request in "Delete all merged branches" service
Closes #29427
See merge request !10727
Diffstat (limited to 'spec')
-rw-r--r-- | spec/factories/merge_requests.rb | 4 | ||||
-rw-r--r-- | spec/services/delete_merged_branches_service_spec.rb | 13 |
2 files changed, 17 insertions, 0 deletions
diff --git a/spec/factories/merge_requests.rb b/spec/factories/merge_requests.rb index 361f9dac191..253a025af48 100644 --- a/spec/factories/merge_requests.rb +++ b/spec/factories/merge_requests.rb @@ -40,6 +40,10 @@ FactoryGirl.define do state :closed end + trait :opened do + state :opened + end + trait :reopened do state :reopened end diff --git a/spec/services/delete_merged_branches_service_spec.rb b/spec/services/delete_merged_branches_service_spec.rb index a41a421fa6e..7b921f606f8 100644 --- a/spec/services/delete_merged_branches_service_spec.rb +++ b/spec/services/delete_merged_branches_service_spec.rb @@ -42,6 +42,19 @@ describe DeleteMergedBranchesService, services: true do expect { described_class.new(project, user).execute }.to raise_error(Gitlab::Access::AccessDeniedError) end end + + context 'open merge requests' do + it 'does not delete branches from open merge requests' do + fork_link = create(:forked_project_link, forked_from_project: project) + create(:merge_request, :reopened, source_project: project, target_project: project, source_branch: 'branch-merged', target_branch: 'master') + create(:merge_request, :opened, source_project: fork_link.forked_to_project, target_project: project, target_branch: 'improve/awesome', source_branch: 'master') + + service.execute + + expect(project.repository.branch_names).to include('branch-merged') + expect(project.repository.branch_names).to include('improve/awesome') + end + end end context '#async_execute' do |