summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2018-11-12 16:33:59 +0000
committerPhil Hughes <me@iamphill.com>2018-11-12 16:33:59 +0000
commit9736eff056f26bbad68f45ec08d71d9a94fe3b7b (patch)
tree9dd6a902c213e8b52971276cd546e394e2d996dc /spec
parenta407bba81a3fbd8b3313bc84e1ddf0ab4415207d (diff)
downloadgitlab-ce-9736eff056f26bbad68f45ec08d71d9a94fe3b7b.tar.gz
Removes feature flag for ciEnvironmentsStatusChanges
Diffstat (limited to 'spec')
-rw-r--r--spec/javascripts/vue_mr_widget/components/deployment_spec.js44
-rw-r--r--spec/javascripts/vue_mr_widget/mr_widget_options_spec.js4
-rw-r--r--spec/serializers/environment_status_entity_spec.rb8
3 files changed, 0 insertions, 56 deletions
diff --git a/spec/javascripts/vue_mr_widget/components/deployment_spec.js b/spec/javascripts/vue_mr_widget/components/deployment_spec.js
index 2f1bd00fa10..ebbcaeb6f30 100644
--- a/spec/javascripts/vue_mr_widget/components/deployment_spec.js
+++ b/spec/javascripts/vue_mr_widget/components/deployment_spec.js
@@ -174,57 +174,13 @@ describe('Deployment component', () => {
});
});
- describe('with `features.ciEnvironmentsStatusChanges` enabled', () => {
- beforeEach(() => {
- window.gon = window.gon || {};
- window.gon.features = window.gon.features || {};
- window.gon.features.ciEnvironmentsStatusChanges = true;
- vm = mountComponent(Component, { deployment: { ...deploymentMockData } });
- });
-
- afterEach(() => {
- window.gon.features = {};
- });
-
- it('renders dropdown with changes', () => {
- expect(vm.$el.querySelector('.js-mr-wigdet-deployment-dropdown')).not.toBeNull();
- expect(vm.$el.querySelector('.js-deploy-url-feature-flag')).toBeNull();
- });
- });
-
- describe('with `features.ciEnvironmentsStatusChanges` disabled', () => {
- beforeEach(() => {
- window.gon = window.gon || {};
- window.gon.features = window.gon.features || {};
- window.gon.features.ciEnvironmentsStatusChanges = false;
-
- vm = mountComponent(Component, { deployment: { ...deploymentMockData } });
- });
-
- afterEach(() => {
- delete window.gon.features.ciEnvironmentsStatusChanges;
- });
-
- it('renders the old link to the review app', () => {
- expect(vm.$el.querySelector('.js-mr-wigdet-deployment-dropdown')).toBeNull();
- expect(vm.$el.querySelector('.js-deploy-url-feature-flag')).not.toBeNull();
- });
- });
-
describe('without changes', () => {
beforeEach(() => {
- window.gon = window.gon || {};
- window.gon.features = window.gon.features || {};
- window.gon.features.ciEnvironmentsStatusChanges = true;
delete deploymentMockData.changes;
vm = mountComponent(Component, { deployment: { ...deploymentMockData } });
});
- afterEach(() => {
- delete window.gon.features.ciEnvironmentsStatusChanges;
- });
-
it('renders the link to the review app without dropdown', () => {
expect(vm.$el.querySelector('.js-mr-wigdet-deployment-dropdown')).toBeNull();
expect(vm.$el.querySelector('.js-deploy-url-feature-flag')).not.toBeNull();
diff --git a/spec/javascripts/vue_mr_widget/mr_widget_options_spec.js b/spec/javascripts/vue_mr_widget/mr_widget_options_spec.js
index 09fbe87b27e..f72bf627c10 100644
--- a/spec/javascripts/vue_mr_widget/mr_widget_options_spec.js
+++ b/spec/javascripts/vue_mr_widget/mr_widget_options_spec.js
@@ -458,10 +458,6 @@ describe('mrWidgetOptions', () => {
};
beforeEach(done => {
- window.gon = window.gon || {};
- window.gon.features = window.gon.features || {};
- window.gon.features.ciEnvironmentsStatusChanges = true;
-
vm.mr.deployments.push(
{
...deploymentMockData,
diff --git a/spec/serializers/environment_status_entity_spec.rb b/spec/serializers/environment_status_entity_spec.rb
index 52bd40ecb5e..58e2e627410 100644
--- a/spec/serializers/environment_status_entity_spec.rb
+++ b/spec/serializers/environment_status_entity_spec.rb
@@ -33,14 +33,6 @@ describe EnvironmentStatusEntity do
it { is_expected.not_to include(:metrics_url) }
it { is_expected.not_to include(:metrics_monitoring_url) }
- context 'when :ci_environments_status_changes feature flag is disabled' do
- before do
- stub_feature_flags(ci_environments_status_changes: false)
- end
-
- it { is_expected.not_to include(:changes) }
- end
-
context 'when the user is project maintainer' do
before do
project.add_maintainer(user)