diff options
author | Fatih Acet <acetfatih@gmail.com> | 2018-03-28 21:37:43 +0000 |
---|---|---|
committer | Filipa Lacerda <filipa@gitlab.com> | 2018-04-09 10:17:57 +0100 |
commit | f0bd575536bfc8e6dfce111706ac8a50615d1306 (patch) | |
tree | 60dedd30d27d0c261853d87a03c50dfcb0aae3d8 /spec | |
parent | e5821bcae83a8214c714f73ce8898104f5b1e056 (diff) | |
download | gitlab-ce-f0bd575536bfc8e6dfce111706ac8a50615d1306.tar.gz |
Merge branch '44717-no-resolve-issue' into 'master'
Resolve "There should not be a jump discussion button on issues"
Closes #44717
See merge request gitlab-org/gitlab-ce!18034
Diffstat (limited to 'spec')
-rw-r--r-- | spec/javascripts/notes/components/noteable_discussion_spec.js | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/spec/javascripts/notes/components/noteable_discussion_spec.js b/spec/javascripts/notes/components/noteable_discussion_spec.js index 19504e4f7c8..cda550760fe 100644 --- a/spec/javascripts/notes/components/noteable_discussion_spec.js +++ b/spec/javascripts/notes/components/noteable_discussion_spec.js @@ -25,26 +25,34 @@ describe('issue_discussion component', () => { }); it('should render user avatar', () => { - expect(vm.$el.querySelector('.user-avatar-link')).toBeDefined(); + expect(vm.$el.querySelector('.user-avatar-link')).not.toBeNull(); }); it('should render discussion header', () => { - expect(vm.$el.querySelector('.discussion-header')).toBeDefined(); + expect(vm.$el.querySelector('.discussion-header')).not.toBeNull(); expect(vm.$el.querySelector('.notes').children.length).toEqual(discussionMock.notes.length); }); describe('actions', () => { it('should render reply button', () => { - expect(vm.$el.querySelector('.js-vue-discussion-reply').textContent.trim()).toEqual('Reply...'); + expect(vm.$el.querySelector('.js-vue-discussion-reply').textContent.trim()).toEqual( + 'Reply...', + ); }); - it('should toggle reply form', (done) => { + it('should toggle reply form', done => { vm.$el.querySelector('.js-vue-discussion-reply').click(); Vue.nextTick(() => { - expect(vm.$refs.noteForm).toBeDefined(); + expect(vm.$refs.noteForm).not.toBeNull(); expect(vm.isReplying).toEqual(true); done(); }); }); + + it('does not render jump to discussion button', () => { + expect( + vm.$el.querySelector('*[data-original-title="Jump to next unresolved discussion"]'), + ).toBeNull(); + }); }); }); |