summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorMatija Čupić <matteeyah@gmail.com>2019-06-08 18:13:31 +0200
committerMatija Čupić <matteeyah@gmail.com>2019-06-12 18:14:04 +0200
commitbc33f1bd89fb149bbd351136265b0f3a66ee1df8 (patch)
tree456989c43b0d9e308acb2e1edc04da089f88fca3 /spec
parente3eeb779d72006b9fbbaecf9f1d8fbd52a7d6383 (diff)
downloadgitlab-ce-bc33f1bd89fb149bbd351136265b0f3a66ee1df8.tar.gz
Gate MR head_pipeline behind read_pipeline ability
Diffstat (limited to 'spec')
-rw-r--r--spec/requests/api/merge_requests_spec.rb25
1 files changed, 25 insertions, 0 deletions
diff --git a/spec/requests/api/merge_requests_spec.rb b/spec/requests/api/merge_requests_spec.rb
index 5c94a87529b..e37c7ed36d9 100644
--- a/spec/requests/api/merge_requests_spec.rb
+++ b/spec/requests/api/merge_requests_spec.rb
@@ -834,6 +834,31 @@ describe API::MergeRequests do
end
end
+ context 'head_pipeline' do
+ before do
+ merge_request.update(head_pipeline: create(:ci_pipeline))
+ merge_request.project.project_feature.update(builds_access_level: 10)
+ end
+
+ context 'when user can read the pipeline' do
+ it 'exposes pipeline information' do
+ get api("/projects/#{project.id}/merge_requests/#{merge_request.iid}", user)
+
+ expect(json_response).to include('head_pipeline')
+ end
+ end
+
+ context 'when user can not read the pipeline' do
+ let(:guest) { create(:user) }
+
+ it 'does not expose pipeline information' do
+ get api("/projects/#{project.id}/merge_requests/#{merge_request.iid}", guest)
+
+ expect(json_response).not_to include('head_pipeline')
+ end
+ end
+ end
+
it 'returns the commits behind the target branch when include_diverged_commits_count is present' do
allow_any_instance_of(merge_request.class).to receive(:diverged_commits_count).and_return(1)