summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorThong Kuah <tkuah@gitlab.com>2018-09-07 22:01:37 +1200
committerThong Kuah <tkuah@gitlab.com>2018-09-14 16:26:51 +1200
commit9c5050b12226781d49d2ce25d47477eab6a4354b (patch)
tree2a7eb79693e19b3bc6d85ee1514fa795a4d19ffe /spec
parent577c79bb58ae80f4d7aef55e76bfeff67a1cfc45 (diff)
downloadgitlab-ce-9c5050b12226781d49d2ce25d47477eab6a4354b.tar.gz
Drive creation of a rbac platform_kubernetes off provider#legacy_abac so that there is one single source of truth.
Diffstat (limited to 'spec')
-rw-r--r--spec/services/clusters/gcp/finalize_creation_service_spec.rb16
1 files changed, 8 insertions, 8 deletions
diff --git a/spec/services/clusters/gcp/finalize_creation_service_spec.rb b/spec/services/clusters/gcp/finalize_creation_service_spec.rb
index 278ba795042..1ea41b41771 100644
--- a/spec/services/clusters/gcp/finalize_creation_service_spec.rb
+++ b/spec/services/clusters/gcp/finalize_creation_service_spec.rb
@@ -28,10 +28,6 @@ describe Clusters::Gcp::FinalizeCreationService do
end
end
- before do
- stub_feature_flags(rbac_clusters: false)
- end
-
context 'when suceeded to fetch gke cluster info' do
let(:endpoint) { '111.111.111.111' }
let(:api_url) { 'https://' + endpoint }
@@ -85,7 +81,8 @@ describe Clusters::Gcp::FinalizeCreationService do
let(:secret_name) { 'gitlab-token-Y1a' }
before do
- stub_feature_flags(rbac_clusters: true)
+ provider.legacy_abac = false
+
stub_kubeclient_create_service_account(api_url)
stub_kubeclient_create_cluster_role_binding(api_url)
end
@@ -118,7 +115,8 @@ describe Clusters::Gcp::FinalizeCreationService do
context 'rbac_clusters feature enabled' do
before do
- stub_feature_flags(rbac_clusters: true)
+ provider.legacy_abac = false
+
stub_kubeclient_create_service_account(api_url)
stub_kubeclient_create_cluster_role_binding(api_url)
end
@@ -140,7 +138,8 @@ describe Clusters::Gcp::FinalizeCreationService do
let(:secret_name) { 'gitlab-token-321' }
before do
- stub_feature_flags(rbac_clusters: true)
+ provider.legacy_abac = false
+
stub_kubeclient_create_service_account(api_url)
stub_kubeclient_create_cluster_role_binding(api_url)
end
@@ -158,7 +157,8 @@ describe Clusters::Gcp::FinalizeCreationService do
context 'rbac_clusters feature enabled' do
before do
- stub_feature_flags(rbac_clusters: true)
+ provider.legacy_abac = false
+
stub_kubeclient_create_service_account(api_url)
stub_kubeclient_create_cluster_role_binding(api_url)
end