diff options
author | Grzegorz Bizon <grzegorz@gitlab.com> | 2019-08-28 11:53:25 +0000 |
---|---|---|
committer | Grzegorz Bizon <grzegorz@gitlab.com> | 2019-08-28 11:53:25 +0000 |
commit | f8a442b71fdb6c0fecb8d54ef09120abd6982929 (patch) | |
tree | fafa9ed95037a20f871c4f1e25321aa46316c5c5 /spec | |
parent | e8bcabb4a735ecb84b5bc65269fffc21a72b6da6 (diff) | |
parent | 24493c50232b6109bbcc680ada32dfe832201a67 (diff) | |
download | gitlab-ce-f8a442b71fdb6c0fecb8d54ef09120abd6982929.tar.gz |
Merge branch 'add-rubocop-check-for-be-success' into 'master'
Add rubocop check for be success
See merge request gitlab-org/gitlab-ce!32091
Diffstat (limited to 'spec')
-rw-r--r-- | spec/rubocop/cop/rspec/be_success_matcher_spec.rb | 63 |
1 files changed, 63 insertions, 0 deletions
diff --git a/spec/rubocop/cop/rspec/be_success_matcher_spec.rb b/spec/rubocop/cop/rspec/be_success_matcher_spec.rb new file mode 100644 index 00000000000..12aa7d1643e --- /dev/null +++ b/spec/rubocop/cop/rspec/be_success_matcher_spec.rb @@ -0,0 +1,63 @@ +# frozen_string_literal: true + +require 'spec_helper' + +require_relative '../../../../rubocop/cop/rspec/be_success_matcher' + +describe RuboCop::Cop::RSpec::BeSuccessMatcher do + include CopHelper + + let(:source_file) { 'spec/foo_spec.rb' } + + subject(:cop) { described_class.new } + + shared_examples 'cop' do |good:, bad:| + context "using #{bad} call" do + it 'registers an offense' do + inspect_source(bad, source_file) + + expect(cop.offenses.size).to eq(1) + expect(cop.offenses.map(&:line)).to eq([1]) + expect(cop.highlights).to eq([bad]) + end + + it "autocorrects it to `#{good}`" do + autocorrected = autocorrect_source(bad, source_file) + + expect(autocorrected).to eql(good) + end + end + + context "using #{good} call" do + it 'does not register an offense' do + inspect_source(good) + + expect(cop.offenses).to be_empty + end + end + end + + include_examples 'cop', + bad: 'expect(response).to be_success', + good: 'expect(response).to be_successful' + + include_examples 'cop', + bad: 'expect(response).to_not be_success', + good: 'expect(response).to_not be_successful' + + include_examples 'cop', + bad: 'expect(response).not_to be_success', + good: 'expect(response).not_to be_successful' + + include_examples 'cop', + bad: 'is_expected.to be_success', + good: 'is_expected.to be_successful' + + include_examples 'cop', + bad: 'is_expected.to_not be_success', + good: 'is_expected.to_not be_successful' + + include_examples 'cop', + bad: 'is_expected.not_to be_success', + good: 'is_expected.not_to be_successful' +end |