diff options
author | Phil Hughes <me@iamphill.com> | 2019-02-12 17:29:22 +0000 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2019-02-26 12:21:16 +0000 |
commit | e9b28a28a7494500f0295b87cf9f3389d48a8c30 (patch) | |
tree | 56ed313c0a31045f7bba5455371644593bfa00a3 /spec | |
parent | b0097199a329c4de4eacc99a7d46d62c4ec0a1e0 (diff) | |
download | gitlab-ce-e9b28a28a7494500f0295b87cf9f3389d48a8c30.tar.gz |
Makes the Web IDE the default editor
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/42382
Diffstat (limited to 'spec')
-rw-r--r-- | spec/features/projects/blobs/edit_spec.rb | 4 | ||||
-rw-r--r-- | spec/features/projects/files/user_creates_files_spec.rb | 2 | ||||
-rw-r--r-- | spec/features/projects/files/user_edits_files_spec.rb | 2 | ||||
-rw-r--r-- | spec/helpers/blob_helper_spec.rb | 8 |
4 files changed, 16 insertions, 0 deletions
diff --git a/spec/features/projects/blobs/edit_spec.rb b/spec/features/projects/blobs/edit_spec.rb index 6e6c299ee2e..a8e9d951d5e 100644 --- a/spec/features/projects/blobs/edit_spec.rb +++ b/spec/features/projects/blobs/edit_spec.rb @@ -9,6 +9,10 @@ describe 'Editing file blob', :js do let(:file_path) { project.repository.ls_files(project.repository.root_ref)[1] } let(:readme_file_path) { 'README.md' } + before do + stub_feature_flags(web_ide_default: false) + end + context 'as a developer' do let(:user) { create(:user) } let(:role) { :developer } diff --git a/spec/features/projects/files/user_creates_files_spec.rb b/spec/features/projects/files/user_creates_files_spec.rb index a4f94b7a76d..dd2964c2186 100644 --- a/spec/features/projects/files/user_creates_files_spec.rb +++ b/spec/features/projects/files/user_creates_files_spec.rb @@ -12,6 +12,8 @@ describe 'Projects > Files > User creates files' do let(:user) { create(:user) } before do + stub_feature_flags(web_ide_default: false) + project.add_maintainer(user) sign_in(user) end diff --git a/spec/features/projects/files/user_edits_files_spec.rb b/spec/features/projects/files/user_edits_files_spec.rb index 9eb65ec159c..ec3930c26db 100644 --- a/spec/features/projects/files/user_edits_files_spec.rb +++ b/spec/features/projects/files/user_edits_files_spec.rb @@ -9,6 +9,8 @@ describe 'Projects > Files > User edits files', :js do let(:user) { create(:user) } before do + stub_feature_flags(web_ide_default: false) + sign_in(user) end diff --git a/spec/helpers/blob_helper_spec.rb b/spec/helpers/blob_helper_spec.rb index f709f152c92..2bc3933809f 100644 --- a/spec/helpers/blob_helper_spec.rb +++ b/spec/helpers/blob_helper_spec.rb @@ -50,12 +50,20 @@ describe BlobHelper do end it 'returns a link with the proper route' do + stub_feature_flags(web_ide_default: false) link = edit_blob_button(project, 'master', 'README.md') expect(Capybara.string(link).find_link('Edit')[:href]).to eq("/#{project.full_path}/edit/master/README.md") end + it 'returns a link with a Web IDE route' do + link = edit_blob_button(project, 'master', 'README.md') + + expect(Capybara.string(link).find_link('Edit')[:href]).to eq("/-/ide/project/#{project.full_path}/edit/master/-/README.md") + end + it 'returns a link with the passed link_opts on the expected route' do + stub_feature_flags(web_ide_default: false) link = edit_blob_button(project, 'master', 'README.md', link_opts: { mr_id: 10 }) expect(Capybara.string(link).find_link('Edit')[:href]).to eq("/#{project.full_path}/edit/master/README.md?mr_id=10") |