diff options
author | Robert Speicher <robert@gitlab.com> | 2016-12-22 15:56:08 +0000 |
---|---|---|
committer | Douglas Barbosa Alexandre <dbalexandre@gmail.com> | 2016-12-22 18:51:07 -0200 |
commit | 0478bea7247c95d3ee6eee922d1b1daa10e69f75 (patch) | |
tree | 569a6c5881561fc3651f309c46c19d2d86543b70 /spec | |
parent | 54850bff61f067d9fe4c01c6aa8ba3095de5ea70 (diff) | |
download | gitlab-ce-0478bea7247c95d3ee6eee922d1b1daa10e69f75.tar.gz |
Merge branch '25979-fix-todos-on-failed-build' into 'master'
Fix viewing "build failed" TODOs
Closes #25979
See merge request !8262
Diffstat (limited to 'spec')
-rw-r--r-- | spec/factories/todos.rb | 1 | ||||
-rw-r--r-- | spec/features/todos/todos_spec.rb | 19 |
2 files changed, 20 insertions, 0 deletions
diff --git a/spec/factories/todos.rb b/spec/factories/todos.rb index 866e663f026..082b02116c0 100644 --- a/spec/factories/todos.rb +++ b/spec/factories/todos.rb @@ -21,6 +21,7 @@ FactoryGirl.define do trait :build_failed do action { Todo::BUILD_FAILED } + target factory: :merge_request end trait :approval_required do diff --git a/spec/features/todos/todos_spec.rb b/spec/features/todos/todos_spec.rb index 88eabea7e3a..4bda0927692 100644 --- a/spec/features/todos/todos_spec.rb +++ b/spec/features/todos/todos_spec.rb @@ -155,5 +155,24 @@ describe 'Dashboard Todos', feature: true do expect(page).to have_selector('.todos-all-done', count: 1) end end + + context 'User has a Build Failed todo' do + let!(:todo) { create(:todo, :build_failed, user: user, project: project, author: author) } + + before do + login_as user + visit dashboard_todos_path + end + + it 'shows the todo' do + expect(page).to have_content 'The build failed for your merge request' + end + + it 'links to the pipelines for the merge request' do + href = pipelines_namespace_project_merge_request_path(project.namespace, project, todo.target) + + expect(page).to have_link "merge request #{todo.target.to_reference}", href + end + end end end |