diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-12-17 11:59:07 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-12-17 11:59:07 +0000 |
commit | 8b573c94895dc0ac0e1d9d59cf3e8745e8b539ca (patch) | |
tree | 544930fb309b30317ae9797a9683768705d664c4 /workhorse/sendfile_test.go | |
parent | 4b1de649d0168371549608993deac953eb692019 (diff) | |
download | gitlab-ce-8b573c94895dc0ac0e1d9d59cf3e8745e8b539ca.tar.gz |
Add latest changes from gitlab-org/gitlab@13-7-stable-eev13.7.0-rc42
Diffstat (limited to 'workhorse/sendfile_test.go')
-rw-r--r-- | workhorse/sendfile_test.go | 103 |
1 files changed, 103 insertions, 0 deletions
diff --git a/workhorse/sendfile_test.go b/workhorse/sendfile_test.go new file mode 100644 index 00000000000..2408f4fde38 --- /dev/null +++ b/workhorse/sendfile_test.go @@ -0,0 +1,103 @@ +package main + +import ( + "fmt" + "io/ioutil" + "mime" + "net/http" + "net/http/httptest" + "os" + "path" + "testing" + + "github.com/stretchr/testify/require" + "gitlab.com/gitlab-org/labkit/log" +) + +func TestDeniedLfsDownload(t *testing.T) { + contentFilename := "b68143e6463773b1b6c6fd009a76c32aeec041faff32ba2ed42fd7f708a17f80" + url := fmt.Sprintf("gitlab-lfs/objects/%s", contentFilename) + + prepareDownloadDir(t) + deniedXSendfileDownload(t, contentFilename, url) +} + +func TestAllowedLfsDownload(t *testing.T) { + contentFilename := "b68143e6463773b1b6c6fd009a76c32aeec041faff32ba2ed42fd7f708a17f80" + url := fmt.Sprintf("gitlab-lfs/objects/%s", contentFilename) + + prepareDownloadDir(t) + allowedXSendfileDownload(t, contentFilename, url) +} + +func allowedXSendfileDownload(t *testing.T, contentFilename string, filePath string) { + contentPath := path.Join(cacheDir, contentFilename) + prepareDownloadDir(t) + + // Prepare test server and backend + ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + log.WithFields(log.Fields{"method": r.Method, "url": r.URL}).Info("UPSTREAM") + + require.Equal(t, "X-Sendfile", r.Header.Get("X-Sendfile-Type")) + + w.Header().Set("X-Sendfile", contentPath) + w.Header().Set("Content-Disposition", fmt.Sprintf(`attachment; filename="%s"`, contentFilename)) + w.Header().Set("Content-Type", "application/octet-stream") + w.WriteHeader(200) + })) + defer ts.Close() + ws := startWorkhorseServer(ts.URL) + defer ws.Close() + + require.NoError(t, os.MkdirAll(cacheDir, 0755)) + contentBytes := []byte("content") + require.NoError(t, ioutil.WriteFile(contentPath, contentBytes, 0644)) + + resp, err := http.Get(fmt.Sprintf("%s/%s", ws.URL, filePath)) + require.NoError(t, err) + + requireAttachmentName(t, resp, contentFilename) + + actual, err := ioutil.ReadAll(resp.Body) + require.NoError(t, err) + require.NoError(t, resp.Body.Close()) + + require.Equal(t, actual, contentBytes, "response body") +} + +func deniedXSendfileDownload(t *testing.T, contentFilename string, filePath string) { + prepareDownloadDir(t) + + // Prepare test server and backend + ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + log.WithFields(log.Fields{"method": r.Method, "url": r.URL}).Info("UPSTREAM") + + require.Equal(t, "X-Sendfile", r.Header.Get("X-Sendfile-Type")) + + w.Header().Set("Content-Disposition", fmt.Sprintf(`attachment; filename="%s"`, contentFilename)) + w.WriteHeader(200) + fmt.Fprint(w, "Denied") + })) + defer ts.Close() + ws := startWorkhorseServer(ts.URL) + defer ws.Close() + + resp, err := http.Get(fmt.Sprintf("%s/%s", ws.URL, filePath)) + require.NoError(t, err) + + requireAttachmentName(t, resp, contentFilename) + + actual, err := ioutil.ReadAll(resp.Body) + require.NoError(t, err, "read body") + require.NoError(t, resp.Body.Close()) + + require.Equal(t, []byte("Denied"), actual, "response body") +} + +func requireAttachmentName(t *testing.T, resp *http.Response, filename string) { + mediaType, params, err := mime.ParseMediaType(resp.Header.Get("Content-Disposition")) + require.NoError(t, err) + + require.Equal(t, "attachment", mediaType) + require.Equal(t, filename, params["filename"], "filename") +} |