diff options
Diffstat (limited to '.rubocop_todo.yml')
| -rw-r--r-- | .rubocop_todo.yml | 419 |
1 files changed, 362 insertions, 57 deletions
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 9e3a54fa7e9..e54d970c671 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -303,6 +303,11 @@ Performance/Detect: RSpec/ContextWording: Enabled: false +# Offense count: 626 +# Cop supports --auto-correct. +RSpec/EmptyLineAfterLetBlock: + Enabled: false + # Offense count: 1121 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. @@ -560,30 +565,6 @@ Style/GuardClause: Style/HashEachMethods: Enabled: false -# Offense count: 6 -# Cop supports --auto-correct. -Style/HashTransformKeys: - Exclude: - - 'ee/app/models/vulnerabilities/occurrence.rb' - - 'ee/spec/lib/gitlab/ci/templates/dependency_scanning_gitlab_ci_yaml_spec.rb' - - 'lib/banzai/filter/commit_trailers_filter.rb' - - 'lib/gitlab/analytics/cycle_analytics/stage_events.rb' - -# Offense count: 10 -# Cop supports --auto-correct. -Style/HashTransformValues: - Exclude: - - 'app/validators/addressable_url_validator.rb' - - 'config/initializers/action_dispatch_journey_formatter.rb' - - 'ee/app/helpers/compliance_management/compliance_framework/project_settings_helper.rb' - - 'ee/app/services/packages/nuget/metadata_extraction_service.rb' - - 'lib/gitlab/config/entry/configurable.rb' - - 'lib/gitlab/config/entry/node.rb' - - 'lib/gitlab/discussions_diff/file_collection.rb' - - 'lib/gitlab/error_tracking.rb' - - 'lib/rspec_flaky/flaky_examples_collection.rb' - - 'spec/lib/gitlab/database_importers/common_metrics/prometheus_metric_spec.rb' - # Offense count: 31 # Configuration parameters: AllowIfModifier. Style/IfInsideElse: @@ -639,12 +620,122 @@ Style/Next: Style/NumericLiteralPrefix: Enabled: false -# Offense count: 255 +# Offense count: 130 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. # SupportedStyles: predicate, comparison +# We use EnforcedStyle of comparison here due to it being better +# performing code as seen https://gitlab.com/gitlab-org/gitlab/-/merge_requests/36221#note_375659681 Style/NumericPredicate: - Enabled: false + EnforcedStyle: comparison + Exclude: + - 'spec/**/*' + - 'app/views/**/*' + - 'ee/app/views/**/*' + - 'app/controllers/concerns/issuable_collections.rb' + - 'app/controllers/concerns/paginated_collection.rb' + - 'app/helpers/graph_helper.rb' + - 'app/helpers/timeboxes_helper.rb' + - 'app/models/ci/pipeline.rb' + - 'app/models/ci/stage.rb' + - 'app/models/concerns/update_project_statistics.rb' + - 'app/models/merge_request_diff.rb' + - 'app/models/milestone.rb' + - 'app/models/network/graph.rb' + - 'app/models/postgresql/replication_slot.rb' + - 'app/models/project.rb' + - 'app/models/suggestion.rb' + - 'app/models/user.rb' + - 'app/serializers/merge_request_widget_entity.rb' + - 'app/services/boards/issues/move_service.rb' + - 'app/services/cohorts_service.rb' + - 'app/services/discussions/resolve_service.rb' + - 'app/services/issues/reorder_service.rb' + - 'app/services/notes/create_service.rb' + - 'app/services/packages/nuget/metadata_extraction_service.rb' + - 'app/services/packages/nuget/search_service.rb' + - 'app/services/projects/auto_devops/disable_service.rb' + - 'app/services/projects/update_pages_service.rb' + - 'app/services/search_service.rb' + - 'app/workers/admin_email_worker.rb' + - 'app/workers/gitlab/import/advance_stage.rb' + - 'config/initializers/validate_puma.rb' + - 'ee/app/controllers/security/projects_controller.rb' + - 'ee/app/graphql/mutations/instance_security_dashboard/remove_project.rb' + - 'ee/app/helpers/ee/timeboxes_helper.rb' + - 'ee/app/models/ci/minutes/quota.rb' + - 'ee/app/models/ee/ci/runner.rb' + - 'ee/app/models/geo_node_status.rb' + - 'ee/app/models/license.rb' + - 'ee/app/models/namespace_statistics.rb' + - 'ee/app/services/ee/issues/base_service.rb' + - 'ee/app/services/ee/merge_requests/approval_service.rb' + - 'ee/app/services/ee/quick_actions/target_service.rb' + - 'ee/app/services/elastic/indexing_control_service.rb' + - 'ee/app/services/geo/hashed_storage_migration_service.rb' + - 'ee/app/services/geo/prune_event_log_service.rb' + - 'ee/app/services/security/waf_anomaly_summary_service.rb' + - 'ee/app/services/update_build_minutes_service.rb' + - 'ee/app/workers/geo/container_repository_sync_dispatch_worker.rb' + - 'ee/app/workers/geo/file_download_dispatch_worker.rb' + - 'ee/app/workers/geo/registry_sync_worker.rb' + - 'ee/app/workers/geo/repository_shard_sync_worker.rb' + - 'ee/app/workers/geo/repository_verification/primary/shard_worker.rb' + - 'ee/lib/api/helpers/packages/conan/api_helpers.rb' + - 'ee/lib/ee/gitlab/auth/ldap/person.rb' + - 'ee/lib/ee/gitlab/background_migration/prune_orphaned_geo_events.rb' + - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' + - 'ee/lib/ee/gitlab/geo_git_access.rb' + - 'ee/lib/gitlab/geo/fdw.rb' + - 'ee/lib/gitlab/geo/log_cursor/lease.rb' + - 'ee/lib/tasks/gitlab/elastic.rake' + - 'lib/api/entities/feature.rb' + - 'lib/api/helpers/pagination_strategies.rb' + - 'lib/backup/files.rb' + - 'lib/banzai/filter/gollum_tags_filter.rb' + - 'lib/bitbucket_server/paginator.rb' + - 'lib/declarative_policy/runner.rb' + - 'lib/gitlab/auth/ldap/adapter.rb' + - 'lib/gitlab/bare_repository_import/importer.rb' + - 'lib/gitlab/ci/config/external/context.rb' + - 'lib/gitlab/ci/reports/accessibility_reports_comparer.rb' + - 'lib/gitlab/cycle_analytics/summary/value.rb' + - 'lib/gitlab/cycle_analytics/summary_helper.rb' + - 'lib/gitlab/danger/teammate.rb' + - 'lib/gitlab/database.rb' + - 'lib/gitlab/database/connection_timer.rb' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/gitlab/exclusive_lease.rb' + - 'lib/gitlab/exclusive_lease_helpers/sleeping_lock.rb' + - 'lib/gitlab/experimentation.rb' + - 'lib/gitlab/file_hook.rb' + - 'lib/gitlab/git/commit.rb' + - 'lib/gitlab/git/repository.rb' + - 'lib/gitlab/git/rugged_impl/blob.rb' + - 'lib/gitlab/gitaly_client.rb' + - 'lib/gitlab/github_import/user_finder.rb' + - 'lib/gitlab/hashed_storage/migrator.rb' + - 'lib/gitlab/import_export/command_line_util.rb' + - 'lib/gitlab/multi_collection_paginator.rb' + - 'lib/gitlab/polling_interval.rb' + - 'lib/gitlab/project_search_results.rb' + - 'lib/gitlab/seeder.rb' + - 'lib/gitlab/sidekiq_cluster.rb' + - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' + - 'lib/gitlab/sidekiq_middleware/memory_killer.rb' + - 'lib/gitlab/sidekiq_status.rb' + - 'lib/gitlab/slash_commands/presenters/issue_show.rb' + - 'lib/gitlab/task_helpers.rb' + - 'lib/gitlab/untrusted_regexp.rb' + - 'lib/gitlab/utils.rb' + - 'lib/system_check/sidekiq_check.rb' + - 'lib/tasks/gitlab/gitaly.rake' + - 'lib/tasks/gitlab/snippets.rake' + - 'lib/tasks/gitlab/workhorse.rake' + - 'qa/qa/git/repository.rb' + - 'qa/qa/support/wait_for_requests.rb' + - 'ee/app/models/ee/project.rb' + - 'lib/gitlab/usage_data/topology.rb' # Offense count: 117 # Cop supports --auto-correct. @@ -690,18 +781,6 @@ Style/RedundantFreeze: Style/RedundantInterpolation: Enabled: false -# Offense count: 6 -# Cop supports --auto-correct. -Style/RedundantParentheses: - Exclude: - - 'ee/app/models/ee/merge_request.rb' - -# Offense count: 33 -# Cop supports --auto-correct. -# Configuration parameters: AllowMultipleReturnValues. -Style/RedundantReturn: - Enabled: false - # Offense count: 801 # Cop supports --auto-correct. Style/RedundantSelf: @@ -711,8 +790,8 @@ Style/RedundantSelf: # Cop supports --auto-correct. Style/RedundantSort: Exclude: - - 'ee/app/presenters/packages/nuget/search_results_presenter.rb' - - 'ee/spec/presenters/packages/nuget/search_results_presenter_spec.rb' + - 'app/presenters/packages/nuget/search_results_presenter.rb' + - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' # Offense count: 120 # Cop supports --auto-correct. @@ -769,25 +848,20 @@ Style/StringLiteralsInInterpolation: Style/SymbolProc: Enabled: false -# Offense count: 1478 +# Offense count: 2362 # Cop supports --auto-correct. # Configuration parameters: AllowImplicitReturn, AllowedReceivers. Rails/SaveBang: Exclude: - - 'ee/spec/controllers/groups/epic_issues_controller_spec.rb' - - 'ee/spec/controllers/groups/epic_links_controller_spec.rb' - - 'ee/spec/controllers/groups/epics_controller_spec.rb' - - 'ee/spec/controllers/groups/roadmap_controller_spec.rb' - - 'ee/spec/controllers/projects/environments_controller_spec.rb' - - 'ee/spec/controllers/projects/issues_controller_spec.rb' - - 'ee/spec/controllers/projects/merge_requests/creations_controller_spec.rb' - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' - - 'ee/spec/controllers/projects/service_desk_controller_spec.rb' - - 'ee/spec/controllers/projects/subscriptions_controller_spec.rb' - - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' + - 'ee/spec/factories/ci/job_artifacts.rb' + - 'ee/spec/factories/epics.rb' + - 'ee/spec/factories/licenses.rb' - 'ee/spec/factories/merge_requests.rb' + - 'ee/spec/features/admin/admin_users_spec.rb' - 'ee/spec/features/admin/geo/admin_geo_nodes_spec.rb' + - 'ee/spec/features/admin/licenses/admin_views_license_spec.rb' - 'ee/spec/features/boards/scoped_issue_board_spec.rb' - 'ee/spec/features/ci_shared_runner_warnings_spec.rb' - 'ee/spec/features/dashboards/operations_spec.rb' @@ -796,13 +870,19 @@ Rails/SaveBang: - 'ee/spec/features/merge_requests/user_views_all_merge_requests_spec.rb' - 'ee/spec/features/projects/members/invite_group_and_members_spec.rb' - 'ee/spec/features/projects/merge_requests/user_approves_merge_request_spec.rb' + - 'ee/spec/features/projects/mirror_spec.rb' - 'ee/spec/features/projects/new_project_spec.rb' - 'ee/spec/features/projects/settings/user_manages_approval_settings_spec.rb' - 'ee/spec/features/projects/settings/user_manages_members_spec.rb' - 'ee/spec/features/search/elastic/global_search_spec.rb' + - 'ee/spec/features/security/project/internal_access_spec.rb' + - 'ee/spec/features/security/project/public_access_spec.rb' - 'ee/spec/finders/epics_finder_spec.rb' + - 'ee/spec/finders/security/vulnerabilities_finder_spec.rb' - 'ee/spec/frontend/fixtures/analytics.rb' + - 'ee/spec/graphql/resolvers/vulnerabilities_resolver_spec.rb' - 'ee/spec/helpers/application_helper_spec.rb' + - 'ee/spec/helpers/ee/dashboard_helper_spec.rb' - 'ee/spec/helpers/ee/issues_helper_spec.rb' - 'ee/spec/initializers/fog_google_https_private_urls_spec.rb' - 'ee/spec/lib/analytics/merge_request_metrics_calculator_spec.rb' @@ -811,60 +891,84 @@ Rails/SaveBang: - 'ee/spec/lib/ee/gitlab/background_migration/move_epic_issues_after_epics_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_any_approval_rule_for_merge_requests_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_any_approval_rule_for_projects_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/prune_orphaned_geo_events_spec.rb' - 'ee/spec/lib/ee/gitlab/checks/push_rules/commit_check_spec.rb' - 'ee/spec/lib/ee/gitlab/ci/pipeline/quota/activity_spec.rb' - 'ee/spec/lib/gitlab/auth/ldap/access_spec.rb' - 'ee/spec/lib/gitlab/auth/o_auth/user_spec.rb' - 'ee/spec/lib/gitlab/auth/saml/user_spec.rb' + - 'ee/spec/lib/gitlab/background_migration/fix_orphan_promoted_issues_spec.rb' - 'ee/spec/lib/gitlab/elastic/search_results_spec.rb' - 'ee/spec/lib/gitlab/email/handler/ee/service_desk_handler_spec.rb' + - 'ee/spec/lib/gitlab/geo/cron_manager_spec.rb' - 'ee/spec/lib/gitlab/geo/jwt_request_decoder_spec.rb' - 'ee/spec/lib/gitlab/geo/oauth/session_spec.rb' - 'ee/spec/lib/gitlab/geo_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' + - 'ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb' + - 'ee/spec/lib/gitlab/mirror_spec.rb' - 'ee/spec/mailers/notify_spec.rb' + - 'ee/spec/migrations/fix_any_approver_rule_for_projects_spec.rb' - 'ee/spec/migrations/geo/migrate_ci_job_artifacts_to_separate_registry_spec.rb' - 'ee/spec/migrations/geo/migrate_lfs_objects_to_separate_registry_spec.rb' + - 'ee/spec/migrations/schedule_merge_request_any_approval_rule_migration_spec.rb' - 'ee/spec/migrations/schedule_project_any_approval_rule_migration_spec.rb' - 'ee/spec/models/application_setting_spec.rb' - 'ee/spec/models/approval_merge_request_rule_spec.rb' + - 'ee/spec/models/approval_project_rule_spec.rb' - 'ee/spec/models/approval_state_spec.rb' - 'ee/spec/models/burndown_spec.rb' - 'ee/spec/models/ci/build_spec.rb' - 'ee/spec/models/ci/pipeline_spec.rb' - 'ee/spec/models/ci/subscriptions/project_spec.rb' + - 'ee/spec/models/concerns/approver_migrate_hook_spec.rb' - 'ee/spec/models/concerns/deprecated_approvals_before_merge_spec.rb' - 'ee/spec/models/concerns/elastic/note_spec.rb' + - 'ee/spec/models/ee/appearance_spec.rb' + - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - 'ee/spec/models/ee/protected_branch_spec.rb' - 'ee/spec/models/ee/protected_ref_access_spec.rb' - 'ee/spec/models/ee/protected_ref_spec.rb' + - 'ee/spec/models/elasticsearch_indexed_namespace_spec.rb' + - 'ee/spec/models/environment_spec.rb' - 'ee/spec/models/epic_spec.rb' - 'ee/spec/models/geo/project_registry_spec.rb' - 'ee/spec/models/geo_node_spec.rb' - 'ee/spec/models/geo_node_status_spec.rb' + - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/group_spec.rb' - 'ee/spec/models/issue_spec.rb' - 'ee/spec/models/label_note_spec.rb' + - 'ee/spec/models/lfs_object_spec.rb' - 'ee/spec/models/license_spec.rb' - 'ee/spec/models/merge_request_spec.rb' + - 'ee/spec/models/merge_train_spec.rb' - 'ee/spec/models/operations/feature_flag_scope_spec.rb' - 'ee/spec/models/operations/feature_flag_spec.rb' - 'ee/spec/models/operations/feature_flags/strategy_spec.rb' - 'ee/spec/models/operations/feature_flags/user_list_spec.rb' + - 'spec/models/packages/package_spec.rb' + - 'ee/spec/models/project_ci_cd_setting_spec.rb' - 'ee/spec/models/project_services/github_service_spec.rb' - 'ee/spec/models/project_services/jenkins_service_spec.rb' - 'ee/spec/models/project_spec.rb' + - 'ee/spec/models/protected_environment_spec.rb' + - 'ee/spec/models/repository_spec.rb' - 'ee/spec/models/scim_identity_spec.rb' - 'ee/spec/models/scim_oauth_access_token_spec.rb' + - 'ee/spec/models/upload_spec.rb' - 'ee/spec/models/user_preference_spec.rb' - 'ee/spec/models/user_spec.rb' - 'ee/spec/models/visible_approvable_spec.rb' - 'ee/spec/models/vulnerabilities/feedback_spec.rb' - 'ee/spec/models/vulnerabilities/issue_link_spec.rb' + - 'ee/spec/policies/group_policy_spec.rb' + - 'ee/spec/policies/note_policy_spec.rb' + - 'ee/spec/policies/project_policy_spec.rb' - 'ee/spec/policies/protected_branch_policy_spec.rb' + - 'ee/spec/policies/vulnerabilities/feedback_policy_spec.rb' - 'ee/spec/presenters/audit_event_presenter_spec.rb' - 'ee/spec/presenters/epic_presenter_spec.rb' - - 'ee/spec/presenters/packages/conan/package_presenter_spec.rb' - 'ee/spec/requests/api/boards_spec.rb' - 'ee/spec/requests/api/epic_issues_spec.rb' - 'ee/spec/requests/api/epic_links_spec.rb' @@ -876,7 +980,6 @@ Rails/SaveBang: - 'ee/spec/requests/api/groups_spec.rb' - 'ee/spec/requests/api/issues_spec.rb' - 'ee/spec/requests/api/ldap_group_links_spec.rb' - - 'ee/spec/requests/api/maven_packages_spec.rb' - 'ee/spec/requests/api/merge_request_approval_rules_spec.rb' - 'ee/spec/requests/api/merge_request_approvals_spec.rb' - 'ee/spec/requests/api/merge_requests_spec.rb' @@ -885,9 +988,15 @@ Rails/SaveBang: - 'ee/spec/requests/api/protected_branches_spec.rb' - 'ee/spec/requests/api/scim_spec.rb' - 'ee/spec/requests/api/todos_spec.rb' + - 'ee/spec/requests/lfs_http_spec.rb' - 'ee/spec/services/approval_rules/finalize_service_spec.rb' + - 'ee/spec/services/approval_rules/update_service_spec.rb' + - 'ee/spec/services/ci/minutes/email_notification_service_spec.rb' + - 'ee/spec/services/ci/process_build_service_spec.rb' - 'ee/spec/services/ci/register_job_service_spec.rb' - 'ee/spec/services/ee/boards/issues/create_service_spec.rb' + - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' + - 'ee/spec/services/ee/boards/lists/list_service_spec.rb' - 'ee/spec/services/ee/issuable/clone/attributes_rewriter_spec.rb' - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - 'ee/spec/services/ee/issues/update_service_spec.rb' @@ -896,13 +1005,15 @@ Rails/SaveBang: - 'ee/spec/services/ee/notes/quick_actions_service_spec.rb' - 'ee/spec/services/ee/notification_service_spec.rb' - 'ee/spec/services/ee/resource_events/change_weight_service_spec.rb' - - 'ee/spec/services/elastic/index_record_service_spec.rb' - 'ee/spec/services/epic_links/create_service_spec.rb' + - 'ee/spec/services/epics/close_service_spec.rb' - 'ee/spec/services/epics/issue_promote_service_spec.rb' + - 'ee/spec/services/epics/reopen_service_spec.rb' - 'ee/spec/services/epics/tree_reorder_service_spec.rb' - 'ee/spec/services/epics/update_dates_service_spec.rb' - 'ee/spec/services/epics/update_service_spec.rb' - 'ee/spec/services/geo/blob_verification_secondary_service_spec.rb' + - 'ee/spec/services/geo/files_expire_service_spec.rb' - 'ee/spec/services/geo/metrics_update_service_spec.rb' - 'ee/spec/services/geo/registry_consistency_service_spec.rb' - 'ee/spec/services/geo/repository_verification_secondary_service_spec.rb' @@ -911,8 +1022,11 @@ Rails/SaveBang: - 'ee/spec/services/lfs/unlock_file_service_spec.rb' - 'ee/spec/services/merge_requests/approval_service_spec.rb' - 'ee/spec/services/merge_requests/remove_approval_service_spec.rb' + - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' - 'ee/spec/services/merge_trains/refresh_merge_request_service_spec.rb' - 'ee/spec/services/projects/after_rename_service_spec.rb' + - 'ee/spec/services/projects/import_export/export_service_spec.rb' + - 'ee/spec/services/projects/update_mirror_service_spec.rb' - 'ee/spec/services/projects/update_service_spec.rb' - 'ee/spec/services/quick_actions/interpret_service_spec.rb' - 'ee/spec/services/slash_commands/global_slack_handler_spec.rb' @@ -920,50 +1034,92 @@ Rails/SaveBang: - 'ee/spec/services/status_page/trigger_publish_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/services/update_build_minutes_service_spec.rb' + - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' + - 'ee/spec/support/helpers/ee/geo_helpers.rb' + - 'ee/spec/support/protected_tags/access_control_shared_examples.rb' + - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' + - 'ee/spec/support/shared_examples/finders/geo/framework_registry_finder_shared_examples.rb' + - 'ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb' - 'ee/spec/support/shared_examples/lib/analytics/common_merge_request_metrics_refresh_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/replicator_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/elasticsearch_indexed_container_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/geo_framework_registry_shared_examples.rb' - 'ee/spec/support/shared_examples/models/member_shared_examples.rb' - 'ee/spec/support/shared_examples/models/mentionable_shared_examples.rb' - 'ee/spec/support/shared_examples/policies/protected_environments_shared_examples.rb' + - 'ee/spec/support/shared_examples/requests/api/graphql/geo/registries_shared_examples.rb' - 'ee/spec/support/shared_examples/requests/api/project_approval_rules_api_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/build_execute_shared_examples.rb' - 'ee/spec/support/shared_examples/services/issue_epic_shared_examples.rb' - 'ee/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - 'ee/spec/workers/adjourned_project_deletion_worker_spec.rb' + - 'ee/spec/workers/clear_shared_runners_minutes_worker_spec.rb' - 'ee/spec/workers/create_github_webhook_worker_spec.rb' - - 'ee/spec/workers/elastic_indexer_worker_spec.rb' + - 'ee/spec/workers/elastic_namespace_rollout_worker_spec.rb' - 'ee/spec/workers/geo/container_repository_sync_dispatch_worker_spec.rb' - 'ee/spec/workers/geo/file_download_dispatch_worker_spec.rb' + - 'ee/spec/workers/geo/prune_event_log_worker_spec.rb' + - 'ee/spec/workers/geo/registry_sync_worker_spec.rb' - 'ee/spec/workers/geo/repository_shard_sync_worker_spec.rb' - 'ee/spec/workers/repository_import_worker_spec.rb' - 'ee/spec/workers/update_all_mirrors_worker_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_over_http_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_http_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb' - 'spec/controllers/abuse_reports_controller_spec.rb' - 'spec/controllers/admin/impersonations_controller_spec.rb' - 'spec/controllers/admin/runners_controller_spec.rb' + - 'spec/controllers/admin/services_controller_spec.rb' - 'spec/controllers/boards/issues_controller_spec.rb' + - 'spec/controllers/groups/milestones_controller_spec.rb' - 'spec/controllers/groups/runners_controller_spec.rb' + - 'spec/controllers/groups/uploads_controller_spec.rb' + - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/oauth/authorizations_controller_spec.rb' - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/profiles/emails_controller_spec.rb' - 'spec/controllers/profiles/notifications_controller_spec.rb' - 'spec/controllers/projects/artifacts_controller_spec.rb' + - 'spec/controllers/projects/cycle_analytics/events_controller_spec.rb' - 'spec/controllers/projects/cycle_analytics_controller_spec.rb' + - 'spec/controllers/projects/discussions_controller_spec.rb' + - 'spec/controllers/projects/forks_controller_spec.rb' + - 'spec/controllers/projects/group_links_controller_spec.rb' + - 'spec/controllers/projects/imports_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - 'spec/controllers/projects/labels_controller_spec.rb' - 'spec/controllers/projects/merge_requests_controller_spec.rb' - 'spec/controllers/projects/milestones_controller_spec.rb' - 'spec/controllers/projects/notes_controller_spec.rb' - 'spec/controllers/projects/pipelines_controller_spec.rb' + - 'spec/controllers/projects/releases/evidences_controller_spec.rb' - 'spec/controllers/projects/runners_controller_spec.rb' + - 'spec/controllers/projects/starrers_controller_spec.rb' + - 'spec/controllers/projects/uploads_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' + - 'spec/controllers/sent_notifications_controller_spec.rb' + - 'spec/controllers/sessions_controller_spec.rb' + - 'spec/controllers/users_controller_spec.rb' + - 'spec/factories/alert_management/alerts.rb' + - 'spec/factories/boards.rb' - 'spec/factories/ci/pipelines.rb' - 'spec/factories/design_management/designs.rb' - 'spec/factories/design_management/versions.rb' + - 'spec/factories/emails.rb' + - 'spec/factories/issues.rb' - 'spec/factories/labels.rb' + - 'spec/factories/merge_requests.rb' + - 'spec/factories/plans.rb' - 'spec/factories/projects.rb' + - 'spec/factories/services.rb' + - 'spec/factories/wiki_pages.rb' + - 'spec/factories_spec.rb' + - 'spec/features/admin/admin_appearance_spec.rb' + - 'spec/features/admin/admin_labels_spec.rb' - 'spec/features/admin/admin_mode/login_spec.rb' - 'spec/features/admin/admin_runners_spec.rb' + - 'spec/features/admin/admin_sees_project_statistics_spec.rb' + - 'spec/features/admin/admin_sees_projects_statistics_spec.rb' - 'spec/features/admin/admin_users_impersonation_tokens_spec.rb' - 'spec/features/admin/admin_users_spec.rb' - 'spec/features/boards/sidebar_spec.rb' @@ -975,6 +1131,7 @@ Rails/SaveBang: - 'spec/features/dashboard/projects_spec.rb' - 'spec/features/error_tracking/user_sees_error_index_spec.rb' - 'spec/features/groups/members/request_access_spec.rb' + - 'spec/features/issuables/close_reopen_report_toggle_spec.rb' - 'spec/features/issues/bulk_assignment_labels_spec.rb' - 'spec/features/issues/gfm_autocomplete_spec.rb' - 'spec/features/issues/issue_sidebar_spec.rb' @@ -989,30 +1146,45 @@ Rails/SaveBang: - 'spec/features/merge_request/user_posts_diff_notes_spec.rb' - 'spec/features/merge_request/user_resolves_diff_notes_and_discussions_resolve_spec.rb' - 'spec/features/merge_request/user_sees_cherry_pick_modal_spec.rb' + - 'spec/features/merge_request/user_sees_discussions_spec.rb' - 'spec/features/merge_request/user_sees_merge_widget_spec.rb' + - 'spec/features/merge_request/user_sees_versions_spec.rb' - 'spec/features/merge_requests/user_mass_updates_spec.rb' - 'spec/features/profiles/emails_spec.rb' - 'spec/features/profiles/password_spec.rb' - 'spec/features/profiles/personal_access_tokens_spec.rb' - 'spec/features/projects/features_visibility_spec.rb' + - 'spec/features/projects/fork_spec.rb' + - 'spec/features/projects/jobs/permissions_spec.rb' - 'spec/features/projects/jobs_spec.rb' - 'spec/features/projects/members/user_requests_access_spec.rb' - 'spec/features/projects/pages_lets_encrypt_spec.rb' - 'spec/features/projects/pages_spec.rb' + - 'spec/features/projects/pipelines/pipeline_spec.rb' + - 'spec/features/projects/pipelines/pipelines_spec.rb' - 'spec/features/projects/remote_mirror_spec.rb' - 'spec/features/projects/services/user_activates_slack_notifications_spec.rb' - 'spec/features/projects/settings/access_tokens_spec.rb' - 'spec/features/projects/show/user_sees_deletion_failure_message_spec.rb' - 'spec/features/projects/user_sees_sidebar_spec.rb' - 'spec/features/projects/wiki/user_updates_wiki_page_spec.rb' + - 'spec/features/projects/wiki/user_views_wiki_page_spec.rb' - 'spec/features/projects/wiki/users_views_asciidoc_page_with_includes_spec.rb' + - 'spec/features/runners_spec.rb' + - 'spec/features/security/project/internal_access_spec.rb' - 'spec/features/security/project/private_access_spec.rb' + - 'spec/features/security/project/public_access_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/features/users/show_spec.rb' + - 'spec/finders/admin/projects_finder_spec.rb' - 'spec/finders/autocomplete/move_to_project_finder_spec.rb' + - 'spec/finders/ci/pipelines_for_merge_request_finder_spec.rb' - 'spec/finders/group_descendants_finder_spec.rb' + - 'spec/finders/group_projects_finder_spec.rb' - 'spec/finders/issues_finder_spec.rb' + - 'spec/finders/joined_groups_finder_spec.rb' - 'spec/finders/merge_requests_finder_spec.rb' + - 'spec/finders/personal_projects_finder_spec.rb' - 'spec/finders/projects_finder_spec.rb' - 'spec/finders/uploader_finder_spec.rb' - 'spec/frontend/fixtures/issues.rb' @@ -1021,6 +1193,11 @@ Rails/SaveBang: - 'spec/graphql/mutations/merge_requests/set_wip_spec.rb' - 'spec/graphql/resolvers/boards_resolver_spec.rb' - 'spec/helpers/appearances_helper_spec.rb' + - 'spec/helpers/auto_devops_helper_spec.rb' + - 'spec/helpers/issuables_helper_spec.rb' + - 'spec/helpers/issues_helper_spec.rb' + - 'spec/helpers/members_helper_spec.rb' + - 'spec/helpers/notes_helper_spec.rb' - 'spec/helpers/profiles_helper_spec.rb' - 'spec/helpers/projects/alert_management_helper_spec.rb' - 'spec/helpers/projects_helper_spec.rb' @@ -1030,18 +1207,23 @@ Rails/SaveBang: - 'spec/lib/after_commit_queue_spec.rb' - 'spec/lib/backup/manager_spec.rb' - 'spec/lib/banzai/reference_parser/external_issue_parser_spec.rb' + - 'spec/lib/banzai/reference_redactor_spec.rb' + - 'spec/lib/gitlab/alerting/alert_spec.rb' - 'spec/lib/gitlab/analytics/cycle_analytics/records_fetcher_spec.rb' - 'spec/lib/gitlab/auth/ldap/user_spec.rb' - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - 'spec/lib/gitlab/auth/saml/user_spec.rb' - 'spec/lib/gitlab/auth_spec.rb' + - 'spec/lib/gitlab/authorized_keys_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_deployment_clusters_from_deployments_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_settings_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_push_rules_id_in_projects_spec.rb' + - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/digest_column_spec.rb' - 'spec/lib/gitlab/background_migration/encrypt_columns_spec.rb' - 'spec/lib/gitlab/background_migration/fix_cross_project_label_links_spec.rb' + - 'spec/lib/gitlab/background_migration/fix_projects_without_project_feature_spec.rb' - 'spec/lib/gitlab/background_migration/fix_projects_without_prometheus_service_spec.rb' - 'spec/lib/gitlab/background_migration/fix_user_namespace_names_spec.rb' - 'spec/lib/gitlab/background_migration/fix_user_project_route_names_spec.rb' @@ -1056,82 +1238,130 @@ Rails/SaveBang: - 'spec/lib/gitlab/background_migration/populate_user_highest_roles_table_spec.rb' - 'spec/lib/gitlab/background_migration/recalculate_project_authorizations_spec.rb' - 'spec/lib/gitlab/background_migration/remove_restricted_todos_spec.rb' + - 'spec/lib/gitlab/background_migration/reset_merge_status_spec.rb' - 'spec/lib/gitlab/background_migration/set_confidential_note_events_on_services_spec.rb' - 'spec/lib/gitlab/background_migration/set_confidential_note_events_on_webhooks_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/style_spec.rb' + - 'spec/lib/gitlab/ci/status/build/common_spec.rb' - 'spec/lib/gitlab/cycle_analytics/base_event_fetcher_spec.rb' - 'spec/lib/gitlab/cycle_analytics/events_spec.rb' - 'spec/lib/gitlab/database/custom_structure_spec.rb' - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/database_importers/self_monitoring/project/create_service_spec.rb' + - 'spec/lib/gitlab/email/handler/create_note_handler_spec.rb' + - 'spec/lib/gitlab/email/handler/unsubscribe_handler_spec.rb' + - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb' + - 'spec/lib/gitlab/git/object_pool_spec.rb' - 'spec/lib/gitlab/git/remote_mirror_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/git_access_spec.rb' + - 'spec/lib/gitlab/gitaly_client/object_pool_service_spec.rb' - 'spec/lib/gitlab/gitaly_client/repository_service_spec.rb' - 'spec/lib/gitlab/import_export/avatar_saver_spec.rb' + - 'spec/lib/gitlab/import_export/base/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/design_repo_restorer_spec.rb' - 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb' - 'spec/lib/gitlab/import_export/fork_spec.rb' - 'spec/lib/gitlab/import_export/group/legacy_tree_saver_spec.rb' + - 'spec/lib/gitlab/import_export/group/relation_factory_spec.rb' + - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb' - 'spec/lib/gitlab/import_export/importer_spec.rb' - 'spec/lib/gitlab/import_export/lfs_restorer_spec.rb' - 'spec/lib/gitlab/import_export/lfs_saver_spec.rb' - 'spec/lib/gitlab/import_export/members_mapper_spec.rb' + - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' - 'spec/lib/gitlab/import_export/repo_restorer_spec.rb' - 'spec/lib/gitlab/import_export/saver_spec.rb' + - 'spec/lib/gitlab/import_export/snippet_repo_restorer_spec.rb' - 'spec/lib/gitlab/import_export/snippet_repo_saver_spec.rb' - 'spec/lib/gitlab/import_export/snippets_repo_restorer_spec.rb' - 'spec/lib/gitlab/import_export/snippets_repo_saver_spec.rb' - 'spec/lib/gitlab/import_export/uploads_manager_spec.rb' - 'spec/lib/gitlab/import_export/uploads_saver_spec.rb' - 'spec/lib/gitlab/import_export/wiki_restorer_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/issue_formatter_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/milestone_formatter_spec.rb' + - 'spec/lib/gitlab/legacy_github_import/pull_request_formatter_spec.rb' - 'spec/lib/gitlab/lets_encrypt/client_spec.rb' - 'spec/lib/gitlab/markdown_cache/active_record/extension_spec.rb' - 'spec/lib/gitlab/markdown_cache/redis/store_spec.rb' + - 'spec/lib/gitlab/middleware/go_spec.rb' - 'spec/lib/gitlab/shard_health_cache_spec.rb' + - 'spec/lib/mattermost/command_spec.rb' + - 'spec/lib/mattermost/session_spec.rb' + - 'spec/lib/mattermost/team_spec.rb' - 'spec/mailers/notify_spec.rb' + - 'spec/migrations/20190924152703_migrate_issue_trackers_data_spec.rb' - 'spec/migrations/20200122123016_backfill_project_settings_spec.rb' - 'spec/migrations/20200123155929_remove_invalid_jira_data_spec.rb' - 'spec/migrations/20200127090233_remove_invalid_issue_tracker_data_spec.rb' + - 'spec/migrations/20200130145430_reschedule_migrate_issue_trackers_data_spec.rb' + - 'spec/migrations/20200313203550_remove_orphaned_chat_names_spec.rb' - 'spec/migrations/20200406102120_backfill_deployment_clusters_from_deployments_spec.rb' + - 'spec/migrations/20200526115436_dedup_mr_metrics_spec.rb' + - 'spec/migrations/add_deploy_token_type_to_deploy_tokens_spec.rb' + - 'spec/migrations/add_incident_settings_to_all_existing_projects_spec.rb' - 'spec/migrations/add_unique_constraint_to_approvals_user_id_and_merge_request_id_spec.rb' - 'spec/migrations/backfill_and_add_not_null_constraint_to_released_at_column_on_releases_table_spec.rb' + - 'spec/migrations/backfill_imported_snippet_repositories_spec.rb' - 'spec/migrations/backfill_releases_table_updated_at_and_add_not_null_constraints_to_timestamps_spec.rb' + - 'spec/migrations/backfill_snippet_repositories_spec.rb' - 'spec/migrations/encrypt_plaintext_attributes_on_application_settings_spec.rb' + - 'spec/migrations/enqueue_reset_merge_status_second_run_spec.rb' + - 'spec/migrations/enqueue_reset_merge_status_spec.rb' - 'spec/migrations/fill_file_store_lfs_objects_spec.rb' - 'spec/migrations/fill_store_uploads_spec.rb' - 'spec/migrations/fix_null_type_labels_spec.rb' - 'spec/migrations/fix_pool_repository_source_project_id_spec.rb' + - 'spec/migrations/fix_projects_without_project_feature_spec.rb' + - 'spec/migrations/fix_projects_without_prometheus_services_spec.rb' - 'spec/migrations/fix_wrong_pages_access_level_spec.rb' - 'spec/migrations/insert_project_hooks_plan_limits_spec.rb' - 'spec/migrations/migrate_auto_dev_ops_domain_to_cluster_domain_spec.rb' + - 'spec/migrations/move_limits_from_plans_spec.rb' + - 'spec/migrations/populate_project_statistics_packages_size_spec.rb' - 'spec/migrations/schedule_link_lfs_objects_projects_spec.rb' + - 'spec/migrations/schedule_populate_merge_request_assignees_table_spec.rb' + - 'spec/migrations/seed_repository_storages_weighted_spec.rb' - 'spec/models/appearance_spec.rb' + - 'spec/models/application_record_spec.rb' - 'spec/models/application_setting_spec.rb' + - 'spec/models/ci/build_metadata_spec.rb' - 'spec/models/ci/build_spec.rb' + - 'spec/models/ci/build_trace_chunk_spec.rb' - 'spec/models/ci/instance_variable_spec.rb' + - 'spec/models/ci/legacy_stage_spec.rb' + - 'spec/models/ci/persistent_ref_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/ci/runner_spec.rb' - 'spec/models/clusters/applications/helm_spec.rb' + - 'spec/models/commit_spec.rb' + - 'spec/models/commit_status_spec.rb' - 'spec/models/concerns/avatarable_spec.rb' - 'spec/models/concerns/bulk_insertable_associations_spec.rb' - 'spec/models/concerns/cache_markdown_field_spec.rb' + - 'spec/models/concerns/case_sensitivity_spec.rb' - 'spec/models/concerns/featurable_spec.rb' - 'spec/models/concerns/issuable_spec.rb' - 'spec/models/concerns/mentionable_spec.rb' - 'spec/models/concerns/milestoneable_spec.rb' + - 'spec/models/concerns/milestoneish_spec.rb' - 'spec/models/concerns/routable_spec.rb' - 'spec/models/concerns/subscribable_spec.rb' - 'spec/models/concerns/token_authenticatable_spec.rb' - 'spec/models/container_repository_spec.rb' - 'spec/models/cycle_analytics/issue_spec.rb' - 'spec/models/cycle_analytics/plan_spec.rb' + - 'spec/models/cycle_analytics/production_spec.rb' - 'spec/models/deploy_keys_project_spec.rb' - 'spec/models/deploy_token_spec.rb' - 'spec/models/deployment_spec.rb' - 'spec/models/design_management/version_spec.rb' + - 'spec/models/diff_discussion_spec.rb' - 'spec/models/diff_note_spec.rb' - 'spec/models/email_spec.rb' - 'spec/models/environment_spec.rb' @@ -1143,7 +1373,9 @@ Rails/SaveBang: - 'spec/models/hooks/system_hook_spec.rb' - 'spec/models/hooks/web_hook_spec.rb' - 'spec/models/identity_spec.rb' + - 'spec/models/issue/metrics_spec.rb' - 'spec/models/issue_spec.rb' + - 'spec/models/jira_import_state_spec.rb' - 'spec/models/key_spec.rb' - 'spec/models/lfs_objects_project_spec.rb' - 'spec/models/member_spec.rb' @@ -1155,12 +1387,18 @@ Rails/SaveBang: - 'spec/models/note_spec.rb' - 'spec/models/notification_setting_spec.rb' - 'spec/models/pages_domain_spec.rb' + - 'spec/models/project_auto_devops_spec.rb' + - 'spec/models/project_feature_spec.rb' - 'spec/models/project_services/bamboo_service_spec.rb' + - 'spec/models/project_services/buildkite_service_spec.rb' - 'spec/models/project_services/jira_service_spec.rb' + - 'spec/models/project_services/packagist_service_spec.rb' - 'spec/models/project_services/pipelines_email_service_spec.rb' - 'spec/models/project_services/teamcity_service_spec.rb' - 'spec/models/project_spec.rb' - 'spec/models/project_team_spec.rb' + - 'spec/models/protectable_dropdown_spec.rb' + - 'spec/models/redirect_route_spec.rb' - 'spec/models/release_spec.rb' - 'spec/models/remote_mirror_spec.rb' - 'spec/models/resource_milestone_event_spec.rb' @@ -1171,47 +1409,77 @@ Rails/SaveBang: - 'spec/models/upload_spec.rb' - 'spec/models/user_preference_spec.rb' - 'spec/models/user_spec.rb' + - 'spec/models/user_status_spec.rb' - 'spec/models/wiki_page/meta_spec.rb' - 'spec/models/wiki_page_spec.rb' - 'spec/policies/ci/build_policy_spec.rb' - 'spec/policies/ci/pipeline_policy_spec.rb' - 'spec/policies/ci/pipeline_schedule_policy_spec.rb' + - 'spec/policies/group_policy_spec.rb' + - 'spec/policies/issue_policy_spec.rb' - 'spec/policies/merge_request_policy_spec.rb' - 'spec/policies/project_policy_spec.rb' + - 'spec/presenters/ci/build_runner_presenter_spec.rb' + - 'spec/presenters/ci/trigger_presenter_spec.rb' + - 'spec/presenters/packages/conan/package_presenter_spec.rb' + - 'spec/requests/api/access_requests_spec.rb' - 'spec/requests/api/boards_spec.rb' + - 'spec/requests/api/branches_spec.rb' + - 'spec/requests/api/ci/runner_spec.rb' + - 'spec/requests/api/commit_statuses_spec.rb' + - 'spec/requests/api/conan_packages_spec.rb' - 'spec/requests/api/deployments_spec.rb' - 'spec/requests/api/environments_spec.rb' + - 'spec/requests/api/go_proxy_spec.rb' - 'spec/requests/api/graphql/mutations/merge_requests/set_labels_spec.rb' - 'spec/requests/api/graphql/user_query_spec.rb' - 'spec/requests/api/graphql_spec.rb' + - 'spec/requests/api/group_import_spec.rb' - 'spec/requests/api/group_milestones_spec.rb' - 'spec/requests/api/internal/base_spec.rb' - 'spec/requests/api/issues/get_group_issues_spec.rb' + - 'spec/requests/api/issues/post_projects_issues_spec.rb' - 'spec/requests/api/jobs_spec.rb' - 'spec/requests/api/labels_spec.rb' + - 'spec/requests/api/maven_packages_spec.rb' - 'spec/requests/api/members_spec.rb' - 'spec/requests/api/merge_request_diffs_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' + - 'spec/requests/api/notes_spec.rb' + - 'spec/requests/api/pages/internal_access_spec.rb' + - 'spec/requests/api/pages/private_access_spec.rb' + - 'spec/requests/api/pages/public_access_spec.rb' - 'spec/requests/api/pipeline_schedules_spec.rb' - 'spec/requests/api/project_import_spec.rb' + - 'spec/requests/api/project_milestones_spec.rb' - 'spec/requests/api/projects_spec.rb' - - 'spec/requests/api/runners_spec.rb' - 'spec/requests/api/snippets_spec.rb' - 'spec/requests/git_http_spec.rb' + - 'spec/requests/lfs_http_spec.rb' - 'spec/requests/profiles/notifications_controller_spec.rb' - 'spec/requests/projects/cycle_analytics_events_spec.rb' - 'spec/serializers/environment_status_entity_spec.rb' + - 'spec/serializers/issue_entity_spec.rb' + - 'spec/serializers/job_entity_spec.rb' - 'spec/serializers/merge_request_poll_widget_entity_spec.rb' - 'spec/serializers/merge_request_widget_entity_spec.rb' + - 'spec/services/auth/container_registry_authentication_service_spec.rb' + - 'spec/services/auto_merge/base_service_spec.rb' + - 'spec/services/auto_merge_service_spec.rb' + - 'spec/services/ci/create_cross_project_pipeline_service_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' - 'spec/services/ci/register_job_service_spec.rb' - 'spec/services/ci/retry_build_service_spec.rb' + - 'spec/services/ci/update_runner_service_spec.rb' + - 'spec/services/clusters/update_service_spec.rb' - 'spec/services/deployments/after_create_service_spec.rb' - 'spec/services/design_management/generate_image_versions_service_spec.rb' + - 'spec/services/discussions/resolve_service_spec.rb' - 'spec/services/draft_notes/destroy_service_spec.rb' - 'spec/services/emails/confirm_service_spec.rb' - 'spec/services/groups/destroy_service_spec.rb' - 'spec/services/groups/import_export/import_service_spec.rb' + - 'spec/services/issuable/bulk_update_service_spec.rb' - 'spec/services/issuable/clone/attributes_rewriter_spec.rb' - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issues/close_service_spec.rb' @@ -1221,6 +1489,7 @@ Rails/SaveBang: - 'spec/services/issues/update_service_spec.rb' - 'spec/services/labels/promote_service_spec.rb' - 'spec/services/members/destroy_service_spec.rb' + - 'spec/services/merge_requests/build_service_spec.rb' - 'spec/services/merge_requests/conflicts/list_service_spec.rb' - 'spec/services/merge_requests/create_service_spec.rb' - 'spec/services/merge_requests/merge_service_spec.rb' @@ -1230,11 +1499,16 @@ Rails/SaveBang: - 'spec/services/milestones/destroy_service_spec.rb' - 'spec/services/milestones/promote_service_spec.rb' - 'spec/services/milestones/transfer_service_spec.rb' + - 'spec/services/notes/create_service_spec.rb' - 'spec/services/notification_recipients/build_service_spec.rb' - 'spec/services/notification_service_spec.rb' + - 'spec/services/packages/conan/create_package_file_service_spec.rb' - 'spec/services/projects/after_rename_service_spec.rb' + - 'spec/services/projects/autocomplete_service_spec.rb' - 'spec/services/projects/create_service_spec.rb' + - 'spec/services/projects/destroy_service_spec.rb' - 'spec/services/projects/fork_service_spec.rb' + - 'spec/services/projects/hashed_storage/base_attachment_service_spec.rb' - 'spec/services/projects/move_access_service_spec.rb' - 'spec/services/projects/move_project_group_links_service_spec.rb' - 'spec/services/projects/overwrite_project_service_spec.rb' @@ -1243,6 +1517,8 @@ Rails/SaveBang: - 'spec/services/projects/update_pages_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' - 'spec/services/quick_actions/interpret_service_spec.rb' + - 'spec/services/reset_project_cache_service_spec.rb' + - 'spec/services/resource_events/change_milestone_service_spec.rb' - 'spec/services/system_hooks_service_spec.rb' - 'spec/services/system_note_service_spec.rb' - 'spec/services/system_notes/issuables_service_spec.rb' @@ -1250,42 +1526,71 @@ Rails/SaveBang: - 'spec/services/todos/destroy/confidential_issue_service_spec.rb' - 'spec/services/users/destroy_service_spec.rb' - 'spec/services/users/repair_ldap_blocked_service_spec.rb' + - 'spec/services/verify_pages_domain_service_spec.rb' + - 'spec/sidekiq/cron/job_gem_dependency_spec.rb' - 'spec/support/helpers/cycle_analytics_helpers.rb' + - 'spec/support/helpers/design_management_test_helpers.rb' - 'spec/support/helpers/jira_service_helper.rb' - 'spec/support/helpers/login_helpers.rb' - 'spec/support/helpers/notification_helpers.rb' - - 'spec/support/helpers/stub_action_cable_connection.rb' - 'spec/support/helpers/stub_object_storage.rb' - 'spec/support/migrations_helpers/cluster_helpers.rb' + - 'spec/support/migrations_helpers/namespaces_helper.rb' - 'spec/support/migrations_helpers/track_untracked_uploads_helpers.rb' + - 'spec/support/shared_contexts/email_shared_context.rb' - 'spec/support/shared_contexts/finders/group_projects_finder_shared_contexts.rb' - 'spec/support/shared_contexts/mailers/notify_shared_context.rb' + - 'spec/support/shared_examples/controllers/cache_control_shared_examples.rb' - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb' - 'spec/support/shared_examples/controllers/sessionless_auth_controller_shared_examples.rb' - 'spec/support/shared_examples/features/editable_merge_request_shared_examples.rb' - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' + - 'spec/support/shared_examples/models/chat_slash_commands_shared_examples.rb' + - 'spec/support/shared_examples/models/cluster_application_helm_cert_shared_examples.rb' + - 'spec/support/shared_examples/models/concerns/limitable_shared_examples.rb' + - 'spec/support/shared_examples/models/concerns/timebox_shared_examples.rb' - 'spec/support/shared_examples/models/diff_note_after_commit_shared_examples.rb' - 'spec/support/shared_examples/models/member_shared_examples.rb' - 'spec/support/shared_examples/models/members_notifications_shared_example.rb' - 'spec/support/shared_examples/models/mentionable_shared_examples.rb' + - 'spec/support/shared_examples/models/project_latest_successful_build_for_shared_examples.rb' - 'spec/support/shared_examples/models/relative_positioning_shared_examples.rb' - 'spec/support/shared_examples/models/slack_mattermost_notifications_shared_examples.rb' - 'spec/support/shared_examples/models/update_project_statistics_shared_examples.rb' - 'spec/support/shared_examples/models/with_uploads_shared_examples.rb' + - 'spec/support/shared_examples/policies/project_policy_shared_examples.rb' - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb' - 'spec/support/shared_examples/quick_actions/merge_request/merge_quick_action_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/award_emoji_todo_shared_examples.rb' - 'spec/support/shared_examples/requests/api/boards_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/custom_attributes_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb' + - 'spec/support/shared_examples/serializers/note_entity_shared_examples.rb' - 'spec/support/shared_examples/services/common_system_notes_shared_examples.rb' - 'spec/support/shared_examples/services/issuable_shared_examples.rb' + - 'spec/support/shared_examples/services/wiki_pages/destroy_service_shared_examples.rb' - 'spec/tasks/gitlab/web_hook_rake_spec.rb' + - 'spec/uploaders/file_uploader_spec.rb' + - 'spec/uploaders/object_storage_spec.rb' + - 'spec/views/notify/changed_milestone_email.html.haml_spec.rb' - 'spec/views/projects/imports/new.html.haml_spec.rb' - 'spec/views/projects/merge_requests/show.html.haml_spec.rb' - 'spec/views/shared/_label_row.html.haml_spec.rb' + - 'spec/workers/concerns/project_export_options_spec.rb' + - 'spec/workers/gitlab/import/stuck_project_import_jobs_worker_spec.rb' + - 'spec/workers/gitlab/jira_import/stuck_jira_import_jobs_worker_spec.rb' - 'spec/workers/migrate_external_diffs_worker_spec.rb' - 'spec/workers/namespaceless_project_destroy_worker_spec.rb' + - 'spec/workers/namespaces/root_statistics_worker_spec.rb' - 'spec/workers/pages_domain_verification_worker_spec.rb' + - 'spec/workers/process_commit_worker_spec.rb' + - 'spec/workers/propagate_integration_worker_spec.rb' - 'spec/workers/propagate_service_template_worker_spec.rb' - 'spec/workers/remove_unreferenced_lfs_objects_worker_spec.rb' + - 'spec/workers/repository_check/single_repository_worker_spec.rb' - 'spec/workers/repository_cleanup_worker_spec.rb' - 'spec/workers/repository_import_worker_spec.rb' - 'spec/workers/repository_update_remote_mirror_worker_spec.rb' + - 'spec/workers/stuck_ci_jobs_worker_spec.rb' + - 'spec/workers/update_head_pipeline_for_merge_request_worker_spec.rb' |