diff options
Diffstat (limited to '.rubocop_todo/gitlab')
| -rw-r--r-- | .rubocop_todo/gitlab/delegate_predicate_methods.yml | 4 | ||||
| -rw-r--r-- | .rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/gitlab/doc_url.yml | 55 | ||||
| -rw-r--r-- | .rubocop_todo/gitlab/feature_available_usage.yml | 3 | ||||
| -rw-r--r-- | .rubocop_todo/gitlab/namespaced_class.yml | 7 | ||||
| -rw-r--r-- | .rubocop_todo/gitlab/no_code_coverage_comment.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/gitlab/strong_memoize_attr.yml | 18 |
7 files changed, 59 insertions, 30 deletions
diff --git a/.rubocop_todo/gitlab/delegate_predicate_methods.yml b/.rubocop_todo/gitlab/delegate_predicate_methods.yml deleted file mode 100644 index eb96914796f..00000000000 --- a/.rubocop_todo/gitlab/delegate_predicate_methods.yml +++ /dev/null @@ -1,4 +0,0 @@ ---- -Gitlab/DelegatePredicateMethods: - Exclude: - - 'app/models/clusters/cluster.rb' diff --git a/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml b/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml index ce2190c980c..f5433dfd320 100644 --- a/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml +++ b/.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml @@ -10,5 +10,4 @@ Gitlab/DeprecateTrackRedisHLLEvent: - 'ee/app/controllers/groups/analytics/ci_cd_analytics_controller.rb' - 'ee/app/controllers/groups/audit_events_controller.rb' - 'ee/app/controllers/groups/epic_boards_controller.rb' - - 'ee/app/controllers/groups/security/compliance_dashboards_controller.rb' - 'spec/controllers/concerns/redis_tracking_spec.rb' diff --git a/.rubocop_todo/gitlab/doc_url.yml b/.rubocop_todo/gitlab/doc_url.yml new file mode 100644 index 00000000000..67c70593b44 --- /dev/null +++ b/.rubocop_todo/gitlab/doc_url.yml @@ -0,0 +1,55 @@ +--- +Gitlab/DocUrl: + Details: grace period + Exclude: + - 'app/controllers/jira_connect/app_descriptor_controller.rb' + - 'app/graphql/types/merge_request_type.rb' + - 'app/graphql/types/notes/diff_position_input_type.rb' + - 'app/graphql/types/query_complexity_type.rb' + - 'app/models/integrations/apple_app_store.rb' + - 'app/models/integrations/microsoft_teams.rb' + - 'app/presenters/dev_ops_report/metric_presenter.rb' + - 'app/serializers/build_details_entity.rb' + - 'app/services/security/ci_configuration/container_scanning_create_service.rb' + - 'app/services/security/ci_configuration/dependency_scanning_create_service.rb' + - 'app/services/security/ci_configuration/sast_create_service.rb' + - 'app/services/security/ci_configuration/sast_iac_create_service.rb' + - 'app/services/security/ci_configuration/secret_detection_create_service.rb' + - 'app/services/tasks_to_be_done/create_ci_task_service.rb' + - 'app/services/tasks_to_be_done/create_code_task_service.rb' + - 'app/services/tasks_to_be_done/create_issues_task_service.rb' + - 'ee/app/graphql/mutations/requirements_management/export_requirements.rb' + - 'ee/app/graphql/types/vulnerability_state_enum.rb' + - 'ee/app/helpers/projects/learn_gitlab_helper.rb' + - 'ee/app/mailers/emails/user_cap.rb' + - 'ee/app/workers/concerns/elastic/migration_obsolete.rb' + - 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb' + - 'ee/lib/slack/block_kit/app_home_opened.rb' + - 'ee/lib/system_check/app/advanced_search_migrations_check.rb' + - 'ee/lib/tasks/gitlab/geo.rake' + - 'lib/backup/database.rb' + - 'lib/feature.rb' + - 'lib/gitlab/audit/auditor.rb' + - 'lib/gitlab/ci/config/entry/processable.rb' + - 'lib/gitlab/config_checker/external_database_checker.rb' + - 'lib/gitlab/config_checker/puma_rugged_checker.rb' + - 'lib/gitlab/database.rb' + - 'lib/gitlab/database/migration_helpers/automatic_lock_writes_on_tables.rb' + - 'lib/gitlab/database/migration_helpers/v2.rb' + - 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb' + - 'lib/gitlab/database/migrations/extension_helpers.rb' + - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' + - 'lib/gitlab/database/query_analyzers/restrict_allowed_schemas.rb' + - 'lib/gitlab/i18n/po_linter.rb' + - 'lib/gitlab/instrumentation/redis_base.rb' + - 'lib/gitlab/pagination/keyset/unsupported_scope_order.rb' + - 'lib/gitlab/redis/hll.rb' + - 'lib/gitlab/slash_commands/presenters/help.rb' + - 'lib/gitlab/utils/strong_memoize.rb' + - 'lib/initializer_connections.rb' + - 'lib/security/ci_configuration/base_build_action.rb' + - 'lib/tasks/db_obsolete_ignored_columns.rake' + - 'lib/tasks/gitlab/docs/redirect.rake' + - 'lib/tasks/gitlab/shell.rake' + - 'lib/tasks/migrate/schema_check.rake' + - 'lib/tasks/test.rake' diff --git a/.rubocop_todo/gitlab/feature_available_usage.yml b/.rubocop_todo/gitlab/feature_available_usage.yml index 26800923393..d7eec700a9d 100644 --- a/.rubocop_todo/gitlab/feature_available_usage.yml +++ b/.rubocop_todo/gitlab/feature_available_usage.yml @@ -58,7 +58,6 @@ Gitlab/FeatureAvailableUsage: - 'ee/app/policies/compliance_management/framework_policy.rb' - 'ee/app/policies/ee/group_policy.rb' - 'ee/app/policies/ee/project_policy.rb' - - 'ee/app/policies/ee/protected_branch_policy.rb' - 'ee/app/presenters/ee/label_presenter.rb' - 'ee/app/presenters/merge_request_approver_presenter.rb' - 'ee/app/serializers/dashboard_operations_project_entity.rb' @@ -109,8 +108,8 @@ Gitlab/FeatureAvailableUsage: - 'ee/lib/gitlab/code_owners.rb' - 'ee/lib/gitlab/path_locks_finder.rb' - 'ee/lib/incident_management/incident_sla.rb' + - 'ee/spec/models/ee/project_spec.rb' - 'ee/spec/models/instance_security_dashboard_spec.rb' - 'ee/spec/models/license_spec.rb' - - 'ee/spec/models/project_spec.rb' - 'lib/api/helpers/related_resources_helpers.rb' - 'spec/models/concerns/featurable_spec.rb' diff --git a/.rubocop_todo/gitlab/namespaced_class.yml b/.rubocop_todo/gitlab/namespaced_class.yml index f394851193c..eec55aa7bbe 100644 --- a/.rubocop_todo/gitlab/namespaced_class.yml +++ b/.rubocop_todo/gitlab/namespaced_class.yml @@ -429,6 +429,7 @@ Gitlab/NamespacedClass: - 'app/presenters/group_clusterable_presenter.rb' - 'app/presenters/group_member_presenter.rb' - 'app/presenters/instance_clusterable_presenter.rb' + - 'app/presenters/issue_email_participant_presenter.rb' - 'app/presenters/issue_presenter.rb' - 'app/presenters/label_presenter.rb' - 'app/presenters/member_presenter.rb' @@ -1074,7 +1075,6 @@ Gitlab/NamespacedClass: - 'ee/lib/gitlab/cidr.rb' - 'ee/lib/gitlab/custom_file_templates.rb' - 'ee/lib/gitlab/expiring_subscription_message.rb' - - 'ee/lib/gitlab/geo_logger.rb' - 'ee/lib/gitlab/group_plans_preloader.rb' - 'ee/lib/gitlab/ip_address_state.rb' - 'ee/lib/gitlab/items_collection.rb' @@ -1130,7 +1130,9 @@ Gitlab/NamespacedClass: - 'lib/gitlab/empty_search_results.rb' - 'lib/gitlab/encrypted_command_base.rb' - 'lib/gitlab/encrypted_configuration.rb' + - 'lib/gitlab/encrypted_incoming_email_command.rb' - 'lib/gitlab/encrypted_ldap_command.rb' + - 'lib/gitlab/encrypted_service_desk_email_command.rb' - 'lib/gitlab/encrypted_smtp_command.rb' - 'lib/gitlab/environment_logger.rb' - 'lib/gitlab/exceptions_app.rb' @@ -1266,10 +1268,7 @@ Gitlab/NamespacedClass: - 'spec/lib/bitbucket/collection_spec.rb' - 'spec/lib/gitlab/multi_destination_logger_spec.rb' - 'spec/lib/marginalia_spec.rb' - - 'spec/mailers/notify_spec.rb' - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' - - 'spec/models/concerns/bulk_insertable_associations_spec.rb' - - 'spec/models/concerns/triggerable_hooks_spec.rb' - 'spec/support/helpers/ci_artifact_metadata_generator.rb' - 'spec/support/helpers/fake_migration_classes.rb' - 'spec/support/helpers/fake_u2f_device.rb' diff --git a/.rubocop_todo/gitlab/no_code_coverage_comment.yml b/.rubocop_todo/gitlab/no_code_coverage_comment.yml index 195dfe5a81d..e37a9702094 100644 --- a/.rubocop_todo/gitlab/no_code_coverage_comment.yml +++ b/.rubocop_todo/gitlab/no_code_coverage_comment.yml @@ -13,6 +13,5 @@ Gitlab/NoCodeCoverageComment: - 'lib/gitlab/database/background_migration/health_status/signals.rb' - 'lib/gitlab/seeder.rb' - 'lib/gitlab/webpack/dev_server_middleware.rb' - - 'lib/tasks/dev.rake' - 'lib/tasks/gems.rake' - 'lib/tasks/gitlab/db.rake' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index 9fe784e1be9..1eeb7c69a96 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -97,9 +97,7 @@ Gitlab/StrongMemoizeAttr: - 'app/models/concerns/has_repository.rb' - 'app/models/concerns/has_wiki.rb' - 'app/models/concerns/has_wiki_page_meta_attributes.rb' - - 'app/models/concerns/mentionable/reference_regexes.rb' - 'app/models/concerns/redis_cacheable.rb' - - 'app/models/concerns/require_email_verification.rb' - 'app/models/concerns/resolvable_discussion.rb' - 'app/models/concerns/security/latest_pipeline_information.rb' - 'app/models/container_registry/event.rb' @@ -237,7 +235,6 @@ Gitlab/StrongMemoizeAttr: - 'app/services/packages/debian/generate_distribution_key_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - 'app/services/packages/debian/process_changes_service.rb' - - 'app/services/packages/debian/process_package_file_service.rb' - 'app/services/packages/helm/process_file_service.rb' - 'app/services/packages/maven/metadata/base_create_xml_service.rb' - 'app/services/packages/maven/metadata/create_plugins_xml_service.rb' @@ -326,9 +323,7 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/helpers/ee/trial_helper.rb' - 'ee/app/helpers/ee/welcome_helper.rb' - 'ee/app/helpers/license_monitoring_helper.rb' - - 'ee/app/helpers/paid_feature_callout_helper.rb' - 'ee/app/helpers/subscriptions_helper.rb' - - 'ee/app/helpers/trial_status_widget_helper.rb' - 'ee/app/models/approval_merge_request_rule.rb' - 'ee/app/models/approval_state.rb' - 'ee/app/models/approval_wrapped_any_approver_rule.rb' @@ -356,7 +351,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/models/ee/list.rb' - 'ee/app/models/ee/merge_request.rb' - 'ee/app/models/ee/namespace.rb' - - 'ee/app/models/ee/namespace/storage/notification.rb' - 'ee/app/models/ee/project.rb' - 'ee/app/models/ee/snippet.rb' - 'ee/app/models/ee/user.rb' @@ -490,13 +484,11 @@ Gitlab/StrongMemoizeAttr: - 'ee/lib/gitlab/code_owners/entry.rb' - 'ee/lib/gitlab/code_owners/loader.rb' - 'ee/lib/gitlab/custom_file_templates.rb' - - 'ee/lib/gitlab/elastic/client.rb' - 'ee/lib/gitlab/elastic/document_reference.rb' - 'ee/lib/gitlab/elastic/indexer.rb' - 'ee/lib/gitlab/elastic/project_search_results.rb' - 'ee/lib/gitlab/elastic/search_results.rb' - 'ee/lib/gitlab/expiring_subscription_message.rb' - - 'ee/lib/gitlab/geo.rb' - 'ee/lib/gitlab/geo/health_check.rb' - 'ee/lib/gitlab/geo/jwt_request_decoder.rb' - 'ee/lib/gitlab/geo/oauth/logout_state.rb' @@ -593,7 +585,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/ci/pipeline/chain/seed.rb' - 'lib/gitlab/ci/pipeline/chain/skip.rb' - 'lib/gitlab/ci/pipeline/expression/lexer.rb' - - 'lib/gitlab/ci/pipeline/metrics.rb' - 'lib/gitlab/ci/pipeline/quota/deployments.rb' - 'lib/gitlab/ci/pipeline/seed/processable/resource_group.rb' - 'lib/gitlab/ci/project_config/auto_devops.rb' @@ -602,7 +593,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/ci/project_config/remote.rb' - 'lib/gitlab/ci/project_config/repository.rb' - 'lib/gitlab/ci/project_config/source.rb' - - 'lib/gitlab/ci/queue/metrics.rb' - 'lib/gitlab/ci/reports/accessibility_reports_comparer.rb' - 'lib/gitlab/ci/reports/codequality_reports_comparer.rb' - 'lib/gitlab/ci/reports/security/locations/base.rb' @@ -610,13 +600,11 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/ci/reports/test_reports_comparer.rb' - 'lib/gitlab/ci/reports/test_suite_comparer.rb' - 'lib/gitlab/ci/reports/test_suite_summary.rb' - - 'lib/gitlab/ci/runner/metrics.rb' - 'lib/gitlab/ci/status/composite.rb' - 'lib/gitlab/ci/tags/bulk_insert.rb' - 'lib/gitlab/ci/trace.rb' - 'lib/gitlab/ci/trace/archive.rb' - 'lib/gitlab/ci/trace/checksum.rb' - - 'lib/gitlab/ci/trace/metrics.rb' - 'lib/gitlab/ci/trace/remote_checksum.rb' - 'lib/gitlab/ci/variables/builder.rb' - 'lib/gitlab/ci/variables/builder/group.rb' @@ -629,9 +617,7 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/config/entry/composable_array.rb' - 'lib/gitlab/config/loader/yaml.rb' - 'lib/gitlab/conflict/file.rb' - - 'lib/gitlab/database/as_with_materialized.rb' - 'lib/gitlab/database/background_migration/health_status/indicators/write_ahead_log.rb' - - 'lib/gitlab/database/background_migration/prometheus_metrics.rb' - 'lib/gitlab/database/bulk_update.rb' - 'lib/gitlab/database/load_balancing/srv_resolver.rb' - 'lib/gitlab/database/metrics.rb' @@ -647,7 +633,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/diff/suggestion.rb' - 'lib/gitlab/discussions_diff/file_collection.rb' - 'lib/gitlab/email/handler/service_desk_handler.rb' - - 'lib/gitlab/email/hook/delivery_metrics_observer.rb' - 'lib/gitlab/email/receiver.rb' - 'lib/gitlab/external_authorization/response.rb' - 'lib/gitlab/gfm/reference_rewriter.rb' @@ -691,7 +676,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/metrics/dashboard/stages/grafana_formatter.rb' - 'lib/gitlab/metrics/dashboard/url.rb' - 'lib/gitlab/metrics/prometheus.rb' - - 'lib/gitlab/metrics/subscribers/active_record.rb' - 'lib/gitlab/pages/cache_control.rb' - 'lib/gitlab/prometheus_client.rb' - 'lib/gitlab/rack_attack/request.rb' @@ -717,7 +701,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/webpack/graphql_known_operations.rb' - 'lib/gitlab/webpack/manifest.rb' - 'lib/gitlab/wiki_pages/front_matter_parser.rb' - - 'lib/gitlab/x509/certificate.rb' - 'lib/gitlab/x509/signature.rb' - 'lib/gitlab/x509/tag.rb' - 'lib/grafana/time_window.rb' @@ -727,6 +710,5 @@ Gitlab/StrongMemoizeAttr: - 'lib/sidebars/groups/menus/merge_requests_menu.rb' - 'lib/sidebars/projects/menus/analytics_menu.rb' - 'lib/sidebars/projects/menus/issues_menu.rb' - - 'lib/sidebars/projects/menus/learn_gitlab_menu.rb' - 'lib/unnested_in_filters/rewriter.rb' - 'tooling/graphql/docs/helper.rb' |