diff options
Diffstat (limited to '.rubocop_todo/lint')
22 files changed, 1889 insertions, 22 deletions
diff --git a/.rubocop_todo/lint/ambiguous_operator_precedence.yml b/.rubocop_todo/lint/ambiguous_operator_precedence.yml new file mode 100644 index 00000000000..ea6cadc7f8a --- /dev/null +++ b/.rubocop_todo/lint/ambiguous_operator_precedence.yml @@ -0,0 +1,152 @@ +--- +# Cop supports --autocorrect. +Lint/AmbiguousOperatorPrecedence: + Details: grace period + Exclude: + - 'app/controllers/explore/projects_controller.rb' + - 'app/controllers/omniauth_callbacks_controller.rb' + - 'app/controllers/profiles/two_factor_auths_controller.rb' + - 'app/helpers/form_helper.rb' + - 'app/helpers/groups_helper.rb' + - 'app/helpers/time_helper.rb' + - 'app/helpers/timeboxes_helper.rb' + - 'app/helpers/tree_helper.rb' + - 'app/helpers/users_helper.rb' + - 'app/models/concerns/relative_positioning.rb' + - 'app/models/design_management/version.rb' + - 'app/models/integrations/chat_message/pipeline_message.rb' + - 'app/models/merge_request_diff.rb' + - 'app/models/namespace.rb' + - 'app/models/network/graph.rb' + - 'app/models/note.rb' + - 'app/models/notification_reason.rb' + - 'app/models/project_feature.rb' + - 'app/models/terraform/state.rb' + - 'app/models/webauthn_registration.rb' + - 'app/presenters/project_presenter.rb' + - 'app/services/cohorts_service.rb' + - 'app/services/concerns/validates_classification_label.rb' + - 'app/services/groups/group_links/destroy_service.rb' + - 'app/services/issuable_links/create_service.rb' + - 'app/services/issues/relative_position_rebalancing_service.rb' + - 'app/services/jira/requests/base.rb' + - 'app/services/projects/blame_service.rb' + - 'config/initializers/1_settings.rb' + - 'config/initializers/carrierwave_patch.rb' + - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' + - 'danger/roulette/Dangerfile' + - 'ee/app/models/ee/integrations/jira.rb' + - 'ee/app/models/geo/upload_registry.rb' + - 'ee/app/models/iterations/cadence.rb' + - 'ee/app/models/license.rb' + - 'ee/app/models/namespaces/storage/root_size.rb' + - 'ee/app/policies/ee/issuable_policy.rb' + - 'ee/app/services/boards/epics/position_create_service.rb' + - 'ee/app/services/geo/registry_consistency_service.rb' + - 'ee/app/services/vulnerabilities/create_service.rb' + - 'ee/lib/gitlab/expiring_subscription_message.rb' + - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' + - 'ee/spec/models/ee/audit_event_spec.rb' + - 'ee/spec/models/ee/iterations/cadence_spec.rb' + - 'ee/spec/models/ee/project_statistics_spec.rb' + - 'ee/spec/models/geo/project_registry_spec.rb' + - 'ee/spec/models/license_spec.rb' + - 'ee/spec/models/security/finding_spec.rb' + - 'ee/spec/models/status_page/project_setting_spec.rb' + - 'ee/spec/presenters/subscription_presenter_spec.rb' + - 'ee/spec/requests/api/graphql/project/incident_management/oncall_shifts_spec.rb' + - 'ee/spec/services/boards/epics/position_create_service_spec.rb' + - 'ee/spec/support/shared_examples/models/geo_framework_registry_shared_examples.rb' + - 'ee/spec/workers/incident_management/oncall_rotations/persist_shifts_job_spec.rb' + - 'lib/banzai/filter/references/user_reference_filter.rb' + - 'lib/banzai/filter_array.rb' + - 'lib/extracts_ref.rb' + - 'lib/gitlab/chaos.rb' + - 'lib/gitlab/ci/config/normalizer/number_strategy.rb' + - 'lib/gitlab/console.rb' + - 'lib/gitlab/database/background_migration/batch_metrics.rb' + - 'lib/gitlab/database/background_migration/batched_migration.rb' + - 'lib/gitlab/database/migrations/background_migration_helpers.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' + - 'lib/gitlab/database/postgres_hll/buckets.rb' + - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' + - 'lib/gitlab/email/message/in_product_marketing/helper.rb' + - 'lib/gitlab/i18n/po_linter.rb' + - 'lib/gitlab/import_export/project/relation_factory.rb' + - 'lib/gitlab/memory/instrumentation.rb' + - 'lib/gitlab/metrics/prometheus.rb' + - 'lib/gitlab/middleware/rails_queue_duration.rb' + - 'lib/gitlab/pagination/gitaly_keyset_pager.rb' + - 'lib/gitlab/quick_actions/issuable_actions.rb' + - 'lib/gitlab/relative_positioning.rb' + - 'lib/gitlab/template_parser/parser.rb' + - 'lib/gitlab/tree_summary.rb' + - 'lib/gitlab/usage/metrics/name_suggestion.rb' + - 'lib/gitlab/utils/email.rb' + - 'lib/omni_auth/strategies/bitbucket.rb' + - 'qa/qa/ee/page/project/secure/pipeline_security.rb' + - 'qa/qa/resource/api_fabricator.rb' + - 'qa/qa/resource/group_access_token.rb' + - 'qa/qa/resource/impersonation_token.rb' + - 'qa/qa/resource/personal_access_token.rb' + - 'qa/qa/resource/project_access_token.rb' + - 'qa/qa/runtime/feature.rb' + - 'qa/qa/tools/test_resources_handler.rb' + - 'scripts/packages/automated_cleanup.rb' + - 'scripts/perf/gc/print_gc_stats.rb' + - 'scripts/perf/query_limiting_report.rb' + - 'scripts/review_apps/automated_cleanup.rb' + - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/controllers/search_controller_spec.rb' + - 'spec/helpers/events_helper_spec.rb' + - 'spec/helpers/time_helper_spec.rb' + - 'spec/lib/api/helpers/pagination_strategies_spec.rb' + - 'spec/lib/banzai/filter/front_matter_filter_spec.rb' + - 'spec/lib/gitlab/ci/ansi2json/line_spec.rb' + - 'spec/lib/gitlab/ci/runner_releases_spec.rb' + - 'spec/lib/gitlab/ci/trace/chunked_io_spec.rb' + - 'spec/lib/gitlab/ci/trace/stream_spec.rb' + - 'spec/lib/gitlab/conan_token_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' + - 'spec/lib/gitlab/database/batch_count_spec.rb' + - 'spec/lib/gitlab/database/consistency_checker_spec.rb' + - 'spec/lib/gitlab/graphql/tracers/metrics_tracer_spec.rb' + - 'spec/lib/gitlab/instrumentation/redis_interceptor_spec.rb' + - 'spec/lib/gitlab/issues/rebalancing/state_spec.rb' + - 'spec/lib/gitlab/kroki_spec.rb' + - 'spec/lib/gitlab/memory/instrumentation_spec.rb' + - 'spec/lib/gitlab/memory/watchdog/configurator_spec.rb' + - 'spec/lib/gitlab/memory/watchdog/monitor/unique_memory_growth_spec.rb' + - 'spec/lib/gitlab/project_search_results_spec.rb' + - 'spec/lib/gitlab/prometheus_client_spec.rb' + - 'spec/lib/gitlab/quick_actions/extractor_spec.rb' + - 'spec/lib/gitlab/regex_spec.rb' + - 'spec/lib/gitlab/search/abuse_validators/no_abusive_term_length_validator_spec.rb' + - 'spec/lib/gitlab/slash_commands/deploy_spec.rb' + - 'spec/lib/gitlab/url_blocker_spec.rb' + - 'spec/mailers/notify_spec.rb' + - 'spec/models/appearance_spec.rb' + - 'spec/models/ci/build_spec.rb' + - 'spec/models/ci/runner_spec.rb' + - 'spec/models/commit_spec.rb' + - 'spec/models/concerns/pg_full_text_searchable_spec.rb' + - 'spec/models/custom_emoji_spec.rb' + - 'spec/models/environment_spec.rb' + - 'spec/models/grafana_integration_spec.rb' + - 'spec/models/integrations/chat_message/push_message_spec.rb' + - 'spec/models/merge_request_diff_spec.rb' + - 'spec/models/packages/package_file_spec.rb' + - 'spec/models/project_metrics_setting_spec.rb' + - 'spec/models/prometheus_alert_spec.rb' + - 'spec/requests/api/pypi_packages_spec.rb' + - 'spec/requests/lfs_http_spec.rb' + - 'spec/services/ci/pipeline_schedules/calculate_next_run_service_spec.rb' + - 'spec/services/issues/relative_position_rebalancing_service_spec.rb' + - 'spec/services/web_hook_service_spec.rb' + - 'spec/support/cycle_analytics_helpers/test_generation.rb' + - 'spec/support/helpers/dependency_proxy_helpers.rb' + - 'spec/support/models/ci/partitioning_testing/cascade_check.rb' + - 'spec/support/shared_examples/features/sidebar_shared_examples.rb' + - 'spec/support/shared_examples/models/relative_positioning_shared_examples.rb' + - 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb' + - 'spec/tooling/lib/tooling/kubernetes_client_spec.rb' diff --git a/.rubocop_todo/lint/ambiguous_range.yml b/.rubocop_todo/lint/ambiguous_range.yml new file mode 100644 index 00000000000..3d6f49a4846 --- /dev/null +++ b/.rubocop_todo/lint/ambiguous_range.yml @@ -0,0 +1,10 @@ +--- +# Cop supports --autocorrect. +Lint/AmbiguousRange: + Details: grace period + Exclude: + - 'app/models/ci/runner.rb' + - 'app/models/ci/runner_machine.rb' + - 'app/services/clusters/agent_tokens/track_usage_service.rb' + - 'lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb' + - 'spec/lib/gitlab/database/reindexing/reindex_concurrently_spec.rb' diff --git a/.rubocop_todo/lint/constant_definition_in_block.yml b/.rubocop_todo/lint/constant_definition_in_block.yml index ff3f6b2afbc..1758c51e55a 100644 --- a/.rubocop_todo/lint/constant_definition_in_block.yml +++ b/.rubocop_todo/lint/constant_definition_in_block.yml @@ -45,12 +45,6 @@ Lint/ConstantDefinitionInBlock: - 'lib/tasks/gitlab/update_templates.rake' - 'lib/tasks/tanuki_emoji.rake' - 'spec/db/schema_spec.rb' - - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' - 'spec/lib/marginalia_spec.rb' - - 'spec/mailers/notify_spec.rb' - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' - 'spec/models/concerns/bulk_insert_safe_spec.rb' - - 'spec/models/concerns/bulk_insertable_associations_spec.rb' - - 'spec/models/concerns/triggerable_hooks_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb' diff --git a/.rubocop_todo/lint/deprecated_constants.yml b/.rubocop_todo/lint/deprecated_constants.yml new file mode 100644 index 00000000000..ab0c9884e0a --- /dev/null +++ b/.rubocop_todo/lint/deprecated_constants.yml @@ -0,0 +1,7 @@ +--- +# Cop supports --autocorrect. +Lint/DeprecatedConstants: + Details: grace period + Exclude: + - 'scripts/pipeline_test_report_builder.rb' + - 'spec/scripts/pipeline_test_report_builder_spec.rb' diff --git a/.rubocop_todo/lint/duplicate_branch.yml b/.rubocop_todo/lint/duplicate_branch.yml new file mode 100644 index 00000000000..89d1ff7e2aa --- /dev/null +++ b/.rubocop_todo/lint/duplicate_branch.yml @@ -0,0 +1,36 @@ +--- +Lint/DuplicateBranch: + Details: grace period + Exclude: + - 'app/controllers/concerns/issuable_collections.rb' + - 'app/controllers/concerns/sorting_preference.rb' + - 'app/controllers/projects/google_cloud/databases_controller.rb' + - 'app/controllers/repositories/lfs_storage_controller.rb' + - 'app/helpers/ci/status_helper.rb' + - 'app/helpers/icons_helper.rb' + - 'app/helpers/labels_helper.rb' + - 'app/models/application_setting_implementation.rb' + - 'app/models/integrations/base_chat_notification.rb' + - 'app/models/packages/package.rb' + - 'app/models/release.rb' + - 'app/services/admin/set_feature_flag_service.rb' + - 'app/services/ci/job_token_scope/add_project_service.rb' + - 'app/services/spam/spam_action_service.rb' + - 'config/initializers/postgresql_cte.rb' + - 'ee/app/controllers/projects/integrations/jira/issues_controller.rb' + - 'ee/app/controllers/projects/security/policies_controller.rb' + - 'ee/app/finders/compliance_management/merge_requests/compliance_violations_finder.rb' + - 'ee/app/models/ee/vulnerability.rb' + - 'ee/app/models/license.rb' + - 'ee/app/models/vulnerabilities/read.rb' + - 'lib/event_filter.rb' + - 'lib/gitlab/checks/branch_check.rb' + - 'lib/gitlab/ci/yaml_processor.rb' + - 'lib/gitlab/database/load_balancing/load_balancer.rb' + - 'lib/gitlab/import_export/project/relation_factory.rb' + - 'lib/gitlab/search_results.rb' + - 'lib/mattermost/session.rb' + - 'lib/sidebars/groups/menus/settings_menu.rb' + - 'qa/qa/resource/pipeline.rb' + - 'scripts/rubocop-parse' + - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' diff --git a/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml b/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml new file mode 100644 index 00000000000..813a27455a8 --- /dev/null +++ b/.rubocop_todo/lint/duplicate_regexp_character_class_element.yml @@ -0,0 +1,7 @@ +--- +# Cop supports --autocorrect. +Lint/DuplicateRegexpCharacterClassElement: + Details: grace period + Exclude: + - 'lib/gitlab/path_regex.rb' + - 'spec/support/shared_contexts/features/integrations/integrations_shared_context.rb' diff --git a/.rubocop_todo/lint/empty_block.yml b/.rubocop_todo/lint/empty_block.yml new file mode 100644 index 00000000000..8845fb3abe2 --- /dev/null +++ b/.rubocop_todo/lint/empty_block.yml @@ -0,0 +1,212 @@ +--- +Lint/EmptyBlock: + Details: grace period + Exclude: + - 'app/controllers/groups/boards_controller.rb' + - 'app/controllers/projects/boards_controller.rb' + - 'app/controllers/projects/pipelines_controller.rb' + - 'app/experiments/logged_out_marketing_header_experiment.rb' + - 'app/experiments/security_reports_mr_widget_prompt_experiment.rb' + - 'config/application.rb' + - 'ee/app/controllers/projects/learn_gitlab_controller.rb' + - 'ee/spec/factories/incident_management/escalation_rules.rb' + - 'ee/spec/finders/snippets_finder_spec.rb' + - 'ee/spec/graphql/types/epic_type_spec.rb' + - 'ee/spec/graphql/types/incident_management/escalation_rule_input_type_spec.rb' + - 'ee/spec/lib/gitlab/ci/minutes/cost_factor_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb' + - 'ee/spec/lib/gitlab/ip_address_state_spec.rb' + - 'ee/spec/lib/gitlab/search_context/builder_spec.rb' + - 'ee/spec/models/concerns/ee/noteable_spec.rb' + - 'ee/spec/models/dast/profile_schedule_spec.rb' + - 'ee/spec/models/ee/ci/build_dependencies_spec.rb' + - 'ee/spec/models/ee/user_spec.rb' + - 'ee/spec/models/environment_spec.rb' + - 'ee/spec/models/protected_environment_spec.rb' + - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' + - 'ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb' + - 'ee/spec/models/vulnerabilities/stat_diff_spec.rb' + - 'ee/spec/requests/api/analytics/group_activity_analytics_spec.rb' + - 'ee/spec/requests/api/graphql/boards/board_lists_query_spec.rb' + - 'ee/spec/requests/api/vulnerability_exports_spec.rb' + - 'ee/spec/requests/groups/security/credentials_controller_spec.rb' + - 'ee/spec/requests/lfs_http_spec.rb' + - 'ee/spec/serializers/merge_request_poll_widget_entity_spec.rb' + - 'ee/spec/services/audit_events/register_runner_audit_event_service_spec.rb' + - 'ee/spec/services/audit_events/unregister_runner_audit_event_service_spec.rb' + - 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb' + - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' + - 'ee/spec/services/ci/runners/register_runner_service_spec.rb' + - 'ee/spec/services/incident_management/escalation_policies/update_service_spec.rb' + - 'lib/api/helpers/groups_helpers.rb' + - 'lib/api/helpers/issues_helpers.rb' + - 'lib/api/helpers/members_helpers.rb' + - 'lib/api/helpers/merge_requests_helpers.rb' + - 'lib/api/helpers/projects_helpers.rb' + - 'lib/api/helpers/protected_branches_helpers.rb' + - 'lib/api/helpers/protected_tags_helpers.rb' + - 'lib/api/helpers/remote_mirrors_helpers.rb' + - 'lib/api/helpers/settings_helpers.rb' + - 'lib/api/helpers/users_helpers.rb' + - 'lib/api/helpers/variables_helpers.rb' + - 'lib/api/merge_requests.rb' + - 'lib/gitlab/alert_management/payload/base.rb' + - 'lib/gitlab/seeder.rb' + - 'lib/sidebars/groups/panel.rb' + - 'lib/sidebars/projects/panel.rb' + - 'qa/qa/specs/features/shared_contexts/import/gitlab_group_migration_common.rb' + - 'qa/spec/scenario/test/instance/airgapped_spec.rb' + - 'qa/spec/specs/helpers/context_selector_spec.rb' + - 'qa/spec/specs/helpers/feature_flag_spec.rb' + - 'qa/spec/specs/helpers/quarantine_spec.rb' + - 'qa/spec/support/formatters/test_metrics_formatter_spec.rb' + - 'scripts/lib/glfm/update_example_snapshots.rb' + - 'scripts/lib/glfm/update_specification.rb' + - 'spec/controllers/application_controller_spec.rb' + - 'spec/controllers/projects/artifacts_controller_spec.rb' + - 'spec/controllers/projects/feature_flags_controller_spec.rb' + - 'spec/dependencies/omniauth_saml_spec.rb' + - 'spec/experiments/application_experiment_spec.rb' + - 'spec/factories/packages/package_files.rb' + - 'spec/features/merge_request/user_sees_deployment_widget_spec.rb' + - 'spec/features/projects/environments/environment_spec.rb' + - 'spec/finders/ci/runners_finder_spec.rb' + - 'spec/initializers/enumerator_next_patch_spec.rb' + - 'spec/initializers/net_http_response_patch_spec.rb' + - 'spec/lib/api/base_spec.rb' + - 'spec/lib/api/helpers/authentication_spec.rb' + - 'spec/lib/bitbucket_server/connection_spec.rb' + - 'spec/lib/feature_spec.rb' + - 'spec/lib/gitlab/application_context_spec.rb' + - 'spec/lib/gitlab/audit/ci_runner_token_author_spec.rb' + - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' + - 'spec/lib/gitlab/chat_name_token_spec.rb' + - 'spec/lib/gitlab/ci/build/rules/rule/clause/changes_spec.rb' + - 'spec/lib/gitlab/ci/build/rules/rule/clause/exists_spec.rb' + - 'spec/lib/gitlab/ci/config/edge_stages_injector_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/retry_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/root_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/rules/rule/changes_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb' + - 'spec/lib/gitlab/ci/config/external/context_spec.rb' + - 'spec/lib/gitlab/ci/config/external/file/artifact_spec.rb' + - 'spec/lib/gitlab/ci/config/external/file/base_spec.rb' + - 'spec/lib/gitlab/ci/config/external/rules_spec.rb' + - 'spec/lib/gitlab/ci/config/normalizer_spec.rb' + - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/seed_block_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/seed_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/logger_spec.rb' + - 'spec/lib/gitlab/ci/runner_releases_spec.rb' + - 'spec/lib/gitlab/ci/trace/chunked_io_spec.rb' + - 'spec/lib/gitlab/ci/variables/helpers_spec.rb' + - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' + - 'spec/lib/gitlab/database/each_database_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/sidekiq_client_middleware_spec.rb' + - 'spec/lib/gitlab/database/migration_helpers/automatic_lock_writes_on_tables_spec.rb' + - 'spec/lib/gitlab/database/migration_helpers/v2_spec.rb' + - 'spec/lib/gitlab/database/migrations/instrumentation_spec.rb' + - 'spec/lib/gitlab/database/migrations/lock_retries_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/observers/transaction_duration_spec.rb' + - 'spec/lib/gitlab/database/obsolete_ignored_columns_spec.rb' + - 'spec/lib/gitlab/database/shared_model_spec.rb' + - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' + - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' + - 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb' + - 'spec/lib/gitlab/database_spec.rb' + - 'spec/lib/gitlab/etag_caching/router/graphql_spec.rb' + - 'spec/lib/gitlab/exclusive_lease_helpers_spec.rb' + - 'spec/lib/gitlab/exclusive_lease_spec.rb' + - 'spec/lib/gitlab/git/raw_diff_change_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' + - 'spec/lib/gitlab/gitaly_client/operation_service_spec.rb' + - 'spec/lib/gitlab/github_import/client_spec.rb' + - 'spec/lib/gitlab/github_import/importer/protected_branches_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_requests_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_requests_merged_by_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/pull_requests_reviews_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/single_endpoint_diff_notes_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/single_endpoint_issue_notes_importer_spec.rb' + - 'spec/lib/gitlab/github_import/importer/single_endpoint_merge_request_notes_importer_spec.rb' + - 'spec/lib/gitlab/gpg_spec.rb' + - 'spec/lib/gitlab/graphql/negatable_arguments_spec.rb' + - 'spec/lib/gitlab/http_io_spec.rb' + - 'spec/lib/gitlab/memory/reports_daemon_spec.rb' + - 'spec/lib/gitlab/metrics/background_transaction_spec.rb' + - 'spec/lib/gitlab/metrics/web_transaction_spec.rb' + - 'spec/lib/gitlab/patch/prependable_spec.rb' + - 'spec/lib/gitlab/profiler_spec.rb' + - 'spec/lib/gitlab/quick_actions/extractor_spec.rb' + - 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb' + - 'spec/lib/gitlab/search_context/builder_spec.rb' + - 'spec/lib/gitlab/session_spec.rb' + - 'spec/lib/gitlab/sidekiq_daemon/memory_killer_spec.rb' + - 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/extra_done_log_metadata_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb' + - 'spec/lib/gitlab/verify/uploads_spec.rb' + - 'spec/lib/gitlab_spec.rb' + - 'spec/lib/marginalia_spec.rb' + - 'spec/lib/mattermost/session_spec.rb' + - 'spec/models/aws/role_spec.rb' + - 'spec/models/ci/build_dependencies_spec.rb' + - 'spec/models/ci/build_spec.rb' + - 'spec/models/ci/build_trace_metadata_spec.rb' + - 'spec/models/ci/job_artifact_spec.rb' + - 'spec/models/ci/pipeline_schedule_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/ci/runner_spec.rb' + - 'spec/models/clusters/cluster_spec.rb' + - 'spec/models/commit_status_spec.rb' + - 'spec/models/concerns/has_environment_scope_spec.rb' + - 'spec/models/concerns/noteable_spec.rb' + - 'spec/models/container_expiration_policy_spec.rb' + - 'spec/models/container_repository_spec.rb' + - 'spec/models/environment_spec.rb' + - 'spec/models/merge_request/approval_removal_settings_spec.rb' + - 'spec/models/merge_request_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/presenters/ci/pipeline_presenter_spec.rb' + - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' + - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' + - 'spec/requests/api/ci/runner/runners_verify_post_spec.rb' + - 'spec/requests/api/ci/triggers_spec.rb' + - 'spec/requests/api/graphql/boards/board_list_issues_query_spec.rb' + - 'spec/requests/api/graphql/boards/board_lists_query_spec.rb' + - 'spec/requests/api/graphql/ci/runner_spec.rb' + - 'spec/requests/api/graphql/mutations/achievements/create_spec.rb' + - 'spec/requests/api/group_variables_spec.rb' + - 'spec/requests/api/groups_spec.rb' + - 'spec/requests/api/helpers_spec.rb' + - 'spec/requests/api/markdown_spec.rb' + - 'spec/requests/api/release/links_spec.rb' + - 'spec/requests/api/releases_spec.rb' + - 'spec/requests/api/unleash_spec.rb' + - 'spec/rubocop/cop/migration/create_table_with_foreign_keys_spec.rb' + - 'spec/services/auto_merge/base_service_spec.rb' + - 'spec/services/auto_merge_service_spec.rb' + - 'spec/services/ci/archive_trace_service_spec.rb' + - 'spec/services/ci/create_pipeline_service_spec.rb' + - 'spec/services/ci/parse_dotenv_artifact_service_spec.rb' + - 'spec/services/ci/runners/bulk_delete_runners_service_spec.rb' + - 'spec/services/ci/runners/register_runner_service_spec.rb' + - 'spec/services/ci/stuck_builds/drop_pending_service_spec.rb' + - 'spec/services/ci/stuck_builds/drop_scheduled_service_spec.rb' + - 'spec/services/deployments/create_for_build_service_spec.rb' + - 'spec/services/environments/create_for_build_service_spec.rb' + - 'spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb' + - 'spec/services/releases/destroy_service_spec.rb' + - 'spec/services/releases/update_service_spec.rb' + - 'spec/services/terraform/remote_state_handler_spec.rb' + - 'spec/support/shared_contexts/security_and_compliance_permissions_shared_context.rb' + - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/sidekiq_middleware/strategy_shared_examples.rb' + - 'spec/support/shared_examples/models/concerns/bulk_insert_safe_shared_examples.rb' + - 'spec/support/shared_examples/quick_actions/issue/board_move_quick_action_shared_examples.rb' + - 'spec/support/shared_examples/requests/lfs_http_shared_examples.rb' + - 'spec/support/shared_examples/sends_git_audit_streaming_event_shared_examples.rb' + - 'spec/support_specs/database/without_check_constraint_spec.rb' + - 'spec/views/layouts/_published_experiments.html.haml_spec.rb' + - 'spec/workers/ci/initial_pipeline_process_worker_spec.rb' diff --git a/.rubocop_todo/lint/empty_class.yml b/.rubocop_todo/lint/empty_class.yml new file mode 100644 index 00000000000..c7c90313992 --- /dev/null +++ b/.rubocop_todo/lint/empty_class.yml @@ -0,0 +1,5 @@ +--- +Lint/EmptyClass: + Details: grace period + Exclude: + - 'spec/lib/gitlab/multi_destination_logger_spec.rb' diff --git a/.rubocop_todo/lint/incompatible_io_select_with_fiber_scheduler.yml b/.rubocop_todo/lint/incompatible_io_select_with_fiber_scheduler.yml new file mode 100644 index 00000000000..7e9dd3970be --- /dev/null +++ b/.rubocop_todo/lint/incompatible_io_select_with_fiber_scheduler.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --autocorrect. +Lint/IncompatibleIoSelectWithFiberScheduler: + Details: grace period + Exclude: + - 'lib/gitlab/stack_prof.rb' diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml index d4091e27353..8346468e4fc 100644 --- a/.rubocop_todo/lint/missing_cop_enable_directive.yml +++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml @@ -67,13 +67,8 @@ Lint/MissingCopEnableDirective: - 'danger/feature_flag/Dangerfile' - 'danger/pajamas/Dangerfile' - 'danger/z_metadata/Dangerfile' - - 'db/migrate/20210807101621_add_timezone_to_dast_profile_schedules.rb' - - 'db/migrate/20210816095826_add_unique_index_on_dast_profile_to_dast_profile_schedules.rb' - - 'db/migrate/20210818061156_remove_project_profile_compound_index_from_dast_profile_schedules.rb' - - 'db/migrate/20210818115613_add_index_project_id_on_dast_profile_schedule.rb' - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - - 'db/post_migrate/20210825182303_remove_duplicate_dast_site_tokens_with_same_token.rb' - 'ee/app/controllers/ee/admin/dashboard_controller.rb' - 'ee/app/controllers/ee/admin/groups_controller.rb' - 'ee/app/controllers/ee/admin/users_controller.rb' @@ -199,7 +194,6 @@ Lint/MissingCopEnableDirective: - 'qa/qa/scenario/test/integration/registry_with_cdn.rb' - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb' - - 'spec/lib/initializer_connections_spec.rb' - 'spec/support/capybara.rb' - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/google_api/cloud_platform_helpers.rb' diff --git a/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml b/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml new file mode 100644 index 00000000000..04115b12600 --- /dev/null +++ b/.rubocop_todo/lint/no_return_in_begin_end_blocks.yml @@ -0,0 +1,20 @@ +--- +Lint/NoReturnInBeginEndBlocks: + Details: grace period + Exclude: + - 'app/models/concerns/metric_image_uploading.rb' + - 'app/models/merge_request.rb' + - 'app/services/security/ci_configuration/sast_parser_service.rb' + - 'app/services/work_items/parent_links/create_service.rb' + - 'ee/app/services/epic_issues/create_service.rb' + - 'ee/app/services/gitlab_subscriptions/preview_billable_user_change_service.rb' + - 'ee/app/services/security/token_revocation_service.rb' + - 'ee/lib/api/vulnerability_findings.rb' + - 'ee/lib/ee/gitlab/scim/filter_parser.rb' + - 'lib/api/internal/base.rb' + - 'lib/gitlab/git/repository.rb' + - 'lib/gitlab/metrics/dashboard/importer.rb' + - 'lib/object_storage/config.rb' + - 'qa/qa/support/formatters/test_metrics_formatter.rb' + - 'qa/qa/support/influxdb_tools.rb' + - 'spec/support/database/prevent_cross_joins.rb' diff --git a/.rubocop_todo/lint/non_atomic_file_operation.yml b/.rubocop_todo/lint/non_atomic_file_operation.yml new file mode 100644 index 00000000000..924893c19de --- /dev/null +++ b/.rubocop_todo/lint/non_atomic_file_operation.yml @@ -0,0 +1,46 @@ +--- +# Cop supports --autocorrect. +Lint/NonAtomicFileOperation: + Details: grace period + Exclude: + - 'app/models/merge_request_diff.rb' + - 'app/services/bulk_imports/file_decompression_service.rb' + - 'app/services/bulk_imports/file_download_service.rb' + - 'app/services/projects/import_export/parallel_export_service.rb' + - 'app/services/projects/import_export/relation_export_service.rb' + - 'app/services/projects/lfs_pointers/lfs_download_service.rb' + - 'ee/spec/lib/ee/gitlab/usage_data_counters/hll_redis_counter_spec.rb' + - 'lib/bulk_imports/common/extractors/json_extractor.rb' + - 'lib/bulk_imports/common/extractors/ndjson_extractor.rb' + - 'lib/bulk_imports/common/pipelines/lfs_objects_pipeline.rb' + - 'lib/bulk_imports/common/pipelines/uploads_pipeline.rb' + - 'lib/bulk_imports/projects/pipelines/design_bundle_pipeline.rb' + - 'lib/bulk_imports/projects/pipelines/repository_bundle_pipeline.rb' + - 'lib/gitlab/ci/trace.rb' + - 'lib/gitlab/database/migrations/test_batched_background_runner.rb' + - 'lib/gitlab/database/query_analyzers/query_recorder.rb' + - 'lib/gitlab/gpg.rb' + - 'lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb' + - 'lib/gitlab/import_export/recursive_merge_folders.rb' + - 'lib/gitlab/memory/upload_and_cleanup_reports.rb' + - 'lib/gitlab/setup_helper.rb' + - 'lib/tasks/gitlab/update_templates.rake' + - 'lib/tasks/tanuki_emoji.rake' + - 'qa/qa/git/repository.rb' + - 'qa/qa/runtime/browser.rb' + - 'spec/lib/bulk_imports/common/pipelines/lfs_objects_pipeline_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/uploads_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/design_bundle_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/repository_bundle_pipeline_spec.rb' + - 'spec/lib/gitlab/authorized_keys_spec.rb' + - 'spec/lib/gitlab/cleanup/project_uploads_spec.rb' + - 'spec/lib/gitlab/import_export/project/export_task_spec.rb' + - 'spec/lib/gitlab/import_export/uploads_manager_spec.rb' + - 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb' + - 'spec/services/bulk_imports/file_decompression_service_spec.rb' + - 'spec/services/bulk_imports/lfs_objects_export_service_spec.rb' + - 'spec/services/bulk_imports/repository_bundle_export_service_spec.rb' + - 'spec/services/bulk_imports/uploads_export_service_spec.rb' + - 'spec/support/database/query_recorder.rb' + - 'spec/tooling/rspec_flaky/report_spec.rb' + - 'tooling/rspec_flaky/report.rb' diff --git a/.rubocop_todo/lint/or_assignment_to_constant.yml b/.rubocop_todo/lint/or_assignment_to_constant.yml new file mode 100644 index 00000000000..741d65e9ffa --- /dev/null +++ b/.rubocop_todo/lint/or_assignment_to_constant.yml @@ -0,0 +1,8 @@ +--- +# Cop supports --autocorrect. +Lint/OrAssignmentToConstant: + Details: grace period + Exclude: + - 'lib/gitlab/email/handler/base_handler.rb' + - 'lib/gitlab/utils.rb' + - 'tooling/danger/project_helper.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index 146d7ce164f..b5870b251b5 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -1,7 +1,7 @@ --- # Cop supports --autocorrect. Lint/RedundantCopDisableDirective: - # Offense count: 357 + # Offense count: 429 # Temporarily disabled due to too many offenses Enabled: false Exclude: @@ -11,6 +11,7 @@ Lint/RedundantCopDisableDirective: - 'app/controllers/groups/autocomplete_sources_controller.rb' - 'app/controllers/groups/labels_controller.rb' - 'app/controllers/projects/merge_requests/diffs_controller.rb' + - 'app/controllers/projects/merge_requests_controller.rb' - 'app/finders/autocomplete/acts_as_taggable_on/tags_finder.rb' - 'app/finders/autocomplete/move_to_project_finder.rb' - 'app/finders/autocomplete/routes_finder.rb' @@ -35,7 +36,6 @@ Lint/RedundantCopDisableDirective: - 'app/models/concerns/from_intersect.rb' - 'app/models/concerns/from_union.rb' - 'app/models/concerns/redis_cacheable.rb' - - 'app/models/project_statistics.rb' - 'app/models/user.rb' - 'app/presenters/dev_ops_report/metric_presenter.rb' - 'app/presenters/packages/nuget/search_results_presenter.rb' @@ -66,11 +66,16 @@ Lint/RedundantCopDisableDirective: - 'app/workers/ci/track_failed_build_worker.rb' - 'app/workers/container_registry/migration/enqueuer_worker.rb' - 'app/workers/create_note_diff_file_worker.rb' + - 'app/workers/database/batched_background_migration/execution_worker.rb' - 'app/workers/import_issues_csv_worker.rb' - 'app/workers/incident_management/process_alert_worker_v2.rb' - 'app/workers/merge_worker.rb' + - 'app/workers/new_merge_request_worker.rb' - 'app/workers/remove_unaccepted_member_invites_worker.rb' + - 'app/workers/run_pipeline_schedule_worker.rb' + - 'config/initializers/grape_validators.rb' - 'config/initializers/warden.rb' + - 'config/initializers/wikicloth_redos_patch.rb' - 'config/initializers/wikicloth_ruby_3_patch.rb' - 'config/routes/api.rb' - 'db/migrate/20210917134321_remove_temporary_index_for_project_topics_on_taggings.rb' @@ -78,21 +83,21 @@ Lint/RedundantCopDisableDirective: - 'db/migrate/20220316022505_create_namespace_details.rb' - 'db/migrate/20220421141342_add_allowed_plans_to_ci_runners.rb' - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - - 'db/post_migrate/20210610042700_remove_clusters_applications_fluentd_table.rb' - - 'db/post_migrate/20210708011426_finalize_ci_builds_metadata_bigint_conversion.rb' - - 'db/post_migrate/20210730104800_schedule_extract_project_topics_into_separate_table.rb' - - 'db/post_migrate/20210806131706_finalize_taggins_bigint_conversion.rb' - 'db/post_migrate/20210906130643_drop_temporary_columns_and_triggers_for_taggings.rb' - 'db/post_migrate/20211028100303_tmp_index_for_delete_issue_merge_request_taggings_records.rb' - 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb' - 'db/post_migrate/20220720090354_remove_pending_builds_covering_index_from_ci_builds.rb' - 'db/post_migrate/20220902204048_move_security_findings_table_to_gitlab_partitions_dynamic_schema.rb' + - 'db/post_migrate/20221102231131_remove_temp_index_for_user_details_fields.rb' + - 'db/post_migrate/20230104103748_remove_new_amount_used_column.rb' + - 'db/post_migrate/20230105180002_remove_new_amount_used_column_on_ci_namespace_monthly_usages.rb' - 'ee/app/controllers/ee/admin/application_settings_controller.rb' - 'ee/app/controllers/ee/groups/group_members_controller.rb' - 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb' - 'ee/app/controllers/groups/todos_controller.rb' - 'ee/app/experiments/cart_abandonment_modal_experiment.rb' + - 'ee/app/finders/epics/with_issues_finder.rb' - 'ee/app/finders/geo/file_registry_finder.rb' - 'ee/app/finders/geo/project_registry_finder.rb' - 'ee/app/finders/geo/registry_finder.rb' @@ -104,15 +109,25 @@ Lint/RedundantCopDisableDirective: - 'ee/app/graphql/types/vulnerability_request_type.rb' - 'ee/app/helpers/ee/boards_helper.rb' - 'ee/app/helpers/projects/on_demand_scans_helper.rb' + - 'ee/app/models/approver.rb' + - 'ee/app/models/approver_group.rb' - 'ee/app/models/dast/branch.rb' + - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/group.rb' + - 'ee/app/models/ee/merge_request.rb' + - 'ee/app/models/ee/project.rb' + - 'ee/app/models/ee/user.rb' - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/geo/event_log.rb' + - 'ee/app/models/geo_node.rb' - 'ee/app/models/protected_environments/approval_rules/summarizable.rb' + - 'ee/app/models/requirements_management/requirement.rb' - 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb' - 'ee/app/services/analytics/cycle_analytics/data_loader_service.rb' - 'ee/app/services/ee/boards/issues/list_service.rb' - 'ee/app/services/ee/ci/queue/build_queue_service.rb' - 'ee/app/services/ee/search_service.rb' + - 'ee/app/services/security/token_revocation_service.rb' - 'ee/app/workers/ee/issuable_export_csv_worker.rb' - 'ee/app/workers/ee/namespaces/in_product_marketing_emails_worker.rb' - 'ee/app/workers/geo/design_repository_shard_sync_worker.rb' @@ -126,7 +141,10 @@ Lint/RedundantCopDisableDirective: - 'ee/lib/api/dora/metrics.rb' - 'ee/lib/ee/api/entities/analytics/code_review/merge_request.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_epic_cache_counts.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb' + - 'ee/lib/ee/gitlab/background_migration/fix_security_scan_statuses.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb' + - 'ee/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition.rb' - 'ee/lib/ee/gitlab/background_migration/purge_stale_security_scans.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - 'ee/lib/elastic/latest/git_class_proxy.rb' @@ -134,15 +152,21 @@ Lint/RedundantCopDisableDirective: - 'ee/lib/gitlab/elastic/bool_expr.rb' - 'ee/lib/gitlab/spdx/license.rb' - 'ee/lib/gitlab/status_page/storage/object.rb' + - 'ee/spec/controllers/concerns/gitlab_subscriptions/seat_count_alert_spec.rb' + - 'ee/spec/controllers/concerns/registrations/verification_spec.rb' + - 'ee/spec/controllers/concerns/routable_actions_spec.rb' - 'ee/spec/elastic/migrate/20221026082700_backfill_users_spec.rb' - 'ee/spec/features/boards/user_visits_board_spec.rb' - 'ee/spec/features/groups/settings/domain_verification_spec.rb' - 'ee/spec/helpers/ee/releases_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size_spec.rb' - 'ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb' - 'ee/spec/lib/elastic/latest/project_instance_proxy_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_helpers_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_user_merge_requests_for_projects_with_applied_scan_result_policies_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb' + - 'ee/spec/requests/api/conan_project_packages_spec.rb' - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' - 'ee/spec/support/shared_examples/models/elasticsearch_indexed_container_shared_examples.rb' @@ -151,19 +175,25 @@ Lint/RedundantCopDisableDirective: - 'lib/api/ci/variables.rb' - 'lib/api/entities/issuable_time_stats.rb' - 'lib/api/helpers.rb' + - 'lib/api/issue_links.rb' + - 'lib/backup/manager.rb' - 'lib/bulk_imports/common/transformers/user_reference_transformer.rb' - 'lib/bulk_imports/pipeline/runner.rb' - 'lib/container_registry/tag.rb' - 'lib/event_filter.rb' + - 'lib/feature.rb' - 'lib/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb' - 'lib/gitlab/analytics/cycle_analytics/base_query_builder.rb' - 'lib/gitlab/analytics/cycle_analytics/records_fetcher.rb' - 'lib/gitlab/application_context.rb' - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' + - 'lib/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb' - 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb' - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' + - 'lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics.rb' - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' + - 'lib/gitlab/background_migration/re_expire_o_auth_tokens.rb' - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb' @@ -184,12 +214,15 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/database/consistency_checker.rb' - 'lib/gitlab/database/migration.rb' - 'lib/gitlab/database/migrations/observation.rb' + - 'lib/gitlab/database/migrations/observers/query_log.rb' - 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces.rb' - 'lib/gitlab/diff/file.rb' - 'lib/gitlab/diff/file_collection/paginated_diffs.rb' - 'lib/gitlab/diff/pair_selector.rb' - 'lib/gitlab/diff/parser.rb' + - 'lib/gitlab/encrypted_incoming_email_command.rb' - 'lib/gitlab/encrypted_ldap_command.rb' + - 'lib/gitlab/encrypted_service_desk_email_command.rb' - 'lib/gitlab/encrypted_smtp_command.rb' - 'lib/gitlab/git/commit.rb' - 'lib/gitlab/git/patches/collection.rb' @@ -209,6 +242,8 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/project_search_results.rb' - 'lib/gitlab/redis/hll.rb' - 'lib/gitlab/search/sort_options.rb' + - 'lib/gitlab/seeders/ci/runner/runner_fleet_seeder.rb' + - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/slash_commands/issue_search.rb' - 'lib/gitlab/slash_commands/result.rb' - 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric.rb' @@ -220,11 +255,14 @@ Lint/RedundantCopDisableDirective: - 'qa/qa/specs/features/ee/browser_ui/10_govern/create_merge_request_with_secure_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/10_govern/security_reports_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb' + - 'rubocop/cop/static_translation_definition.rb' - 'scripts/security-harness' - 'sidekiq_cluster/cli.rb' - 'sidekiq_cluster/sidekiq_cluster.rb' - 'spec/components/previews/pajamas/banner_component_preview.rb' - - 'spec/fixtures/packages/rubygems/package.gemspec' + - 'spec/controllers/concerns/preferred_language_switcher_spec.rb' + - 'spec/controllers/profiles/two_factor_auths_controller_spec.rb' + - 'spec/finders/personal_access_tokens_finder_spec.rb' - 'spec/frontend/fixtures/merge_requests.rb' - 'spec/graphql/mutations/clusters/agent_tokens/create_spec.rb' - 'spec/graphql/mutations/clusters/agents/create_spec.rb' @@ -242,24 +280,30 @@ Lint/RedundantCopDisableDirective: - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects_spec.rb' - 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/transaction_leaking_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' - 'spec/lib/gitlab/doorkeeper_secret_storing/secret/pbkdf2_sha512_spec.rb' - 'spec/lib/gitlab/doorkeeper_secret_storing/token/pbkdf2_sha512_spec.rb' + - 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb' - 'spec/lib/gitlab/git/tree_spec.rb' - 'spec/lib/gitlab/import_export/project/relation_saver_spec.rb' - 'spec/lib/gitlab/memory/watchdog/configurator_spec.rb' + - 'spec/lib/gitlab/merge_requests/message_generator_spec.rb' - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' + - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' - 'spec/lib/gitlab/rack_attack/request_spec.rb' + - 'spec/lib/gitlab/redis/multi_store_spec.rb' - 'spec/lib/gitlab/shard_health_cache_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb' - - 'spec/lib/initializer_connections_spec.rb' - 'spec/metrics_server/metrics_server_spec.rb' - 'spec/migrations/20220725150127_update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - - 'spec/migrations/reschedule_backfill_imported_issue_search_data_spec.rb' + - 'spec/migrations/add_namespaces_emails_enabled_column_data_spec.rb' + - 'spec/migrations/add_projects_emails_enabled_column_data_spec.rb' - 'spec/models/ci/build_trace_chunk_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/concerns/encrypted_user_password_spec.rb' + - 'spec/models/concerns/triggerable_hooks_spec.rb' - 'spec/models/namespace/package_setting_spec.rb' - 'spec/models/namespace_spec.rb' - 'spec/models/project_feature_spec.rb' @@ -276,6 +320,7 @@ Lint/RedundantCopDisableDirective: - 'spec/services/spam/spam_verdict_service_spec.rb' - 'spec/services/topics/merge_service_spec.rb' - 'spec/support/forgery_protection.rb' + - 'spec/support/helpers/database/multiple_databases_helpers.rb' - 'spec/support/helpers/snowplow_helpers.rb' - 'spec/support/helpers/wait_for_requests.rb' - 'spec/support/shared_examples/lib/gitlab/local_and_remote_storage_migration_shared_examples.rb' @@ -283,9 +328,11 @@ Lint/RedundantCopDisableDirective: - 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb' - 'spec/support/shared_examples/models/packages/debian/distribution_key_shared_examples.rb' - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb' - - 'spec/tasks/gitlab/db/validate_config_rake_spec.rb' - 'spec/uploaders/packages/composer/cache_uploader_spec.rb' - 'tooling/danger/product_intelligence.rb' + - 'tooling/danger/stable_branch.rb' + - 'tooling/danger/suggestor.rb' - 'tooling/lib/tooling/helm3_client.rb' - 'tooling/lib/tooling/kubernetes_client.rb' + - 'tooling/quality/test_level.rb' - 'tooling/rspec_flaky/listener.rb' diff --git a/.rubocop_todo/lint/redundant_dir_glob_sort.yml b/.rubocop_todo/lint/redundant_dir_glob_sort.yml new file mode 100644 index 00000000000..84be6e2dd6a --- /dev/null +++ b/.rubocop_todo/lint/redundant_dir_glob_sort.yml @@ -0,0 +1,11 @@ +--- +# Cop supports --autocorrect. +Lint/RedundantDirGlobSort: + Details: grace period + Exclude: + - 'app/models/release_highlight.rb' + - 'config/application.rb' + - 'ee/spec/spec_helper.rb' + - 'qa/qa/specs/spec_helper.rb' + - 'rubocop/rubocop.rb' + - 'spec/spec_helper.rb' diff --git a/.rubocop_todo/lint/symbol_conversion.yml b/.rubocop_todo/lint/symbol_conversion.yml new file mode 100644 index 00000000000..537b32d856d --- /dev/null +++ b/.rubocop_todo/lint/symbol_conversion.yml @@ -0,0 +1,176 @@ +--- +# Cop supports --autocorrect. +Lint/SymbolConversion: + Details: grace period + Exclude: + - 'app/controllers/projects/environments/sample_metrics_controller.rb' + - 'app/helpers/breadcrumbs_helper.rb' + - 'app/helpers/environments_helper.rb' + - 'app/helpers/tooling/visual_review_helper.rb' + - 'app/services/google_cloud/create_cloudsql_instance_service.rb' + - 'app/services/packages/debian/generate_distribution_key_service.rb' + - 'app/services/packages/debian/process_changes_service.rb' + - 'config/puma.rb' + - 'ee/app/components/billing/plan_component.rb' + - 'ee/app/controllers/projects/security/scanned_resources_controller.rb' + - 'ee/app/models/product_analytics/jitsu_authentication.rb' + - 'ee/app/serializers/integrations/zentao_serializers/issue_entity.rb' + - 'ee/app/services/integrations/slack_interactions/incident_management/incident_modal_closed_service.rb' + - 'ee/app/services/integrations/slack_interactions/incident_management/incident_modal_submit_service.rb' + - 'ee/app/services/integrations/slack_interactions/slack_block_actions/incident_management/project_update_handler.rb' + - 'ee/app/services/integrations/slack_options/user_search_handler.rb' + - 'ee/db/fixtures/development/35_merge_request_predictions.rb' + - 'ee/lib/api/analytics/product_analytics.rb' + - 'ee/lib/ee/gitlab/scim/attribute_transform.rb' + - 'ee/lib/elastic/latest/note_class_proxy.rb' + - 'ee/lib/gitlab/applied_ml/suggested_reviewers/client.rb' + - 'ee/lib/slack/block_kit/app_home_opened.rb' + - 'ee/lib/slack/block_kit/incident_management/incident_modal_opened.rb' + - 'ee/spec/controllers/admin/audit_logs_controller_spec.rb' + - 'ee/spec/controllers/groups/audit_events_controller_spec.rb' + - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' + - 'ee/spec/elastic/migrate/20220613120500_migrate_commits_to_separate_index_spec.rb' + - 'ee/spec/factories/vulnerabilities/findings.rb' + - 'ee/spec/features/admin/subscriptions/admin_views_subscription_spec.rb' + - 'ee/spec/graphql/resolvers/security_report_summary_resolver_spec.rb' + - 'ee/spec/helpers/ee/environments_helper_spec.rb' + - 'ee/spec/helpers/subscriptions_helper_spec.rb' + - 'ee/spec/lib/arkose/logger_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' + - 'ee/spec/lib/ee/gitlab/ci/parsers/security/common_spec.rb' + - 'ee/spec/lib/ee/gitlab/scim/params_parser_spec.rb' + - 'ee/spec/lib/ee/gitlab/tracking_spec.rb' + - 'ee/spec/lib/gitlab/ci/parsers/security/coverage_fuzzing_spec.rb' + - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' + - 'ee/spec/lib/gitlab/search/aggregation_parser_spec.rb' + - 'ee/spec/lib/gitlab/search/aggregation_spec.rb' + - 'ee/spec/lib/gitlab/subscription_portal/clients/graphql_spec.rb' + - 'ee/spec/models/ee/integrations/jira_spec.rb' + - 'ee/spec/models/integrations/github_spec.rb' + - 'ee/spec/requests/api/analytics/product_analytics_spec.rb' + - 'ee/spec/requests/api/graphql/audit_events/streaming/headers/create_spec.rb' + - 'ee/spec/requests/api/graphql/audit_events/streaming/headers/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/audit_events/streaming/headers/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/update_spec.rb' + - 'ee/spec/requests/api/integrations/slack/interactions_spec.rb' + - 'ee/spec/requests/api/integrations/slack/options_spec.rb' + - 'ee/spec/requests/api/scim/group_scim_spec.rb' + - 'ee/spec/requests/api/scim/instance_scim_spec.rb' + - 'ee/spec/services/elastic/data_migration_service_spec.rb' + - 'ee/spec/services/integrations/slack_interactions/incident_management/incident_modal_closed_service_spec.rb' + - 'ee/spec/services/integrations/slack_interactions/incident_management/incident_modal_submit_service_spec.rb' + - 'ee/spec/services/security/token_revocation_service_spec.rb' + - 'ee/spec/support/helpers/subscription_portal_helpers.rb' + - 'ee/spec/support/prometheus/additional_metrics_shared_examples.rb' + - 'ee/spec/workers/deployments/approval_worker_spec.rb' + - 'lib/gitlab/auth/otp/strategies/forti_token_cloud.rb' + - 'lib/gitlab/data_builder/repository.rb' + - 'lib/gitlab/database/reindexing/grafana_notifier.rb' + - 'lib/gitlab/gitaly_client.rb' + - 'lib/gitlab/grape_logging/loggers/queue_duration_logger.rb' + - 'lib/gitlab/harbor/client.rb' + - 'lib/gitlab/prometheus_client.rb' + - 'lib/gitlab/zentao/client.rb' + - 'lib/version_check.rb' + - 'qa/qa/resource/merge_request.rb' + - 'qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_from_push_notification_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/change_vulnerability_status_spec.rb' + - 'qa/qa/specs/features/ee/browser_ui/10_govern/project_security_dashboard_spec.rb' + - 'qa/spec/resource/events/project_spec.rb' + - 'qa/spec/specs/allure_report_spec.rb' + - 'spec/controllers/import/gitlab_controller_spec.rb' + - 'spec/controllers/jira_connect/branches_controller_spec.rb' + - 'spec/factories/ci/reports/codequality_degradations.rb' + - 'spec/factories/evidences.rb' + - 'spec/factories/packages/debian/file_metadatum.rb' + - 'spec/factories/packages/helm/file_metadatum.rb' + - 'spec/factories/packages/npm/metadata.rb' + - 'spec/features/file_uploads/graphql_add_design_spec.rb' + - 'spec/features/projects/new_project_spec.rb' + - 'spec/graphql/mutations/ci/job_token_scope/remove_project_spec.rb' + - 'spec/helpers/application_settings_helper_spec.rb' + - 'spec/helpers/auth_helper_spec.rb' + - 'spec/helpers/environments_helper_spec.rb' + - 'spec/helpers/form_helper_spec.rb' + - 'spec/helpers/tooling/visual_review_helper_spec.rb' + - 'spec/initializers/sawyer_patch_spec.rb' + - 'spec/lib/api/entities/nuget/dependency_group_spec.rb' + - 'spec/lib/api/entities/nuget/dependency_spec.rb' + - 'spec/lib/api/entities/nuget/metadatum_spec.rb' + - 'spec/lib/api/entities/nuget/package_metadata_catalog_entry_spec.rb' + - 'spec/lib/api/entities/nuget/search_result_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb' + - 'spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb' + - 'spec/lib/constraints/group_url_constrainer_spec.rb' + - 'spec/lib/constraints/project_url_constrainer_spec.rb' + - 'spec/lib/constraints/user_url_constrainer_spec.rb' + - 'spec/lib/container_registry/gitlab_api_client_spec.rb' + - 'spec/lib/generators/gitlab/usage_metric_definition/redis_hll_generator_spec.rb' + - 'spec/lib/generators/gitlab/usage_metric_definition_generator_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/job_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/jobs_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/processable_spec.rb' + - 'spec/lib/gitlab/ci/interpolation/template_spec.rb' + - 'spec/lib/gitlab/ci/parsers/accessibility/pa11y_spec.rb' + - 'spec/lib/gitlab/ci/parsers/codequality/code_climate_spec.rb' + - 'spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb' + - 'spec/lib/gitlab/ci/reports/codequality_reports_spec.rb' + - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' + - 'spec/lib/gitlab/database/query_analyzers/prevent_cross_database_modification_spec.rb' + - 'spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb' + - 'spec/lib/gitlab/diff/formatters/text_formatter_spec.rb' + - 'spec/lib/gitlab/fake_application_settings_spec.rb' + - 'spec/lib/gitlab/grape_logging/formatters/lograge_with_timestamp_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/token_logger_spec.rb' + - 'spec/lib/gitlab/harbor/client_spec.rb' + - 'spec/lib/gitlab/harbor/query_spec.rb' + - 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb' + - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb' + - 'spec/lib/gitlab/lfs/client_spec.rb' + - 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb' + - 'spec/lib/gitlab/prometheus_client_spec.rb' + - 'spec/lib/gitlab/search/abuse_validators/no_abusive_coercion_from_string_validator_spec.rb' + - 'spec/lib/gitlab/slug/path_spec.rb' + - 'spec/lib/gitlab/tracking_spec.rb' + - 'spec/lib/gitlab/utils_spec.rb' + - 'spec/lib/google_api/cloud_platform/client_spec.rb' + - 'spec/lib/service_ping/devops_report_spec.rb' + - 'spec/models/integrations/prometheus_spec.rb' + - 'spec/models/merge_request_diff_commit_spec.rb' + - 'spec/models/packages/debian/file_metadatum_spec.rb' + - 'spec/models/packages/helm/file_metadatum_spec.rb' + - 'spec/models/packages/npm/metadatum_spec.rb' + - 'spec/presenters/packages/npm/package_presenter_spec.rb' + - 'spec/requests/api/admin/plan_limits_spec.rb' + - 'spec/requests/api/ci/job_artifacts_spec.rb' + - 'spec/requests/api/ci/runner/jobs_put_spec.rb' + - 'spec/requests/api/feature_flags_spec.rb' + - 'spec/requests/api/group_debian_distributions_spec.rb' + - 'spec/requests/api/integrations_spec.rb' + - 'spec/requests/api/project_debian_distributions_spec.rb' + - 'spec/requests/api/terraform/state_spec.rb' + - 'spec/requests/mailgun/webhooks_controller_spec.rb' + - 'spec/requests/users_controller_spec.rb' + - 'spec/scripts/pipeline_test_report_builder_spec.rb' + - 'spec/serializers/integrations/harbor_serializers/artifact_entity_spec.rb' + - 'spec/serializers/integrations/harbor_serializers/tag_entity_spec.rb' + - 'spec/services/bulk_imports/get_importable_data_service_spec.rb' + - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' + - 'spec/services/git/base_hooks_service_spec.rb' + - 'spec/services/incident_management/timeline_event_tags/create_service_spec.rb' + - 'spec/services/jira_connect/sync_service_spec.rb' + - 'spec/services/ml/experiment_tracking/candidate_repository_spec.rb' + - 'spec/support/google_api/cloud_platform_helpers.rb' + - 'spec/support/helpers/kubernetes_helpers.rb' + - 'spec/support/helpers/prometheus_helpers.rb' + - 'spec/support/prometheus/additional_metrics_shared_examples.rb' + - 'spec/support/shared_examples/harbor/artifacts_controller_shared_examples.rb' + - 'spec/support/shared_examples/harbor/repositories_controller_shared_examples.rb' + - 'spec/support/shared_examples/harbor/tags_controller_shared_examples.rb' + - 'spec/support/shared_examples/models/diff_positionable_note_shared_examples.rb' + - 'spec/views/admin/application_settings/_repository_storage.html.haml_spec.rb' + - 'spec/workers/gitlab/github_gists_import/import_gist_worker_spec.rb' + - 'spec/workers/packages/go/sync_packages_worker_spec.rb' diff --git a/.rubocop_todo/lint/to_enum_arguments.yml b/.rubocop_todo/lint/to_enum_arguments.yml new file mode 100644 index 00000000000..3e5579b4afb --- /dev/null +++ b/.rubocop_todo/lint/to_enum_arguments.yml @@ -0,0 +1,6 @@ +--- +Lint/ToEnumArguments: + Details: grace period + Exclude: + - 'lib/gitlab/ci/trace/stream.rb' + - 'spec/lib/gitlab/ci/trace/section_parser_spec.rb' diff --git a/.rubocop_todo/lint/triple_quotes.yml b/.rubocop_todo/lint/triple_quotes.yml new file mode 100644 index 00000000000..7695fa46b03 --- /dev/null +++ b/.rubocop_todo/lint/triple_quotes.yml @@ -0,0 +1,7 @@ +--- +# Cop supports --autocorrect. +Lint/TripleQuotes: + Details: grace period + Exclude: + - 'spec/lib/gitlab/database/with_lock_retries_outside_transaction_spec.rb' + - 'spec/lib/gitlab/database/with_lock_retries_spec.rb' diff --git a/.rubocop_todo/lint/unexpected_block_arity.yml b/.rubocop_todo/lint/unexpected_block_arity.yml new file mode 100644 index 00000000000..a7ad3d0a227 --- /dev/null +++ b/.rubocop_todo/lint/unexpected_block_arity.yml @@ -0,0 +1,6 @@ +--- +Lint/UnexpectedBlockArity: + Details: grace period + Exclude: + - 'app/services/issues/referenced_merge_requests_service.rb' + - 'lib/gitlab/issuable_sorter.rb' diff --git a/.rubocop_todo/lint/unmodified_reduce_accumulator.yml b/.rubocop_todo/lint/unmodified_reduce_accumulator.yml new file mode 100644 index 00000000000..6aec00738e7 --- /dev/null +++ b/.rubocop_todo/lint/unmodified_reduce_accumulator.yml @@ -0,0 +1,5 @@ +--- +Lint/UnmodifiedReduceAccumulator: + Details: grace period + Exclude: + - 'qa/qa/specs/runner.rb' diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml new file mode 100644 index 00000000000..f226f04445a --- /dev/null +++ b/.rubocop_todo/lint/unused_block_argument.yml @@ -0,0 +1,449 @@ +--- +# Cop supports --autocorrect. +Lint/UnusedBlockArgument: + Details: grace period + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/controllers/concerns/project_unauthorized.rb' + - 'app/controllers/concerns/renders_notes.rb' + - 'app/controllers/import/fogbugz_controller.rb' + - 'app/controllers/oauth/applications_controller.rb' + - 'app/controllers/profiles/two_factor_auths_controller.rb' + - 'app/controllers/projects/commit_controller.rb' + - 'app/finders/releases/group_releases_finder.rb' + - 'app/graphql/batch_loaders/award_emoji_votes_batch_loader.rb' + - 'app/graphql/batch_loaders/merge_request_diff_summary_batch_loader.rb' + - 'app/graphql/mutations/ci/runner/update.rb' + - 'app/graphql/resolvers/bulk_labels_resolver.rb' + - 'app/graphql/resolvers/incident_management/timeline_events_resolver.rb' + - 'app/graphql/resolvers/merge_requests_count_resolver.rb' + - 'app/graphql/resolvers/user_discussions_count_resolver.rb' + - 'app/graphql/resolvers/user_notes_count_resolver.rb' + - 'app/graphql/types/ci/runner_type.rb' + - 'app/graphql/types/global_id_type.rb' + - 'app/graphql/types/merge_request_type.rb' + - 'app/helpers/explore_helper.rb' + - 'app/helpers/issues_helper.rb' + - 'app/models/abuse_report.rb' + - 'app/models/alert_management/alert.rb' + - 'app/models/appearance.rb' + - 'app/models/ci/build.rb' + - 'app/models/ci/instance_variable.rb' + - 'app/models/ci/pipeline.rb' + - 'app/models/clusters/cluster.rb' + - 'app/models/concerns/atomic_internal_id.rb' + - 'app/models/concerns/avatarable.rb' + - 'app/models/concerns/enum_with_nil.rb' + - 'app/models/concerns/mentionable.rb' + - 'app/models/customer_relations/organization.rb' + - 'app/models/integration.rb' + - 'app/models/merge_request.rb' + - 'app/models/namespace/root_storage_statistics.rb' + - 'app/models/project.rb' + - 'app/models/projects/build_artifacts_size_refresh.rb' + - 'app/models/service_desk_setting.rb' + - 'app/models/users/phone_number_validation.rb' + - 'app/models/wiki.rb' + - 'app/serializers/analytics_commit_entity.rb' + - 'app/serializers/build_details_entity.rb' + - 'app/serializers/ci/daily_build_group_report_result_entity.rb' + - 'app/serializers/ci/lint/result_entity.rb' + - 'app/serializers/diff_file_base_entity.rb' + - 'app/serializers/diff_file_entity.rb' + - 'app/serializers/diffs_entity.rb' + - 'app/serializers/environment_entity.rb' + - 'app/serializers/group_child_entity.rb' + - 'app/serializers/group_entity.rb' + - 'app/serializers/import/bitbucket_provider_repo_entity.rb' + - 'app/serializers/import/bitbucket_server_provider_repo_entity.rb' + - 'app/serializers/integrations/event_entity.rb' + - 'app/serializers/issue_entity.rb' + - 'app/serializers/merge_request_diff_entity.rb' + - 'app/serializers/merge_request_noteable_entity.rb' + - 'app/serializers/merge_request_poll_widget_entity.rb' + - 'app/serializers/merge_request_user_entity.rb' + - 'app/serializers/merge_request_widget_entity.rb' + - 'app/serializers/note_entity.rb' + - 'app/serializers/paginated_diff_entity.rb' + - 'app/serializers/personal_access_token_entity.rb' + - 'app/serializers/stage_entity.rb' + - 'app/serializers/test_suite_entity.rb' + - 'app/serializers/user_preference_entity.rb' + - 'app/services/authorized_project_update/find_records_due_for_refresh_service.rb' + - 'app/services/design_management/copy_design_collection/copy_service.rb' + - 'app/services/environments/stop_stale_service.rb' + - 'app/services/prometheus/proxy_service.rb' + - 'app/services/resource_events/synthetic_label_notes_builder_service.rb' + - 'app/services/web_hooks/log_execution_service.rb' + - 'app/uploaders/object_storage.rb' + - 'app/views/projects/commits/_commit.atom.builder' + - 'app/views/projects/tags/_tag.atom.builder' + - 'app/workers/process_commit_worker.rb' + - 'config/application.rb' + - 'config/initializers/content_security_policy.rb' + - 'config/initializers/doorkeeper.rb' + - 'config/initializers/lograge.rb' + - 'config/initializers/sawyer_patch.rb' + - 'config/initializers/warden.rb' + - 'config/routes/project.rb' + - 'config/routes/wiki.rb' + - 'db/post_migrate/20211117084814_migrate_remaining_u2f_registrations.rb' + - 'ee/app/finders/security/training_providers/kontra_url_finder.rb' + - 'ee/app/finders/security/training_providers/secure_code_warrior_url_finder.rb' + - 'ee/app/graphql/resolvers/incident_management/escalation_policies_resolver.rb' + - 'ee/app/graphql/resolvers/incident_management/oncall_rotations_resolver.rb' + - 'ee/app/graphql/types/health_status_enum.rb' + - 'ee/app/models/ee/application_setting.rb' + - 'ee/app/models/ee/ci/build.rb' + - 'ee/app/models/ee/deployment.rb' + - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/namespace_setting.rb' + - 'ee/app/serializers/ee/build_detail_entity.rb' + - 'ee/app/serializers/ee/merge_request_widget_entity.rb' + - 'ee/app/serializers/ee/note_entity.rb' + - 'ee/app/serializers/ee/note_user_entity.rb' + - 'ee/app/serializers/epic_entity.rb' + - 'ee/app/serializers/integrations/zentao_serializers/issue_entity.rb' + - 'ee/app/serializers/security/vulnerability_report_data_entity.rb' + - 'ee/app/services/elastic/cluster_reindexing_service.rb' + - 'ee/app/workers/sync_seat_link_request_worker.rb' + - 'ee/lib/ee/api/entities/geo_node_status.rb' + - 'ee/lib/ee/api/entities/gitlab_license.rb' + - 'ee/lib/ee/api/entities/group.rb' + - 'ee/lib/ee/api/entities/group_detail.rb' + - 'ee/lib/ee/api/entities/issue_basic.rb' + - 'ee/lib/ee/gitlab/analytics/cycle_analytics/stage_events.rb' + - 'ee/lib/ee/gitlab/quick_actions/issue_and_merge_request_actions.rb' + - 'ee/lib/ee/gitlab/throttle.rb' + - 'ee/lib/gitlab/authority_analyzer.rb' + - 'ee/lib/gitlab/insights/reducers/count_per_label_reducer.rb' + - 'ee/lib/gitlab/proxy.rb' + - 'ee/lib/tasks/contracts/merge_requests.rake' + - 'ee/lib/tasks/gitlab/elastic.rake' + - 'ee/lib/tasks/gitlab/indexer.rake' + - 'ee/lib/tasks/gitlab/seed/insights.rake' + - 'ee/spec/config/metrics/every_metric_definition_spec.rb' + - 'ee/spec/elastic/migrate/20220118150500_delete_orphaned_commits_spec.rb' + - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' + - 'ee/spec/elastic/migrate/20220613120500_migrate_commits_to_separate_index_spec.rb' + - 'ee/spec/factories/approvers.rb' + - 'ee/spec/factories/ci/pipelines.rb' + - 'ee/spec/factories/ci/reports/license_scanning/report.rb' + - 'ee/spec/factories/group_saml_identities.rb' + - 'ee/spec/factories/groups.rb' + - 'ee/spec/factories/merge_requests.rb' + - 'ee/spec/factories/namespaces.rb' + - 'ee/spec/factories/projects.rb' + - 'ee/spec/factories/protected_branches.rb' + - 'ee/spec/factories/protected_environments.rb' + - 'ee/spec/factories/slack_integrations.rb' + - 'ee/spec/factories/users.rb' + - 'ee/spec/features/billings/extend_reactivate_trial_spec.rb' + - 'ee/spec/features/groups/group_settings_spec.rb' + - 'ee/spec/graphql/mutations/dast/profiles/update_spec.rb' + - 'ee/spec/graphql/resolvers/analytics/contribution_analytics/contributions_resolver_spec.rb' + - 'ee/spec/lib/compliance_management/compliance_report/commit_loader_spec.rb' + - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used_spec.rb' + - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' + - 'ee/spec/lib/gitlab/insights/project_insights_config_spec.rb' + - 'ee/spec/lib/gitlab/usage_data_metrics_spec.rb' + - 'ee/spec/models/member_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/security_report_summary_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/sort_spec.rb' + - 'ee/spec/requests/api/related_epic_links_spec.rb' + - 'ee/spec/services/app_sec/dast/site_validations/revoke_service_spec.rb' + - 'ee/spec/services/ci/retry_pipeline_service_spec.rb' + - 'ee/spec/services/elastic/process_bookkeeping_service_spec.rb' + - 'ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb' + - 'ee/spec/services/security/vulnerability_counting_service_spec.rb' + - 'ee/spec/services/todo_service_spec.rb' + - 'ee/spec/support/shared_examples/finders/security/findings_finder_shared_examples.rb' + - 'ee/spec/support/shared_examples/graphql/geo/geo_registry_type_shared_examples.rb' + - 'ee/spec/support/shared_examples/lib/gitlab/middleware/maintenance_mode_gitlab_ee_instance_shared_examples.rb' + - 'ee/spec/support/shared_examples/lib/gitlab/middleware/read_only_gitlab_ee_instance_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/build_execute_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/search_notes_shared_examples.rb' + - 'ee/spec/views/shared/credentials_inventory/ssh_keys/_ssh_key.html.haml_spec.rb' + - 'lib/api/api.rb' + - 'lib/api/entities/appearance.rb' + - 'lib/api/entities/basic_project_details.rb' + - 'lib/api/entities/ci/job.rb' + - 'lib/api/entities/ci/job_request/dependency.rb' + - 'lib/api/entities/ci/lint/result.rb' + - 'lib/api/entities/ci/reset_token_result.rb' + - 'lib/api/entities/commit_with_link.rb' + - 'lib/api/entities/event.rb' + - 'lib/api/entities/global_notification_setting.rb' + - 'lib/api/entities/group.rb' + - 'lib/api/entities/issue_basic.rb' + - 'lib/api/entities/label_basic.rb' + - 'lib/api/entities/member_access.rb' + - 'lib/api/entities/merge_request_basic.rb' + - 'lib/api/entities/merge_request_simple.rb' + - 'lib/api/entities/milestone.rb' + - 'lib/api/entities/ml/mlflow/experiment.rb' + - 'lib/api/entities/ml/mlflow/run_info.rb' + - 'lib/api/entities/note.rb' + - 'lib/api/entities/project.rb' + - 'lib/api/entities/project_integration.rb' + - 'lib/api/entities/project_label.rb' + - 'lib/api/entities/projects/topic.rb' + - 'lib/api/entities/public_group_details.rb' + - 'lib/api/entities/resource_label_event.rb' + - 'lib/api/entities/shared_group_with_project.rb' + - 'lib/api/entities/snippet.rb' + - 'lib/api/entities/todo.rb' + - 'lib/api/entities/tree_object.rb' + - 'lib/api/entities/user_basic.rb' + - 'lib/api/github/entities.rb' + - 'lib/api/group_variables.rb' + - 'lib/api/helpers/authentication.rb' + - 'lib/api/helpers/container_registry_helpers.rb' + - 'lib/api/helpers/snippets_helpers.rb' + - 'lib/api/search.rb' + - 'lib/atlassian/jira_connect/serializers/repository_entity.rb' + - 'lib/backup/database.rb' + - 'lib/banzai/filter/autolink_filter.rb' + - 'lib/banzai/filter/emoji_filter.rb' + - 'lib/banzai/filter/inline_metrics_redactor_filter.rb' + - 'lib/banzai/filter/markdown_post_escape_filter.rb' + - 'lib/banzai/filter/references/abstract_reference_filter.rb' + - 'lib/banzai/filter/spaced_link_filter.rb' + - 'lib/banzai/issuable_extractor.rb' + - 'lib/container_registry/client.rb' + - 'lib/gem_extensions/active_record/disable_joins/associations/association_scope.rb' + - 'lib/gitlab/background_migration/backfill_project_feature_package_registry_access_level.rb' + - 'lib/gitlab/ci/build/artifacts/path.rb' + - 'lib/gitlab/ci/config/normalizer.rb' + - 'lib/gitlab/ci/reports/accessibility_reports.rb' + - 'lib/gitlab/ci/reports/test_suite.rb' + - 'lib/gitlab/ci/secure_files/mobile_provision.rb' + - 'lib/gitlab/cleanup/orphan_job_artifact_files.rb' + - 'lib/gitlab/cleanup/project_upload_file_finder.rb' + - 'lib/gitlab/config/entry/composable_array.rb' + - 'lib/gitlab/config/entry/configurable.rb' + - 'lib/gitlab/database/background_migration/batched_migration.rb' + - 'lib/gitlab/database/bulk_update.rb' + - 'lib/gitlab/database/load_balancing/service_discovery/sampler.rb' + - 'lib/gitlab/database/read_only_relation.rb' + - 'lib/gitlab/database/reindexing.rb' + - 'lib/gitlab/database/schema_cache_with_renamed_table.rb' + - 'lib/gitlab/dependency_linker/base_linker.rb' + - 'lib/gitlab/dependency_linker/go_mod_linker.rb' + - 'lib/gitlab/dependency_linker/go_sum_linker.rb' + - 'lib/gitlab/diff/inline_diff_markdown_marker.rb' + - 'lib/gitlab/gfm/uploads_rewriter.rb' + - 'lib/gitlab/git/merge_base.rb' + - 'lib/gitlab/github_import/object_counter.rb' + - 'lib/gitlab/grape_logging/formatters/lograge_with_timestamp.rb' + - 'lib/gitlab/health_checks/probes/collection.rb' + - 'lib/gitlab/health_checks/server.rb' + - 'lib/gitlab/import_export/members_mapper.rb' + - 'lib/gitlab/metrics/dashboard/stages/variable_endpoint_inserter.rb' + - 'lib/gitlab/metrics/dashboard/transformers/yml/v1/prometheus_metrics.rb' + - 'lib/gitlab/metrics/dashboard/validator/custom_formats.rb' + - 'lib/gitlab/metrics/exporter/base_exporter.rb' + - 'lib/gitlab/pagination/gitaly_keyset_pager.rb' + - 'lib/gitlab/safe_request_store.rb' + - 'lib/gitlab/sidekiq_config.rb' + - 'lib/gitlab/sidekiq_daemon/monitor.rb' + - 'lib/gitlab/suggestions/commit_message.rb' + - 'lib/gitlab/testing/request_inspector_middleware.rb' + - 'lib/gitlab/throttle.rb' + - 'lib/gitlab/utils/batch_loader.rb' + - 'lib/gitlab/utils/merge_hash.rb' + - 'lib/google_api/cloud_platform/client.rb' + - 'lib/peek/views/gitaly.rb' + - 'lib/security/ci_configuration/sast_build_action.rb' + - 'lib/tasks/cleanup.rake' + - 'lib/tasks/contracts/merge_requests.rake' + - 'lib/tasks/contracts/pipeline_schedules.rake' + - 'lib/tasks/contracts/pipelines.rake' + - 'lib/tasks/frontend.rake' + - 'lib/tasks/gitlab/background_migrations.rake' + - 'lib/tasks/gitlab/bulk_add_permission.rake' + - 'lib/tasks/gitlab/db.rake' + - 'lib/tasks/gitlab/external_diffs.rake' + - 'lib/tasks/gitlab/gitaly.rake' + - 'lib/tasks/gitlab/graphql.rake' + - 'lib/tasks/gitlab/metrics_exporter.rake' + - 'lib/tasks/gitlab/praefect.rake' + - 'lib/tasks/gitlab/seed.rake' + - 'lib/tasks/gitlab/seed/group_seed.rake' + - 'lib/tasks/gitlab/shell.rake' + - 'lib/tasks/gitlab/snippets.rake' + - 'lib/tasks/gitlab/two_factor.rake' + - 'lib/tasks/gitlab/uploads/sanitize.rake' + - 'lib/tasks/gitlab/user_management.rake' + - 'lib/tasks/gitlab/workhorse.rake' + - 'lib/version_check.rb' + - 'qa/qa/runtime/allure_report.rb' + - 'qa/qa/service/praefect_manager.rb' + - 'qa/qa/specs/features/api/12_systems/gitaly/distributed_reads_spec.rb' + - 'qa/qa/specs/features/api/12_systems/gitaly/praefect_dataloss_spec.rb' + - 'qa/qa/support/knapsack_report.rb' + - 'qa/qa/support/matchers/eventually_matcher.rb' + - 'qa/qa/tools/generate_perf_testdata.rb' + - 'qa/qa/tools/long_running_spec_reporter.rb' + - 'qa/qa/tools/reliable_report.rb' + - 'qa/qa/tools/test_resource_data_processor.rb' + - 'qa/tasks/vulnerabilities.rake' + - 'scripts/docs_screenshots.rb' + - 'scripts/packages/automated_cleanup.rb' + - 'scripts/perf/gc/collect_gc_stats.rb' + - 'scripts/qa/testcases-check' + - 'scripts/review_apps/automated_cleanup.rb' + - 'scripts/used-feature-flags' + - 'sidekiq_cluster/cli.rb' + - 'spec/components/pajamas/button_component_spec.rb' + - 'spec/components/previews/pajamas/banner_component_preview.rb' + - 'spec/controllers/concerns/confirm_email_warning_spec.rb' + - 'spec/controllers/concerns/routable_actions_spec.rb' + - 'spec/controllers/groups/children_controller_spec.rb' + - 'spec/controllers/projects/labels_controller_spec.rb' + - 'spec/factories/alert_management/alerts.rb' + - 'spec/factories/ci/builds.rb' + - 'spec/factories/ci/job_artifacts.rb' + - 'spec/factories/ci/pipelines.rb' + - 'spec/factories/ci/processable.rb' + - 'spec/factories/ci/reports/sbom/reports.rb' + - 'spec/factories/ci/runner_namespaces.rb' + - 'spec/factories/ci/runner_projects.rb' + - 'spec/factories/ci/runners.rb' + - 'spec/factories/clusters/clusters.rb' + - 'spec/factories/clusters/platforms/kubernetes.rb' + - 'spec/factories/clusters/providers/gcp.rb' + - 'spec/factories/commit_statuses.rb' + - 'spec/factories/container_repositories.rb' + - 'spec/factories/deployments.rb' + - 'spec/factories/environments.rb' + - 'spec/factories/merge_requests.rb' + - 'spec/factories/namespaces.rb' + - 'spec/factories/packages/debian/distribution.rb' + - 'spec/factories/project_group_links.rb' + - 'spec/factories/protected_branches.rb' + - 'spec/factories/resource_label_events.rb' + - 'spec/factories/suggestions.rb' + - 'spec/factories/users.rb' + - 'spec/features/issuables/issuable_list_spec.rb' + - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' + - 'spec/fixtures/lib/generators/gitlab/usage_metric_generator/sample_numbers_metric.rb' + - 'spec/graphql/features/authorization_spec.rb' + - 'spec/graphql/types/base_object_spec.rb' + - 'spec/initializers/secret_token_spec.rb' + - 'spec/lib/api/helpers/pagination_strategies_spec.rb' + - 'spec/lib/backup/database_spec.rb' + - 'spec/lib/banzai/filter/audio_link_filter_spec.rb' + - 'spec/lib/banzai/filter/video_link_filter_spec.rb' + - 'spec/lib/feature_spec.rb' + - 'spec/lib/gitlab/auth/saml/user_spec.rb' + - 'spec/lib/gitlab/background_migration/cleanup_draft_data_from_faulty_regex_spec.rb' + - 'spec/lib/gitlab/background_migration/populate_vulnerability_reads_spec.rb' + - 'spec/lib/gitlab/ci/parsers/terraform/tfplan_spec.rb' + - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/logger_spec.rb' + - 'spec/lib/gitlab/ci/status/composite_spec.rb' + - 'spec/lib/gitlab/cleanup/orphan_job_artifact_files_spec.rb' + - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' + - 'spec/lib/gitlab/database/migrations/test_background_runner_spec.rb' + - 'spec/lib/gitlab/database/partitioning/detached_partition_dropper_spec.rb' + - 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1_spec.rb' + - 'spec/lib/gitlab/git_access_wiki_spec.rb' + - 'spec/lib/gitlab/graphql/tracers/application_context_tracer_spec.rb' + - 'spec/lib/gitlab/health_checks/simple_check_shared.rb' + - 'spec/lib/gitlab/http_spec.rb' + - 'spec/lib/gitlab/jwt_authenticatable_spec.rb' + - 'spec/lib/gitlab/memory/jemalloc_spec.rb' + - 'spec/lib/gitlab/middleware/memory_report_spec.rb' + - 'spec/lib/gitlab/middleware/speedscope_spec.rb' + - 'spec/lib/gitlab/null_request_store_spec.rb' + - 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/strategies/record_loader_strategy_spec.rb' + - 'spec/lib/gitlab/process_supervisor_spec.rb' + - 'spec/lib/gitlab/query_limiting_spec.rb' + - 'spec/lib/gitlab/redis/multi_store_spec.rb' + - 'spec/lib/gitlab/string_placeholder_replacer_spec.rb' + - 'spec/lib/gitlab/string_range_marker_spec.rb' + - 'spec/lib/gitlab/string_regex_marker_spec.rb' + - 'spec/lib/gitlab/tracking/incident_management_spec.rb' + - 'spec/lib/gitlab/usage_data_metrics_spec.rb' + - 'spec/lib/gitlab/utils/usage_data_spec.rb' + - 'spec/lib/mattermost/session_spec.rb' + - 'spec/mailers/notify_spec.rb' + - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb' + - 'spec/models/active_session_spec.rb' + - 'spec/models/ci/build_spec.rb' + - 'spec/models/concerns/ci/partitionable/switch_spec.rb' + - 'spec/models/concerns/ci/partitionable_spec.rb' + - 'spec/models/concerns/each_batch_spec.rb' + - 'spec/models/concerns/uniquify_spec.rb' + - 'spec/models/container_repository_spec.rb' + - 'spec/models/network/graph_spec.rb' + - 'spec/models/packages/debian/file_metadatum_spec.rb' + - 'spec/requests/api/ci/pipeline_schedules_spec.rb' + - 'spec/requests/api/graphql/gitlab_schema_spec.rb' + - 'spec/requests/api/internal/container_registry/migration_spec.rb' + - 'spec/requests/git_http_spec.rb' + - 'spec/requests/projects/google_cloud/deployments_controller_spec.rb' + - 'spec/requests/projects/google_cloud/gcp_regions_controller_spec.rb' + - 'spec/requests/projects/ml/experiments_controller_spec.rb' + - 'spec/services/ci/job_token_scope/add_project_service_spec.rb' + - 'spec/services/ci/job_token_scope/remove_project_service_spec.rb' + - 'spec/services/ci/pipelines/add_job_service_spec.rb' + - 'spec/services/issues/relative_position_rebalancing_service_spec.rb' + - 'spec/services/merge_requests/merge_to_ref_service_spec.rb' + - 'spec/services/packages/create_event_service_spec.rb' + - 'spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb' + - 'spec/services/repository_archive_clean_up_service_spec.rb' + - 'spec/services/snippets/update_service_spec.rb' + - 'spec/spec_helper.rb' + - 'spec/support/atlassian/jira_connect/schemata.rb' + - 'spec/support/cycle_analytics_helpers/test_generation.rb' + - 'spec/support/database/prevent_cross_database_modification.rb' + - 'spec/support/graphql/subscriptions/action_cable/mock_action_cable.rb' + - 'spec/support/helpers/cycle_analytics_helpers.rb' + - 'spec/support/helpers/docs_screenshot_helpers.rb' + - 'spec/support/helpers/graphql_helpers.rb' + - 'spec/support/helpers/stub_method_calls.rb' + - 'spec/support/helpers/stub_metrics.rb' + - 'spec/support/matchers/be_n_plus_1_query.rb' + - 'spec/support/matchers/event_store.rb' + - 'spec/support/matchers/exceed_query_limit.rb' + - 'spec/support/matchers/graphql_matchers.rb' + - 'spec/support/matchers/issuable_matchers.rb' + - 'spec/support/matchers/pagination_matcher.rb' + - 'spec/support/matchers/schema_matcher.rb' + - 'spec/support/matchers/security_header_matcher.rb' + - 'spec/support/redis.rb' + - 'spec/support/shared_contexts/jobs/handling_retried_jobs_shared_context.rb' + - 'spec/support/shared_contexts/lib/gitlab/middleware/multipart_shared_contexts.rb' + - 'spec/support/shared_contexts/services/service_ping/stubbed_service_ping_metrics_definitions_shared_context.rb' + - 'spec/support/shared_examples/ci/jobs_shared_examples.rb' + - 'spec/support/shared_examples/controllers/rate_limited_endpoint_shared_examples.rb' + - 'spec/support/shared_examples/features/packages_shared_examples.rb' + - 'spec/support/shared_examples/graphql/members_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/database/reestablished_connection_stack_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/diff_file_collections_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/middleware/read_only_gitlab_instance_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/usage_data_counters/code_review_extension_request_examples.rb' + - 'spec/support/shared_examples/metrics/active_record_subscriber_shared_examples.rb' + - 'spec/support/shared_examples/models/active_record_enum_shared_examples.rb' + - 'spec/support/shared_examples/models/cluster_application_core_shared_examples.rb' + - 'spec/support/shared_examples/models/diff_positionable_note_shared_examples.rb' + - 'spec/support/shared_examples/models/issue_tracker_service_shared_examples.rb' + - 'spec/support/shared_examples/models/snippet_shared_examples.rb' + - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/container_repositories_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/helm_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/npm_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/npm_packages_tags_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/project_statistics_refresh_conflicts_shared_examples.rb' + - 'spec/support/shared_examples/services/boards/issues_move_service_shared_examples.rb' + - 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb' + - 'spec/support/shared_examples/workers/concerns/reenqueuer_shared_examples.rb' + - 'spec/tooling/lib/tooling/find_codeowners_spec.rb' + - 'spec/tooling/rspec_flaky/config_spec.rb' + - 'spec/workers/projects/git_garbage_collect_worker_spec.rb' + - 'tooling/danger/specs.rb' + - 'tooling/lib/tooling/find_codeowners.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml new file mode 100644 index 00000000000..8c23a6ae84b --- /dev/null +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -0,0 +1,663 @@ +--- +# Cop supports --autocorrect. +Lint/UnusedMethodArgument: + Details: grace period + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/controllers/concerns/authenticates_with_two_factor.rb' + - 'app/controllers/concerns/creates_commit.rb' + - 'app/controllers/concerns/metrics_dashboard.rb' + - 'app/controllers/concerns/renders_notes.rb' + - 'app/controllers/concerns/send_file_upload.rb' + - 'app/controllers/concerns/spammable_actions/captcha_check/common.rb' + - 'app/controllers/concerns/wiki_actions.rb' + - 'app/controllers/confirmations_controller.rb' + - 'app/controllers/import/bitbucket_controller.rb' + - 'app/controllers/ldap/omniauth_callbacks_controller.rb' + - 'app/controllers/projects/forks_controller.rb' + - 'app/finders/issuable_finder/params.rb' + - 'app/graphql/mutations/base_mutation.rb' + - 'app/graphql/mutations/ci/runner/delete.rb' + - 'app/graphql/mutations/concerns/mutations/assignable.rb' + - 'app/graphql/mutations/members/groups/bulk_update.rb' + - 'app/graphql/mutations/notes/create/base.rb' + - 'app/graphql/mutations/notes/create/diff_note.rb' + - 'app/graphql/mutations/notes/create/image_diff_note.rb' + - 'app/graphql/mutations/timelogs/create.rb' + - 'app/graphql/resolvers/base_resolver.rb' + - 'app/graphql/resolvers/board_list_issues_resolver.rb' + - 'app/graphql/resolvers/branch_commit_resolver.rb' + - 'app/graphql/resolvers/ci/runner_groups_resolver.rb' + - 'app/graphql/resolvers/ci/runner_platforms_resolver.rb' + - 'app/graphql/resolvers/ci/runner_setup_resolver.rb' + - 'app/graphql/resolvers/ci/runner_status_resolver.rb' + - 'app/graphql/resolvers/ci/test_report_summary_resolver.rb' + - 'app/graphql/resolvers/clusters/agent_activity_events_resolver.rb' + - 'app/graphql/resolvers/concerns/caching_array_resolver.rb' + - 'app/graphql/resolvers/error_tracking/sentry_error_collection_resolver.rb' + - 'app/graphql/resolvers/last_commit_resolver.rb' + - 'app/graphql/resolvers/merge_request_resolver.rb' + - 'app/graphql/resolvers/metadata_resolver.rb' + - 'app/graphql/resolvers/project_resolver.rb' + - 'app/graphql/resolvers/projects/branch_rules_resolver.rb' + - 'app/graphql/resolvers/projects/grafana_integration_resolver.rb' + - 'app/graphql/resolvers/release_milestones_resolver.rb' + - 'app/graphql/resolvers/users/group_count_resolver.rb' + - 'app/graphql/resolvers/users/participants_resolver.rb' + - 'app/graphql/resolvers/users_resolver.rb' + - 'app/graphql/resolvers/work_items/work_item_discussions_resolver.rb' + - 'app/graphql/subscriptions/issuable_updated.rb' + - 'app/graphql/subscriptions/notes/base.rb' + - 'app/graphql/subscriptions/notes/created.rb' + - 'app/graphql/subscriptions/notes/deleted.rb' + - 'app/graphql/types/alert_management/integration_type.rb' + - 'app/graphql/types/base_field.rb' + - 'app/graphql/types/ci/job_need_union.rb' + - 'app/graphql/types/color_type.rb' + - 'app/graphql/types/commit_signature_interface.rb' + - 'app/graphql/types/date_type.rb' + - 'app/graphql/types/design_management/design_type.rb' + - 'app/graphql/types/duration_type.rb' + - 'app/graphql/types/invitation_interface.rb' + - 'app/graphql/types/issuable_type.rb' + - 'app/graphql/types/member_interface.rb' + - 'app/graphql/types/merge_requests/interacts_with_merge_request.rb' + - 'app/graphql/types/noteable_type.rb' + - 'app/graphql/types/notes/noteable_interface.rb' + - 'app/graphql/types/packages/dependency_link_metadata_type.rb' + - 'app/graphql/types/packages/file_metadata_type.rb' + - 'app/graphql/types/packages/metadata_type.rb' + - 'app/graphql/types/projects/service_type.rb' + - 'app/graphql/types/projects/service_type_enum.rb' + - 'app/graphql/types/time_type.rb' + - 'app/graphql/types/todoable_interface.rb' + - 'app/graphql/types/user_interface.rb' + - 'app/graphql/types/work_item_id_type.rb' + - 'app/graphql/types/work_items/widget_interface.rb' + - 'app/helpers/admin/identities_helper.rb' + - 'app/helpers/diff_helper.rb' + - 'app/helpers/environment_helper.rb' + - 'app/helpers/groups/group_members_helper.rb' + - 'app/helpers/groups_helper.rb' + - 'app/helpers/invite_members_helper.rb' + - 'app/helpers/issuables_helper.rb' + - 'app/helpers/issues_helper.rb' + - 'app/helpers/labels_helper.rb' + - 'app/helpers/markup_helper.rb' + - 'app/helpers/nav/new_dropdown_helper.rb' + - 'app/helpers/projects_helper.rb' + - 'app/helpers/releases_helper.rb' + - 'app/helpers/routing/groups/members_helper.rb' + - 'app/helpers/routing/projects/members_helper.rb' + - 'app/helpers/routing/projects_helper.rb' + - 'app/helpers/routing/snippets_helper.rb' + - 'app/helpers/search_helper.rb' + - 'app/helpers/timeboxes_helper.rb' + - 'app/helpers/users_helper.rb' + - 'app/mailers/emails/merge_requests.rb' + - 'app/mailers/emails/releases.rb' + - 'app/models/ability.rb' + - 'app/models/blob_viewer/auxiliary.rb' + - 'app/models/ci/bridge.rb' + - 'app/models/ci/build.rb' + - 'app/models/ci/build_trace_chunk.rb' + - 'app/models/ci/build_trace_chunks/database.rb' + - 'app/models/ci/processable.rb' + - 'app/models/ci/runner.rb' + - 'app/models/concerns/bulk_insert_safe.rb' + - 'app/models/concerns/cache_markdown_field.rb' + - 'app/models/concerns/ci/partitionable/partitioned_filter.rb' + - 'app/models/concerns/cross_database_modification.rb' + - 'app/models/concerns/issuable.rb' + - 'app/models/concerns/mentionable.rb' + - 'app/models/concerns/note_on_diff.rb' + - 'app/models/concerns/protected_ref.rb' + - 'app/models/concerns/reactive_caching.rb' + - 'app/models/concerns/referable.rb' + - 'app/models/concerns/spammable.rb' + - 'app/models/concerns/subscribable.rb' + - 'app/models/concerns/timebox.rb' + - 'app/models/design_management/version.rb' + - 'app/models/discussion.rb' + - 'app/models/external_issue.rb' + - 'app/models/group.rb' + - 'app/models/integrations/bamboo.rb' + - 'app/models/integrations/buildkite.rb' + - 'app/models/integrations/discord.rb' + - 'app/models/integrations/ewm.rb' + - 'app/models/integrations/hangouts_chat.rb' + - 'app/models/integrations/jira.rb' + - 'app/models/integrations/microsoft_teams.rb' + - 'app/models/integrations/mock_ci.rb' + - 'app/models/integrations/mock_monitoring.rb' + - 'app/models/integrations/prometheus.rb' + - 'app/models/integrations/pumble.rb' + - 'app/models/integrations/teamcity.rb' + - 'app/models/integrations/unify_circuit.rb' + - 'app/models/integrations/webex_teams.rb' + - 'app/models/internal_id.rb' + - 'app/models/issue.rb' + - 'app/models/label.rb' + - 'app/models/label_note.rb' + - 'app/models/merge_request.rb' + - 'app/models/milestone_note.rb' + - 'app/models/notification_setting.rb' + - 'app/models/project.rb' + - 'app/models/project_wiki.rb' + - 'app/models/protected_branch.rb' + - 'app/models/snippet.rb' + - 'app/models/state_note.rb' + - 'app/models/storage/hashed.rb' + - 'app/models/uploads/base.rb' + - 'app/models/user.rb' + - 'app/models/wiki.rb' + - 'app/policies/group_policy.rb' + - 'app/presenters/clusterable_presenter.rb' + - 'app/presenters/project_presenter.rb' + - 'app/serializers/feature_flags_client_serializer.rb' + - 'app/serializers/group_child_serializer.rb' + - 'app/serializers/group_link/group_group_link_entity.rb' + - 'app/serializers/group_link/project_group_link_entity.rb' + - 'app/services/applications/create_service.rb' + - 'app/services/auth/dependency_proxy_authentication_service.rb' + - 'app/services/auto_merge/base_service.rb' + - 'app/services/award_emojis/add_service.rb' + - 'app/services/boards/base_item_move_service.rb' + - 'app/services/boards/lists/base_create_service.rb' + - 'app/services/boards/lists/list_service.rb' + - 'app/services/boards/lists/update_service.rb' + - 'app/services/ci/copy_cross_database_associations_service.rb' + - 'app/services/ci/job_artifacts/destroy_batch_service.rb' + - 'app/services/ci/pipelines/add_job_service.rb' + - 'app/services/ci/queue/pending_builds_strategy.rb' + - 'app/services/ci/register_job_service.rb' + - 'app/services/ci/update_build_state_service.rb' + - 'app/services/concerns/exclusive_lease_guard.rb' + - 'app/services/deploy_keys/create_service.rb' + - 'app/services/design_management/copy_design_collection/copy_service.rb' + - 'app/services/groups/transfer_service.rb' + - 'app/services/groups/update_service.rb' + - 'app/services/import/gitlab_projects/file_acquisition_strategies/file_upload.rb' + - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' + - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3.rb' + - 'app/services/issuable/destroy_service.rb' + - 'app/services/issues/export_csv_service.rb' + - 'app/services/issues/move_service.rb' + - 'app/services/jira/requests/base.rb' + - 'app/services/keys/destroy_service.rb' + - 'app/services/merge_requests/close_service.rb' + - 'app/services/merge_requests/ff_merge_service.rb' + - 'app/services/merge_requests/merge_base_service.rb' + - 'app/services/metrics/dashboard/grafana_metric_embed_service.rb' + - 'app/services/notification_service.rb' + - 'app/services/packages/nuget/metadata_extraction_service.rb' + - 'app/services/projects/base_move_relations_service.rb' + - 'app/services/projects/hashed_storage/base_attachment_service.rb' + - 'app/services/projects/lfs_pointers/lfs_download_service.rb' + - 'app/services/projects/open_issues_count_service.rb' + - 'app/services/prometheus/proxy_service.rb' + - 'app/services/protected_refs/access_level_params.rb' + - 'app/services/repositories/base_service.rb' + - 'app/services/system_notes/incidents_service.rb' + - 'app/services/web_hooks/admin_destroy_service.rb' + - 'app/services/work_items/update_service.rb' + - 'app/uploaders/file_uploader.rb' + - 'app/uploaders/gitlab_uploader.rb' + - 'app/uploaders/records_uploads.rb' + - 'app/validators/cron_freeze_period_timezone_validator.rb' + - 'app/validators/cron_timezone_validator.rb' + - 'app/validators/cron_validator.rb' + - 'app/validators/gitlab/zoom_url_validator.rb' + - 'app/validators/iso8601_date_validator.rb' + - 'app/workers/ci/delete_objects_worker.rb' + - 'app/workers/concerns/worker_attributes.rb' + - 'app/workers/concerns/worker_context.rb' + - 'app/workers/database/batched_background_migration/execution_worker.rb' + - 'app/workers/detect_repository_languages_worker.rb' + - 'app/workers/environments/auto_stop_worker.rb' + - 'app/workers/gitlab/jira_import/import_issue_worker.rb' + - 'app/workers/issues/rebalancing_worker.rb' + - 'app/workers/personal_access_tokens/expired_notification_worker.rb' + - 'app/workers/personal_access_tokens/expiring_worker.rb' + - 'app/workers/process_commit_worker.rb' + - 'app/workers/projects/inactive_projects_deletion_cron_worker.rb' + - 'app/workers/projects/refresh_build_artifacts_size_statistics_worker.rb' + - 'config/initializers/00_active_record_disable_joins.rb' + - 'config/initializers/active_record_preloader.rb' + - 'config/initializers/active_record_table_definition.rb' + - 'config/initializers/forbid_sidekiq_in_transactions.rb' + - 'config/initializers/rspec_profiling.rb' + - 'config/object_store_settings.rb' + - 'ee/app/controllers/ee/projects/protected_branches_controller.rb' + - 'ee/app/controllers/groups/omniauth_callbacks_controller.rb' + - 'ee/app/controllers/groups/roadmap_controller.rb' + - 'ee/app/graphql/mutations/dast/profiles/run.rb' + - 'ee/app/graphql/mutations/dast/profiles/update.rb' + - 'ee/app/graphql/mutations/dast_scanner_profiles/delete.rb' + - 'ee/app/graphql/mutations/dast_scanner_profiles/update.rb' + - 'ee/app/graphql/mutations/dast_site_profiles/delete.rb' + - 'ee/app/graphql/mutations/dast_site_profiles/update.rb' + - 'ee/app/graphql/mutations/incident_management/escalation_policy/create.rb' + - 'ee/app/graphql/mutations/instance_security_dashboard/remove_project.rb' + - 'ee/app/graphql/mutations/iterations/create.rb' + - 'ee/app/graphql/mutations/security/finding/revert_to_detected.rb' + - 'ee/app/graphql/resolvers/boards/board_list_epics_resolver.rb' + - 'ee/app/graphql/resolvers/ci/code_coverage_summary_resolver.rb' + - 'ee/app/graphql/resolvers/epics/default_project_for_issue_creation_resolver.rb' + - 'ee/app/graphql/resolvers/epics_resolver.rb' + - 'ee/app/graphql/resolvers/incident_management/oncall_shifts_resolver.rb' + - 'ee/app/graphql/resolvers/instance_security_dashboard_resolver.rb' + - 'ee/app/graphql/resolvers/path_locks_resolver.rb' + - 'ee/app/graphql/resolvers/timebox_report_resolver.rb' + - 'ee/app/graphql/resolvers/vulnerabilities/container_images_resolver.rb' + - 'ee/app/graphql/resolvers/vulnerabilities/scanners_resolver.rb' + - 'ee/app/graphql/resolvers/vulnerabilities_base_resolver.rb' + - 'ee/app/graphql/types/security_orchestration/security_policy_source_type.rb' + - 'ee/app/graphql/types/vulnerability_detail_type.rb' + - 'ee/app/graphql/types/vulnerability_location_type.rb' + - 'ee/app/helpers/ee/groups_helper.rb' + - 'ee/app/helpers/ee/lock_helper.rb' + - 'ee/app/helpers/trial_status_widget_helper.rb' + - 'ee/app/models/boards/epic_board.rb' + - 'ee/app/models/burndown.rb' + - 'ee/app/models/concerns/elastic/application_versioned_search.rb' + - 'ee/app/models/concerns/geo/blob_replicator_strategy.rb' + - 'ee/app/models/concerns/geo/repository_replicator_strategy.rb' + - 'ee/app/models/concerns/geo/verifiable_replicator.rb' + - 'ee/app/models/concerns/geo/verification_state.rb' + - 'ee/app/models/ee/iteration.rb' + - 'ee/app/models/ee/member.rb' + - 'ee/app/models/ee/project.rb' + - 'ee/app/models/group_wiki.rb' + - 'ee/app/models/iteration_note.rb' + - 'ee/app/replicators/geo/container_repository_replicator.rb' + - 'ee/app/replicators/geo/pipeline_replicator.rb' + - 'ee/app/serializers/analytics/cycle_analytics/value_stream_errors_serializer.rb' + - 'ee/app/services/app_sec/dast/scans/run_service.rb' + - 'ee/app/services/audit_events/runners_token_audit_event_service.rb' + - 'ee/app/services/automation/dispatch_service.rb' + - 'ee/app/services/boards/epic_lists/update_service.rb' + - 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb' + - 'ee/app/services/ee/merge_requests/merge_base_service.rb' + - 'ee/app/services/epics/related_epic_links/create_service.rb' + - 'ee/app/services/epics/transfer_service.rb' + - 'ee/app/services/group_saml/identity/destroy_service.rb' + - 'ee/app/services/projects/update_mirror_service.rb' + - 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb' + - 'ee/app/services/vulnerabilities/finding_dismiss_service.rb' + - 'ee/app/validators/vulnerabilities/cvss_vector_validator.rb' + - 'ee/app/workers/automation/execute_rule_worker.rb' + - 'ee/app/workers/gitlab_subscriptions/refresh_seats_worker.rb' + - 'ee/app/workers/namespaces/free_user_cap/over_limit_notification_worker.rb' + - 'ee/db/fixtures/development/20_burndown.rb' + - 'ee/lib/audit/compliance_framework_changes_auditor.rb' + - 'ee/lib/compliance_management/compliance_report/commit_loader.rb' + - 'ee/lib/ee/api/ci/helpers/runner.rb' + - 'ee/lib/ee/api/entities/project.rb' + - 'ee/lib/ee/backup/repositories.rb' + - 'ee/lib/ee/banzai/reference_parser/iteration_parser.rb' + - 'ee/lib/ee/gitlab/auth/ldap/sync/proxy.rb' + - 'ee/lib/ee/gitlab/geo_git_access.rb' + - 'ee/lib/ee/gitlab/tracking.rb' + - 'ee/lib/elastic/as_json.rb' + - 'ee/lib/elastic/latest/issue_instance_proxy.rb' + - 'ee/lib/elastic/latest/merge_request_instance_proxy.rb' + - 'ee/lib/elastic/latest/milestone_instance_proxy.rb' + - 'ee/lib/elastic/latest/note_class_proxy.rb' + - 'ee/lib/elastic/latest/note_instance_proxy.rb' + - 'ee/lib/elastic/latest/project_instance_proxy.rb' + - 'ee/lib/elastic/latest/repository_instance_proxy.rb' + - 'ee/lib/elastic/latest/snippet_class_proxy.rb' + - 'ee/lib/elastic/latest/snippet_instance_proxy.rb' + - 'ee/lib/elastic/latest/user_instance_proxy.rb' + - 'ee/lib/gitlab/audit/events/preloader.rb' + - 'ee/lib/gitlab/elastic/elasticsearch_enabled_cache.rb' + - 'ee/lib/gitlab/elastic/indexer.rb' + - 'ee/lib/gitlab/elastic/snippet_search_results.rb' + - 'ee/lib/gitlab/geo.rb' + - 'ee/lib/gitlab/geo/log_cursor/events/base_event.rb' + - 'ee/lib/gitlab/geo/replicator.rb' + - 'ee/lib/gitlab/license_scanning/base_scanner.rb' + - 'ee/lib/gitlab/package_metadata/connector/gcp.rb' + - 'ee/lib/gitlab/package_metadata/connector/offline.rb' + - 'ee/lib/gitlab/zoekt/search_results.rb' + - 'ee/lib/tasks/gitlab/elastic.rake' + - 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb' + - 'ee/spec/features/groups/group_roadmap_spec.rb' + - 'ee/spec/graphql/ee/resolvers/namespace_projects_resolver_spec.rb' + - 'ee/spec/helpers/ee/integrations_helper_spec.rb' + - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' + - 'ee/spec/lib/ee/api/helpers/notes_helpers_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition_spec.rb' + - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' + - 'ee/spec/lib/gitlab/patch/geo_database_tasks_spec.rb' + - 'ee/spec/requests/api/project_import_spec.rb' + - 'ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb' + - 'ee/spec/services/geo/repository_verification_primary_service_spec.rb' + - 'ee/spec/support/helpers/ee/geo_helpers.rb' + - 'ee/spec/support/helpers/ee/migrations_helpers.rb' + - 'lib/api/concerns/packages/nuget_endpoints.rb' + - 'lib/api/entities/basic_project_details.rb' + - 'lib/api/entities/entity_helpers.rb' + - 'lib/api/entities/project.rb' + - 'lib/api/groups.rb' + - 'lib/api/helpers.rb' + - 'lib/api/helpers/notes_helpers.rb' + - 'lib/api/merge_requests.rb' + - 'lib/api/projects_relation_builder.rb' + - 'lib/api/search.rb' + - 'lib/atlassian/jira_connect/client.rb' + - 'lib/backup/database.rb' + - 'lib/backup/files.rb' + - 'lib/backup/gitaly_backup.rb' + - 'lib/banzai/filter/playable_link_filter.rb' + - 'lib/banzai/filter/references/abstract_reference_filter.rb' + - 'lib/banzai/filter/references/commit_range_reference_filter.rb' + - 'lib/banzai/filter/references/design_reference_filter.rb' + - 'lib/banzai/filter/references/external_issue_reference_filter.rb' + - 'lib/banzai/filter/references/feature_flag_reference_filter.rb' + - 'lib/banzai/filter/references/label_reference_filter.rb' + - 'lib/banzai/filter/references/milestone_reference_filter.rb' + - 'lib/banzai/filter/references/project_reference_filter.rb' + - 'lib/banzai/filter/references/reference_cache.rb' + - 'lib/banzai/filter/references/user_reference_filter.rb' + - 'lib/banzai/reference_parser/alert_parser.rb' + - 'lib/banzai/reference_parser/base_parser.rb' + - 'lib/banzai/reference_parser/commit_parser.rb' + - 'lib/banzai/reference_parser/commit_range_parser.rb' + - 'lib/banzai/reference_parser/external_issue_parser.rb' + - 'lib/banzai/reference_parser/feature_flag_parser.rb' + - 'lib/banzai/reference_parser/issuable_parser.rb' + - 'lib/banzai/reference_parser/label_parser.rb' + - 'lib/banzai/reference_parser/mentioned_user_parser.rb' + - 'lib/banzai/reference_parser/milestone_parser.rb' + - 'lib/banzai/reference_parser/project_parser.rb' + - 'lib/banzai/reference_parser/user_parser.rb' + - 'lib/bitbucket_server/client.rb' + - 'lib/bulk_imports/clients/graphql.rb' + - 'lib/bulk_imports/projects/pipelines/snippets_repository_pipeline.rb' + - 'lib/declarative_enum.rb' + - 'lib/error_tracking/sentry_client.rb' + - 'lib/gitlab/analytics/cycle_analytics/stage_events/stage_event.rb' + - 'lib/gitlab/api_authentication/token_resolver.rb' + - 'lib/gitlab/app_text_logger.rb' + - 'lib/gitlab/asciidoc/syntax_highlighter/html_pipeline_adapter.rb' + - 'lib/gitlab/auth/database/authentication.rb' + - 'lib/gitlab/auth/ldap/access.rb' + - 'lib/gitlab/auth/ldap/adapter.rb' + - 'lib/gitlab/background_migration/backfill_ci_queuing_tables.rb' + - 'lib/gitlab/background_migration/backfill_project_settings.rb' + - 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb' + - 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb' + - 'lib/gitlab/background_migration/cleanup_orphaned_routes.rb' + - 'lib/gitlab/background_migration/job_coordinator.rb' + - 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb' + - 'lib/gitlab/background_migration/project_namespaces/backfill_project_namespaces.rb' + - 'lib/gitlab/bitbucket_import/importer.rb' + - 'lib/gitlab/cache/helpers.rb' + - 'lib/gitlab/cache/metrics.rb' + - 'lib/gitlab/ci/ansi2html.rb' + - 'lib/gitlab/ci/build/artifacts/adapters/gzip_stream.rb' + - 'lib/gitlab/ci/build/artifacts/metadata.rb' + - 'lib/gitlab/ci/build/policy/changes.rb' + - 'lib/gitlab/ci/build/policy/kubernetes.rb' + - 'lib/gitlab/ci/build/policy/refs.rb' + - 'lib/gitlab/ci/build/policy/variables.rb' + - 'lib/gitlab/ci/config/entry/hidden.rb' + - 'lib/gitlab/ci/config/entry/inherit/default.rb' + - 'lib/gitlab/ci/parsers/test/junit.rb' + - 'lib/gitlab/ci/pipeline/expression/lexeme/null.rb' + - 'lib/gitlab/ci/pipeline/expression/lexeme/pattern.rb' + - 'lib/gitlab/ci/pipeline/expression/lexeme/string.rb' + - 'lib/gitlab/ci/status/bridge/play.rb' + - 'lib/gitlab/ci/status/build/action.rb' + - 'lib/gitlab/ci/status/build/cancelable.rb' + - 'lib/gitlab/ci/status/build/canceled.rb' + - 'lib/gitlab/ci/status/build/created.rb' + - 'lib/gitlab/ci/status/build/erased.rb' + - 'lib/gitlab/ci/status/build/failed.rb' + - 'lib/gitlab/ci/status/build/failed_allowed.rb' + - 'lib/gitlab/ci/status/build/manual.rb' + - 'lib/gitlab/ci/status/build/pending.rb' + - 'lib/gitlab/ci/status/build/play.rb' + - 'lib/gitlab/ci/status/build/retried.rb' + - 'lib/gitlab/ci/status/build/retryable.rb' + - 'lib/gitlab/ci/status/build/scheduled.rb' + - 'lib/gitlab/ci/status/build/skipped.rb' + - 'lib/gitlab/ci/status/build/stop.rb' + - 'lib/gitlab/ci/status/build/unschedule.rb' + - 'lib/gitlab/ci/status/build/waiting_for_approval.rb' + - 'lib/gitlab/ci/status/pipeline/blocked.rb' + - 'lib/gitlab/ci/status/pipeline/delayed.rb' + - 'lib/gitlab/ci/status/stage/play_manual.rb' + - 'lib/gitlab/ci/status/success_warning.rb' + - 'lib/gitlab/ci/trace.rb' + - 'lib/gitlab/cleanup/orphan_job_artifact_files.rb' + - 'lib/gitlab/cleanup/orphan_job_artifact_files_batch.rb' + - 'lib/gitlab/cleanup/project_upload_file_finder.rb' + - 'lib/gitlab/cluster/puma_worker_killer_observer.rb' + - 'lib/gitlab/config/entry/composable_hash.rb' + - 'lib/gitlab/config/entry/node.rb' + - 'lib/gitlab/config/entry/validators.rb' + - 'lib/gitlab/conflict/file_collection.rb' + - 'lib/gitlab/data_builder/note.rb' + - 'lib/gitlab/database.rb' + - 'lib/gitlab/database/async_indexes/migration_helpers.rb' + - 'lib/gitlab/database/batch_count.rb' + - 'lib/gitlab/database/date_time.rb' + - 'lib/gitlab/database/each_database.rb' + - 'lib/gitlab/database/load_balancing/connection_proxy.rb' + - 'lib/gitlab/database/load_balancing/primary_host.rb' + - 'lib/gitlab/database/load_balancing/session.rb' + - 'lib/gitlab/database/lock_writes_manager.rb' + - 'lib/gitlab/database/migrations/instrumentation.rb' + - 'lib/gitlab/database/migrations/lock_retries_helpers.rb' + - 'lib/gitlab/database/migrations/reestablished_connection_stack.rb' + - 'lib/gitlab/database/migrations/runner.rb' + - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' + - 'lib/gitlab/database/query_analyzers/base.rb' + - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' + - 'lib/gitlab/database/rename_table_helpers.rb' + - 'lib/gitlab/database_importers/common_metrics/importer.rb' + - 'lib/gitlab/dependency_linker/base_linker.rb' + - 'lib/gitlab/diff/file_collection/merge_request_diff_base.rb' + - 'lib/gitlab/diff/line.rb' + - 'lib/gitlab/encoding_helper.rb' + - 'lib/gitlab/error_tracking/error_repository/active_record_strategy.rb' + - 'lib/gitlab/fogbugz_import/importer.rb' + - 'lib/gitlab/git/commit_stats.rb' + - 'lib/gitlab/git/conflict/parser.rb' + - 'lib/gitlab/git/cross_repo.rb' + - 'lib/gitlab/git/ref.rb' + - 'lib/gitlab/gitaly_client.rb' + - 'lib/gitlab/gitaly_client/commit_service.rb' + - 'lib/gitlab/gitaly_client/operation_service.rb' + - 'lib/gitlab/github_gists_import/representation/gist.rb' + - 'lib/gitlab/github_import/importer/pull_requests/review_requests_importer.rb' + - 'lib/gitlab/github_import/importer/pull_requests_reviews_importer.rb' + - 'lib/gitlab/github_import/representation/diff_note.rb' + - 'lib/gitlab/github_import/representation/issue_event.rb' + - 'lib/gitlab/github_import/representation/lfs_object.rb' + - 'lib/gitlab/github_import/representation/note.rb' + - 'lib/gitlab/github_import/representation/pull_request.rb' + - 'lib/gitlab/github_import/representation/pull_request_review.rb' + - 'lib/gitlab/github_import/representation/user.rb' + - 'lib/gitlab/graphql/authorize/connection_filter_extension.rb' + - 'lib/gitlab/graphql/board/issues_connection_extension.rb' + - 'lib/gitlab/graphql/calls_gitaly/field_extension.rb' + - 'lib/gitlab/graphql/connection_redaction.rb' + - 'lib/gitlab/graphql/extensions/externally_paginated_array_extension.rb' + - 'lib/gitlab/graphql/generic_tracing.rb' + - 'lib/gitlab/graphql/lazy.rb' + - 'lib/gitlab/graphql/project/dast_profile_connection_extension.rb' + - 'lib/gitlab/graphql/query_analyzers/ast/logger_analyzer.rb' + - 'lib/gitlab/graphql/tracers/timer_tracer.rb' + - 'lib/gitlab/hashed_storage/rake_helper.rb' + - 'lib/gitlab/hook_data/subgroup_builder.rb' + - 'lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb' + - 'lib/gitlab/import_export/fast_hash_serializer.rb' + - 'lib/gitlab/issuable_sorter.rb' + - 'lib/gitlab/json.rb' + - 'lib/gitlab/json_cache.rb' + - 'lib/gitlab/lfs/client.rb' + - 'lib/gitlab/markdown_cache/redis/extension.rb' + - 'lib/gitlab/memory/diagnostic_reports_logger.rb' + - 'lib/gitlab/metrics/null_metric.rb' + - 'lib/gitlab/metrics/subscribers/action_cable.rb' + - 'lib/gitlab/metrics/subscribers/rails_cache.rb' + - 'lib/gitlab/null_request_store.rb' + - 'lib/gitlab/optimistic_locking.rb' + - 'lib/gitlab/otp_key_rotator.rb' + - 'lib/gitlab/project_search_results.rb' + - 'lib/gitlab/prometheus/queries/query_additional_metrics.rb' + - 'lib/gitlab/quick_actions/issue_and_merge_request_actions.rb' + - 'lib/gitlab/redis/multi_store.rb' + - 'lib/gitlab/repository_cache.rb' + - 'lib/gitlab/repository_cache_adapter.rb' + - 'lib/gitlab/repository_hash_cache.rb' + - 'lib/gitlab/repository_set_cache.rb' + - 'lib/gitlab/safe_request_loader.rb' + - 'lib/gitlab/safe_request_store.rb' + - 'lib/gitlab/sanitizers/exif.rb' + - 'lib/gitlab/search_results.rb' + - 'lib/gitlab/setup_helper.rb' + - 'lib/gitlab/sidekiq_logging/json_formatter.rb' + - 'lib/gitlab/sidekiq_logging/structured_logger.rb' + - 'lib/gitlab/sidekiq_middleware/arguments_logger.rb' + - 'lib/gitlab/sidekiq_middleware/batch_loader.rb' + - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/client.rb' + - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' + - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/server.rb' + - 'lib/gitlab/sidekiq_middleware/extra_done_log_metadata.rb' + - 'lib/gitlab/sidekiq_middleware/instrumentation_logger.rb' + - 'lib/gitlab/sidekiq_middleware/query_analyzer.rb' + - 'lib/gitlab/sidekiq_middleware/request_store_middleware.rb' + - 'lib/gitlab/sidekiq_middleware/size_limiter/client.rb' + - 'lib/gitlab/sidekiq_middleware/size_limiter/server.rb' + - 'lib/gitlab/sidekiq_status/server_middleware.rb' + - 'lib/gitlab/sidekiq_versioning/middleware.rb' + - 'lib/gitlab/slash_commands/incident_management/incident_command.rb' + - 'lib/gitlab/slash_commands/presenters/issue_new.rb' + - 'lib/gitlab/snippet_search_results.rb' + - 'lib/gitlab/string_placeholder_replacer.rb' + - 'lib/gitlab/template/dockerfile_template.rb' + - 'lib/gitlab/template/gitignore_template.rb' + - 'lib/gitlab/template/gitlab_ci_yml_template.rb' + - 'lib/gitlab/template/issue_template.rb' + - 'lib/gitlab/template/merge_request_template.rb' + - 'lib/gitlab/template/metrics_dashboard_template.rb' + - 'lib/gitlab/template_parser/ast.rb' + - 'lib/gitlab/testing/request_blocker_middleware.rb' + - 'lib/gitlab/testing/robots_blocker_middleware.rb' + - 'lib/gitlab/tracking.rb' + - 'lib/gitlab/untrusted_regexp/ruby_syntax.rb' + - 'lib/gitlab/usage/metrics/aggregates/sources/redis_hll.rb' + - 'lib/gitlab/usage/metrics/names_suggestions/generator.rb' + - 'lib/gitlab/usage_data.rb' + - 'lib/gitlab/usage_data_non_sql_metrics.rb' + - 'lib/gitlab/usage_data_queries.rb' + - 'lib/gitlab/user_access_snippet.rb' + - 'lib/gitlab/utils/safe_inline_hash.rb' + - 'lib/gitlab/utils/usage_data.rb' + - 'lib/gitlab/verify/batch_verifier.rb' + - 'lib/gitlab/view/presenter/base.rb' + - 'lib/gitlab/web_ide/config.rb' + - 'lib/gitlab/work_items/work_item_hierarchy.rb' + - 'lib/kramdown/parser/atlassian_document_format.rb' + - 'lib/tasks/gems.rake' + - 'lib/tasks/gettext.rake' + - 'lib/tasks/gitlab/graphql.rake' + - 'metrics_server/metrics_server.rb' + - 'qa/qa/page/project/settings/ci_variables.rb' + - 'qa/qa/page/project/settings/monitor.rb' + - 'qa/qa/resource/base.rb' + - 'qa/qa/resource/design.rb' + - 'qa/qa/scenario/template.rb' + - 'qa/qa/service/kubernetes_cluster.rb' + - 'qa/qa/specs/features/browser_ui/3_create/repository/protected_tags_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb' + - 'qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb' + - 'qa/qa/support/wait_for_requests.rb' + - 'qa/spec/resource/base_spec.rb' + - 'rubocop/cop/gitlab/finder_with_find_by.rb' + - 'rubocop/cop/migration/safer_boolean_column.rb' + - 'scripts/rubocop-parse' + - 'scripts/static-analysis' + - 'spec/components/pajamas/concerns/checkbox_radio_label_with_help_text_spec.rb' + - 'spec/components/pajamas/concerns/checkbox_radio_options_spec.rb' + - 'spec/controllers/concerns/issuable_actions_spec.rb' + - 'spec/controllers/groups/registry/repositories_controller_spec.rb' + - 'spec/controllers/projects/error_tracking/projects_controller_spec.rb' + - 'spec/features/profiles/user_edit_profile_spec.rb' + - 'spec/features/projects/commits/user_browses_commits_spec.rb' + - 'spec/graphql/resolvers/base_resolver_spec.rb' + - 'spec/graphql/resolvers/concerns/looks_ahead_spec.rb' + - 'spec/graphql/types/base_field_spec.rb' + - 'spec/graphql/types/base_object_spec.rb' + - 'spec/helpers/markup_helper_spec.rb' + - 'spec/initializers/rack_multipart_patch_spec.rb' + - 'spec/lib/banzai/object_renderer_spec.rb' + - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' + - 'spec/lib/gitlab/auth_spec.rb' + - 'spec/lib/gitlab/background_migration/batched_migration_job_spec.rb' + - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' + - 'spec/lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings_spec.rb' + - 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' + - 'spec/lib/gitlab/background_migration/set_correct_vulnerability_state_spec.rb' + - 'spec/lib/gitlab/background_migration/truncate_overlong_vulnerability_html_titles_spec.rb' + - 'spec/lib/gitlab/cache/request_cache_spec.rb' + - 'spec/lib/gitlab/middleware/same_site_cookies_spec.rb' + - 'spec/lib/gitlab/otp_key_rotator_spec.rb' + - 'spec/lib/gitlab/path_regex_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/server_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/worker_context/server_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware_spec.rb' + - 'spec/lib/gitlab/url_blocker_spec.rb' + - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' + - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' + - 'spec/migrations/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4_spec.rb' + - 'spec/models/concerns/from_set_operator_spec.rb' + - 'spec/models/concerns/redis_cacheable_spec.rb' + - 'spec/policies/resource_state_event_policy_spec.rb' + - 'spec/requests/api/graphql/boards/board_list_issues_query_spec.rb' + - 'spec/requests/api/graphql/gitlab_schema_spec.rb' + - 'spec/requests/api/graphql/project/milestones_spec.rb' + - 'spec/requests/api/helpers_spec.rb' + - 'spec/requests/api/personal_access_tokens_spec.rb' + - 'spec/requests/import/gitlab_projects_controller_spec.rb' + - 'spec/services/concerns/rate_limited_service_spec.rb' + - 'spec/services/git/wiki_push_service_spec.rb' + - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_spec.rb' + - 'spec/services/lfs/push_service_spec.rb' + - 'spec/services/projects/transfer_service_spec.rb' + - 'spec/support/database/prevent_cross_joins.rb' + - 'spec/support/graphql/subscriptions/action_cable/mock_action_cable.rb' + - 'spec/support/helpers/cycle_analytics_helpers.rb' + - 'spec/support/helpers/database/multiple_databases_helpers.rb' + - 'spec/support/helpers/database/table_schema_helpers.rb' + - 'spec/support/helpers/design_management_test_helpers.rb' + - 'spec/support/helpers/devise_helpers.rb' + - 'spec/support/helpers/feature_flag_helpers.rb' + - 'spec/support/helpers/gitaly_setup.rb' + - 'spec/support/helpers/graphql_helpers.rb' + - 'spec/support/helpers/migrations_helpers.rb' + - 'spec/support/helpers/notification_helpers.rb' + - 'spec/support/helpers/query_recorder.rb' + - 'spec/support/helpers/rack_attack_spec_helpers.rb' + - 'spec/support/helpers/redis_commands/recorder.rb' + - 'spec/support/helpers/redis_without_keys.rb' + - 'spec/support/helpers/repo_helpers.rb' + - 'spec/support/helpers/stub_feature_flags.rb' + - 'spec/support/helpers/stub_member.rb' + - 'spec/support/helpers/test_env.rb' + - 'spec/support/import_export/project_tree_expectations.rb' + - 'spec/support/shared_contexts/mailers/emails/service_desk_shared_context.rb' + - 'spec/support/shared_examples/features/master_manages_access_requests_shared_example.rb' + - 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb' + - 'spec/support/sidekiq_middleware.rb' + - 'spec/support_specs/capybara_slow_finder_spec.rb' + - 'spec/tooling/graphql/docs/renderer_spec.rb' + - 'spec/workers/concerns/cronjob_queue_spec.rb' + - 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb' + - 'tooling/lib/tooling/mappings/base.rb' |