diff options
Diffstat (limited to '.rubocop_todo/lint')
| -rw-r--r-- | .rubocop_todo/lint/ambiguous_range.yml | 1 | ||||
| -rw-r--r-- | .rubocop_todo/lint/empty_block.yml | 2 | ||||
| -rw-r--r-- | .rubocop_todo/lint/unused_block_argument.yml | 3 | ||||
| -rw-r--r-- | .rubocop_todo/lint/unused_method_argument.yml | 10 |
4 files changed, 15 insertions, 1 deletions
diff --git a/.rubocop_todo/lint/ambiguous_range.yml b/.rubocop_todo/lint/ambiguous_range.yml index 71fa2441680..3d6f49a4846 100644 --- a/.rubocop_todo/lint/ambiguous_range.yml +++ b/.rubocop_todo/lint/ambiguous_range.yml @@ -4,6 +4,7 @@ Lint/AmbiguousRange: Details: grace period Exclude: - 'app/models/ci/runner.rb' + - 'app/models/ci/runner_machine.rb' - 'app/services/clusters/agent_tokens/track_usage_service.rb' - 'lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb' - 'spec/lib/gitlab/database/reindexing/reindex_concurrently_spec.rb' diff --git a/.rubocop_todo/lint/empty_block.yml b/.rubocop_todo/lint/empty_block.yml index dc2d9bf521e..66210d071a1 100644 --- a/.rubocop_todo/lint/empty_block.yml +++ b/.rubocop_todo/lint/empty_block.yml @@ -171,9 +171,11 @@ Lint/EmptyBlock: - 'spec/presenters/ci/pipeline_presenter_spec.rb' - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' + - 'spec/requests/api/ci/runner/runners_verify_post_spec.rb' - 'spec/requests/api/ci/triggers_spec.rb' - 'spec/requests/api/graphql/boards/board_list_issues_query_spec.rb' - 'spec/requests/api/graphql/boards/board_lists_query_spec.rb' + - 'spec/requests/api/graphql/ci/runner_spec.rb' - 'spec/requests/api/graphql/mutations/achievements/create_spec.rb' - 'spec/requests/api/group_variables_spec.rb' - 'spec/requests/api/groups_spec.rb' diff --git a/.rubocop_todo/lint/unused_block_argument.yml b/.rubocop_todo/lint/unused_block_argument.yml index b6d3c3c7cdf..445b8924552 100644 --- a/.rubocop_todo/lint/unused_block_argument.yml +++ b/.rubocop_todo/lint/unused_block_argument.yml @@ -8,6 +8,7 @@ Lint/UnusedBlockArgument: - 'app/controllers/concerns/renders_notes.rb' - 'app/controllers/import/fogbugz_controller.rb' - 'app/controllers/oauth/applications_controller.rb' + - 'app/controllers/profiles/two_factor_auths_controller.rb' - 'app/controllers/projects/commit_controller.rb' - 'app/finders/releases/group_releases_finder.rb' - 'app/graphql/batch_loaders/award_emoji_votes_batch_loader.rb' @@ -25,6 +26,7 @@ Lint/UnusedBlockArgument: - 'app/helpers/issues_helper.rb' - 'app/models/abuse_report.rb' - 'app/models/alert_management/alert.rb' + - 'app/models/appearance.rb' - 'app/models/ci/build.rb' - 'app/models/ci/instance_variable.rb' - 'app/models/ci/pipeline.rb' @@ -414,6 +416,7 @@ Lint/UnusedBlockArgument: - 'spec/support/matchers/pagination_matcher.rb' - 'spec/support/matchers/schema_matcher.rb' - 'spec/support/matchers/security_header_matcher.rb' + - 'spec/support/redis.rb' - 'spec/support/shared_contexts/jobs/handling_retried_jobs_shared_context.rb' - 'spec/support/shared_contexts/lib/gitlab/middleware/multipart_shared_contexts.rb' - 'spec/support/shared_contexts/services/service_ping/stubbed_service_ping_metrics_definitions_shared_context.rb' diff --git a/.rubocop_todo/lint/unused_method_argument.yml b/.rubocop_todo/lint/unused_method_argument.yml index 8fcad186276..dd97ca9a877 100644 --- a/.rubocop_todo/lint/unused_method_argument.yml +++ b/.rubocop_todo/lint/unused_method_argument.yml @@ -48,6 +48,7 @@ Lint/UnusedMethodArgument: - 'app/graphql/resolvers/work_items/work_item_discussions_resolver.rb' - 'app/graphql/subscriptions/issuable_updated.rb' - 'app/graphql/subscriptions/notes/base.rb' + - 'app/graphql/subscriptions/notes/created.rb' - 'app/graphql/subscriptions/notes/deleted.rb' - 'app/graphql/types/alert_management/integration_type.rb' - 'app/graphql/types/base_field.rb' @@ -274,15 +275,21 @@ Lint/UnusedMethodArgument: - 'ee/app/serializers/analytics/cycle_analytics/value_stream_errors_serializer.rb' - 'ee/app/services/app_sec/dast/scans/run_service.rb' - 'ee/app/services/audit_events/runners_token_audit_event_service.rb' + - 'ee/app/services/automation/dispatch_service.rb' - 'ee/app/services/boards/epic_lists/update_service.rb' - 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb' - 'ee/app/services/ee/merge_requests/merge_base_service.rb' - 'ee/app/services/epics/related_epic_links/create_service.rb' - 'ee/app/services/epics/transfer_service.rb' - 'ee/app/services/group_saml/identity/destroy_service.rb' + - 'ee/app/services/package_metadata/ingestion/ingestion_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' + - 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb' - 'ee/app/services/vulnerabilities/finding_dismiss_service.rb' - 'ee/app/validators/vulnerabilities/cvss_vector_validator.rb' + - 'ee/app/workers/automation/execute_rule_worker.rb' + - 'ee/app/workers/gitlab_subscriptions/refresh_seats_worker.rb' + - 'ee/app/workers/namespaces/free_user_cap/over_limit_notification_worker.rb' - 'ee/db/fixtures/development/20_burndown.rb' - 'ee/lib/audit/compliance_framework_changes_auditor.rb' - 'ee/lib/compliance_management/compliance_report/commit_loader.rb' @@ -313,6 +320,7 @@ Lint/UnusedMethodArgument: - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/license_scanning/base_scanner.rb' - 'ee/lib/gitlab/package_metadata/connector/gcp.rb' + - 'ee/lib/gitlab/package_metadata/connector/offline.rb' - 'ee/lib/gitlab/zoekt/search_results.rb' - 'ee/lib/tasks/gitlab/elastic.rake' - 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb' @@ -607,7 +615,6 @@ Lint/UnusedMethodArgument: - 'spec/lib/gitlab/sidekiq_middleware/worker_context/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware_spec.rb' - 'spec/lib/gitlab/url_blocker_spec.rb' - - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - 'spec/migrations/20211116111644_schedule_remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb' - 'spec/migrations/20211207135331_schedule_recalculate_uuid_on_vulnerabilities_occurrences4_spec.rb' @@ -646,6 +653,7 @@ Lint/UnusedMethodArgument: - 'spec/support/helpers/stub_member.rb' - 'spec/support/helpers/test_env.rb' - 'spec/support/import_export/project_tree_expectations.rb' + - 'spec/support/shared_contexts/mailers/emails/service_desk_shared_context.rb' - 'spec/support/shared_examples/features/master_manages_access_requests_shared_example.rb' - 'spec/support/shared_examples/requests/rack_attack_shared_examples.rb' - 'spec/support/sidekiq_middleware.rb' |