diff options
Diffstat (limited to '.rubocop_todo/performance')
5 files changed, 223 insertions, 0 deletions
diff --git a/.rubocop_todo/performance/concurrent_monotonic_time.yml b/.rubocop_todo/performance/concurrent_monotonic_time.yml new file mode 100644 index 00000000000..0e55eaf4a18 --- /dev/null +++ b/.rubocop_todo/performance/concurrent_monotonic_time.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --autocorrect. +Performance/ConcurrentMonotonicTime: + Details: grace period + Exclude: + - 'lib/gitlab/database/connection_timer.rb' diff --git a/.rubocop_todo/performance/flat_map.yml b/.rubocop_todo/performance/flat_map.yml new file mode 100644 index 00000000000..32dce1bf317 --- /dev/null +++ b/.rubocop_todo/performance/flat_map.yml @@ -0,0 +1,38 @@ +--- +# Cop supports --autocorrect. +Performance/FlatMap: + Details: grace period + Exclude: + - 'app/presenters/packages/nuget/service_index_presenter.rb' + - 'app/services/projects/apple_target_platform_detector_service.rb' + - 'ee/app/models/burndown.rb' + - 'ee/app/models/geo_node_status.rb' + - 'ee/app/serializers/dashboard_environments_serializer.rb' + - 'ee/app/services/elastic/process_bookkeeping_service.rb' + - 'ee/lib/elastic/latest/issue_class_proxy.rb' + - 'ee/spec/lib/elastic/latest/user_class_proxy_spec.rb' + - 'ee/spec/models/analytics/issues_analytics_spec.rb' + - 'ee/spec/requests/api/members_spec.rb' + - 'ee/spec/support/helpers/license_scanning_report_helpers.rb' + - 'ee/spec/support/shared_examples/finders/security/findings_finder_shared_examples.rb' + - 'lib/gitlab/ci/pipeline/chain/create_deployments.rb' + - 'lib/gitlab/ci/pipeline/chain/ensure_environments.rb' + - 'lib/gitlab/ci/pipeline/chain/ensure_resource_groups.rb' + - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' + - 'lib/gitlab/diff/file_collection/base.rb' + - 'lib/gitlab/instrumentation/redis_cluster_validator.rb' + - 'lib/gitlab/testing/request_inspector_middleware.rb' + - 'lib/gitlab/usage_data_counters/hll_redis_counter.rb' + - 'qa/qa/resource/base.rb' + - 'qa/qa/tools/ci/non_empty_suites.rb' + - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/lib/bulk_imports/groups/stage_spec.rb' + - 'spec/lib/bulk_imports/projects/stage_spec.rb' + - 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' + - 'spec/requests/api/graphql/ci/pipelines_spec.rb' + - 'spec/requests/api/projects_spec.rb' + - 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb' + - 'spec/services/git/process_ref_changes_service_spec.rb' + - 'spec/support/shared_examples/models/with_debian_distributions_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/graphql/issue_list_shared_examples.rb' diff --git a/.rubocop_todo/performance/map_compact.yml b/.rubocop_todo/performance/map_compact.yml new file mode 100644 index 00000000000..57ebe251798 --- /dev/null +++ b/.rubocop_todo/performance/map_compact.yml @@ -0,0 +1,148 @@ +--- +# Cop supports --autocorrect. +Performance/MapCompact: + Details: grace period + Exclude: + - 'app/graphql/resolvers/concerns/resolves_ids.rb' + - 'app/graphql/resolvers/todos_resolver.rb' + - 'app/helpers/issuables_description_templates_helper.rb' + - 'app/helpers/notifications_helper.rb' + - 'app/models/ci/build_dependencies.rb' + - 'app/models/ci/pipeline.rb' + - 'app/models/ci/runner.rb' + - 'app/models/ci_platform_metric.rb' + - 'app/models/concerns/mentionable/reference_regexes.rb' + - 'app/models/concerns/pg_full_text_searchable.rb' + - 'app/models/container_repository.rb' + - 'app/models/design_management/design_at_version.rb' + - 'app/models/design_management/version.rb' + - 'app/models/environment.rb' + - 'app/models/environment_status.rb' + - 'app/models/instance_configuration.rb' + - 'app/models/integrations/chat_message/pipeline_message.rb' + - 'app/models/repository.rb' + - 'app/models/resource_label_event.rb' + - 'app/models/snippet_repository.rb' + - 'app/models/web_ide_terminal.rb' + - 'app/presenters/packages/conan/package_presenter.rb' + - 'app/presenters/packages/nuget/packages_metadata_presenter.rb' + - 'app/presenters/packages/nuget/search_results_presenter.rb' + - 'app/serializers/analytics/cycle_analytics/event_entity.rb' + - 'app/services/auth/container_registry_authentication_service.rb' + - 'app/services/events/render_service.rb' + - 'app/services/feature_flags/update_service.rb' + - 'app/services/git/base_hooks_service.rb' + - 'app/services/google_cloud/fetch_google_ip_list_service.rb' + - 'app/services/jira_import/start_import_service.rb' + - 'app/services/jira_import/users_mapper_service.rb' + - 'app/services/labels/available_labels_service.rb' + - 'app/services/merge_requests/get_urls_service.rb' + - 'app/services/merge_requests/pushed_branches_service.rb' + - 'app/services/merge_requests/update_service.rb' + - 'app/services/packages/maven/find_or_create_package_service.rb' + - 'app/services/projects/container_repository/third_party/delete_tags_service.rb' + - 'app/services/projects/update_statistics_service.rb' + - 'app/services/quick_actions/interpret_service.rb' + - 'app/services/repositories/changelog_service.rb' + - 'app/services/todos/allowed_target_filter_service.rb' + - 'config/initializers/trusted_proxies.rb' + - 'config/initializers/wikicloth_redos_patch.rb' + - 'ee/app/finders/security/findings_finder.rb' + - 'ee/app/graphql/ee/types/issue_connection_type.rb' + - 'ee/app/models/app_sec/fuzzing/api/ci_configuration.rb' + - 'ee/app/models/burndown.rb' + - 'ee/app/models/concerns/ee/project_security_scanners_information.rb' + - 'ee/app/models/concerns/elastic/application_versioned_search.rb' + - 'ee/app/models/gitlab_subscriptions/features.rb' + - 'ee/app/models/sca/license_compliance.rb' + - 'ee/app/services/app_sec/dast/profiles/create_associations_service.rb' + - 'ee/app/services/app_sec/dast/scan_configs/fetch_service.rb' + - 'ee/app/services/epic_issues/create_service.rb' + - 'ee/app/services/members/activate_service.rb' + - 'ee/app/services/security/override_uuids_service.rb' + - 'ee/app/services/security/store_scan_service.rb' + - 'ee/app/services/upcoming_reconciliations/update_service.rb' + - 'ee/app/services/vulnerabilities/findings/find_or_create_from_security_finding_service.rb' + - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' + - 'ee/db/fixtures/development/30_customizable_cycle_analytics.rb' + - 'ee/lib/ee/api/entities/experiment.rb' + - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' + - 'ee/lib/ee/gitlab/auth/ldap/person.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' + - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' + - 'ee/lib/elastic/latest/repository_instance_proxy.rb' + - 'ee/lib/gitlab/alert_management/alert_payload_field_extractor.rb' + - 'ee/lib/gitlab/ci/parsers/security/dast.rb' + - 'ee/lib/gitlab/ci/reports/license_scanning/report.rb' + - 'ee/lib/gitlab/ci/reports/metrics/reports_comparer.rb' + - 'ee/lib/gitlab/search/aggregation_parser.rb' + - 'ee/spec/models/analytics/issues_analytics_spec.rb' + - 'ee/spec/models/member_spec.rb' + - 'ee/spec/requests/api/audit_events_spec.rb' + - 'ee/spec/requests/api/search_spec.rb' + - 'haml_lint/linter/no_plain_nodes.rb' + - 'lib/api/entities/feature.rb' + - 'lib/api/entities/project.rb' + - 'lib/api/helpers/common_helpers.rb' + - 'lib/atlassian/jira_connect/client.rb' + - 'lib/atlassian/jira_connect/serializers/feature_flag_entity.rb' + - 'lib/banzai/filter/image_link_filter.rb' + - 'lib/banzai/filter/references/design_reference_filter.rb' + - 'lib/banzai/filter/references/label_reference_filter.rb' + - 'lib/banzai/filter/references/milestone_reference_filter.rb' + - 'lib/banzai/reference_parser/issuable_parser.rb' + - 'lib/error_tracking/sentry_client/pagination_parser.rb' + - 'lib/gitaly/server.rb' + - 'lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher.rb' + - 'lib/gitlab/analytics/usage_trends/workers_argument_builder.rb' + - 'lib/gitlab/auth/ip_rate_limiter.rb' + - 'lib/gitlab/background_migration/backfill_project_repositories.rb' + - 'lib/gitlab/changes_list.rb' + - 'lib/gitlab/checks/changes_access.rb' + - 'lib/gitlab/ci/parsers/security/common.rb' + - 'lib/gitlab/ci/reports/security/aggregated_report.rb' + - 'lib/gitlab/ci/reports/security/finding.rb' + - 'lib/gitlab/ci/reports/test_suite_summary.rb' + - 'lib/gitlab/config/entry/validators.rb' + - 'lib/gitlab/database/load_balancing/service_discovery.rb' + - 'lib/gitlab/database/obsolete_ignored_columns.rb' + - 'lib/gitlab/email/receiver.rb' + - 'lib/gitlab/git/commit.rb' + - 'lib/gitlab/git/conflict/file.rb' + - 'lib/gitlab/git/rugged_impl/commit.rb' + - 'lib/gitlab/github_import/importer/pull_requests/review_request_importer.rb' + - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb' + - 'lib/gitlab/issues/rebalancing/state.rb' + - 'lib/gitlab/jira_import/metadata_collector.rb' + - 'lib/gitlab/json_cache.rb' + - 'lib/gitlab/language_detection.rb' + - 'lib/gitlab/legacy_github_import/importer.rb' + - 'lib/gitlab/private_commit_email.rb' + - 'lib/gitlab/sql/pattern.rb' + - 'lib/gitlab/url_blocker.rb' + - 'lib/gitlab/verify/batch_verifier.rb' + - 'qa/qa/page/component/issuable/sidebar.rb' + - 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_large_project_spec.rb' + - 'qa/qa/support/formatters/test_metrics_formatter.rb' + - 'qa/qa/tools/ci/ff_changes.rb' + - 'scripts/lint_templates_bash.rb' + - 'spec/controllers/every_controller_spec.rb' + - 'spec/controllers/projects/merge_requests/conflicts_controller_spec.rb' + - 'spec/lib/api/every_api_endpoint_spec.rb' + - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb' + - 'spec/lib/gitlab/conflict/file_spec.rb' + - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' + - 'spec/lib/gitlab/import_export/references_configuration_spec.rb' + - 'spec/models/deployment_spec.rb' + - 'spec/models/network/graph_spec.rb' + - 'spec/models/repository_spec.rb' + - 'spec/requests/api/commits_spec.rb' + - 'spec/requests/api/groups_spec.rb' + - 'spec/requests/lfs_http_spec.rb' + - 'spec/serializers/diff_file_entity_spec.rb' + - 'spec/services/projects/container_repository/third_party/cleanup_tags_service_spec.rb' + - 'spec/support/helpers/dns_helpers.rb' + - 'spec/support/helpers/graphql_helpers.rb' + - 'spec/support/shared_examples/features/navbar_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/config/inheritable_shared_examples.rb' + - 'spec/support/shared_examples/models/label_note_shared_examples.rb' diff --git a/.rubocop_todo/performance/redundant_equality_comparison_block.yml b/.rubocop_todo/performance/redundant_equality_comparison_block.yml new file mode 100644 index 00000000000..44da9710249 --- /dev/null +++ b/.rubocop_todo/performance/redundant_equality_comparison_block.yml @@ -0,0 +1,23 @@ +--- +# Cop supports --autocorrect. +Performance/RedundantEqualityComparisonBlock: + Details: grace period + Exclude: + - 'app/graphql/types/work_item_id_type.rb' + - 'app/models/concerns/group_descendant.rb' + - 'app/models/concerns/id_in_ordered.rb' + - 'app/models/todo.rb' + - 'app/validators/feature_flag_strategies_validator.rb' + - 'ee/app/helpers/ee/dashboard_helper.rb' + - 'ee/lib/compliance_management/merge_request_approval_settings/resolver.rb' + - 'ee/lib/elastic/latest/user_instance_proxy.rb' + - 'ee/lib/gitlab/geo/geo_node_status_check.rb' + - 'ee/spec/lib/ee/sidebars/projects/panel_spec.rb' + - 'lib/gitlab/ci/config/yaml/tags/reference.rb' + - 'lib/gitlab/config/entry/validators.rb' + - 'lib/gitlab/i18n/translation_entry.rb' + - 'lib/gitlab/push_options.rb' + - 'lib/gitlab/utils/delegator_override.rb' + - 'lib/gitlab/view/presenter/base.rb' + - 'spec/lib/object_storage/direct_upload_spec.rb' + - 'spec/support/import_export/project_tree_expectations.rb' diff --git a/.rubocop_todo/performance/redundant_split_regexp_argument.yml b/.rubocop_todo/performance/redundant_split_regexp_argument.yml new file mode 100644 index 00000000000..0c0e12480d5 --- /dev/null +++ b/.rubocop_todo/performance/redundant_split_regexp_argument.yml @@ -0,0 +1,8 @@ +--- +# Cop supports --autocorrect. +Performance/RedundantSplitRegexpArgument: + Details: grace period + Exclude: + - 'lib/file_size_validator.rb' + - 'lib/gitlab/git/raw_diff_change.rb' + - 'lib/kramdown/converter/commonmark.rb' |