diff options
Diffstat (limited to '.rubocop_todo/style/empty_method.yml')
| -rw-r--r-- | .rubocop_todo/style/empty_method.yml | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/.rubocop_todo/style/empty_method.yml b/.rubocop_todo/style/empty_method.yml index 3e6a1efec70..7fbec98ead5 100644 --- a/.rubocop_todo/style/empty_method.yml +++ b/.rubocop_todo/style/empty_method.yml @@ -1,16 +1,12 @@ --- # Cop supports --auto-correct. Style/EmptyMethod: - # Offense count: 240 - # Temporarily disabled due to too many offenses - Enabled: false + Details: grace period Exclude: - 'app/controllers/admin/application_settings/appearances_controller.rb' - 'app/controllers/admin/applications_controller.rb' - 'app/controllers/admin/broadcast_messages_controller.rb' - 'app/controllers/admin/deploy_keys_controller.rb' - - 'app/controllers/admin/hook_logs_controller.rb' - - 'app/controllers/admin/hooks_controller.rb' - 'app/controllers/admin/identities_controller.rb' - 'app/controllers/admin/labels_controller.rb' - 'app/controllers/admin/runners_controller.rb' @@ -35,13 +31,11 @@ Style/EmptyMethod: - 'app/controllers/projects/alert_management_controller.rb' - 'app/controllers/projects/ci/lints_controller.rb' - 'app/controllers/projects/ci/pipeline_editor_controller.rb' - - 'app/controllers/projects/ci/secure_files_controller.rb' - 'app/controllers/projects/confluences_controller.rb' - 'app/controllers/projects/deploy_keys_controller.rb' - 'app/controllers/projects/environments_controller.rb' - 'app/controllers/projects/feature_flags_controller.rb' - 'app/controllers/projects/feature_flags_user_lists_controller.rb' - - 'app/controllers/projects/hook_logs_controller.rb' - 'app/controllers/projects/import/jira_controller.rb' - 'app/controllers/projects/imports_controller.rb' - 'app/controllers/projects/incidents_controller.rb' @@ -55,30 +49,32 @@ Style/EmptyMethod: - 'app/controllers/projects/runners_controller.rb' - 'app/controllers/projects/settings/integrations_controller.rb' - 'app/controllers/projects/settings/packages_and_registries_controller.rb' - - 'app/controllers/projects/tags/releases_controller.rb' - 'app/controllers/projects/terraform_controller.rb' - 'app/controllers/projects/triggers_controller.rb' + - 'app/controllers/pwa_controller.rb' - 'app/controllers/registrations/welcome_controller.rb' - 'app/controllers/search_controller.rb' + - 'app/experiments/security_actions_continuous_onboarding_experiment.rb' - 'app/graphql/resolvers/concerns/caching_array_resolver.rb' - 'app/helpers/subscribable_banner_helper.rb' - 'app/helpers/users/callouts_helper.rb' - 'app/models/ci/bridge.rb' + - 'app/models/ci/job_artifact.rb' - 'app/models/concerns/cross_database_modification.rb' - 'app/models/concerns/reactive_caching.rb' - 'app/models/concerns/relative_positioning.rb' - 'app/models/hooks/web_hook.rb' - 'app/models/integrations/hangouts_chat.rb' - 'app/models/integrations/microsoft_teams.rb' + - 'app/models/integrations/pumble.rb' - 'app/models/integrations/unify_circuit.rb' - 'app/models/integrations/webex_teams.rb' - 'app/models/wiki.rb' - 'app/services/auto_merge/base_service.rb' - 'app/services/award_emojis/destroy_service.rb' + - 'app/services/groups/transfer_service.rb' - 'app/services/issuable_base_service.rb' - - 'app/services/issues/reopen_service.rb' - 'app/services/projects/transfer_service.rb' - - 'app/workers/authorized_projects_worker.rb' - 'app/workers/namespaces/root_statistics_worker.rb' - 'db/migrate/20210420012444_change_web_hook_events_default.rb' - 'db/migrate/20210507191949_add_remove_on_issue_close_to_labels.rb' @@ -92,6 +88,7 @@ Style/EmptyMethod: - 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb' - 'db/post_migrate/20220412143552_consume_remaining_encrypt_integration_property_jobs.rb' - 'db/post_migrate/20220425121435_backfill_integrations_enable_ssl_verification.rb' + - 'db/post_migrate/20220524074947_finalize_backfill_null_note_discussion_ids.rb' - 'ee/app/controllers/admin/emails_controller.rb' - 'ee/app/controllers/admin/geo/designs_controller.rb' - 'ee/app/controllers/admin/geo/settings_controller.rb' @@ -101,9 +98,8 @@ Style/EmptyMethod: - 'ee/app/controllers/groups/analytics/devops_adoption_controller.rb' - 'ee/app/controllers/groups/compliance_frameworks_controller.rb' - 'ee/app/controllers/groups/feature_discovery_moments_controller.rb' - - 'ee/app/controllers/groups/hooks_controller.rb' - 'ee/app/controllers/groups/ldap_group_links_controller.rb' - - 'ee/app/controllers/groups/push_rules_controller.rb' + - 'ee/app/controllers/groups/settings/reporting_controller.rb' - 'ee/app/controllers/projects/analytics/code_reviews_controller.rb' - 'ee/app/controllers/projects/analytics/merge_request_analytics_controller.rb' - 'ee/app/controllers/projects/incident_management/escalation_policies_controller.rb' @@ -122,8 +118,10 @@ Style/EmptyMethod: - 'ee/app/controllers/subscriptions/groups_controller.rb' - 'ee/app/controllers/trial_registrations_controller.rb' - 'ee/app/controllers/trials_controller.rb' + - 'ee/app/controllers/users/identity_verification_controller.rb' - 'ee/app/experiments/cart_abandonment_modal_experiment.rb' - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/geo/group_wiki_repository_registry.rb' - 'ee/app/services/feature_flag_issues/destroy_service.rb' - 'ee/db/geo/migrate/20170906174622_remove_duplicates_from_project_registry.rb' - 'lib/api/helpers/packages/conan/api_helpers.rb' @@ -135,6 +133,8 @@ Style/EmptyMethod: - 'lib/gitlab/alert_management/payload/base.rb' - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'lib/gitlab/background_migration/create_security_setting.rb' + - 'lib/gitlab/background_migration/delete_approval_rules_with_vulnerability.rb' + - 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb' - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' @@ -142,6 +142,7 @@ Style/EmptyMethod: - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch.rb' - 'lib/gitlab/background_migration/migrate_job_artifact_registry_to_ssf.rb' - 'lib/gitlab/background_migration/migrate_requirements_to_work_items.rb' + - 'lib/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb' - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'lib/gitlab/ci/config/entry/need.rb' @@ -150,10 +151,10 @@ Style/EmptyMethod: - 'lib/gitlab/ci/pipeline/chain/validate/after_config.rb' - 'lib/gitlab/config/entry/node.rb' - 'lib/gitlab/config/entry/simplifiable.rb' - - 'lib/gitlab/email/message/in_product_marketing/experience.rb' - 'lib/gitlab/empty_search_results.rb' - 'lib/gitlab/git_access.rb' - 'lib/gitlab/import_export/json/ndjson_writer.rb' + - 'lib/gitlab/mailgun/webhook_processors/base.rb' - 'lib/gitlab/null_request_store.rb' - 'lib/gitlab/usage_data_non_sql_metrics.rb' - 'lib/mattermost/session.rb' @@ -162,7 +163,6 @@ Style/EmptyMethod: - 'qa/qa/resource/job.rb' - 'qa/qa/resource/package.rb' - 'qa/qa/resource/registry_repository.rb' - - 'qa/qa/resource/runner.rb' - 'qa/qa/service/cluster_provider/k3d.rb' - 'qa/qa/service/cluster_provider/k3s.rb' - 'qa/qa/service/cluster_provider/minikube.rb' @@ -173,7 +173,6 @@ Style/EmptyMethod: - 'spec/lib/gitlab/database/load_balancing/sidekiq_client_middleware_spec.rb' - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb' - - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' - 'spec/lib/gitlab/database/partitioning/sliding_list_strategy_spec.rb' - 'spec/lib/gitlab/database/postgresql_adapter/dump_schema_versions_mixin_spec.rb' - 'spec/lib/gitlab/database/postgresql_database_tasks/load_schema_versions_mixin_spec.rb' @@ -192,4 +191,5 @@ Style/EmptyMethod: - 'spec/lib/gitlab/utils/delegator_override/validator_spec.rb' - 'spec/lib/gitlab/utils/delegator_override_spec.rb' - 'spec/lib/gitlab/utils/override_spec.rb' + - 'spec/lib/gitlab/utils/strong_memoize_spec.rb' - 'spec/workers/concerns/waitable_worker_spec.rb' |