diff options
Diffstat (limited to '.rubocop_todo/style/guard_clause.yml')
| -rw-r--r-- | .rubocop_todo/style/guard_clause.yml | 38 |
1 files changed, 0 insertions, 38 deletions
diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 586f146c2ba..a6461e7b177 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -8,15 +8,12 @@ Style/GuardClause: - 'app/controllers/clusters/clusters_controller.rb' - 'app/controllers/concerns/accepts_pending_invitations.rb' - 'app/controllers/concerns/authenticates_with_two_factor.rb' - - 'app/controllers/concerns/controller_with_cross_project_access_check.rb' - 'app/controllers/concerns/creates_commit.rb' - 'app/controllers/concerns/cycle_analytics_params.rb' - 'app/controllers/concerns/enforces_admin_authentication.rb' - 'app/controllers/concerns/enforces_two_factor_authentication.rb' - 'app/controllers/concerns/impersonation.rb' - - 'app/controllers/concerns/issuable_actions.rb' - 'app/controllers/concerns/issuable_collections.rb' - - 'app/controllers/concerns/oauth_applications.rb' - 'app/controllers/groups/application_controller.rb' - 'app/controllers/groups_controller.rb' - 'app/controllers/import/gitea_controller.rb' @@ -52,7 +49,6 @@ Style/GuardClause: - 'app/finders/deployments_finder.rb' - 'app/finders/group_members_finder.rb' - 'app/finders/snippets_finder.rb' - - 'app/graphql/mutations/concerns/mutations/spam_protection.rb' - 'app/graphql/mutations/design_management/delete.rb' - 'app/graphql/mutations/notes/create/note.rb' - 'app/graphql/mutations/notes/reposition_image_diff_note.rb' @@ -65,7 +61,6 @@ Style/GuardClause: - 'app/graphql/types/ci/job_type.rb' - 'app/graphql/types/permission_types/base_permission_type.rb' - 'app/helpers/admin/user_actions_helper.rb' - - 'app/helpers/application_helper.rb' - 'app/helpers/events_helper.rb' - 'app/helpers/issues_helper.rb' - 'app/helpers/nav/top_nav_helper.rb' @@ -93,10 +88,8 @@ Style/GuardClause: - 'app/models/concerns/bulk_insert_safe.rb' - 'app/models/concerns/cache_markdown_field.rb' - 'app/models/concerns/cacheable_attributes.rb' - - 'app/models/concerns/counter_attribute.rb' - 'app/models/concerns/deprecated_assignee.rb' - 'app/models/concerns/has_wiki_page_meta_attributes.rb' - - 'app/models/concerns/issuable.rb' - 'app/models/concerns/issuable_link.rb' - 'app/models/concerns/metric_image_uploading.rb' - 'app/models/concerns/milestoneish.rb' @@ -120,7 +113,6 @@ Style/GuardClause: - 'app/models/integrations/confluence.rb' - 'app/models/integrations/datadog.rb' - 'app/models/integrations/emails_on_push.rb' - - 'app/models/integrations/field.rb' - 'app/models/integrations/jira.rb' - 'app/models/integrations/pipelines_email.rb' - 'app/models/internal_id.rb' @@ -145,7 +137,6 @@ Style/GuardClause: - 'app/models/project_import_state.rb' - 'app/models/project_label.rb' - 'app/models/project_setting.rb' - - 'app/models/protected_branch.rb' - 'app/models/protected_branch/push_access_level.rb' - 'app/models/repository.rb' - 'app/models/sent_notification.rb' @@ -190,7 +181,6 @@ Style/GuardClause: - 'app/services/groups/update_service.rb' - 'app/services/groups/update_shared_runners_service.rb' - 'app/services/ide/base_config_service.rb' - - 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb' - 'app/services/import/validate_remote_git_endpoint_service.rb' - 'app/services/issuable/bulk_update_service.rb' - 'app/services/issuable/common_system_notes_service.rb' @@ -205,7 +195,6 @@ Style/GuardClause: - 'app/services/merge_requests/merge_base_service.rb' - 'app/services/merge_requests/merge_service.rb' - 'app/services/merge_requests/mergeability_check_service.rb' - - 'app/services/merge_requests/outdated_discussion_diff_lines_service.rb' - 'app/services/merge_requests/push_options_handler_service.rb' - 'app/services/merge_requests/refresh_service.rb' - 'app/services/metrics/dashboard/base_service.rb' @@ -268,19 +257,12 @@ Style/GuardClause: - 'config/initializers/0_inject_enterprise_edition_module.rb' - 'config/initializers/carrierwave_patch.rb' - 'config/initializers/devise_dynamic_password_length_validation.rb' - - 'config/initializers/google_api_client_patch.rb' - 'config/initializers/postgresql_cte.rb' - 'config/object_store_settings.rb' - 'danger/feature_flag/Dangerfile' - - 'db/migrate/20210707095545_add_status_to_merge_request_cleanup_schedules.rb' - - 'db/migrate/20210816095826_add_unique_index_on_dast_profile_to_dast_profile_schedules.rb' - - 'db/migrate/20210816192041_add_invites_email_success_to_member.rb' - - 'db/migrate/20210818061156_remove_project_profile_compound_index_from_dast_profile_schedules.rb' - 'db/migrate/20210830140524_add_state_to_member.rb' - 'db/migrate/20211202094944_move_loose_fk_deleted_records_to_dynamic_schema.rb' - 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb' - - 'db/post_migrate/20210713042000_fix_ci_sources_pipelines_index_names.rb' - - 'db/post_migrate/20210805192450_update_trial_plans_ci_daily_pipeline_schedule_triggers.rb' - 'db/post_migrate/20210907211557_finalize_ci_builds_bigint_conversion.rb' - 'ee/app/controllers/admin/emails_controller.rb' - 'ee/app/controllers/admin/geo/application_controller.rb' @@ -309,7 +291,6 @@ Style/GuardClause: - 'ee/app/graphql/resolvers/iterations_resolver.rb' - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/helpers/ee/auth_helper.rb' - - 'ee/app/helpers/ee/award_emoji_helper.rb' - 'ee/app/helpers/ee/nav/new_dropdown_helper.rb' - 'ee/app/helpers/ee/nav/top_nav_helper.rb' - 'ee/app/helpers/ee/projects/pipeline_helper.rb' @@ -317,7 +298,6 @@ Style/GuardClause: - 'ee/app/models/allowed_email_domain.rb' - 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb' - 'ee/app/models/approval_merge_request_rule_source.rb' - - 'ee/app/models/audit_events/external_audit_event_destination.rb' - 'ee/app/models/concerns/app_sec/dast/buildable.rb' - 'ee/app/models/concerns/ee/protected_ref_access.rb' - 'ee/app/models/concerns/elastic/application_versioned_search.rb' @@ -462,7 +442,6 @@ Style/GuardClause: - 'lib/api/helpers/projects_helpers.rb' - 'lib/api/helpers/snippets_helpers.rb' - 'lib/api/helpers/version.rb' - - 'lib/api/internal/base.rb' - 'lib/api/projects.rb' - 'lib/backup/files.rb' - 'lib/banzai/filter/external_link_filter.rb' @@ -470,7 +449,6 @@ Style/GuardClause: - 'lib/banzai/filter/references/merge_request_reference_filter.rb' - 'lib/banzai/filter/wiki_link_filter/rewriter.rb' - 'lib/bulk_imports/clients/graphql.rb' - - 'lib/bulk_imports/clients/http.rb' - 'lib/bulk_imports/pipeline/runner.rb' - 'lib/bulk_imports/projects/pipelines/project_pipeline.rb' - 'lib/container_registry/client.rb' @@ -487,7 +465,6 @@ Style/GuardClause: - 'lib/gitlab/blob_helper.rb' - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - 'lib/gitlab/changelog/config.rb' - - 'lib/gitlab/chat/responder.rb' - 'lib/gitlab/checks/branch_check.rb' - 'lib/gitlab/checks/matching_merge_request.rb' - 'lib/gitlab/checks/push_file_count_check.rb' @@ -503,7 +480,6 @@ Style/GuardClause: - 'lib/gitlab/ci/config/external/file/base.rb' - 'lib/gitlab/ci/config/external/file/remote.rb' - 'lib/gitlab/ci/config/external/file/template.rb' - - 'lib/gitlab/ci/config/external/mapper.rb' - 'lib/gitlab/ci/parsers/coverage/sax_document.rb' - 'lib/gitlab/ci/parsers/security/common.rb' - 'lib/gitlab/ci/pipeline/chain/command.rb' @@ -533,7 +509,6 @@ Style/GuardClause: - 'lib/gitlab/database/partitioning/partition_manager.rb' - 'lib/gitlab/database/partitioning/sliding_list_strategy.rb' - 'lib/gitlab/database/postgresql_adapter/force_disconnectable_mixin.rb' - - 'lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection.rb' - 'lib/gitlab/database/query_analyzers/restrict_allowed_schemas.rb' - 'lib/gitlab/diff/file.rb' - 'lib/gitlab/diff/highlight.rb' @@ -552,13 +527,11 @@ Style/GuardClause: - 'lib/gitlab/git_access.rb' - 'lib/gitlab/git_access_design.rb' - 'lib/gitlab/git_access_snippet.rb' - - 'lib/gitlab/gitaly_client/blobs_stitcher.rb' - 'lib/gitlab/gitaly_client/conflicts_service.rb' - 'lib/gitlab/gitaly_client/operation_service.rb' - 'lib/gitlab/github_import.rb' - 'lib/gitlab/github_import/client.rb' - 'lib/gitlab/github_import/importer/pull_request_importer.rb' - - 'lib/gitlab/github_import/importer/pull_request_merged_by_importer.rb' - 'lib/gitlab/github_import/importer/pull_request_review_importer.rb' - 'lib/gitlab/github_import/object_counter.rb' - 'lib/gitlab/gitlab_import/client.rb' @@ -577,7 +550,6 @@ Style/GuardClause: - 'lib/gitlab/import_export/version_checker.rb' - 'lib/gitlab/instrumentation/global_search_api.rb' - 'lib/gitlab/instrumentation/rate_limiting_gates.rb' - - 'lib/gitlab/instrumentation/redis_cluster_validator.rb' - 'lib/gitlab/instrumentation/uploads.rb' - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb' - 'lib/gitlab/legacy_github_import/client.rb' @@ -597,14 +569,12 @@ Style/GuardClause: - 'lib/gitlab/pagination/keyset/order.rb' - 'lib/gitlab/pagination/keyset/pager.rb' - 'lib/gitlab/pagination/keyset/paginator.rb' - - 'lib/gitlab/pagination/keyset/simple_order_builder.rb' - 'lib/gitlab/patch/global_id.rb' - 'lib/gitlab/patch/sprockets_base_file_digest_key.rb' - 'lib/gitlab/process_supervisor.rb' - 'lib/gitlab/prometheus/query_variables.rb' - 'lib/gitlab/prometheus_client.rb' - 'lib/gitlab/recaptcha.rb' - - 'lib/gitlab/relative_positioning/mover.rb' - 'lib/gitlab/sanitizers/exif.rb' - 'lib/gitlab/search/abuse_validators/no_abusive_coercion_from_string_validator.rb' - 'lib/gitlab/search/abuse_validators/no_abusive_term_length_validator.rb' @@ -616,11 +586,9 @@ Style/GuardClause: - 'lib/gitlab/sidekiq_middleware/extra_done_log_metadata.rb' - 'lib/gitlab/sidekiq_middleware/size_limiter/compressor.rb' - 'lib/gitlab/sql/set_operator.rb' - - 'lib/gitlab/ssh_public_key.rb' - 'lib/gitlab/url_blocker.rb' - 'lib/gitlab/usage/metric_definition.rb' - 'lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric.rb' - - 'lib/gitlab/usage_data_counters/ci_template_unique_counter.rb' - 'lib/gitlab/utils.rb' - 'lib/gitlab/utils/override.rb' - 'lib/gitlab/webpack/manifest.rb' @@ -632,16 +600,12 @@ Style/GuardClause: - 'lib/tasks/config_lint.rake' - 'lib/tasks/gettext.rake' - 'qa/qa/ee/page/file/show.rb' - - 'qa/qa/ee/resource/license.rb' - 'qa/qa/mobile/page/main/menu.rb' - 'qa/qa/mobile/page/sub_menus/common.rb' - - 'qa/qa/page/component/invite_members_modal.rb' - - 'qa/qa/page/component/select2.rb' - 'qa/qa/page/component/snippet.rb' - 'qa/qa/page/mattermost/login.rb' - 'qa/qa/page/page_concern.rb' - 'qa/qa/page/project/settings/deploy_tokens.rb' - - 'qa/qa/resource/api_fabricator.rb' - 'qa/qa/resource/package.rb' - 'qa/qa/resource/registry_repository.rb' - 'qa/qa/resource/user_gpg.rb' @@ -649,7 +613,6 @@ Style/GuardClause: - 'qa/qa/runtime/search.rb' - 'qa/qa/service/cluster_provider/gcloud.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_trial_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/group_file_template_spec.rb' - 'qa/qa/specs/helpers/feature_flag.rb' - 'qa/qa/vendor/jenkins/job.rb' @@ -664,7 +627,6 @@ Style/GuardClause: - 'scripts/lint_templates_bash.rb' - 'scripts/setup/find-jh-branch.rb' - 'scripts/trigger-build.rb' - - 'spec/deprecation_toolkit_env.rb' - 'spec/features/issuables/issuable_list_spec.rb' - 'spec/features/projects/blobs/edit_spec.rb' - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' |