diff options
| -rw-r--r-- | danger/changelog/Dangerfile | 6 | ||||
| -rw-r--r-- | danger/changes_size/Dangerfile | 2 | ||||
| -rw-r--r-- | danger/database/Dangerfile | 1 | ||||
| -rw-r--r-- | danger/gemfile/Dangerfile | 4 | ||||
| -rw-r--r-- | danger/specs/Dangerfile | 4 |
5 files changed, 5 insertions, 12 deletions
diff --git a/danger/changelog/Dangerfile b/danger/changelog/Dangerfile index b4a2f7b964c..76ebe57cf8d 100644 --- a/danger/changelog/Dangerfile +++ b/danger/changelog/Dangerfile @@ -2,9 +2,9 @@ require 'yaml' -NO_CHANGELOG_LABELS = %w[backstage QA test] -SEE_DOC = "See [the documentation](https://docs.gitlab.com/ce/development/changelog.html)." -MISSING_CHANGELOG_MESSAGE = <<~MSG +NO_CHANGELOG_LABELS = %w[backstage QA test].freeze +SEE_DOC = "See [the documentation](https://docs.gitlab.com/ce/development/changelog.html).".freeze +MISSING_CHANGELOG_MESSAGE = <<~MSG.freeze **[CHANGELOG missing](https://docs.gitlab.com/ce/development/changelog.html).** You can create one with: diff --git a/danger/changes_size/Dangerfile b/danger/changes_size/Dangerfile index 597073e6029..8251d0d5cbf 100644 --- a/danger/changes_size/Dangerfile +++ b/danger/changes_size/Dangerfile @@ -1,5 +1,3 @@ -# rubocop:disable Style/SignalException - # FIXME: git.info_for_file raises the following error # /usr/local/bundle/gems/git-1.4.0/lib/git/lib.rb:956:in `command': (Danger::DSLError) # [!] Invalid `Dangerfile` file: diff --git a/danger/database/Dangerfile b/danger/database/Dangerfile index 2328a6c1733..6f48994945a 100644 --- a/danger/database/Dangerfile +++ b/danger/database/Dangerfile @@ -1,5 +1,4 @@ # frozen_string_literal: true -# rubocop:disable Style/SignalException # All the files/directories that should be reviewed by the DB team. DB_FILES = [ diff --git a/danger/gemfile/Dangerfile b/danger/gemfile/Dangerfile index b9f59d95815..8ef4a464fe4 100644 --- a/danger/gemfile/Dangerfile +++ b/danger/gemfile/Dangerfile @@ -1,6 +1,4 @@ -# rubocop:disable Style/SignalException - -GEMFILE_LOCK_NOT_UPDATED_MESSAGE = <<~MSG +GEMFILE_LOCK_NOT_UPDATED_MESSAGE = <<~MSG.freeze **%<gemfile>s was updated but %<gemfile_lock>s wasn't updated.** Usually, when %<gemfile>s is updated, you should run diff --git a/danger/specs/Dangerfile b/danger/specs/Dangerfile index 0ed5235ec02..934ea0beadb 100644 --- a/danger/specs/Dangerfile +++ b/danger/specs/Dangerfile @@ -1,6 +1,4 @@ -# rubocop:disable Style/SignalException - -NO_NEW_SPEC_MESSAGE = <<~MSG +NO_NEW_SPEC_MESSAGE = <<~MSG.freeze You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding the ~backstage label in that case. |