summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--app/models/commit_range.rb2
-rw-r--r--spec/models/commit_range_spec.rb6
2 files changed, 6 insertions, 2 deletions
diff --git a/app/models/commit_range.rb b/app/models/commit_range.rb
index 66daa072c9e..dce1bfcc198 100644
--- a/app/models/commit_range.rb
+++ b/app/models/commit_range.rb
@@ -73,7 +73,7 @@ class CommitRange
# Returns a String for use in a link's title attribute
def reference_title
- "Commits #{sha_from} through #{sha_to}"
+ "Commits #{sha_from_as_param} through #{sha_to}"
end
# Return a Hash of parameters for passing to a URL helper
diff --git a/spec/models/commit_range_spec.rb b/spec/models/commit_range_spec.rb
index 8412c7d2140..fe7ede92bc9 100644
--- a/spec/models/commit_range_spec.rb
+++ b/spec/models/commit_range_spec.rb
@@ -49,9 +49,13 @@ describe CommitRange do
end
describe '#reference_title' do
- it 'returns the correct String' do
+ it 'returns the correct String for three-dot ranges' do
expect(range.reference_title).to eq "Commits #{sha_from} through #{sha_to}"
end
+
+ it 'returns the correct String for two-dot ranges' do
+ expect(range2.reference_title).to eq "Commits #{sha_from}^ through #{sha_to}"
+ end
end
describe '#to_param' do