diff options
94 files changed, 180 insertions, 305 deletions
diff --git a/.gitlab/ci/package-and-test/main.gitlab-ci.yml b/.gitlab/ci/package-and-test/main.gitlab-ci.yml index b70ced69969..301a2ddb5f1 100644 --- a/.gitlab/ci/package-and-test/main.gitlab-ci.yml +++ b/.gitlab/ci/package-and-test/main.gitlab-ci.yml @@ -8,7 +8,7 @@ include: - local: .gitlab/ci/package-and-test/rules.gitlab-ci.yml - local: .gitlab/ci/package-and-test/variables.gitlab-ci.yml - project: gitlab-org/quality/pipeline-common - ref: 2.0.0 + ref: 2.1.1 file: - /ci/base.gitlab-ci.yml - /ci/allure-report.yml diff --git a/.gitlab/ci/review-apps/qa.gitlab-ci.yml b/.gitlab/ci/review-apps/qa.gitlab-ci.yml index edca2cae1c6..6c81bc1972b 100644 --- a/.gitlab/ci/review-apps/qa.gitlab-ci.yml +++ b/.gitlab/ci/review-apps/qa.gitlab-ci.yml @@ -1,6 +1,6 @@ include: - project: gitlab-org/quality/pipeline-common - ref: 2.0.0 + ref: 2.1.1 file: - /ci/base.gitlab-ci.yml - /ci/allure-report.yml diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index 12e76e391ca..b592a402f40 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -138,7 +138,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/finders/security/vulnerability_feedbacks_finder_spec.rb' - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - 'ee/spec/finders/snippets_finder_spec.rb' - - 'ee/spec/finders/software_license_policies_finder_spec.rb' - 'ee/spec/finders/status_page/incident_comments_finder_spec.rb' - 'ee/spec/finders/status_page/incidents_finder_spec.rb' - 'ee/spec/finders/template_finder_spec.rb' @@ -295,7 +294,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/resolvers/compliance_management/merge_requests/compliance_violation_resolver_spec.rb' - 'ee/spec/graphql/resolvers/dast_site_profile_resolver_spec.rb' - 'ee/spec/graphql/resolvers/dast_site_validation_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/dora_metrics_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epic_ancestors_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epic_issues_resolver_spec.rb' - 'ee/spec/graphql/resolvers/epics/children_resolver_spec.rb' @@ -397,7 +395,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/graphql/types/deployments/approval_type_spec.rb' - 'ee/spec/graphql/types/dora_metric_bucketing_interval_enum_spec.rb' - 'ee/spec/graphql/types/dora_metric_type_enum_spec.rb' - - 'ee/spec/graphql/types/dora_metric_type_spec.rb' - 'ee/spec/graphql/types/dora_type_spec.rb' - 'ee/spec/graphql/types/epic_connection_type_spec.rb' - 'ee/spec/graphql/types/epic_descendant_count_type_spec.rb' @@ -560,7 +557,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/helpers/ee/geo_helper_spec.rb' - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' - 'ee/spec/helpers/ee/graph_helper_spec.rb' - - 'ee/spec/helpers/ee/groups/analytics/cycle_analytics_helper_spec.rb' - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - 'ee/spec/helpers/ee/groups/settings_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' @@ -653,7 +649,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/audit/group_merge_request_approval_setting_changes_auditor_spec.rb' - 'ee/spec/lib/audit/group_push_rules_changes_auditor_spec.rb' - 'ee/spec/lib/banzai/filter/cross_project_issuable_information_filter_spec.rb' - - 'ee/spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb' - 'ee/spec/lib/banzai/filter/jira_private_image_link_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/epic_reference_filter_spec.rb' - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb' @@ -773,7 +768,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/database/gitlab_schema_spec.rb' - 'ee/spec/lib/ee/gitlab/database_spec.rb' - 'ee/spec/lib/ee/gitlab/email/handler/service_desk_handler_spec.rb' - - 'ee/spec/lib/ee/gitlab/etag_caching/router/rails_spec.rb' - 'ee/spec/lib/ee/gitlab/event_store_spec.rb' - 'ee/spec/lib/ee/gitlab/git_access_design_spec.rb' - 'ee/spec/lib/ee/gitlab/git_access_project_spec.rb' @@ -803,8 +797,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/gitlab/repo_path_spec.rb' - 'ee/spec/lib/ee/gitlab/repository_size_checker_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/attribute_transform_spec.rb' - - 'ee/spec/lib/ee/gitlab/scim/filter_parser_spec.rb' - - 'ee/spec/lib/ee/gitlab/scim/params_parser_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/value_parser_spec.rb' - 'ee/spec/lib/ee/gitlab/search_results_spec.rb' - 'ee/spec/lib/ee/gitlab/security/scan_configuration_spec.rb' @@ -832,7 +824,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/ee/sidebars/projects/menus/repository_menu_spec.rb' - 'ee/spec/lib/ee/sidebars/projects/menus/security_compliance_menu_spec.rb' - 'ee/spec/lib/ee/sidebars/projects/panel_spec.rb' - - 'ee/spec/lib/elastic/latest/application_instance_proxy_spec.rb' - 'ee/spec/lib/elastic/latest/commit_config_spec.rb' - 'ee/spec/lib/elastic/latest/config_spec.rb' - 'ee/spec/lib/elastic/latest/custom_language_analyzers_spec.rb' @@ -856,7 +847,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_for_duration_chart_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/distinct_stage_loader_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_closed_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_first_added_to_board_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/issue_first_associated_with_milestone_spec.rb' @@ -868,11 +858,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_label_added_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_label_removed_spec.rb' - 'ee/spec/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_last_edited_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/base_dora_summary_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/change_failure_rate_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/lead_time_for_changes_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/lead_time_spec.rb' - - 'ee/spec/lib/gitlab/analytics/cycle_analytics/summary/time_to_restore_service_spec.rb' - 'ee/spec/lib/gitlab/analytics/type_of_work/tasks_by_type_spec.rb' - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' - 'ee/spec/lib/gitlab/audit/events/preloader_spec.rb' @@ -936,7 +921,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/ci/parsers/security/dependency_scanning_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/formatters/dependency_list_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/validators/default_branch_image_validator_spec.rb' - - 'ee/spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/create_cross_database_associations_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/activity_spec.rb' - 'ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb' @@ -973,7 +957,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/code_owners/validator_spec.rb' - 'ee/spec/lib/gitlab/code_owners_spec.rb' - 'ee/spec/lib/gitlab/com_spec.rb' - - 'ee/spec/lib/gitlab/console_spec.rb' - 'ee/spec/lib/gitlab/contribution_analytics/data_collector_spec.rb' - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' - 'ee/spec/lib/gitlab/customers_dot/jwt_spec.rb' @@ -1048,7 +1031,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/lib/gitlab/import_sources_spec.rb' - 'ee/spec/lib/gitlab/incident_management_spec.rb' - 'ee/spec/lib/gitlab/ingestion/bulk_insertable_task_spec.rb' - - 'ee/spec/lib/gitlab/insights/executors/dora_executor_spec.rb' - 'ee/spec/lib/gitlab/insights/executors/issuable_executor_spec.rb' - 'ee/spec/lib/gitlab/insights/finders/projects_finder_spec.rb' - 'ee/spec/lib/gitlab/insights/loader_spec.rb' @@ -1193,7 +1175,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/mailers/license_mailer_spec.rb' - 'ee/spec/mailers/notify_spec.rb' - 'ee/spec/models/alert_management/alert_payload_field_spec.rb' - - 'ee/spec/models/allowed_email_domain_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/aggregation_context_spec.rb' - 'ee/spec/models/analytics/cycle_analytics/runtime_limiter_spec.rb' - 'ee/spec/models/analytics/devops_adoption/enabled_namespace_spec.rb' @@ -1223,7 +1204,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/boards/epic_user_preference_spec.rb' - 'ee/spec/models/broadcast_message_spec.rb' - 'ee/spec/models/ci/bridge_spec.rb' - - 'ee/spec/models/ci/build_spec.rb' - 'ee/spec/models/ci/daily_build_group_report_result_spec.rb' - 'ee/spec/models/ci/minutes/additional_pack_spec.rb' - 'ee/spec/models/ci/minutes/context_spec.rb' @@ -1266,7 +1246,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/concerns/geo/verifiable_model_spec.rb' - 'ee/spec/models/concerns/geo/verification_state_spec.rb' - 'ee/spec/models/concerns/health_status_spec.rb' - - 'ee/spec/models/concerns/identity_verifiable_spec.rb' - 'ee/spec/models/concerns/incident_management/base_pending_escalation_spec.rb' - 'ee/spec/models/concerns/mirror_configuration_spec.rb' - 'ee/spec/models/concerns/password_complexity_spec.rb' @@ -1392,7 +1371,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/models/geo_node_spec.rb' - 'ee/spec/models/gitlab/seat_link_data_spec.rb' - 'ee/spec/models/gitlab_subscription_history_spec.rb' - - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/gitlab_subscriptions/features_spec.rb' - 'ee/spec/models/gitlab_subscriptions/upcoming_reconciliation_spec.rb' - 'ee/spec/models/group_deletion_schedule_spec.rb' @@ -1732,7 +1710,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/audit_events/release_associate_milestone_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/release_created_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/release_updated_audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/repository_download_started_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/runner_custom_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/runners_token_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/streaming/event_type_filters/create_service_spec.rb' @@ -1813,20 +1790,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/dashboard/projects/list_service_spec.rb' - 'ee/spec/services/deploy_keys/create_service_spec.rb' - 'ee/spec/services/deployments/auto_rollback_service_spec.rb' - - 'ee/spec/services/ee/admin/set_feature_flag_service_spec.rb' - - 'ee/spec/services/ee/alert_management/alerts/update_service_spec.rb' - - 'ee/spec/services/ee/alert_management/create_alert_issue_service_spec.rb' - - 'ee/spec/services/ee/alert_management/http_integrations/create_service_spec.rb' - - 'ee/spec/services/ee/alert_management/http_integrations/update_service_spec.rb' - - 'ee/spec/services/ee/allowed_email_domains/update_service_spec.rb' - - 'ee/spec/services/ee/auth/container_registry_authentication_service_spec.rb' - 'ee/spec/services/ee/auto_merge_service_spec.rb' - - 'ee/spec/services/ee/boards/issues/create_service_spec.rb' - - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' - - 'ee/spec/services/ee/boards/issues/move_service_spec.rb' - - 'ee/spec/services/ee/boards/lists/create_service_spec.rb' - - 'ee/spec/services/ee/boards/lists/list_service_spec.rb' - - 'ee/spec/services/ee/boards/lists/max_limits_spec.rb' - 'ee/spec/services/ee/ci/change_variable_service_spec.rb' - 'ee/spec/services/ee/ci/change_variables_service_spec.rb' - 'ee/spec/services/ee/ci/job_artifacts/create_service_spec.rb' @@ -2143,10 +2107,7 @@ RSpec/MissingFeatureCategory: - 'ee/spec/services/security/findings/dismiss_service_spec.rb' - 'ee/spec/services/security/ingestion/finding_map_collection_spec.rb' - 'ee/spec/services/security/ingestion/finding_map_spec.rb' - - 'ee/spec/services/security/ingestion/ingest_report_service_spec.rb' - 'ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb' - - 'ee/spec/services/security/ingestion/ingest_reports_service_spec.rb' - - 'ee/spec/services/security/ingestion/mark_as_resolved_service_spec.rb' - 'ee/spec/services/security/ingestion/tasks/hooks_execution_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_finding_evidence_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_identifiers_spec.rb' @@ -2353,7 +2314,6 @@ RSpec/MissingFeatureCategory: - 'ee/spec/workers/ci/trigger_downstream_subscriptions_worker_spec.rb' - 'ee/spec/workers/ci/upstream_projects_subscriptions_cleanup_worker_spec.rb' - 'ee/spec/workers/clear_shared_runners_minutes_worker_spec.rb' - - 'ee/spec/workers/compliance_management/chain_of_custody_report_worker_spec.rb' - 'ee/spec/workers/compliance_management/merge_requests/compliance_violations_worker_spec.rb' - 'ee/spec/workers/compliance_management/update_default_framework_worker_spec.rb' - 'ee/spec/workers/concerns/elastic/indexing_control_spec.rb' @@ -2489,7 +2449,6 @@ RSpec/MissingFeatureCategory: - 'spec/channels/awareness_channel_spec.rb' - 'spec/commands/diagnostic_reports/uploader_smoke_spec.rb' - 'spec/commands/metrics_server/metrics_server_spec.rb' - - 'spec/commands/sidekiq_cluster/cli_spec.rb' - 'spec/components/diffs/overflow_warning_component_spec.rb' - 'spec/components/diffs/stats_component_spec.rb' - 'spec/components/layouts/horizontal_section_component_spec.rb' @@ -2527,12 +2486,10 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/admin/plan_limits_controller_spec.rb' - 'spec/controllers/admin/projects_controller_spec.rb' - 'spec/controllers/admin/sessions_controller_spec.rb' - - 'spec/controllers/admin/spam_logs_controller_spec.rb' - 'spec/controllers/admin/topics/avatars_controller_spec.rb' - 'spec/controllers/admin/topics_controller_spec.rb' - 'spec/controllers/admin/usage_trends_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' - - 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/autocomplete_controller_spec.rb' - 'spec/controllers/chaos_controller_spec.rb' - 'spec/controllers/concerns/check_rate_limit_spec.rb' @@ -2636,7 +2593,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/analytics/cycle_analytics/stages_controller_spec.rb' - 'spec/controllers/projects/analytics/cycle_analytics/summary_controller_spec.rb' - 'spec/controllers/projects/analytics/cycle_analytics/value_streams_controller_spec.rb' - - 'spec/controllers/projects/artifacts_controller_spec.rb' - 'spec/controllers/projects/autocomplete_sources_controller_spec.rb' - 'spec/controllers/projects/avatars_controller_spec.rb' - 'spec/controllers/projects/badges_controller_spec.rb' @@ -2677,7 +2633,6 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/mirrors_controller_spec.rb' - 'spec/controllers/projects/packages/infrastructure_registry_controller_spec.rb' - 'spec/controllers/projects/packages/packages_controller_spec.rb' - - 'spec/controllers/projects/pages_controller_spec.rb' - 'spec/controllers/projects/performance_monitoring/dashboards_controller_spec.rb' - 'spec/controllers/projects/pipelines/stages_controller_spec.rb' - 'spec/controllers/projects/pipelines/tests_controller_spec.rb' @@ -2711,10 +2666,8 @@ RSpec/MissingFeatureCategory: - 'spec/controllers/projects/web_ide_schemas_controller_spec.rb' - 'spec/controllers/projects/web_ide_terminals_controller_spec.rb' - 'spec/controllers/projects/wikis_controller_spec.rb' - - 'spec/controllers/repositories/git_http_controller_spec.rb' - 'spec/controllers/repositories/lfs_storage_controller_spec.rb' - 'spec/controllers/root_controller_spec.rb' - - 'spec/controllers/search_controller_spec.rb' - 'spec/controllers/sent_notifications_controller_spec.rb' - 'spec/controllers/sessions_controller_spec.rb' - 'spec/controllers/snippets/blobs_controller_spec.rb' @@ -2732,7 +2685,6 @@ RSpec/MissingFeatureCategory: - 'spec/dependencies/omniauth_saml_spec.rb' - 'spec/docs_screenshots/container_registry_docs.rb' - 'spec/docs_screenshots/wiki_docs.rb' - - 'spec/experiments/application_experiment_spec.rb' - 'spec/experiments/concerns/project_commit_count_spec.rb' - 'spec/experiments/force_company_trial_experiment_spec.rb' - 'spec/experiments/in_product_guidance_environments_webide_experiment_spec.rb' @@ -2741,7 +2693,6 @@ RSpec/MissingFeatureCategory: - 'spec/experiments/security_reports_mr_widget_prompt_experiment_spec.rb' - 'spec/features/admin/dashboard_spec.rb' - 'spec/features/groups/integrations/group_integrations_spec.rb' - - 'spec/features/markdown/observability_spec.rb' - 'spec/features/milestones/user_views_milestones_spec.rb' - 'spec/features/projects/feature_flags/user_creates_feature_flag_spec.rb' - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' @@ -3095,7 +3046,6 @@ RSpec/MissingFeatureCategory: - 'spec/graphql/resolvers/group_milestones_resolver_spec.rb' - 'spec/graphql/resolvers/group_packages_resolver_spec.rb' - 'spec/graphql/resolvers/group_resolver_spec.rb' - - 'spec/graphql/resolvers/groups_resolver_spec.rb' - 'spec/graphql/resolvers/incident_management/timeline_event_tags_resolver_spec.rb' - 'spec/graphql/resolvers/incident_management/timeline_events_resolver_spec.rb' - 'spec/graphql/resolvers/issue_status_counts_resolver_spec.rb' @@ -3452,7 +3402,6 @@ RSpec/MissingFeatureCategory: - 'spec/helpers/admin/deploy_key_helper_spec.rb' - 'spec/helpers/admin/identities_helper_spec.rb' - 'spec/helpers/admin/user_actions_helper_spec.rb' - - 'spec/helpers/analytics/cycle_analytics_helper_spec.rb' - 'spec/helpers/appearances_helper_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/application_settings_helper_spec.rb' @@ -3467,7 +3416,6 @@ RSpec/MissingFeatureCategory: - 'spec/helpers/boards_helper_spec.rb' - 'spec/helpers/branches_helper_spec.rb' - 'spec/helpers/breadcrumbs_helper_spec.rb' - - 'spec/helpers/broadcast_messages_helper_spec.rb' - 'spec/helpers/button_helper_spec.rb' - 'spec/helpers/calendar_helper_spec.rb' - 'spec/helpers/ci/builds_helper_spec.rb' @@ -3722,7 +3670,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/banzai/filter/inline_grafana_metrics_filter_spec.rb' - 'spec/lib/banzai/filter/inline_metrics_filter_spec.rb' - 'spec/lib/banzai/filter/inline_metrics_redactor_filter_spec.rb' - - 'spec/lib/banzai/filter/inline_observability_filter_spec.rb' - 'spec/lib/banzai/pipeline/incident_management/timeline_event_pipeline_spec.rb' - 'spec/lib/bitbucket/collection_spec.rb' - 'spec/lib/bitbucket/connection_spec.rb' @@ -3872,7 +3819,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/api_authentication/builder_spec.rb' - 'spec/lib/gitlab/api_authentication/sent_through_builder_spec.rb' - 'spec/lib/gitlab/api_authentication/token_locator_spec.rb' - - 'spec/lib/gitlab/api_authentication/token_resolver_spec.rb' - 'spec/lib/gitlab/api_authentication/token_type_builder_spec.rb' - 'spec/lib/gitlab/app_json_logger_spec.rb' - 'spec/lib/gitlab/app_logger_spec.rb' @@ -3898,7 +3844,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/auth/atlassian/auth_hash_spec.rb' - 'spec/lib/gitlab/auth/atlassian/identity_linker_spec.rb' - 'spec/lib/gitlab/auth/atlassian/user_spec.rb' - - 'spec/lib/gitlab/auth/auth_finders_spec.rb' - 'spec/lib/gitlab/auth/blocked_user_tracker_spec.rb' - 'spec/lib/gitlab/auth/crowd/authentication_spec.rb' - 'spec/lib/gitlab/auth/current_user_mode_spec.rb' @@ -4039,7 +3984,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/background_migration/update_timelogs_project_id_spec.rb' - 'spec/lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group_spec.rb' - 'spec/lib/gitlab/background_migration_spec.rb' - - 'spec/lib/gitlab/background_task_spec.rb' - 'spec/lib/gitlab/backtrace_cleaner_spec.rb' - 'spec/lib/gitlab/bare_repository_import/importer_spec.rb' - 'spec/lib/gitlab/bare_repository_import/repository_spec.rb' @@ -4062,7 +4006,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/changelog/config_spec.rb' - 'spec/lib/gitlab/changelog/generator_spec.rb' - 'spec/lib/gitlab/changelog/release_spec.rb' - - 'spec/lib/gitlab/changes_list_spec.rb' - 'spec/lib/gitlab/chat/command_spec.rb' - 'spec/lib/gitlab/chat/output_spec.rb' - 'spec/lib/gitlab/chat/responder/base_spec.rb' @@ -4159,14 +4102,12 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/config/entry/need_spec.rb' - 'spec/lib/gitlab/ci/config/entry/needs_spec.rb' - 'spec/lib/gitlab/ci/config/entry/paths_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/policy_spec.rb' - 'spec/lib/gitlab/ci/config/entry/port_spec.rb' - 'spec/lib/gitlab/ci/config/entry/ports_spec.rb' - 'spec/lib/gitlab/ci/config/entry/prefix_spec.rb' - 'spec/lib/gitlab/ci/config/entry/product/matrix_spec.rb' - 'spec/lib/gitlab/ci/config/entry/product/parallel_spec.rb' - 'spec/lib/gitlab/ci/config/entry/product/variables_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/pull_policy_spec.rb' - 'spec/lib/gitlab/ci/config/entry/release/assets/link_spec.rb' - 'spec/lib/gitlab/ci/config/entry/release/assets/links_spec.rb' - 'spec/lib/gitlab/ci/config/entry/release/assets_spec.rb' @@ -4213,7 +4154,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/pipeline/chain/assign_partition_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/build_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/command_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/create_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/ensure_environments_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/ensure_resource_groups_spec.rb' @@ -4232,7 +4172,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/pipeline/chain/template_usage_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/validate/external_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/validate/repository_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/duration_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/and_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/equals_spec.rb' - 'spec/lib/gitlab/ci/pipeline/expression/lexeme/not_equals_spec.rb' @@ -4253,8 +4192,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/ci/pipeline/seed/processable/resource_group_spec.rb' - 'spec/lib/gitlab/ci/pipeline_object_hierarchy_spec.rb' - 'spec/lib/gitlab/ci/processable_object_hierarchy_spec.rb' - - 'spec/lib/gitlab/ci/project_config/repository_spec.rb' - - 'spec/lib/gitlab/ci/project_config/source_spec.rb' - 'spec/lib/gitlab/ci/project_config_spec.rb' - 'spec/lib/gitlab/ci/reports/accessibility_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb' @@ -4409,7 +4346,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/config_checker/puma_rugged_checker_spec.rb' - 'spec/lib/gitlab/conflict/file_collection_spec.rb' - 'spec/lib/gitlab/conflict/file_spec.rb' - - 'spec/lib/gitlab/console_spec.rb' - 'spec/lib/gitlab/consul/internal_spec.rb' - 'spec/lib/gitlab/container_repository/tags/cache_spec.rb' - 'spec/lib/gitlab/content_security_policy/config_loader_spec.rb' @@ -4456,7 +4392,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/count_spec.rb' - 'spec/lib/gitlab/database/dynamic_model_helpers_spec.rb' - 'spec/lib/gitlab/database/each_database_spec.rb' - - 'spec/lib/gitlab/database/gitlab_schema_spec.rb' - 'spec/lib/gitlab/database/grant_spec.rb' - 'spec/lib/gitlab/database/load_balancing/action_cable_callbacks_spec.rb' - 'spec/lib/gitlab/database/load_balancing/configuration_spec.rb' @@ -4518,7 +4453,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/database/postgres_hll/buckets_spec.rb' - 'spec/lib/gitlab/database/postgres_index_bloat_estimate_spec.rb' - 'spec/lib/gitlab/database/postgres_index_spec.rb' - - 'spec/lib/gitlab/database/postgres_partition_spec.rb' - 'spec/lib/gitlab/database/postgres_partitioned_table_spec.rb' - 'spec/lib/gitlab/database/postgresql_adapter/dump_schema_versions_mixin_spec.rb' - 'spec/lib/gitlab/database/postgresql_adapter/empty_query_ping_spec.rb' @@ -4640,7 +4574,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/empty_search_results_spec.rb' - 'spec/lib/gitlab/encoding_helper_spec.rb' - 'spec/lib/gitlab/encrypted_configuration_spec.rb' - - 'spec/lib/gitlab/endpoint_attributes_spec.rb' - 'spec/lib/gitlab/error_tracking/context_payload_generator_spec.rb' - 'spec/lib/gitlab/error_tracking/error_repository/open_api_strategy_spec.rb' - 'spec/lib/gitlab/error_tracking/log_formatter_spec.rb' @@ -4771,7 +4704,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/github_import/importer/issue_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/label_links_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/lfs_object_importer_spec.rb' - - 'spec/lib/gitlab/github_import/importer/note_attachments_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/note_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/protected_branch_importer_spec.rb' - 'spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb' @@ -4787,7 +4719,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/github_import/issuable_finder_spec.rb' - 'spec/lib/gitlab/github_import/label_finder_spec.rb' - 'spec/lib/gitlab/github_import/logger_spec.rb' - - 'spec/lib/gitlab/github_import/markdown/attachment_spec.rb' - 'spec/lib/gitlab/github_import/markdown_text_spec.rb' - 'spec/lib/gitlab/github_import/milestone_finder_spec.rb' - 'spec/lib/gitlab/github_import/object_counter_spec.rb' @@ -4915,21 +4846,16 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/import_export/after_export_strategies/web_upload_strategy_spec.rb' - 'spec/lib/gitlab/import_export/after_export_strategy_builder_spec.rb' - 'spec/lib/gitlab/import_export/attribute_cleaner_spec.rb' - - 'spec/lib/gitlab/import_export/attribute_configuration_spec.rb' - - 'spec/lib/gitlab/import_export/attributes_finder_spec.rb' - - 'spec/lib/gitlab/import_export/attributes_permitter_spec.rb' - 'spec/lib/gitlab/import_export/avatar_restorer_spec.rb' - 'spec/lib/gitlab/import_export/avatar_saver_spec.rb' - 'spec/lib/gitlab/import_export/base/object_builder_spec.rb' - 'spec/lib/gitlab/import_export/base/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/command_line_util_spec.rb' - - 'spec/lib/gitlab/import_export/config_spec.rb' - 'spec/lib/gitlab/import_export/decompressed_archive_size_validator_spec.rb' - 'spec/lib/gitlab/import_export/design_repo_restorer_spec.rb' - 'spec/lib/gitlab/import_export/design_repo_saver_spec.rb' - 'spec/lib/gitlab/import_export/duration_measuring_spec.rb' - 'spec/lib/gitlab/import_export/error_spec.rb' - - 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb' - 'spec/lib/gitlab/import_export/file_importer_spec.rb' - 'spec/lib/gitlab/import_export/fork_spec.rb' - 'spec/lib/gitlab/import_export/group/object_builder_spec.rb' @@ -4944,7 +4870,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/import_export/importer_spec.rb' - 'spec/lib/gitlab/import_export/json/legacy_reader/file_spec.rb' - 'spec/lib/gitlab/import_export/json/legacy_reader/hash_spec.rb' - - 'spec/lib/gitlab/import_export/json/legacy_writer_spec.rb' - 'spec/lib/gitlab/import_export/json/ndjson_reader_spec.rb' - 'spec/lib/gitlab/import_export/json/ndjson_writer_spec.rb' - 'spec/lib/gitlab/import_export/legacy_relation_tree_saver_spec.rb' @@ -4953,7 +4878,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/import_export/log_util_spec.rb' - 'spec/lib/gitlab/import_export/members_mapper_spec.rb' - 'spec/lib/gitlab/import_export/merge_request_parser_spec.rb' - - 'spec/lib/gitlab/import_export/model_configuration_spec.rb' - 'spec/lib/gitlab/import_export/project/export_task_spec.rb' - 'spec/lib/gitlab/import_export/project/exported_relations_merger_spec.rb' - 'spec/lib/gitlab/import_export/project/import_task_spec.rb' @@ -4962,10 +4886,8 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/import_export/project/sample/date_calculator_spec.rb' - 'spec/lib/gitlab/import_export/project/sample/relation_factory_spec.rb' - 'spec/lib/gitlab/import_export/project/sample/relation_tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' - 'spec/lib/gitlab/import_export/reader_spec.rb' - 'spec/lib/gitlab/import_export/recursive_merge_folders_spec.rb' - - 'spec/lib/gitlab/import_export/references_configuration_spec.rb' - 'spec/lib/gitlab/import_export/remote_stream_upload_spec.rb' - 'spec/lib/gitlab/import_export/repo_restorer_spec.rb' - 'spec/lib/gitlab/import_export/repo_saver_spec.rb' @@ -5097,14 +5019,12 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/memory/upload_and_cleanup_reports_spec.rb' - 'spec/lib/gitlab/memory/watchdog/configuration_spec.rb' - 'spec/lib/gitlab/memory/watchdog/monitor/heap_fragmentation_spec.rb' - - 'spec/lib/gitlab/memory/watchdog/monitor/rss_memory_limit_spec.rb' - 'spec/lib/gitlab/memory/watchdog/monitor/unique_memory_growth_spec.rb' - 'spec/lib/gitlab/memory/watchdog/monitor_state_spec.rb' - 'spec/lib/gitlab/merge_requests/mergeability/check_result_spec.rb' - 'spec/lib/gitlab/merge_requests/mergeability/redis_interface_spec.rb' - 'spec/lib/gitlab/merge_requests/mergeability/results_store_spec.rb' - 'spec/lib/gitlab/metrics/background_transaction_spec.rb' - - 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/cache_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/defaults_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/finder_spec.rb' @@ -5175,7 +5095,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/multi_destination_logger_spec.rb' - 'spec/lib/gitlab/namespaced_session_store_spec.rb' - 'spec/lib/gitlab/nav/top_nav_menu_header_spec.rb' - - 'spec/lib/gitlab/net_http_adapter_spec.rb' - 'spec/lib/gitlab/no_cache_headers_spec.rb' - 'spec/lib/gitlab/noteable_metadata_spec.rb' - 'spec/lib/gitlab/null_request_store_spec.rb' @@ -5320,7 +5239,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/safe_request_purger_spec.rb' - 'spec/lib/gitlab/safe_request_store_spec.rb' - 'spec/lib/gitlab/sample_data_template_spec.rb' - - 'spec/lib/gitlab/sanitizers/exception_message_spec.rb' - 'spec/lib/gitlab/sanitizers/exif_spec.rb' - 'spec/lib/gitlab/sanitizers/svg_spec.rb' - 'spec/lib/gitlab/search/abuse_detection_spec.rb' @@ -5642,7 +5560,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/prometheus/cleanup_multiproc_dir_service_spec.rb' - 'spec/lib/prometheus/pid_provider_spec.rb' - 'spec/lib/quality/seeders/issues_spec.rb' - - 'spec/lib/release_highlights/validator/entry_spec.rb' - 'spec/lib/rouge/formatters/html_gitlab_spec.rb' - 'spec/lib/safe_zip/entry_spec.rb' - 'spec/lib/safe_zip/extract_params_spec.rb' @@ -5703,7 +5620,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/system_check/sidekiq_check_spec.rb' - 'spec/lib/system_check/simple_executor_spec.rb' - 'spec/lib/system_check_spec.rb' - - 'spec/lib/tasks/gitlab/metrics_exporter_task_spec.rb' - 'spec/lib/unnested_in_filters/dsl_spec.rb' - 'spec/lib/unnested_in_filters/rewriter_spec.rb' - 'spec/lib/uploaded_file_spec.rb' @@ -5773,7 +5689,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/board_project_recent_visit_spec.rb' - 'spec/models/board_spec.rb' - 'spec/models/broadcast_message_spec.rb' - - 'spec/models/bulk_import_spec.rb' - 'spec/models/bulk_imports/configuration_spec.rb' - 'spec/models/bulk_imports/export_spec.rb' - 'spec/models/bulk_imports/export_status_spec.rb' @@ -5797,7 +5712,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/ci/daily_build_group_report_result_spec.rb' - 'spec/models/ci/deleted_object_spec.rb' - 'spec/models/ci/group_spec.rb' - - 'spec/models/ci/group_variable_spec.rb' - 'spec/models/ci/instance_variable_spec.rb' - 'spec/models/ci/namespace_mirror_spec.rb' - 'spec/models/ci/pending_build_spec.rb' @@ -5819,7 +5733,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/ci/trigger_request_spec.rb' - 'spec/models/ci/unit_test_failure_spec.rb' - 'spec/models/ci/unit_test_spec.rb' - - 'spec/models/ci/variable_spec.rb' - 'spec/models/clusters/agent_spec.rb' - 'spec/models/clusters/agent_token_spec.rb' - 'spec/models/clusters/agents/activity_event_spec.rb' @@ -5842,7 +5755,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/clusters/project_spec.rb' - 'spec/models/clusters/providers/aws_spec.rb' - 'spec/models/clusters/providers/gcp_spec.rb' - - 'spec/models/commit_collection_spec.rb' - 'spec/models/commit_range_spec.rb' - 'spec/models/commit_signatures/gpg_signature_spec.rb' - 'spec/models/commit_signatures/x509_commit_signature_spec.rb' @@ -5898,7 +5810,6 @@ RSpec/MissingFeatureCategory: - 'spec/models/concerns/from_union_spec.rb' - 'spec/models/concerns/group_descendant_spec.rb' - 'spec/models/concerns/has_environment_scope_spec.rb' - - 'spec/models/concerns/has_user_type_spec.rb' - 'spec/models/concerns/id_in_ordered_spec.rb' - 'spec/models/concerns/ignorable_columns_spec.rb' - 'spec/models/concerns/integrations/enable_ssl_verification_spec.rb' @@ -6413,7 +6324,6 @@ RSpec/MissingFeatureCategory: - 'spec/presenters/ci/variable_presenter_spec.rb' - 'spec/presenters/clusterable_presenter_spec.rb' - 'spec/presenters/clusters/cluster_presenter_spec.rb' - - 'spec/presenters/commit_presenter_spec.rb' - 'spec/presenters/commit_status_presenter_spec.rb' - 'spec/presenters/deploy_key_presenter_spec.rb' - 'spec/presenters/deployments/deployment_presenter_spec.rb' @@ -6632,7 +6542,6 @@ RSpec/MissingFeatureCategory: - 'spec/scripts/changed-feature-flags_spec.rb' - 'spec/scripts/failed_tests_spec.rb' - 'spec/scripts/lib/glfm/parse_examples_spec.rb' - - 'spec/scripts/lib/glfm/shared_spec.rb' - 'spec/scripts/lib/glfm/verify_all_generated_files_are_up_to_date_spec.rb' - 'spec/scripts/setup/find_jh_branch_spec.rb' - 'spec/serializers/access_token_entity_base_spec.rb' @@ -6824,69 +6733,15 @@ RSpec/MissingFeatureCategory: - 'spec/serializers/web_ide_terminal_entity_spec.rb' - 'spec/serializers/web_ide_terminal_serializer_spec.rb' - 'spec/services/access_token_validation_service_spec.rb' - - 'spec/services/admin/set_feature_flag_service_spec.rb' - - 'spec/services/alert_management/alerts/todo/create_service_spec.rb' - - 'spec/services/alert_management/alerts/update_service_spec.rb' - - 'spec/services/alert_management/create_alert_issue_service_spec.rb' - - 'spec/services/alert_management/http_integrations/create_service_spec.rb' - - 'spec/services/alert_management/http_integrations/destroy_service_spec.rb' - - 'spec/services/alert_management/http_integrations/update_service_spec.rb' - - 'spec/services/alert_management/metric_images/upload_service_spec.rb' - - 'spec/services/alert_management/process_prometheus_alert_service_spec.rb' - - 'spec/services/analytics/cycle_analytics/stages/list_service_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - 'spec/services/applications/create_service_spec.rb' - 'spec/services/audit_event_service_spec.rb' - - 'spec/services/audit_events/build_service_spec.rb' - - 'spec/services/auth/container_registry_authentication_service_spec.rb' - - 'spec/services/auth/dependency_proxy_authentication_service_spec.rb' - - 'spec/services/authorized_project_update/find_records_due_for_refresh_service_spec.rb' - - 'spec/services/authorized_project_update/periodic_recalculate_service_spec.rb' - - 'spec/services/authorized_project_update/project_access_changed_service_spec.rb' - - 'spec/services/authorized_project_update/project_recalculate_per_user_service_spec.rb' - - 'spec/services/authorized_project_update/project_recalculate_service_spec.rb' - - 'spec/services/auto_merge/base_service_spec.rb' - - 'spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb' - 'spec/services/auto_merge_service_spec.rb' - - 'spec/services/award_emojis/add_service_spec.rb' - - 'spec/services/award_emojis/base_service_spec.rb' - - 'spec/services/award_emojis/collect_user_emoji_service_spec.rb' - - 'spec/services/award_emojis/copy_service_spec.rb' - - 'spec/services/award_emojis/destroy_service_spec.rb' - - 'spec/services/award_emojis/toggle_service_spec.rb' - 'spec/services/base_container_service_spec.rb' - 'spec/services/base_count_service_spec.rb' - - 'spec/services/boards/create_service_spec.rb' - - 'spec/services/boards/destroy_service_spec.rb' - - 'spec/services/boards/issues/create_service_spec.rb' - - 'spec/services/boards/issues/list_service_spec.rb' - - 'spec/services/boards/issues/move_service_spec.rb' - - 'spec/services/boards/lists/create_service_spec.rb' - - 'spec/services/boards/lists/destroy_service_spec.rb' - - 'spec/services/boards/lists/list_service_spec.rb' - - 'spec/services/boards/lists/move_service_spec.rb' - - 'spec/services/boards/lists/update_service_spec.rb' - - 'spec/services/boards/visits/create_service_spec.rb' - - 'spec/services/branches/create_service_spec.rb' - - 'spec/services/branches/delete_merged_service_spec.rb' - - 'spec/services/branches/delete_service_spec.rb' - - 'spec/services/branches/diverging_commit_counts_service_spec.rb' - - 'spec/services/branches/validate_new_service_spec.rb' - 'spec/services/bulk_create_integration_service_spec.rb' - - 'spec/services/bulk_imports/archive_extraction_service_spec.rb' - - 'spec/services/bulk_imports/export_service_spec.rb' - - 'spec/services/bulk_imports/file_decompression_service_spec.rb' - - 'spec/services/bulk_imports/file_download_service_spec.rb' - - 'spec/services/bulk_imports/file_export_service_spec.rb' - - 'spec/services/bulk_imports/lfs_objects_export_service_spec.rb' - - 'spec/services/bulk_imports/relation_export_service_spec.rb' - - 'spec/services/bulk_imports/repository_bundle_export_service_spec.rb' - - 'spec/services/bulk_imports/tree_export_service_spec.rb' - - 'spec/services/bulk_imports/uploads_export_service_spec.rb' - 'spec/services/bulk_push_event_payload_service_spec.rb' - 'spec/services/bulk_update_integration_service_spec.rb' - - 'spec/services/captcha/captcha_verification_service_spec.rb' - - 'spec/services/chat_names/find_user_service_spec.rb' - 'spec/services/ci/abort_pipelines_service_spec.rb' - 'spec/services/ci/append_build_trace_service_spec.rb' - 'spec/services/ci/build_cancel_service_spec.rb' @@ -6976,7 +6831,6 @@ RSpec/MissingFeatureCategory: - 'spec/services/ci/update_build_queue_service_spec.rb' - 'spec/services/ci/update_instance_variables_service_spec.rb' - 'spec/services/ci/update_pending_build_service_spec.rb' - - 'spec/services/clusters/agent_tokens/create_service_spec.rb' - 'spec/services/clusters/agent_tokens/track_usage_service_spec.rb' - 'spec/services/clusters/agents/create_activity_event_service_spec.rb' - 'spec/services/clusters/agents/create_service_spec.rb' @@ -7113,7 +6967,6 @@ RSpec/MissingFeatureCategory: - 'spec/services/import/gitlab_projects/file_acquisition_strategies/file_upload_spec.rb' - 'spec/services/import/gitlab_projects/file_acquisition_strategies/remote_file_s3_spec.rb' - 'spec/services/import/prepare_service_spec.rb' - - 'spec/services/import/validate_remote_git_endpoint_service_spec.rb' - 'spec/services/import_export_clean_up_service_spec.rb' - 'spec/services/incident_management/incidents/create_service_spec.rb' - 'spec/services/incident_management/issuable_escalation_statuses/after_update_service_spec.rb' @@ -7437,7 +7290,6 @@ RSpec/MissingFeatureCategory: - 'spec/services/repositories/destroy_service_spec.rb' - 'spec/services/repository_archive_clean_up_service_spec.rb' - 'spec/services/reset_project_cache_service_spec.rb' - - 'spec/services/resource_access_tokens/create_service_spec.rb' - 'spec/services/resource_access_tokens/revoke_service_spec.rb' - 'spec/services/resource_events/change_milestone_service_spec.rb' - 'spec/services/resource_events/change_state_service_spec.rb' @@ -7479,7 +7331,6 @@ RSpec/MissingFeatureCategory: - 'spec/services/system_hooks_service_spec.rb' - 'spec/services/system_notes/alert_management_service_spec.rb' - 'spec/services/system_notes/base_service_spec.rb' - - 'spec/services/system_notes/commit_service_spec.rb' - 'spec/services/system_notes/design_management_service_spec.rb' - 'spec/services/system_notes/incident_service_spec.rb' - 'spec/services/system_notes/incidents_service_spec.rb' diff --git a/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue b/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue index f2bc4796324..2f29d96d85e 100644 --- a/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue +++ b/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue @@ -65,7 +65,7 @@ export default { releasesHelpText: s__( 'ProjectSettings|Combine git tags with release notes, release evidence, and assets to create a release.', ), - securityAndComplianceLabel: s__('ProjectSettings|Security & Compliance'), + securityAndComplianceLabel: s__('ProjectSettings|Security and Compliance'), snippetsLabel: s__('ProjectSettings|Snippets'), wikiLabel: s__('ProjectSettings|Wiki'), pucWarningLabel: s__('ProjectSettings|Warn about Potentially Unwanted Characters'), @@ -825,7 +825,7 @@ export default { </project-setting-row> <project-setting-row :label="$options.i18n.securityAndComplianceLabel" - :help-text="s__('ProjectSettings|Security & Compliance for this project')" + :help-text="s__('ProjectSettings|Security and compliance for this project.')" > <project-feature-setting v-model="securityAndComplianceAccessLevel" diff --git a/app/views/projects/merge_requests/_page.html.haml b/app/views/projects/merge_requests/_page.html.haml index 47760211bd5..83b56d81a45 100644 --- a/app/views/projects/merge_requests/_page.html.haml +++ b/app/views/projects/merge_requests/_page.html.haml @@ -90,7 +90,7 @@ = render "projects/merge_requests/tabs/pane", name: "pipelines", id: "pipelines", class: "pipelines" do - if @project.builds_enabled? = render 'projects/commit/pipelines_list', disable_initialization: true, endpoint: pipelines_project_merge_request_path(@project, @merge_request) - - params = request.query_parameters.merge(diff_head: true) + - params = request.query_parameters.merge(ck: @diffs_batch_cache_key, diff_head: true) = render "projects/merge_requests/tabs/pane", name: "diffs", id: "js-diffs-app", class: "diffs", data: diffs_tab_pane_data(@project, @merge_request, params) .mr-loading-status diff --git a/doc/administration/audit_event_streaming.md b/doc/administration/audit_event_streaming.md index 92ccbe8b1a6..f2626a5d969 100644 --- a/doc/administration/audit_event_streaming.md +++ b/doc/administration/audit_event_streaming.md @@ -41,7 +41,7 @@ Streaming destinations receive **all** audit event data, which could include sen Users with the Owner role for a group can add streaming destinations for it: 1. On the top bar, select **Main menu > Groups** and find your group. -1. On the left sidebar, select **Security & Compliance > Audit events**. +1. On the left sidebar, select **Security and Compliance > Audit events**. 1. On the main area, select **Streams** tab. 1. Select **Add streaming destination** to show the section for adding destinations. 1. Enter the destination URL to add. @@ -119,7 +119,7 @@ Users with the Owner role for a group can list streaming destinations. To list the streaming destinations: 1. On the top bar, select **Main menu > Groups** and find your group. -1. On the left sidebar, select **Security & Compliance > Audit events**. +1. On the left sidebar, select **Security and Compliance > Audit events**. 1. On the main area, select **Streams** tab. 1. To the right of the item, select **Edit** (**{pencil}**) to see all the custom HTTP headers. @@ -164,7 +164,7 @@ Users with the Owner role for a group can update streaming destinations. To update a streaming destinations custom HTTP headers: 1. On the top bar, select **Main menu > Groups** and find your group. -1. On the left sidebar, select **Security & Compliance > Audit events**. +1. On the left sidebar, select **Security and Compliance > Audit events**. 1. On the main area, select **Streams** tab. 1. To the right of the item, select **Edit** (**{pencil}**). 1. Locate the **Custom HTTP headers** table. @@ -218,14 +218,14 @@ When the last destination is successfully deleted, streaming is disabled for the To delete a streaming destination: 1. On the top bar, select **Main menu > Groups** and find your group. -1. On the left sidebar, select **Security & Compliance > Audit events**. +1. On the left sidebar, select **Security and Compliance > Audit events**. 1. On the main area, select the **Streams** tab. 1. To the right of the item, select **Delete** (**{remove}**). To delete only the custom HTTP headers for a streaming destination: 1. On the top bar, select **Main menu > Groups** and find your group. -1. On the left sidebar, select **Security & Compliance > Audit events**. +1. On the left sidebar, select **Security and Compliance > Audit events**. 1. On the main area, select the **Streams** tab. 1. To the right of the item, **Edit** (**{pencil}**). 1. Locate the **Custom HTTP headers** table. @@ -282,7 +282,7 @@ the destination's value when [listing streaming destinations](#list-streaming-de Users with the Owner role for a group can list streaming destinations and see the verification tokens: 1. On the top bar, select **Main menu > Groups** and find your group. -1. On the left sidebar, select **Security & Compliance > Audit events**. +1. On the left sidebar, select **Security and Compliance > Audit events**. 1. On the main area, select the **Streams**. 1. View the verification token on the right side of each item. diff --git a/doc/administration/audit_events.md b/doc/administration/audit_events.md index 623ecc841ed..47833224c0a 100644 --- a/doc/administration/audit_events.md +++ b/doc/administration/audit_events.md @@ -49,7 +49,7 @@ You can view audit events scoped to a group or project. To view a group's audit events: 1. Go to the group. -1. On the left sidebar, select **Security & Compliance > Audit Events**. +1. On the left sidebar, select **Security and Compliance > Audit Events**. Group events do not include project audit events. Group events can also be accessed using the [Group Audit Events API](../api/audit_events.md#group-audit-events). Group event queries are limited to a maximum of 30 diff --git a/doc/ci/runners/index.md b/doc/ci/runners/index.md index 41cde709143..d3bbd7d8816 100644 --- a/doc/ci/runners/index.md +++ b/doc/ci/runners/index.md @@ -20,7 +20,7 @@ in your [subscription plan](https://about.gitlab.com/pricing/). ## Security for GitLab SaaS runners -GitLab SaaS runners on Linux and Windows run on Google Compute Platform. The [Google Infrastructure Security Design Overview whitepaper](https://cloud.google.com/docs/security/infrastructure/design/resources/google_infrastructure_whitepaper_fa.pdf) provides an overview of how Google designs security into its technical infrastructure. The GitLab [Trust Center](https://about.gitlab.com/security/) and [GitLab Security Compliance Controls](https://about.staging.gitlab.com/handbook/engineering/security/security-assurance/security-compliance/sec-controls.html) pages provide an overview of the Security and Compliance controls that govern the GitLab SaaS runners. +GitLab SaaS runners on Linux and Windows run on Google Compute Platform. The [Google Infrastructure Security Design Overview whitepaper](https://cloud.google.com/docs/security/infrastructure/design/resources/google_infrastructure_whitepaper_fa.pdf) provides an overview of how Google designs security into its technical infrastructure. The GitLab [Trust Center](https://about.gitlab.com/security/) and [GitLab Security Compliance Controls](https://about.staging.gitlab.com/handbook/engineering/security/security-assurance/security-compliance/sec-controls.html) pages provide an overview of the security and compliance controls that govern the GitLab SaaS runners. The runner that serves as a Runner Manager automatically initiates the creation and deletion of the virtual machines (VMs) used for CI jobs. When the Runner Manager picks up a GitLab SaaS CI job, it automatically executes that job on a new VM. There is no human or manual intervention in this process. The following section provides an overview of the additional built-in layers that harden the security of the GitLab Runner SaaS CI build environment. diff --git a/doc/ci/yaml/index.md b/doc/ci/yaml/index.md index 9a4c1711516..083df241958 100644 --- a/doc/ci/yaml/index.md +++ b/doc/ci/yaml/index.md @@ -1941,9 +1941,8 @@ rspec: ### `hooks` -> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/381840) in GitLab 15.6 [with a flag](../../administration/feature_flags.md) named `ci_hooks_pre_get_sources_script`. Disabled by default. -> - [Enabled on GitLab.com](https://gitlab.com/gitlab-org/gitlab/-/issues/381840) in GitLab 15.9. -> - [Generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/381840-link) in GitLab 15.10. Feature flag `ci_hooks_pre_get_sources_script` removed. +> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/356850) in GitLab 15.6 [with a flag](../../administration/feature_flags.md) named `ci_hooks_pre_get_sources_script`. Disabled by default. +> - [Generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/381840) in GitLab 15.10. Feature flag `ci_hooks_pre_get_sources_script` removed. Use `hooks` to specify lists of commands to execute on the runner at certain stages of job execution, like before retrieving the Git repository. @@ -1957,9 +1956,8 @@ at certain stages of job execution, like before retrieving the Git repository. #### `hooks:pre_get_sources_script` -> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/381840) in GitLab 15.6 [with a flag](../../administration/feature_flags.md) named `ci_hooks_pre_get_sources_script`. Disabled by default. -> - [Enabled on GitLab.com](https://gitlab.com/gitlab-org/gitlab/-/issues/381840) in GitLab 15.9. -> - [Generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/381840-link) in GitLab 15.10. Feature flag `ci_hooks_pre_get_sources_script` removed. +> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/356850) in GitLab 15.6 [with a flag](../../administration/feature_flags.md) named `ci_hooks_pre_get_sources_script`. Disabled by default. +> - [Generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/381840) in GitLab 15.10. Feature flag `ci_hooks_pre_get_sources_script` removed. Use `hooks:pre_get_sources_script` to specify a list of commands to execute on the runner before retrieving the Git repository and any submodules. You can use it diff --git a/doc/development/permissions.md b/doc/development/permissions.md index bf7f99de1ab..6ce2b855e64 100644 --- a/doc/development/permissions.md +++ b/doc/development/permissions.md @@ -60,7 +60,7 @@ Additionally, the following project features can have different visibility level - Pipelines - Analytics - Requirements -- Security & Compliance +- Security and Compliance - Wiki - Snippets - Pages diff --git a/doc/user/admin_area/custom_project_templates.md b/doc/user/admin_area/custom_project_templates.md index 847f687d051..78819def5de 100644 --- a/doc/user/admin_area/custom_project_templates.md +++ b/doc/user/admin_area/custom_project_templates.md @@ -18,7 +18,7 @@ is created, based on the user's access permissions: - Public projects can be selected by any authenticated user as a template for a new project, if all enabled [project features](../project/settings/index.md#configure-project-visibility-features-and-permissions) - except for **GitLab Pages** and **Security & Compliance** are set to **Everyone With Access**. + except for **GitLab Pages** and **Security and Compliance** are set to **Everyone With Access**. The same applies to internal projects. - Private projects can be selected only by users who are members of the projects. diff --git a/doc/user/application_security/api_fuzzing/index.md b/doc/user/application_security/api_fuzzing/index.md index b55c5a1b299..e6fb994d9b7 100644 --- a/doc/user/application_security/api_fuzzing/index.md +++ b/doc/user/application_security/api_fuzzing/index.md @@ -98,7 +98,7 @@ a YAML snippet that you can paste in your GitLab CI/CD configuration. To generate an API Fuzzing configuration snippet: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Configuration**. +1. On the left sidebar, select **Security and Compliance > Configuration**. 1. In the **API Fuzzing** row, select **Enable API Fuzzing**. 1. Complete the fields. For details see [Available CI/CD variables](#available-cicd-variables). 1. Select **Generate code snippet**. @@ -1994,7 +1994,7 @@ When configured correctly, a CI/CD pipeline contains a `fuzz` stage and an `apif typical operation, the job always succeeds even if faults are identified during fuzz testing. Faults are displayed on the **Security** pipeline tab with the suite name. When testing against the -repositories default branch, the fuzzing faults are also shown on the Security & Compliance's +repositories default branch, the fuzzing faults are also shown on the Security and Compliance's Vulnerability Report page. To prevent an excessive number of reported faults, the API fuzzing scanner limits the number of @@ -2026,7 +2026,7 @@ Follow these steps to view details of a fuzzing fault: 1. You can view faults in a project, or a merge request: - - In a project, go to the project's **Security & Compliance > Vulnerability Report** + - In a project, go to the project's **Security and Compliance > Vulnerability Report** page. This page shows all vulnerabilities from the default branch only. - In a merge request, go the merge request's **Security** section and select the **Expand** button. API Fuzzing faults are available in a section labeled diff --git a/doc/user/application_security/configuration/index.md b/doc/user/application_security/configuration/index.md index ea422f0b33c..f0ca5173275 100644 --- a/doc/user/application_security/configuration/index.md +++ b/doc/user/application_security/configuration/index.md @@ -41,7 +41,7 @@ all security features are configured by default. To view a project's security configuration: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Configuration**. +1. On the left sidebar, select **Security and Compliance > Configuration**. Select **Configuration history** to see the `.gitlab-ci.yml` file's history. diff --git a/doc/user/application_security/container_scanning/index.md b/doc/user/application_security/container_scanning/index.md index b37aa53e48a..d76f5ebcfba 100644 --- a/doc/user/application_security/container_scanning/index.md +++ b/doc/user/application_security/container_scanning/index.md @@ -328,7 +328,7 @@ To enable Container Scanning in a project, create a merge request from the Secur page: 1. In the project where you want to enable Container Scanning, go to - **Security & Compliance > Configuration**. + **Security and Compliance > Configuration**. 1. In the **Container Scanning** row, select **Configure with a merge request**. This automatically creates a merge request with the changes necessary to enable Container Scanning. diff --git a/doc/user/application_security/coverage_fuzzing/index.md b/doc/user/application_security/coverage_fuzzing/index.md index 5d2593a1bed..820c150597a 100644 --- a/doc/user/application_security/coverage_fuzzing/index.md +++ b/doc/user/application_security/coverage_fuzzing/index.md @@ -54,7 +54,7 @@ You can use the following fuzzing engines to test the specified languages. To confirm the status of coverage-guided fuzz testing: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Configuration**. +1. On the left sidebar, select **Security and Compliance > Configuration**. 1. In the **Coverage Fuzzing** section the status is: - **Not configured** - **Enabled** @@ -168,7 +168,7 @@ artifacts files you can download from the CI/CD pipeline. Also, a project member To view details of the corpus registry: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Configuration**. +1. On the left sidebar, select **Security and Compliance > Configuration**. 1. In the **Coverage Fuzzing** section, select **Manage corpus**. ### Create a corpus in the corpus registry @@ -196,7 +196,7 @@ provided by the `COVFUZZ_CORPUS_NAME` variable. The corpus is updated on every p To upload an existing corpus file: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Configuration**. +1. On the left sidebar, select **Security and Compliance > Configuration**. 1. In the **Coverage Fuzzing** section, select **Manage corpus**. 1. Select **New corpus**. 1. Complete the fields. diff --git a/doc/user/application_security/dast_api/index.md b/doc/user/application_security/dast_api/index.md index 0cdbb879cfc..c663beab2e5 100644 --- a/doc/user/application_security/dast_api/index.md +++ b/doc/user/application_security/dast_api/index.md @@ -1924,7 +1924,7 @@ variables: When configured correctly, a CI/CD pipeline contains a `dast` stage and an `dast_api` job. The job only fails when an invalid configuration is provided. During typical operation, the job always succeeds even if vulnerabilities are identified during testing. -Vulnerabilities are displayed on the **Security** pipeline tab with the suite name. When testing against the repositories default branch, the DAST API vulnerabilities are also shown on the Security & Compliance's Vulnerability Report page. +Vulnerabilities are displayed on the **Security** pipeline tab with the suite name. When testing against the repositories default branch, the DAST API vulnerabilities are also shown on the Security and Compliance's Vulnerability Report page. To prevent an excessive number of reported vulnerabilities, the DAST API scanner limits the number of vulnerabilities it reports per operation. @@ -1941,7 +1941,7 @@ Follow these steps to view details of a vulnerability: 1. You can view vulnerabilities in a project, or a merge request: - - In a project, go to the project's **Security & Compliance > Vulnerability Report** + - In a project, go to the project's **Security and Compliance > Vulnerability Report** page. This page shows all vulnerabilities from the default branch only. - In a merge request, go the merge request's **Security** section and select the **Expand** button. DAST API vulnerabilities are available in a section labeled diff --git a/doc/user/application_security/dependency_list/index.md b/doc/user/application_security/dependency_list/index.md index b86d98471ac..f46c5e5e801 100644 --- a/doc/user/application_security/dependency_list/index.md +++ b/doc/user/application_security/dependency_list/index.md @@ -13,7 +13,7 @@ info: To determine the technical writer assigned to the Stage/Group associated w Use the dependency list to review your project's dependencies and key details about those dependencies, including their known vulnerabilities. It is a collection of dependencies in your project, including existing and new findings. -To see the dependency list, go to your project and select **Security & Compliance > Dependency list**. +To see the dependency list, go to your project and select **Security and Compliance > Dependency list**. This information is sometimes referred to as a Software Bill of Materials, SBOM, or BOM. diff --git a/doc/user/application_security/dependency_scanning/index.md b/doc/user/application_security/dependency_scanning/index.md index 579dd4dfc4f..ccca3c90c67 100644 --- a/doc/user/application_security/dependency_scanning/index.md +++ b/doc/user/application_security/dependency_scanning/index.md @@ -553,7 +553,7 @@ always take the latest dependency scanning artifact available. To enable Dependency Scanning in a project, you can create a merge request: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Configuration**. +1. On the left sidebar, select **Security and Compliance > Configuration**. 1. In the **Dependency Scanning** row, select **Configure with a merge request**. 1. Review and merge the merge request to enable Dependency Scanning. diff --git a/doc/user/application_security/iac_scanning/index.md b/doc/user/application_security/iac_scanning/index.md index c2f1257f989..907248b7d65 100644 --- a/doc/user/application_security/iac_scanning/index.md +++ b/doc/user/application_security/iac_scanning/index.md @@ -119,7 +119,7 @@ that you can download and analyze. To enable IaC Scanning in a project, you can create a merge request: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Configuration**. +1. On the left sidebar, select **Security and Compliance > Configuration**. 1. In the **Infrastructure as Code (IaC) Scanning** row, select **Configure with a merge request**. 1. Review and merge the merge request to enable IaC Scanning. diff --git a/doc/user/application_security/policies/index.md b/doc/user/application_security/policies/index.md index be10be8e707..1f53b671ed1 100644 --- a/doc/user/application_security/policies/index.md +++ b/doc/user/application_security/policies/index.md @@ -13,7 +13,7 @@ info: To determine the technical writer assigned to the Stage/Group associated w Policies in GitLab provide security teams a way to require scans of their choice to be run whenever a project pipeline runs according to the configuration specified. Security teams can therefore be confident that the scans they set up have not been changed, altered, or disabled. You -can access these by navigating to your project's **Security & Compliance > Policies** page. +can access these by navigating to your project's **Security and Compliance > Policies** page. GitLab supports the following security policies: @@ -59,7 +59,7 @@ As a project owner, take the following steps to create or edit an association be project and a project that you would like to designate as the security policy project: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Policies**. +1. On the left sidebar, select **Security and Compliance > Policies**. 1. Select **Edit Policy Project**, and search for and select the project you would like to link from the dropdown list. 1. Select **Save**. @@ -83,7 +83,7 @@ policy's information (for example, description or enforcement status), and create and edit deployed policies: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Policies**. +1. On the left sidebar, select **Security and Compliance > Policies**.  @@ -94,7 +94,7 @@ status), and create and edit deployed policies: You can use the policy editor to create, edit, and delete policies: 1. On the top bar, select **Main menu > Projects** and find your group. -1. On the left sidebar, select **Security & Compliance > Policies**. +1. On the left sidebar, select **Security and Compliance > Policies**. - To create a new policy, select **New policy** which is located in the **Policies** page's header. You can then select which type of policy to create. - To edit an existing policy, select **Edit policy** in the selected policy drawer. diff --git a/doc/user/application_security/sast/index.md b/doc/user/application_security/sast/index.md index b0d84e4cff9..7cb381fe7e5 100644 --- a/doc/user/application_security/sast/index.md +++ b/doc/user/application_security/sast/index.md @@ -303,7 +303,7 @@ successfully, and an error may occur. To enable and configure SAST with customizations: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Configuration**. +1. On the left sidebar, select **Security and Compliance > Configuration**. 1. If the project does not have a `.gitlab-ci.yml` file, select **Enable SAST** in the Static Application Security Testing (SAST) row, otherwise select **Configure SAST**. 1. Enter the custom SAST values. @@ -330,7 +330,7 @@ successfully, and an error may occur. To enable and configure SAST with default settings: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance** > **Configuration**. +1. On the left sidebar, select **Security and Compliance** > **Configuration**. 1. In the SAST section, select **Configure with a merge request**. 1. Review and merge the merge request to enable SAST. diff --git a/doc/user/application_security/secret_detection/index.md b/doc/user/application_security/secret_detection/index.md index d6aab71a2c6..3155114d98a 100644 --- a/doc/user/application_security/secret_detection/index.md +++ b/doc/user/application_security/secret_detection/index.md @@ -185,7 +185,7 @@ error may occur. In that case, use the [manual](#edit-the-gitlabciyml-file-manua To enable Secret Detection automatically: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Configuration**. +1. On the left sidebar, select **Security and compliance > Configuration**. 1. In the **Secret Detection** row, select **Configure with a merge request**. 1. Optional. Complete the fields. 1. Select **Create merge request**. diff --git a/doc/user/application_security/security_dashboard/index.md b/doc/user/application_security/security_dashboard/index.md index 398c86d094a..4b9aeefcfe9 100644 --- a/doc/user/application_security/security_dashboard/index.md +++ b/doc/user/application_security/security_dashboard/index.md @@ -64,7 +64,7 @@ Project Security Dashboards show statistics for all vulnerabilities with a curre To view total number of vulnerabilities over time: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Security Dashboard**. +1. On the left sidebar, select **Security and Compliance > Security Dashboard**. 1. Filter and search for what you need. - To filter the chart by severity, select the legend name. - To view a specific time frame, use the time range handles (**{scroll-handle}**). @@ -77,7 +77,7 @@ To view total number of vulnerabilities over time: To download an SVG image of the vulnerabilities chart: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Security dashboard**. +1. On the left sidebar, select **Security and Compliance > Security dashboard**. 1. Select **Save chart as an image** (**{download}**). ## View vulnerabilities over time for a group diff --git a/doc/user/application_security/vulnerabilities/index.md b/doc/user/application_security/vulnerabilities/index.md index c13f8ccc18e..ede86f29fc9 100644 --- a/doc/user/application_security/vulnerabilities/index.md +++ b/doc/user/application_security/vulnerabilities/index.md @@ -54,7 +54,7 @@ no longer detected, and change their status. To change a vulnerability's status from its Vulnerability Page: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Vulnerability report**. +1. On the left sidebar, select **Security and Compliance > Vulnerability report**. 1. Select the vulnerability's description. 1. From the **Status** dropdown list select a status, then select **Change status**. 1. Optionally, at the bottom of the page, add a comment to the log entry. @@ -80,7 +80,7 @@ that when Jira integration is enabled, the GitLab issue feature is not available To create a GitLab issue for a vulnerability: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Vulnerability report**. +1. On the left sidebar, select **Security and Compliance > Vulnerability report**. 1. Select the vulnerability's description. 1. Select **Create issue**. @@ -102,7 +102,7 @@ Prerequisites: To create a Jira issue for a vulnerability: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Vulnerability report**. +1. On the left sidebar, select **Security and Compliance > Vulnerability report**. 1. Select the vulnerability's description. 1. Select **Create Jira issue**. 1. If you're not already logged in to Jira, sign in. @@ -135,7 +135,7 @@ Be aware of the following conditions between a vulnerability and a linked issue: To link a vulnerability to existing issues: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Vulnerability report**. +1. On the left sidebar, select **Security and Compliance > Vulnerability report**. 1. Select the vulnerability's description. 1. In the **Linked issues** section, select the plus icon (**{plus}**). 1. For each issue to be linked, either: @@ -170,7 +170,7 @@ To resolve a vulnerability, you can either: To resolve the vulnerability with a merge request: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Vulnerability report**. +1. On the left sidebar, select **Security and Compliance > Vulnerability report**. 1. Select the vulnerability's description. 1. From the **Resolve with merge request** dropdown list, select **Resolve with merge request**. @@ -182,7 +182,7 @@ Process the merge request according to your standard workflow. To manually apply the patch that GitLab generated for a vulnerability: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Vulnerability report**. +1. On the left sidebar, select **Security and Compliance > Vulnerability report**. 1. Select the vulnerability's description. 1. From the **Resolve with merge request** dropdown list, select **Download patch to resolve**. 1. Ensure your local project has the same commit checked out that was used to generate the patch. @@ -204,7 +204,7 @@ Security training helps your developers learn how to fix vulnerabilities. Develo To enable security training for vulnerabilities in your project: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Configuration**. +1. On the left sidebar, select **Security and Compliance > Configuration**. 1. On the tab bar, select **Vulnerability Management**. 1. To enable a security training provider, turn on the toggle. @@ -222,6 +222,6 @@ Vulnerabilities with a CWE are most likely to return a training result. To view the security training for a vulnerability: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Vulnerability report**. +1. On the left sidebar, select **Security and Compliance > Vulnerability report**. 1. Select the vulnerability for which you want to view security training. 1. Select **View training**. diff --git a/doc/user/application_security/vulnerability_report/index.md b/doc/user/application_security/vulnerability_report/index.md index 6b2f7f0655d..3d7565f97bc 100644 --- a/doc/user/application_security/vulnerability_report/index.md +++ b/doc/user/application_security/vulnerability_report/index.md @@ -45,7 +45,7 @@ At the project level, the Vulnerability Report also contains: To view the project-level vulnerability report: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Vulnerability report**. +1. On the left sidebar, select **Security and Compliance > Vulnerability report**. ## Vulnerability Report actions @@ -256,7 +256,7 @@ To undo this action, select a different status from the same menu. To add a new vulnerability finding from your project level Vulnerability Report page: 1. On the top bar, select **Main menu > Projects** and find your project. -1. On the left sidebar, select **Security & Compliance > Vulnerability Report**. +1. On the left sidebar, select **Security and Compliance > Vulnerability Report**. 1. Select **Submit vulnerability**. 1. Complete the fields and submit the form. diff --git a/doc/user/compliance/compliance_report/index.md b/doc/user/compliance/compliance_report/index.md index 5cd8012f78d..abf52be610c 100644 --- a/doc/user/compliance/compliance_report/index.md +++ b/doc/user/compliance/compliance_report/index.md @@ -32,7 +32,7 @@ Prerequisites: To view the compliance report: 1. On the top bar, select **Main menu > Groups** and find your group. -1. On the left sidebar, select **Security & Compliance > Compliance report**. +1. On the left sidebar, select **Security and Compliance > Compliance report**. ### Severity levels scale @@ -120,7 +120,7 @@ If the commit has a related merge commit, then the following are also included: To generate the Chain of Custody report: 1. On the top bar, select **Main menu > Groups** and find your group. -1. On the left sidebar, select **Security & Compliance > Compliance report**. +1. On the left sidebar, select **Security and Compliance > Compliance report**. 1. Select **List of all merge commits**. The Chain of Custody report is either: @@ -137,7 +137,7 @@ Authenticated group owners can generate a commit-specific Chain of Custody repor - Using the GitLab UI: 1. On the top bar, select **Main menu > Groups** and find your group. - 1. On the left sidebar, select **Security & Compliance > Compliance report**. + 1. On the left sidebar, select **Security and Compliance > Compliance report**. 1. At the top of the compliance report, to the right of **List of all merge commits**, select the down arrow (**{chevron-lg-down}**). 1. Enter the merge commit SHA, and then select **Export commit custody report**. SHA and then select **Export commit custody report**. diff --git a/doc/user/group/custom_project_templates.md b/doc/user/group/custom_project_templates.md index 2716db27037..d205e834e60 100644 --- a/doc/user/group/custom_project_templates.md +++ b/doc/user/group/custom_project_templates.md @@ -42,7 +42,7 @@ Projects in nested subgroups are not included in the template list. - Public and internal projects can be selected by any authenticated user as a template for a new project, if all [project features](../project/settings/index.md#configure-project-visibility-features-and-permissions) - except for **GitLab Pages** and **Security & Compliance** are set to **Everyone With Access**. + except for **GitLab Pages** and **Security and Compliance** are set to **Everyone With Access**. - Private projects can be selected only by users who are members of the projects. ## Example structure diff --git a/doc/user/project/settings/index.md b/doc/user/project/settings/index.md index ed4eea56514..7d3e5a72289 100644 --- a/doc/user/project/settings/index.md +++ b/doc/user/project/settings/index.md @@ -87,7 +87,7 @@ Use the toggles to enable or disable features in the project. | **Container Registry** | | Activates a [registry](../../packages/container_registry/index.md) for your Docker images. | | **Analytics** | ✓ | Enables [analytics](../../analytics/index.md). | | **Requirements** | ✓ | Control access to [Requirements Management](../requirements/index.md). | -| **Security & Compliance** | ✓ | Control access to [security features](../../application_security/index.md). | +| **Security and Compliance** | ✓ | Control access to [security features](../../application_security/index.md). | | **Wiki** | ✓ | Enables a separate system for [documentation](../wiki/index.md). | | **Snippets** | ✓ | Enables [sharing of code and text](../../snippets.md). | | **Pages** | ✓ | Allows you to [publish static websites](../pages/index.md). | diff --git a/lib/sidebars/projects/menus/security_compliance_menu.rb b/lib/sidebars/projects/menus/security_compliance_menu.rb index 9367514cdca..1e5a7cecdb2 100644 --- a/lib/sidebars/projects/menus/security_compliance_menu.rb +++ b/lib/sidebars/projects/menus/security_compliance_menu.rb @@ -17,7 +17,7 @@ module Sidebars override :title def title - _('Security & Compliance') + _('Security and Compliance') end override :sprite_icon diff --git a/locale/gitlab.pot b/locale/gitlab.pot index 92ffbe40b3f..d6122ef21d9 100644 --- a/locale/gitlab.pot +++ b/locale/gitlab.pot @@ -22113,7 +22113,7 @@ msgstr "" msgid "InProductMarketing|Rapid development, simplified" msgstr "" -msgid "InProductMarketing|Reduce Security & Compliance Risk" +msgid "InProductMarketing|Reduce Security and Compliance Risk" msgstr "" msgid "InProductMarketing|Require multiple approvers on a merge request, so you know it's in good shape before it's merged." @@ -34077,10 +34077,10 @@ msgstr "" msgid "ProjectSettings|Search for topic" msgstr "" -msgid "ProjectSettings|Security & Compliance" +msgid "ProjectSettings|Security and Compliance" msgstr "" -msgid "ProjectSettings|Security & Compliance for this project" +msgid "ProjectSettings|Security and compliance for this project." msgstr "" msgid "ProjectSettings|Select the default branch for this project, and configure the template for branch names." @@ -37889,9 +37889,6 @@ msgstr "" msgid "ScanExecutionPolicy|Conditions" msgstr "" -msgid "ScanExecutionPolicy|Ex, tag-name-1, tag-name-2" -msgstr "" - msgid "ScanExecutionPolicy|If the field is empty, the runner will be automatically selected" msgstr "" @@ -38382,9 +38379,6 @@ msgstr "" msgid "Security" msgstr "" -msgid "Security & Compliance" -msgstr "" - msgid "Security Configuration" msgstr "" @@ -38394,6 +38388,9 @@ msgstr "" msgid "Security Finding not found" msgstr "" +msgid "Security and Compliance" +msgstr "" + msgid "Security dashboard" msgstr "" @@ -38640,6 +38637,9 @@ msgstr "" msgid "SecurityOrchestration|Choose approver type" msgstr "" +msgid "SecurityOrchestration|Clear all" +msgstr "" + msgid "SecurityOrchestration|Create more robust vulnerability rules and apply them to all your projects." msgstr "" @@ -38745,6 +38745,9 @@ msgstr "" msgid "SecurityOrchestration|No description" msgstr "" +msgid "SecurityOrchestration|No matching results" +msgstr "" + msgid "SecurityOrchestration|No rules defined - policy will not run." msgstr "" @@ -38838,6 +38841,9 @@ msgstr "" msgid "SecurityOrchestration|Scan to be performed on every pipeline on the %{branches}" msgstr "" +msgid "SecurityOrchestration|Scan will automatically choose a runner to run on because there are no tags exist on runners" +msgstr "" + msgid "SecurityOrchestration|Security Approvals" msgstr "" @@ -38859,6 +38865,9 @@ msgstr "" msgid "SecurityOrchestration|Select policy" msgstr "" +msgid "SecurityOrchestration|Select runner tags" +msgstr "" + msgid "SecurityOrchestration|Select scan type" msgstr "" @@ -38868,6 +38877,9 @@ msgstr "" msgid "SecurityOrchestration|Select users" msgstr "" +msgid "SecurityOrchestration|Selected automatically" +msgstr "" + msgid "SecurityOrchestration|Something went wrong, unable to fetch policies" msgstr "" @@ -42100,16 +42112,22 @@ msgstr "" msgid "SuperSonics|Start free trial" msgstr "" +msgid "SuperSonics|Subscription detail synchronization has started and will complete soon." +msgstr "" + msgid "SuperSonics|Subscription details" msgstr "" +msgid "SuperSonics|Subscription details did not synchronize due to a possible connectivity issue with GitLab servers. %{connectivityHelpLinkStart}How do I check connectivity%{connectivityHelpLinkEnd}?" +msgstr "" + msgid "SuperSonics|Subscription unavailable" msgstr "" msgid "SuperSonics|Sync subscription details" msgstr "" -msgid "SuperSonics|Sync subscription request." +msgid "SuperSonics|Synchronization started" msgstr "" msgid "SuperSonics|The activation code is not valid. Please make sure to copy it exactly from the Customers Portal or confirmation email. Learn more about %{linkStart}activating your subscription%{linkEnd}." @@ -42118,7 +42136,7 @@ msgstr "" msgid "SuperSonics|The activation code should be a 24-character alphanumeric string" msgstr "" -msgid "SuperSonics|There is a connectivity issue." +msgid "SuperSonics|There is a connectivity issue" msgstr "" msgid "SuperSonics|This is the highest peak of users on your installation since the license started." @@ -42147,9 +42165,6 @@ msgstr "" msgid "SuperSonics|You can %{purchaseSubscriptionLinkStart}purchase a new subscription%{purchaseSubscriptionLinkEnd} and try again. If you need further assistance, please %{supportLinkStart}contact GitLab Support%{supportLinkEnd}." msgstr "" -msgid "SuperSonics|You can no longer sync your subscription details with GitLab. Get help for the most common connectivity issues by %{connectivityHelpLinkStart}troubleshooting the activation code%{connectivityHelpLinkEnd}." -msgstr "" - msgid "SuperSonics|You can start a free trial of GitLab Ultimate without any obligation or payment details." msgstr "" @@ -42192,9 +42207,6 @@ msgstr "" msgid "SuperSonics|Your subscription cannot be located" msgstr "" -msgid "SuperSonics|Your subscription details will sync shortly." -msgstr "" - msgid "SuperSonics|Your subscription is expired" msgstr "" diff --git a/package.json b/package.json index 648474d49bb..8fbc2ecff83 100644 --- a/package.json +++ b/package.json @@ -110,7 +110,7 @@ "clipboard": "^2.0.8", "compression-webpack-plugin": "^5.0.2", "copy-webpack-plugin": "^6.4.1", - "core-js": "^3.28.0", + "core-js": "^3.29.0", "cron-validator": "^1.1.1", "cronstrue": "^1.122.0", "cropper": "^2.3.0", diff --git a/qa/qa/support/json_formatter.rb b/qa/qa/support/json_formatter.rb index 252ccfe73d3..178b76e1974 100644 --- a/qa/qa/support/json_formatter.rb +++ b/qa/qa/support/json_formatter.rb @@ -26,6 +26,10 @@ module QA class: exception.class.name, message: exception.message, message_lines: strip_ansi_codes(notification.message_lines), + correlation_id: exception.message[match_data_after(Loglinking::CORRELATION_ID_TITLE)], + sentry_url: exception.message[match_data_after(Loglinking::SENTRY_URL_TITLE)], + kibana_discover_url: exception.message[match_data_after(Loglinking::KIBANA_DISCOVER_URL_TITLE)], + kibana_dashboard_url: exception.message[match_data_after(Loglinking::KIBANA_DASHBOARD_URL_TITLE)], backtrace: notification.formatted_backtrace } end @@ -70,6 +74,10 @@ module QA modified = Array(strings).map { |string| string.dup.gsub(/\x1b\[{1,2}[0-9;:?]*m/m, '') } modified.size == 1 ? modified[0] : modified end + + def match_data_after(title) + /(?<=#{title} ).*/ + end end end end diff --git a/qa/qa/support/loglinking.rb b/qa/qa/support/loglinking.rb index e9202af3965..ac6e596ef6f 100644 --- a/qa/qa/support/loglinking.rb +++ b/qa/qa/support/loglinking.rb @@ -4,16 +4,22 @@ module QA module Support module Loglinking # Static address variables declared for mapping environment to logging URLs - STAGING_ADDRESS = 'https://staging.gitlab.com' - STAGING_REF_ADDRESS = 'https://staging-ref.gitlab.com' - PRODUCTION_ADDRESS = 'https://gitlab.com' - PRE_PROD_ADDRESS = 'https://pre.gitlab.com' + STAGING_ADDRESS = 'https://staging.gitlab.com' + STAGING_REF_ADDRESS = 'https://staging-ref.gitlab.com' + PRODUCTION_ADDRESS = 'https://gitlab.com' + PRE_PROD_ADDRESS = 'https://pre.gitlab.com' + + # Text titles used for labeling various IDs and URLs + CORRELATION_ID_TITLE = 'Correlation Id:' + SENTRY_URL_TITLE = 'Sentry Url:' + KIBANA_DISCOVER_URL_TITLE = 'Kibana - Discover Url:' + KIBANA_DASHBOARD_URL_TITLE = 'Kibana - Dashboard Url:' class << self def failure_metadata(correlation_id) return if correlation_id.blank? - errors = ["Correlation Id: #{correlation_id}"] + errors = ["#{CORRELATION_ID_TITLE} #{correlation_id}"] env = logging_environment @@ -24,9 +30,9 @@ module QA kibana_discover_url = kibana.discover_url kibana_dashboard_url = kibana.dashboard_url - errors << "Sentry Url: #{sentry_url}" if sentry_url - errors << "Kibana - Discover Url: #{kibana_discover_url}" if kibana_discover_url - errors << "Kibana - Dashboard Url: #{kibana_dashboard_url}" if kibana_dashboard_url + errors << "#{SENTRY_URL_TITLE} #{sentry_url}" if sentry_url + errors << "#{KIBANA_DISCOVER_URL_TITLE} #{kibana_discover_url}" if kibana_discover_url + errors << "#{KIBANA_DASHBOARD_URL_TITLE} #{kibana_dashboard_url}" if kibana_dashboard_url errors.join("\n") end diff --git a/spec/lib/sidebars/projects/menus/security_compliance_menu_spec.rb b/spec/lib/sidebars/projects/menus/security_compliance_menu_spec.rb index 41158bd58dc..697359b7941 100644 --- a/spec/lib/sidebars/projects/menus/security_compliance_menu_spec.rb +++ b/spec/lib/sidebars/projects/menus/security_compliance_menu_spec.rb @@ -20,7 +20,7 @@ RSpec.describe Sidebars::Projects::Menus::SecurityComplianceMenu do end context 'when user is authenticated' do - context 'when the Security & Compliance is disabled' do + context 'when the Security and Compliance is disabled' do before do allow(Ability).to receive(:allowed?).with(user, :access_security_and_compliance, project).and_return(false) end @@ -28,7 +28,7 @@ RSpec.describe Sidebars::Projects::Menus::SecurityComplianceMenu do it { is_expected.to be_falsey } end - context 'when the Security & Compliance is not disabled' do + context 'when the Security and Compliance is not disabled' do it { is_expected.to be_truthy } end end diff --git a/spec/policies/project_policy_spec.rb b/spec/policies/project_policy_spec.rb index 67adcae1dd9..bf845d04e27 100644 --- a/spec/policies/project_policy_spec.rb +++ b/spec/policies/project_policy_spec.rb @@ -2341,7 +2341,7 @@ RSpec.describe ProjectPolicy, feature_category: :system_access do end describe 'access_security_and_compliance' do - context 'when the "Security & Compliance" is enabled' do + context 'when the "Security and Compliance" is enabled' do before do project.project_feature.update!(security_and_compliance_access_level: Featurable::PRIVATE) end @@ -2387,7 +2387,7 @@ RSpec.describe ProjectPolicy, feature_category: :system_access do end end - context 'when the "Security & Compliance" is not enabled' do + context 'when the "Security and Compliance" is not enabled' do before do project.project_feature.update!(security_and_compliance_access_level: Featurable::DISABLED) end diff --git a/spec/services/admin/set_feature_flag_service_spec.rb b/spec/services/admin/set_feature_flag_service_spec.rb index 45ee914558a..e66802f6332 100644 --- a/spec/services/admin/set_feature_flag_service_spec.rb +++ b/spec/services/admin/set_feature_flag_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Admin::SetFeatureFlagService do +RSpec.describe Admin::SetFeatureFlagService, feature_category: :feature_flags do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project) } let_it_be(:group) { create(:group) } diff --git a/spec/services/alert_management/alerts/todo/create_service_spec.rb b/spec/services/alert_management/alerts/todo/create_service_spec.rb index fa4fd8ed0b2..fd81c0893ed 100644 --- a/spec/services/alert_management/alerts/todo/create_service_spec.rb +++ b/spec/services/alert_management/alerts/todo/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AlertManagement::Alerts::Todo::CreateService do +RSpec.describe AlertManagement::Alerts::Todo::CreateService, feature_category: :incident_management do let_it_be(:user) { create(:user) } let_it_be(:alert) { create(:alert_management_alert) } diff --git a/spec/services/alert_management/alerts/update_service_spec.rb b/spec/services/alert_management/alerts/update_service_spec.rb index 8375c8cdf7d..69e2f2de291 100644 --- a/spec/services/alert_management/alerts/update_service_spec.rb +++ b/spec/services/alert_management/alerts/update_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AlertManagement::Alerts::UpdateService do +RSpec.describe AlertManagement::Alerts::UpdateService, feature_category: :incident_management do let_it_be(:user_with_permissions) { create(:user) } let_it_be(:other_user_with_permissions) { create(:user) } let_it_be(:user_without_permissions) { create(:user) } diff --git a/spec/services/alert_management/create_alert_issue_service_spec.rb b/spec/services/alert_management/create_alert_issue_service_spec.rb index 7255a722d26..b8d93f99ae4 100644 --- a/spec/services/alert_management/create_alert_issue_service_spec.rb +++ b/spec/services/alert_management/create_alert_issue_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AlertManagement::CreateAlertIssueService do +RSpec.describe AlertManagement::CreateAlertIssueService, feature_category: :incident_management do let_it_be(:user) { create(:user) } let_it_be(:group) { create(:group) } let_it_be(:project) { create(:project, group: group) } diff --git a/spec/services/alert_management/http_integrations/create_service_spec.rb b/spec/services/alert_management/http_integrations/create_service_spec.rb index ac5c62caf84..5200ec27dd1 100644 --- a/spec/services/alert_management/http_integrations/create_service_spec.rb +++ b/spec/services/alert_management/http_integrations/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AlertManagement::HttpIntegrations::CreateService do +RSpec.describe AlertManagement::HttpIntegrations::CreateService, feature_category: :incident_management do let_it_be(:user_with_permissions) { create(:user) } let_it_be(:user_without_permissions) { create(:user) } let_it_be_with_reload(:project) { create(:project) } diff --git a/spec/services/alert_management/http_integrations/destroy_service_spec.rb b/spec/services/alert_management/http_integrations/destroy_service_spec.rb index cd949d728de..a8e9746cb85 100644 --- a/spec/services/alert_management/http_integrations/destroy_service_spec.rb +++ b/spec/services/alert_management/http_integrations/destroy_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AlertManagement::HttpIntegrations::DestroyService do +RSpec.describe AlertManagement::HttpIntegrations::DestroyService, feature_category: :incident_management do let_it_be(:user_with_permissions) { create(:user) } let_it_be(:user_without_permissions) { create(:user) } let_it_be(:project) { create(:project) } diff --git a/spec/services/alert_management/http_integrations/update_service_spec.rb b/spec/services/alert_management/http_integrations/update_service_spec.rb index 94c34d9a29c..3f1a0967aa9 100644 --- a/spec/services/alert_management/http_integrations/update_service_spec.rb +++ b/spec/services/alert_management/http_integrations/update_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AlertManagement::HttpIntegrations::UpdateService do +RSpec.describe AlertManagement::HttpIntegrations::UpdateService, feature_category: :incident_management do let_it_be(:user_with_permissions) { create(:user) } let_it_be(:user_without_permissions) { create(:user) } let_it_be(:project) { create(:project) } diff --git a/spec/services/alert_management/metric_images/upload_service_spec.rb b/spec/services/alert_management/metric_images/upload_service_spec.rb index 527d9db0fd9..2cafd2c9029 100644 --- a/spec/services/alert_management/metric_images/upload_service_spec.rb +++ b/spec/services/alert_management/metric_images/upload_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AlertManagement::MetricImages::UploadService do +RSpec.describe AlertManagement::MetricImages::UploadService, feature_category: :metrics do subject(:service) { described_class.new(alert, current_user, params) } let_it_be_with_refind(:project) { create(:project) } diff --git a/spec/services/alert_management/process_prometheus_alert_service_spec.rb b/spec/services/alert_management/process_prometheus_alert_service_spec.rb index ae52a09be48..eb5f3808021 100644 --- a/spec/services/alert_management/process_prometheus_alert_service_spec.rb +++ b/spec/services/alert_management/process_prometheus_alert_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AlertManagement::ProcessPrometheusAlertService do +RSpec.describe AlertManagement::ProcessPrometheusAlertService, feature_category: :incident_management do let_it_be(:project, reload: true) { create(:project, :repository) } let(:service) { described_class.new(project, payload) } diff --git a/spec/services/analytics/cycle_analytics/stages/list_service_spec.rb b/spec/services/analytics/cycle_analytics/stages/list_service_spec.rb index 7bfae0cd9fc..c39965a2799 100644 --- a/spec/services/analytics/cycle_analytics/stages/list_service_spec.rb +++ b/spec/services/analytics/cycle_analytics/stages/list_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Analytics::CycleAnalytics::Stages::ListService do +RSpec.describe Analytics::CycleAnalytics::Stages::ListService, feature_category: :value_stream_management do let_it_be(:project) { create(:project) } let_it_be(:user) { create(:user) } let_it_be(:project_namespace) { project.project_namespace.reload } diff --git a/spec/services/application_settings/update_service_spec.rb b/spec/services/application_settings/update_service_spec.rb index e20d59fb0ef..79d4fc67538 100644 --- a/spec/services/application_settings/update_service_spec.rb +++ b/spec/services/application_settings/update_service_spec.rb @@ -110,7 +110,7 @@ RSpec.describe ApplicationSettings::UpdateService do end end - describe 'markdown cache invalidators' do + describe 'markdown cache invalidators', feature_category: :team_planning do shared_examples 'invalidates markdown cache' do |attribute| let(:params) { attribute } @@ -144,7 +144,7 @@ RSpec.describe ApplicationSettings::UpdateService do end end - describe 'performance bar settings' do + describe 'performance bar settings', feature_category: :application_performance do using RSpec::Parameterized::TableSyntax where(:params_performance_bar_enabled, @@ -247,7 +247,7 @@ RSpec.describe ApplicationSettings::UpdateService do end end - context 'when external authorization is enabled' do + context 'when external authorization is enabled', feature_category: :system_access do before do enable_external_authorization_service_check end diff --git a/spec/services/audit_events/build_service_spec.rb b/spec/services/audit_events/build_service_spec.rb index caf405a53aa..575ec9e58b8 100644 --- a/spec/services/audit_events/build_service_spec.rb +++ b/spec/services/audit_events/build_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AuditEvents::BuildService do +RSpec.describe AuditEvents::BuildService, feature_category: :audit_events do let(:author) { build_stubbed(:author, current_sign_in_ip: '127.0.0.1') } let(:deploy_token) { build_stubbed(:deploy_token, user: author) } let(:scope) { build_stubbed(:group) } diff --git a/spec/services/auth/container_registry_authentication_service_spec.rb b/spec/services/auth/container_registry_authentication_service_spec.rb index ba7acd3d3df..90aba1ae54c 100644 --- a/spec/services/auth/container_registry_authentication_service_spec.rb +++ b/spec/services/auth/container_registry_authentication_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Auth::ContainerRegistryAuthenticationService do +RSpec.describe Auth::ContainerRegistryAuthenticationService, feature_category: :container_registry do include AdminModeHelper it_behaves_like 'a container registry auth service' diff --git a/spec/services/auth/dependency_proxy_authentication_service_spec.rb b/spec/services/auth/dependency_proxy_authentication_service_spec.rb index 667f361dc34..8f92fbe272c 100644 --- a/spec/services/auth/dependency_proxy_authentication_service_spec.rb +++ b/spec/services/auth/dependency_proxy_authentication_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Auth::DependencyProxyAuthenticationService do +RSpec.describe Auth::DependencyProxyAuthenticationService, feature_category: :dependency_proxy do let_it_be(:user) { create(:user) } let(:service) { Auth::DependencyProxyAuthenticationService.new(nil, user) } diff --git a/spec/services/authorized_project_update/find_records_due_for_refresh_service_spec.rb b/spec/services/authorized_project_update/find_records_due_for_refresh_service_spec.rb index 691fb3f60f4..e8f86b4d7c5 100644 --- a/spec/services/authorized_project_update/find_records_due_for_refresh_service_spec.rb +++ b/spec/services/authorized_project_update/find_records_due_for_refresh_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AuthorizedProjectUpdate::FindRecordsDueForRefreshService do +RSpec.describe AuthorizedProjectUpdate::FindRecordsDueForRefreshService, feature_category: :projects do # We're using let! here so that any expectations for the service class are not # triggered twice. let!(:project) { create(:project) } diff --git a/spec/services/authorized_project_update/periodic_recalculate_service_spec.rb b/spec/services/authorized_project_update/periodic_recalculate_service_spec.rb index 782f6858870..51cab6d188b 100644 --- a/spec/services/authorized_project_update/periodic_recalculate_service_spec.rb +++ b/spec/services/authorized_project_update/periodic_recalculate_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AuthorizedProjectUpdate::PeriodicRecalculateService do +RSpec.describe AuthorizedProjectUpdate::PeriodicRecalculateService, feature_category: :projects do subject(:service) { described_class.new } describe '#execute' do diff --git a/spec/services/authorized_project_update/project_access_changed_service_spec.rb b/spec/services/authorized_project_update/project_access_changed_service_spec.rb index da428bece20..7c09d7755ca 100644 --- a/spec/services/authorized_project_update/project_access_changed_service_spec.rb +++ b/spec/services/authorized_project_update/project_access_changed_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AuthorizedProjectUpdate::ProjectAccessChangedService do +RSpec.describe AuthorizedProjectUpdate::ProjectAccessChangedService, feature_category: :projects do describe '#execute' do it 'executes projects_authorizations refresh' do expect(AuthorizedProjectUpdate::ProjectRecalculateWorker).to receive(:bulk_perform_async) diff --git a/spec/services/authorized_project_update/project_recalculate_per_user_service_spec.rb b/spec/services/authorized_project_update/project_recalculate_per_user_service_spec.rb index 62862d0e558..7b2dd52810f 100644 --- a/spec/services/authorized_project_update/project_recalculate_per_user_service_spec.rb +++ b/spec/services/authorized_project_update/project_recalculate_per_user_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AuthorizedProjectUpdate::ProjectRecalculatePerUserService, '#execute' do +RSpec.describe AuthorizedProjectUpdate::ProjectRecalculatePerUserService, '#execute', feature_category: :projects do let_it_be(:project) { create(:project) } let_it_be(:user) { create(:user) } let_it_be(:another_user) { create(:user) } diff --git a/spec/services/authorized_project_update/project_recalculate_service_spec.rb b/spec/services/authorized_project_update/project_recalculate_service_spec.rb index c339faaeabf..8360f3c67ab 100644 --- a/spec/services/authorized_project_update/project_recalculate_service_spec.rb +++ b/spec/services/authorized_project_update/project_recalculate_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AuthorizedProjectUpdate::ProjectRecalculateService, '#execute' do +RSpec.describe AuthorizedProjectUpdate::ProjectRecalculateService, '#execute', feature_category: :projects do let_it_be(:project) { create(:project) } subject(:execute) { described_class.new(project).execute } diff --git a/spec/services/auto_merge/base_service_spec.rb b/spec/services/auto_merge/base_service_spec.rb index 6c804a14620..7afe5d406ba 100644 --- a/spec/services/auto_merge/base_service_spec.rb +++ b/spec/services/auto_merge/base_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AutoMerge::BaseService do +RSpec.describe AutoMerge::BaseService, feature_category: :code_review_workflow do let(:project) { create(:project) } let(:user) { create(:user) } let(:service) { described_class.new(project, user, params) } diff --git a/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb b/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb index 676f55be28a..a0b22267960 100644 --- a/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb +++ b/spec/services/auto_merge/merge_when_pipeline_succeeds_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AutoMerge::MergeWhenPipelineSucceedsService do +RSpec.describe AutoMerge::MergeWhenPipelineSucceedsService, feature_category: :code_review_workflow do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project, :repository) } diff --git a/spec/services/award_emojis/add_service_spec.rb b/spec/services/award_emojis/add_service_spec.rb index 0fbb785e2d6..99dbe6dc606 100644 --- a/spec/services/award_emojis/add_service_spec.rb +++ b/spec/services/award_emojis/add_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AwardEmojis::AddService do +RSpec.describe AwardEmojis::AddService, feature_category: :team_planning do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project) } let_it_be(:awardable) { create(:note, project: project) } diff --git a/spec/services/award_emojis/base_service_spec.rb b/spec/services/award_emojis/base_service_spec.rb index e0c8fd39ad9..f1ee4d1cfb8 100644 --- a/spec/services/award_emojis/base_service_spec.rb +++ b/spec/services/award_emojis/base_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AwardEmojis::BaseService do +RSpec.describe AwardEmojis::BaseService, feature_category: :team_planning do let(:awardable) { build(:note) } let(:current_user) { build(:user) } diff --git a/spec/services/award_emojis/collect_user_emoji_service_spec.rb b/spec/services/award_emojis/collect_user_emoji_service_spec.rb index bf5aa0eb9ef..d75d5804f93 100644 --- a/spec/services/award_emojis/collect_user_emoji_service_spec.rb +++ b/spec/services/award_emojis/collect_user_emoji_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AwardEmojis::CollectUserEmojiService do +RSpec.describe AwardEmojis::CollectUserEmojiService, feature_category: :team_planning do describe '#execute' do it 'returns an Array containing the awarded emoji names' do user = create(:user) diff --git a/spec/services/award_emojis/copy_service_spec.rb b/spec/services/award_emojis/copy_service_spec.rb index abb9c65e25d..6c1d7fb21e2 100644 --- a/spec/services/award_emojis/copy_service_spec.rb +++ b/spec/services/award_emojis/copy_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AwardEmojis::CopyService do +RSpec.describe AwardEmojis::CopyService, feature_category: :team_planning do let_it_be(:from_awardable) do create( :issue, diff --git a/spec/services/award_emojis/destroy_service_spec.rb b/spec/services/award_emojis/destroy_service_spec.rb index f743de7c59e..109bdbfa986 100644 --- a/spec/services/award_emojis/destroy_service_spec.rb +++ b/spec/services/award_emojis/destroy_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AwardEmojis::DestroyService do +RSpec.describe AwardEmojis::DestroyService, feature_category: :team_planning do let_it_be(:user) { create(:user) } let_it_be(:awardable) { create(:note) } let_it_be(:project) { awardable.project } diff --git a/spec/services/award_emojis/toggle_service_spec.rb b/spec/services/award_emojis/toggle_service_spec.rb index 74e97c66193..61dcc22561f 100644 --- a/spec/services/award_emojis/toggle_service_spec.rb +++ b/spec/services/award_emojis/toggle_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe AwardEmojis::ToggleService do +RSpec.describe AwardEmojis::ToggleService, feature_category: :team_planning do let_it_be(:user) { create(:user) } let_it_be(:project) { create(:project, :public) } let_it_be(:awardable) { create(:note, project: project) } diff --git a/spec/services/boards/create_service_spec.rb b/spec/services/boards/create_service_spec.rb index f6a9f0903ce..5aaef9d529c 100644 --- a/spec/services/boards/create_service_spec.rb +++ b/spec/services/boards/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Boards::CreateService do +RSpec.describe Boards::CreateService, feature_category: :team_planning do describe '#execute' do context 'when board parent is a project' do let(:parent) { create(:project) } diff --git a/spec/services/boards/destroy_service_spec.rb b/spec/services/boards/destroy_service_spec.rb index cd6df832547..feaca3cfcce 100644 --- a/spec/services/boards/destroy_service_spec.rb +++ b/spec/services/boards/destroy_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Boards::DestroyService do +RSpec.describe Boards::DestroyService, feature_category: :team_planning do context 'with project board' do let_it_be(:parent) { create(:project) } diff --git a/spec/services/boards/issues/create_service_spec.rb b/spec/services/boards/issues/create_service_spec.rb index c4f1eb093dc..f9a9c338f58 100644 --- a/spec/services/boards/issues/create_service_spec.rb +++ b/spec/services/boards/issues/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Boards::Issues::CreateService do +RSpec.describe Boards::Issues::CreateService, feature_category: :team_planning do describe '#execute' do let(:project) { create(:project) } let(:board) { create(:board, project: project) } diff --git a/spec/services/boards/issues/list_service_spec.rb b/spec/services/boards/issues/list_service_spec.rb index 1959710bb0c..5e10d1d216c 100644 --- a/spec/services/boards/issues/list_service_spec.rb +++ b/spec/services/boards/issues/list_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Boards::Issues::ListService do +RSpec.describe Boards::Issues::ListService, feature_category: :team_planning do describe '#execute' do let_it_be(:user) { create(:user) } diff --git a/spec/services/boards/issues/move_service_spec.rb b/spec/services/boards/issues/move_service_spec.rb index 3a25f13762c..9c173f3f86e 100644 --- a/spec/services/boards/issues/move_service_spec.rb +++ b/spec/services/boards/issues/move_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Boards::Issues::MoveService do +RSpec.describe Boards::Issues::MoveService, feature_category: :team_planning do describe '#execute' do context 'when parent is a project' do let(:user) { create(:user) } diff --git a/spec/services/boards/lists/create_service_spec.rb b/spec/services/boards/lists/create_service_spec.rb index cac26b3c88d..da317fdd474 100644 --- a/spec/services/boards/lists/create_service_spec.rb +++ b/spec/services/boards/lists/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Boards::Lists::CreateService do +RSpec.describe Boards::Lists::CreateService, feature_category: :team_planning do context 'when board parent is a project' do let_it_be(:parent) { create(:project) } let_it_be(:board) { create(:board, project: parent) } diff --git a/spec/services/boards/lists/destroy_service_spec.rb b/spec/services/boards/lists/destroy_service_spec.rb index d5358bcc1e1..837635d49e8 100644 --- a/spec/services/boards/lists/destroy_service_spec.rb +++ b/spec/services/boards/lists/destroy_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Boards::Lists::DestroyService do +RSpec.describe Boards::Lists::DestroyService, feature_category: :team_planning do let_it_be(:user) { create(:user) } let(:list_type) { :list } diff --git a/spec/services/boards/lists/list_service_spec.rb b/spec/services/boards/lists/list_service_spec.rb index 2d41de42581..90b705e05c3 100644 --- a/spec/services/boards/lists/list_service_spec.rb +++ b/spec/services/boards/lists/list_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Boards::Lists::ListService do +RSpec.describe Boards::Lists::ListService, feature_category: :team_planning do let_it_be(:user) { create(:user) } let_it_be(:group) { create(:group) } diff --git a/spec/services/boards/lists/move_service_spec.rb b/spec/services/boards/lists/move_service_spec.rb index 2861fc48b4d..abf7d48e114 100644 --- a/spec/services/boards/lists/move_service_spec.rb +++ b/spec/services/boards/lists/move_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Boards::Lists::MoveService do +RSpec.describe Boards::Lists::MoveService, feature_category: :team_planning do describe '#execute' do context 'when board parent is a project' do let(:project) { create(:project) } diff --git a/spec/services/boards/lists/update_service_spec.rb b/spec/services/boards/lists/update_service_spec.rb index 21216e1b945..341eaa52292 100644 --- a/spec/services/boards/lists/update_service_spec.rb +++ b/spec/services/boards/lists/update_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Boards::Lists::UpdateService do +RSpec.describe Boards::Lists::UpdateService, feature_category: :team_planning do let_it_be(:user) { create(:user) } let!(:list) { create(:list, board: board, position: 0) } diff --git a/spec/services/boards/visits/create_service_spec.rb b/spec/services/boards/visits/create_service_spec.rb index 8910345d170..4af4e914da5 100644 --- a/spec/services/boards/visits/create_service_spec.rb +++ b/spec/services/boards/visits/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Boards::Visits::CreateService do +RSpec.describe Boards::Visits::CreateService, feature_category: :team_planning do describe '#execute' do let(:user) { create(:user) } diff --git a/spec/services/branches/create_service_spec.rb b/spec/services/branches/create_service_spec.rb index 19a32aafa38..4467ca374c3 100644 --- a/spec/services/branches/create_service_spec.rb +++ b/spec/services/branches/create_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Branches::CreateService, :use_clean_rails_redis_caching do +RSpec.describe Branches::CreateService, :use_clean_rails_redis_caching, feature_category: :source_code_management do subject(:service) { described_class.new(project, user) } let_it_be(:project) { create(:project_empty_repo) } diff --git a/spec/services/branches/delete_merged_service_spec.rb b/spec/services/branches/delete_merged_service_spec.rb index 46611670fe1..23a892a56ef 100644 --- a/spec/services/branches/delete_merged_service_spec.rb +++ b/spec/services/branches/delete_merged_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Branches::DeleteMergedService do +RSpec.describe Branches::DeleteMergedService, feature_category: :source_code_management do include ProjectForksHelper subject(:service) { described_class.new(project, project.first_owner) } diff --git a/spec/services/branches/delete_service_spec.rb b/spec/services/branches/delete_service_spec.rb index 727cadc5a50..003645b1b8c 100644 --- a/spec/services/branches/delete_service_spec.rb +++ b/spec/services/branches/delete_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Branches::DeleteService do +RSpec.describe Branches::DeleteService, feature_category: :source_code_management do let(:project) { create(:project, :repository) } let(:repository) { project.repository } let(:user) { create(:user) } diff --git a/spec/services/branches/diverging_commit_counts_service_spec.rb b/spec/services/branches/diverging_commit_counts_service_spec.rb index 34a2b81c831..3cccc74735c 100644 --- a/spec/services/branches/diverging_commit_counts_service_spec.rb +++ b/spec/services/branches/diverging_commit_counts_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Branches::DivergingCommitCountsService do +RSpec.describe Branches::DivergingCommitCountsService, feature_category: :source_code_management do let(:project) { create(:project, :repository) } let(:repository) { project.repository } diff --git a/spec/services/branches/validate_new_service_spec.rb b/spec/services/branches/validate_new_service_spec.rb index 02127c8c10d..a5b75a09353 100644 --- a/spec/services/branches/validate_new_service_spec.rb +++ b/spec/services/branches/validate_new_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Branches::ValidateNewService do +RSpec.describe Branches::ValidateNewService, feature_category: :source_code_management do let(:project) { create(:project, :repository) } subject(:service) { described_class.new(project) } diff --git a/spec/services/bulk_imports/archive_extraction_service_spec.rb b/spec/services/bulk_imports/archive_extraction_service_spec.rb index da9df31cde9..40f8d8718ae 100644 --- a/spec/services/bulk_imports/archive_extraction_service_spec.rb +++ b/spec/services/bulk_imports/archive_extraction_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe BulkImports::ArchiveExtractionService do +RSpec.describe BulkImports::ArchiveExtractionService, feature_category: :importers do let_it_be(:tmpdir) { Dir.mktmpdir } let_it_be(:filename) { 'symlink_export.tar' } let_it_be(:filepath) { File.join(tmpdir, filename) } diff --git a/spec/services/bulk_imports/export_service_spec.rb b/spec/services/bulk_imports/export_service_spec.rb index 2414f7c5ca7..ac7514fde5b 100644 --- a/spec/services/bulk_imports/export_service_spec.rb +++ b/spec/services/bulk_imports/export_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe BulkImports::ExportService do +RSpec.describe BulkImports::ExportService, feature_category: :importers do let_it_be(:group) { create(:group) } let_it_be(:user) { create(:user) } diff --git a/spec/services/bulk_imports/file_decompression_service_spec.rb b/spec/services/bulk_imports/file_decompression_service_spec.rb index 77348428d60..9b8320aeac5 100644 --- a/spec/services/bulk_imports/file_decompression_service_spec.rb +++ b/spec/services/bulk_imports/file_decompression_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe BulkImports::FileDecompressionService do +RSpec.describe BulkImports::FileDecompressionService, feature_category: :importers do let_it_be(:tmpdir) { Dir.mktmpdir } let_it_be(:ndjson_filename) { 'labels.ndjson' } let_it_be(:ndjson_filepath) { File.join(tmpdir, ndjson_filename) } diff --git a/spec/services/bulk_imports/file_download_service_spec.rb b/spec/services/bulk_imports/file_download_service_spec.rb index 27f77b678e3..7c64d6efc65 100644 --- a/spec/services/bulk_imports/file_download_service_spec.rb +++ b/spec/services/bulk_imports/file_download_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe BulkImports::FileDownloadService do +RSpec.describe BulkImports::FileDownloadService, feature_category: :importers do describe '#execute' do let_it_be(:allowed_content_types) { %w(application/gzip application/octet-stream) } let_it_be(:file_size_limit) { 5.gigabytes } diff --git a/spec/services/bulk_imports/file_export_service_spec.rb b/spec/services/bulk_imports/file_export_service_spec.rb index 453fc1d0c0d..3c23b86ad5c 100644 --- a/spec/services/bulk_imports/file_export_service_spec.rb +++ b/spec/services/bulk_imports/file_export_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe BulkImports::FileExportService do +RSpec.describe BulkImports::FileExportService, feature_category: :importers do let_it_be(:project) { create(:project) } describe '#execute' do diff --git a/spec/services/bulk_imports/lfs_objects_export_service_spec.rb b/spec/services/bulk_imports/lfs_objects_export_service_spec.rb index 894789c7941..4f721a3a259 100644 --- a/spec/services/bulk_imports/lfs_objects_export_service_spec.rb +++ b/spec/services/bulk_imports/lfs_objects_export_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe BulkImports::LfsObjectsExportService do +RSpec.describe BulkImports::LfsObjectsExportService, feature_category: :importers do let_it_be(:project) { create(:project) } let_it_be(:lfs_json_filename) { "#{BulkImports::FileTransfer::ProjectConfig::LFS_OBJECTS_RELATION}.json" } let_it_be(:remote_url) { 'http://my-object-storage.local' } diff --git a/spec/services/bulk_imports/relation_export_service_spec.rb b/spec/services/bulk_imports/relation_export_service_spec.rb index f0f85217d2e..bc999b0b9b3 100644 --- a/spec/services/bulk_imports/relation_export_service_spec.rb +++ b/spec/services/bulk_imports/relation_export_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe BulkImports::RelationExportService do +RSpec.describe BulkImports::RelationExportService, feature_category: :importers do let_it_be(:jid) { 'jid' } let_it_be(:relation) { 'labels' } let_it_be(:user) { create(:user) } diff --git a/spec/services/bulk_imports/repository_bundle_export_service_spec.rb b/spec/services/bulk_imports/repository_bundle_export_service_spec.rb index f0d63de1ab9..92d5d21c33f 100644 --- a/spec/services/bulk_imports/repository_bundle_export_service_spec.rb +++ b/spec/services/bulk_imports/repository_bundle_export_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe BulkImports::RepositoryBundleExportService do +RSpec.describe BulkImports::RepositoryBundleExportService, feature_category: :importers do let(:project) { create(:project) } let(:export_path) { Dir.mktmpdir } diff --git a/spec/services/bulk_imports/tree_export_service_spec.rb b/spec/services/bulk_imports/tree_export_service_spec.rb index 6e26cb6dc2b..fa96641f1c1 100644 --- a/spec/services/bulk_imports/tree_export_service_spec.rb +++ b/spec/services/bulk_imports/tree_export_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe BulkImports::TreeExportService do +RSpec.describe BulkImports::TreeExportService, feature_category: :importers do let_it_be(:project) { create(:project) } let_it_be(:export_path) { Dir.mktmpdir } diff --git a/spec/services/bulk_imports/uploads_export_service_spec.rb b/spec/services/bulk_imports/uploads_export_service_spec.rb index ad6e005485c..8dc67b28d12 100644 --- a/spec/services/bulk_imports/uploads_export_service_spec.rb +++ b/spec/services/bulk_imports/uploads_export_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe BulkImports::UploadsExportService do +RSpec.describe BulkImports::UploadsExportService, feature_category: :importers do let_it_be(:export_path) { Dir.mktmpdir } let_it_be(:project) { create(:project, avatar: fixture_file_upload('spec/fixtures/rails_sample.png', 'image/png')) } diff --git a/spec/services/captcha/captcha_verification_service_spec.rb b/spec/services/captcha/captcha_verification_service_spec.rb index fe2199fb53e..b67e725bf91 100644 --- a/spec/services/captcha/captcha_verification_service_spec.rb +++ b/spec/services/captcha/captcha_verification_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe Captcha::CaptchaVerificationService do +RSpec.describe Captcha::CaptchaVerificationService, feature_category: :team_planning do describe '#execute' do let(:captcha_response) { 'abc123' } let(:fake_ip) { '1.2.3.4' } diff --git a/spec/services/chat_names/find_user_service_spec.rb b/spec/services/chat_names/find_user_service_spec.rb index 10cb0a2f065..14bece4efb4 100644 --- a/spec/services/chat_names/find_user_service_spec.rb +++ b/spec/services/chat_names/find_user_service_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -RSpec.describe ChatNames::FindUserService, :clean_gitlab_redis_shared_state do +RSpec.describe ChatNames::FindUserService, :clean_gitlab_redis_shared_state, feature_category: :user_profile do describe '#execute' do subject { described_class.new(team_id, user_id).execute } diff --git a/spec/support/shared_contexts/navbar_structure_context.rb b/spec/support/shared_contexts/navbar_structure_context.rb index 08da55162b4..93f387ff619 100644 --- a/spec/support/shared_contexts/navbar_structure_context.rb +++ b/spec/support/shared_contexts/navbar_structure_context.rb @@ -5,7 +5,7 @@ RSpec.shared_context 'project navbar structure' do let(:security_and_compliance_nav_item) do { - nav_item: _('Security & Compliance'), + nav_item: _('Security and Compliance'), nav_sub_items: [ (_('Audit events') if Gitlab.ee?), _('Configuration') @@ -165,7 +165,7 @@ RSpec.shared_context 'group navbar structure' do let(:security_and_compliance_nav_item) do { - nav_item: _('Security & Compliance'), + nav_item: _('Security and Compliance'), nav_sub_items: [ _('Audit events') ] diff --git a/spec/support/shared_contexts/security_and_compliance_permissions_shared_context.rb b/spec/support/shared_contexts/security_and_compliance_permissions_shared_context.rb index dc5195e4b01..1fa1a5c69f4 100644 --- a/spec/support/shared_contexts/security_and_compliance_permissions_shared_context.rb +++ b/spec/support/shared_contexts/security_and_compliance_permissions_shared_context.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -RSpec.shared_context '"Security & Compliance" permissions' do +RSpec.shared_context '"Security and Compliance" permissions' do let(:project_instance) { an_instance_of(Project) } let(:user_instance) { an_instance_of(User) } let(:before_request_defined) { false } @@ -18,7 +18,7 @@ RSpec.shared_context '"Security & Compliance" permissions' do allow(Ability).to receive(:allowed?).with(user_instance, :access_security_and_compliance, project_instance).and_return(true) end - context 'when the "Security & Compliance" feature is disabled' do + context 'when the "Security and Compliance" feature is disabled' do subject { response } before do diff --git a/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb b/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb index cddff276317..b529bf7de2c 100644 --- a/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb +++ b/spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb @@ -310,7 +310,7 @@ RSpec.describe 'layouts/nav/sidebar/_project', feature_category: :navigation do it 'top level navigation link is not visible' do render - expect(rendered).not_to have_link('Security & Compliance') + expect(rendered).not_to have_link('Security and Compliance') end end @@ -322,7 +322,7 @@ RSpec.describe 'layouts/nav/sidebar/_project', feature_category: :navigation do end it 'top level navigation link is visible' do - expect(rendered).to have_link('Security & Compliance') + expect(rendered).to have_link('Security and Compliance') end it 'security configuration link is visible' do diff --git a/yarn.lock b/yarn.lock index 24faa7be684..75e0a54ab6e 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4214,10 +4214,10 @@ core-js-pure@^3.0.0: resolved "https://registry.yarnpkg.com/core-js-pure/-/core-js-pure-3.6.5.tgz#c79e75f5e38dbc85a662d91eea52b8256d53b813" integrity sha512-lacdXOimsiD0QyNf9BC/mxivNJ/ybBGJXQFKzRekp1WTHoVUWsUHEn+2T8GJAzzIhyOuXA+gOxCVN3l+5PLPUA== -core-js@^3.28.0, core-js@^3.6.5: - version "3.28.0" - resolved "https://registry.yarnpkg.com/core-js/-/core-js-3.28.0.tgz#ed8b9e99c273879fdfff0edfc77ee709a5800e4a" - integrity sha512-GiZn9D4Z/rSYvTeg1ljAIsEqFm0LaN9gVtwDCrKL80zHtS31p9BAjmTxVqTQDMpwlMolJZOFntUG2uwyj7DAqw== +core-js@^3.29.0, core-js@^3.6.5: + version "3.29.0" + resolved "https://registry.yarnpkg.com/core-js/-/core-js-3.29.0.tgz#0273e142b67761058bcde5615c503c7406b572d6" + integrity sha512-VG23vuEisJNkGl6XQmFJd3rEG/so/CNatqeE+7uZAwTSwFeB/qaO0be8xZYUNWprJ/GIwL8aMt9cj1kvbpTZhg== core-util-is@~1.0.0: version "1.0.3" |