diff options
-rw-r--r-- | app/helpers/sorting_helper.rb | 2 | ||||
-rw-r--r-- | doc/development/fe_guide/vuex.md | 6 | ||||
-rw-r--r-- | spec/helpers/sorting_helper_spec.rb | 6 |
3 files changed, 11 insertions, 3 deletions
diff --git a/app/helpers/sorting_helper.rb b/app/helpers/sorting_helper.rb index f51b96ba8ce..67c808b167a 100644 --- a/app/helpers/sorting_helper.rb +++ b/app/helpers/sorting_helper.rb @@ -164,7 +164,7 @@ module SortingHelper reverse_sort = issuable_reverse_sort_order_hash[sort_value] if reverse_sort - reverse_url = page_filter_path(sort: reverse_sort) + reverse_url = page_filter_path(sort: reverse_sort, label: true) else reverse_url = '#' link_class += ' disabled' diff --git a/doc/development/fe_guide/vuex.md b/doc/development/fe_guide/vuex.md index 0f57835fb87..65963b959f7 100644 --- a/doc/development/fe_guide/vuex.md +++ b/doc/development/fe_guide/vuex.md @@ -137,6 +137,7 @@ By following this pattern we guarantee: #### Dispatching actions To dispatch an action from a component, use the `mapActions` helper: + ```javascript import { mapActions } from 'vuex'; @@ -204,6 +205,7 @@ export const getUsersWithPets = (state, getters) => { ``` To access a getter from a component, use the `mapGetters` helper: + ```javascript import { mapGetters } from 'vuex'; @@ -226,6 +228,7 @@ export const ADD_USER = 'ADD_USER'; ### How to include the store in your application The store should be included in the main component of your application: + ```javascript // app.vue import store from 'store'; // it will include the index.js file @@ -364,7 +367,8 @@ Because we're currently using [`babel-plugin-rewire`](https://github.com/speedsk `[vuex] actions should be function or object with "handler" function` To prevent this error from happening, you need to export an empty function as `default`: -``` + +```javascript // getters.js or actions.js // prevent babel-plugin-rewire from generating an invalid default during karma tests diff --git a/spec/helpers/sorting_helper_spec.rb b/spec/helpers/sorting_helper_spec.rb index cba0d93e144..f405268d198 100644 --- a/spec/helpers/sorting_helper_spec.rb +++ b/spec/helpers/sorting_helper_spec.rb @@ -21,7 +21,11 @@ describe SortingHelper do describe '#issuable_sort_direction_button' do before do - allow(self).to receive(:request).and_return(double(path: 'http://test.com', query_parameters: {})) + allow(self).to receive(:request).and_return(double(path: 'http://test.com', query_parameters: { label_name: 'test_label' })) + end + + it 'keeps label filter param' do + expect(issuable_sort_direction_button('created_date')).to include('label_name=test_label') end it 'returns icon with sort-highest when sort is created_date' do |