diff options
| -rw-r--r-- | CHANGELOG.md | 49 | ||||
| -rw-r--r-- | changelogs/archive.md | 36 | ||||
| -rw-r--r-- | doc/development/gitaly.md | 2 | ||||
| -rw-r--r-- | doc/development/testing_guide/best_practices.md | 2 | ||||
| -rw-r--r-- | doc/development/testing_guide/end_to_end/quick_start_guide.md | 2 | ||||
| -rw-r--r-- | doc/user/group/index.md | 4 |
6 files changed, 48 insertions, 47 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 8498658b39c..623e5d0acb9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -660,7 +660,7 @@ entry. - Forbid creating discussions for users with restricted access. - Fix leaking private repository information in API. - Fixed ability to see private groups by users not belonging to given group. -- Prevent releases links API to leak tag existance. +- Prevent releases links API to leak tag existence. - Display the correct number of MRs a user has access to. - Block local URLs for Kubernetes integration. - Fix arbitrary file read via diffs during import. @@ -1019,7 +1019,7 @@ entry. - Display SAML failure messages instead of expecting CSRF token. !24509 - Adjust vertical alignment for project visibility icons. !24511 (Martin Hobert) - Load initUserInternalRegexPlaceholder only when required. !24522 -- Hashed Storage: `AfterRenameService` was receiving the wrong `old_path` under some circunstances. !24526 +- Hashed Storage: `AfterRenameService` was receiving the wrong `old_path` under some circumstances. !24526 - Resolve Runners IPv6 address overlaps other values. !24531 - Fix 404s with snippet uploads in object storage. !24550 - Fixed oversized custom project notification selector dropdown. !24557 @@ -1058,7 +1058,7 @@ entry. - Update CI YAML param table with include. - Return bottom border on MR Tabs. - Fixes z-index and margins of archived alert in job page. -- Fixes archived sticky top bar without perfomance bar. +- Fixes archived sticky top bar without performance bar. - Fixed rebase button not showing in merge request widget. - Fixed double tooltips on note awards buttons. - Allow suggestions to be copied and pasted as GFM. @@ -1491,7 +1491,7 @@ entry. - Fix deprecation: Using positional arguments in integration tests. !24009 (Jasper Maes) - UI improvements for redesigned project lists. !24011 - Update cert-manager chart from v0.5.0 to v0.5.2. !24025 (Takuya Noguchi) -- Hide spinner on empty activites list on user profile overview. !24063 +- Hide spinner on empty activities list on user profile overview. !24063 - Don't show Auto DevOps enabled banner for projects with CI file or CI disabled. !24067 - Update GitLab Runner Helm Chart to 0.1.43. !24083 - Fix navigation style in docs. !24090 (Takuya Noguchi) @@ -2020,7 +2020,7 @@ entry. - Hide all tables on Pipeline when no Jobs for the Pipeline. !18540 (Takuya Noguchi) - Fixing count on Milestones. !21446 -- Use case insensitve username lookups. !21728 (William George) +- Use case insensitive username lookups. !21728 (William George) - Correctly process Bamboo API result array. !21970 (Alex Lossent) - Fix 'merged with' UI being displayed when merge request has no merge commit. !22022 - Fix broken file name navigation on MRs. !22109 @@ -2803,7 +2803,7 @@ entry. - Fixes SVGs for empty states in job page overflowing on mobile. - Fix checkboxes on runner admin settings - The labels are now clickable. - Fixed IDE file row scrolling into view when hovering. -- Accept upload files in public/uplaods/tmp when using accelerated uploads. +- Accept upload files in public/uploads/tmp when using accelerated uploads. - Include correct CSS file for xterm in environments page. - Increase padding in code blocks. - Fix: Project deletion may not log audit events during user deletion. @@ -3689,7 +3689,7 @@ entry. ### Fixed (69 changes, 23 of them are from the community) -- Optimize the upload migration proces. !15947 +- Optimize the upload migration process. !15947 - Import bitbucket issues that are reported by an anonymous user. !18199 (bartl) - Fix an issue where the notification email address would be set to an unconfirmed email address. !18474 - Stop logging email information when emails are disabled. !18521 (Marc Shaw) @@ -3817,7 +3817,7 @@ entry. - Add a cronworker to rescue stale live traces. !18680 - Move SquashBeforeMerge vue component. !18813 (George Tsiolis) - Add index on runner_type for ci_runners. !18897 -- Fix CarrierWave reads local files into memoery when migrates to ObjectStorage. !19102 +- Fix CarrierWave reads local files into memory when migrates to ObjectStorage. !19102 - Remove double-checked internal id generation. !19181 - Throttle updates to Project#last_repository_updated_at. !19183 - Add background migrations for archiving legacy job traces. !19194 @@ -3908,7 +3908,7 @@ entry. - Adjust SQL and transaction Prometheus buckets. - Adding branches through the WebUI is handled by Gitaly. - Remove shellout implementation for Repository checksums. -- Refs containting sha checks are done by Gitaly. +- Refs containing sha checks are done by Gitaly. - Finding a wiki page is done by Gitaly by default. - Workhorse will use Gitaly to create archives. - Workhorse to send raw diff and patch for commits. @@ -4112,7 +4112,7 @@ entry. - Display active sessions and allow the user to revoke any of it. !17867 (Alexis Reigel) - Add cron job to email users on issue due date. !17985 (Stuart Nelson) - Rubocop rule to avoid returning from a block. !18000 (Jacopo Beschi @jacopo-beschi) -- Add the signature verfication badge to the compare view. !18245 (Marc Shaw) +- Add the signature verification badge to the compare view. !18245 (Marc Shaw) - Expose Deploy Token data as environment varialbes on CI/CD jobs. !18414 - Show group id in group settings. !18482 (George Tsiolis) - Allow admins to enforce accepting Terms of Service on an instance. !18570 @@ -4850,7 +4850,7 @@ entry. - Override group sidebar links. !16942 (George Tsiolis) - Avoid running `PopulateForkNetworksRange`-migration multiple times. !16988 - Resolve PrepareUntrackedUploads PostgreSQL syntax error. !17019 -- Fix monaco editor features which were incompatable with GitLab CDN settings. !17021 +- Fix monaco editor features which were incompatible with GitLab CDN settings. !17021 - Fixed error 500 when removing an identity with synced attributes and visiting the profile page. !17054 - Fix cnacel edit note button reverting changes. !42462 - For issues display time of last edit of title or description instead of time of any attribute change. @@ -5067,7 +5067,7 @@ entry. ### Performance (2 changes) - rework indexes on redirect_routes. -- Remove unecessary query from labels filter. +- Remove unnecessary query from labels filter. ## 10.4.0 (2018-01-22) @@ -5198,7 +5198,7 @@ entry. - Add a gitlab:tcp_check rake task. !15759 - add support for sorting in tags api. !15772 (haseebeqx) - Add Prometheus to available Cluster applications. !15895 -- Validate file status when commiting multiple files. !15922 +- Validate file status when committing multiple files. !15922 - List of avatars should never show +1. !15972 (Jacopo Beschi @jacopo-beschi) - Do not generate NPM links for private NPM modules in blob view. !16002 (Mario de la Ossa) - Backport fast database lookup of SSH authorized_keys from EE. !16014 @@ -5229,7 +5229,7 @@ entry. - Fix web ide user preferences copy and buttons. !41789 - Update redis-rack to 2.0.4. - Import some code and functionality from gitlab-shell to improve subprocess handling. -- Update Browse file to Choose file in all occurences. +- Update Browse file to Choose file in all occurrences. - Bump mysql2 gem version from 0.4.5 to 0.4.10. (asaparov) - Use a background migration for issues.closed_at. @@ -5364,7 +5364,7 @@ entry. - Fix graph notes number duplication. !15696 (Vladislav Kaverin) - Fix updateEndpoint undefined error for issue_show app root. !15698 - Change boards page boards_data absolute urls to paths. !15703 -- Using appropiate services in the API for managing forks. !15709 +- Using appropriate services in the API for managing forks. !15709 - Confirming email with invalid token should no longer generate an error. !15726 - fix #39233 - 500 in merge request. !15774 (Martin Nowak) - Use Markdown styling for new project guidelines. !15785 (Markus Koller) @@ -5474,7 +5474,7 @@ entry. - Stop reloading the page when using pagination and tabs - use API calls - in Pipelines table. - Clean up schema of the "issues" table. - Clarify wording of protected branch settings for the default branch. -- Update svg external depencency. +- Update svg external dependency. - Clean up schema of the "merge_requests" table. @@ -5644,7 +5644,7 @@ entry. - Fix gitlab:backup rake for hashed storage based repositories. !15400 - Fix issue where clicking a GPG verification badge would scroll to the top of the page. !15407 - Update container repository path reference and allow using double underscore. !15417 -- Fix crash when navigating to second page of the group dashbaord when there are projects and groups on the first page. !15456 +- Fix crash when navigating to second page of the group dashboard when there are projects and groups on the first page. !15456 - Fix flash errors showing up on a non configured prometheus integration. !35652 - Fix timezone bug in Pikaday and upgrade Pikaday version. - Fix arguments Import/Export error importing project merge requests. @@ -6194,7 +6194,7 @@ entry. - [CHANGED] Fire hooks asynchronously when creating a new job to improve performance. !13734 - [CHANGED] Improve performance for AutocompleteController#users.json. !13754 (Hiroyuki Sato) - [CHANGED] Update the GPG verification semantics: A GPG signature must additionally match the committer in order to be verified. !13771 (Alexis Reigel) -- [CHANGED] Support a multi-word fuzzy seach issues/merge requests on search bar. !13780 (Hiroyuki Sato) +- [CHANGED] Support a multi-word fuzzy search issues/merge requests on search bar. !13780 (Hiroyuki Sato) - [CHANGED] Default LDAP config "verify_certificates" to true for security. !13915 - [CHANGED] "Share with group lock" now applies to subgroups, but owner can override setting on subgroups. !13944 - [CHANGED] Make Gitaly PostUploadPack mandatory. !13953 @@ -6893,7 +6893,7 @@ entry. ## 9.3.2 (2017-06-27) -- API: Fix optional arugments for POST :id/variables. !12474 +- API: Fix optional arguments for POST :id/variables. !12474 - Bump premailer-rails gem to 1.9.7 and its dependencies to prevent network retrieval of assets. ## 9.3.1 (2017-06-26) @@ -6910,7 +6910,7 @@ entry. - Refactored gitlab:app:check into SystemCheck liberary and improve some checks. !9173 - Add an ability to cancel attaching file and redesign attaching files UI. !9431 (blackst0ne) - Add Aliyun OSS as the backup storage provider. !9721 (Yuanfei Zhu) -- Add suport for find_local_branches GRPC from Gitaly. !10059 +- Add support for find_local_branches GRPC from Gitaly. !10059 - Allow manual bypass of auto_sign_in_with_provider with a new param. !10187 (Maxime Besson) - Redirect to user's keys index instead of user's index after a key is deleted in the admin. !10227 (Cyril Jouve) - Changed Blame to Annotate in the UI to promote blameless culture. !10378 (Ilya Vassilevsky) @@ -6989,7 +6989,7 @@ entry. - Add tag_list param to project api. !11799 (Ivan Chernov) - Add changelog for improved Registry description. !11816 - Automatically adjust project settings to match changes in project visibility. !11831 -- Add slugify project path to CI enviroment variables. !11838 (Ivan Chernov) +- Add slugify project path to CI environment variables. !11838 (Ivan Chernov) - Add all pipeline sources as special keywords to 'only' and 'except'. !11844 (Filip Krakowski) - Allow pulling of container images using personal access tokens. !11845 - Expose import_status in Projects API. !11851 (Robin Bobbitt) @@ -7904,7 +7904,7 @@ entry. - Clean-up Project navigation order. !9272 - Add Runner's jobs v4 API. !9273 - Add pipeline trigger API with user permissions. !9277 -- Enhanced filter issues layout for better mobile experiance. !9280 (Pratik Borsadiya) +- Enhanced filter issues layout for better mobile experience. !9280 (Pratik Borsadiya) - Move babel config for instanbul to karma config. !9286 (winniehell) - Document U2F limitations with multiple URLs. !9300 - Wrap long Project and Group titles. !9301 @@ -8085,7 +8085,7 @@ entry. - Add badges to global dropdown. - Changed coverage reg expression placeholder text to be more like a placeholder. - Show members of parent groups on project members page. -- Fix grammer issue in admin/runners. +- Fix grammar issue in admin/runners. - Allow slashes in slash command arguments. - Adds paginationd and folders view to environments table. - hide loading spinners for server-rendered sidebar fields. @@ -8258,7 +8258,7 @@ entry. - Allows to search within project by commit hash. (YarNayar) - Show organisation membership and delete comment on smaller viewports, plus change comment author name to username. - Remove turbolinks. -- Convert pipeline action icons to svg to have them propperly positioned. +- Convert pipeline action icons to svg to have them properly positioned. - Remove rogue scrollbars for issue comments with inline elements. - Align Segoe UI label text. - Color + and - signs in diffs to increase code legibility. @@ -8549,3 +8549,4 @@ entry. ## 8.15.8 through 0.8.0 - See [changelogs/archive.md](changelogs/archive.md) + diff --git a/changelogs/archive.md b/changelogs/archive.md index dd7c21dabd6..e36e859a351 100644 --- a/changelogs/archive.md +++ b/changelogs/archive.md @@ -274,7 +274,7 @@ - Pass variables from deployment project services to CI runner. !8107 - New Gitea importer. !8116 - Introduce "Set up autodeploy" button to help configure GitLab CI for deployment. !8135 -- Prevent enviroment table to overflow when name has underscores. !8142 +- Prevent environment table to overflow when name has underscores. !8142 - Fix missing service error importing from EE to CE. !8144 - Milestoneish SQL performance partially improved and memoized. !8146 - Allow unauthenticated access to Repositories API GET endpoints. !8148 @@ -562,7 +562,7 @@ - Fix broken issue/merge request links in JIRA comments. !6143 (Brian Kintz) - Fix filtering of milestones with quotes in title (airatshigapov) - Fix issue boards dragging bug in Safari -- Refactor less readable existance checking code from CoffeeScript !6289 (jlogandavison) +- Refactor less readable existence checking code from CoffeeScript !6289 (jlogandavison) - Update mail_room and enable sentinel support to Reply By Email (!7101) - Add task completion status in Issues and Merge Requests tabs: "X of Y tasks completed" (!6527, @gmesalazar) - Simpler arguments passed to named_route on toggle_award_url helper method @@ -956,7 +956,7 @@ ## 8.12.0 (2016-09-22) - - Removes inconsistency regarding tagging immediatelly as merged once you create a new branch. !6408 + - Removes inconsistency regarding tagging immediately as merged once you create a new branch. !6408 - Update the rouge gem to 2.0.6, which adds highlighting support for JSX, Prometheus, and others. !6251 - Only check :can_resolve permission if the note is resolvable - Bump fog-aws to v0.11.0 to support ap-south-1 region @@ -1389,7 +1389,7 @@ - Fix notification_service argument error of declined invitation emails - Fix a memory leak caused by Banzai::Filter::SanitizationFilter - Speed up todos queries by limiting the projects set we join with - - Ensure file editing in UI does not overwrite commited changes without warning user + - Ensure file editing in UI does not overwrite committed changes without warning user - Eliminate unneeded calls to Repository#blob_at when listing commits with no path - Update gitlab_git gem to 10.4.7 - Simplify SQL queries of marking a todo as done @@ -2076,7 +2076,7 @@ - Don't show forks button when user can't view forks - Fix atom feed links and rendering - Files over 5MB can only be viewed in their raw form, files over 1MB without highlighting !3718 - - Add support for supressing text diffs using .gitattributes on the default branch (Matt Oakes) + - Add support for suppressing text diffs using .gitattributes on the default branch (Matt Oakes) - Add eager load paths to help prevent dependency load issues in Sidekiq workers. !3724 - Added multiple colors for labels in dropdowns when dups happen. - Show commits in the same order as `git log` @@ -2194,7 +2194,7 @@ - All images in discussions and wikis now link to their source files !3464 (Connor Shea). - Return status code 303 after a branch DELETE operation to avoid project deletion (Stan Hu) - Add setting for customizing the list of trusted proxies !3524 - - Allow projects to be transfered to a lower visibility level group + - Allow projects to be transferred to a lower visibility level group - Fix `signed_in_ip` being set to 127.0.0.1 when using a reverse proxy !3524 - Improved Markdown rendering performance !3389 - Make shared runners text in box configurable @@ -2209,7 +2209,7 @@ - API: Ability to update a group (Robert Schilling) - API: Ability to move issues (Robert Schilling) - Fix Error 500 after renaming a project path (Stan Hu) - - Fix a bug whith trailing slash in teamcity_url (Charles May) + - Fix a bug with trailing slash in teamcity_url (Charles May) - Allow back dating on issues when created or updated through the API - Allow back dating on issue notes when created through the API - Propose license template when creating a new LICENSE file @@ -2219,7 +2219,7 @@ - Allow SAML to handle external users based on user's information !3530 - Allow Omniauth providers to be marked as `external` !3657 - Add endpoints to archive or unarchive a project !3372 - - Fix a bug whith trailing slash in bamboo_url + - Fix a bug with trailing slash in bamboo_url - Add links to CI setup documentation from project settings and builds pages - Display project members page to all members - Handle nil descriptions in Slack issue messages (Stan Hu) @@ -2610,7 +2610,7 @@ - Fixed logo animation on Safari (Roman Rott) - Fix Merge When Succeeded when multiple stages - Hide remove source branch button when the MR is merged but new commits are pushed (Zeger-Jan van de Weg) - - In seach autocomplete show only groups and projects you are member of + - In search autocomplete show only groups and projects you are member of - Don't process cross-reference notes from forks - Fix: init.d script not working on OS X - Faster snippet search @@ -2870,7 +2870,7 @@ - Bump Redis requirement to 2.8 for Sidekiq 4 (Stan Hu) - Fix: Assignee selector is empty when 'Unassigned' is selected (Jose Corcuera) - WIP identifier on merge requests no longer requires trailing space - - Add rake tasks for git repository maintainance (Zeger-Jan van de Weg) + - Add rake tasks for git repository maintenance (Zeger-Jan van de Weg) - Fix 500 error when update group member permission - Fix: As an admin, cannot add oneself as a member to a group/project - Trim leading and trailing whitespace of milestone and issueable titles (Jose Corcuera) @@ -3199,7 +3199,7 @@ - Sort issues by creation date in Bitbucket importer (Stan Hu) - Prevent too many redirects upon login when home page URL is set to external_url (Stan Hu) - Improve dropdown positioning on the project home page (Hannes Rosenögger) - - Upgrade browser gem to 1.0.0 to avoid warning in IE11 compatibilty mode (Stan Hu) + - Upgrade browser gem to 1.0.0 to avoid warning in IE11 compatibility mode (Stan Hu) - Remove user OAuth tokens from the database and request new tokens each session (Stan Hu) - Restrict users API endpoints to use integer IDs (Stan Hu) - Only show recent push event if the branch still exists or a recent merge request has not been created (Stan Hu) @@ -3209,7 +3209,7 @@ - Ability to fetch merge requests from refs/merge-requests/:id - Allow displaying of archived projects in the admin interface (Artem Sidorenko) - Allow configuration of import sources for new projects (Artem Sidorenko) - - Search for comments should be case insensetive + - Search for comments should be case insensitive - Create cross-reference for closing references on commits pushed to non-default branches (Maël Valais) - Ability to search milestones - Gracefully handle SMTP user input errors (e.g. incorrect email addresses) to prevent Sidekiq retries (Stan Hu) @@ -3477,7 +3477,7 @@ - Update Asciidoctor gem to version 1.5.2. (Jakub Jirutka) - Fix resolving of relative links to repository files in AsciiDoc documents. (Jakub Jirutka) - Use the user list from the target project in a merge request (Stan Hu) -- Default extention for wiki pages is now .md instead of .markdown (Jeroen van Baarsen) +- Default extension for wiki pages is now .md instead of .markdown (Jeroen van Baarsen) - Add validation to wiki page creation (only [a-zA-Z0-9/_-] are allowed) (Jeroen van Baarsen) - Fix new/empty milestones showing 100% completion value (Jonah Bishop) - Add a note when an Issue or Merge Request's title changes @@ -3613,7 +3613,7 @@ - Set EmailsOnPush reply-to address to committer email when enabled. - Fix broken file browsing with a submodule that contains a relative link (Stan Hu) - Fix persistent XSS vulnerability around profile website URLs. -- Fix project import URL regex to prevent arbitary local repos from being imported. +- Fix project import URL regex to prevent arbitrary local repos from being imported. - Fix directory traversal vulnerability around uploads routes. - Fix directory traversal vulnerability around help pages. - Don't leak existence of project via search autocomplete. @@ -3676,7 +3676,7 @@ - Don't show commit comment button when user is not signed in. - Fix admin user projects lists. - Don't leak private group existence by redirecting from namespace controller to group controller. -- Ability to skip some items from backup (database, respositories or uploads) +- Ability to skip some items from backup (database, repositories or uploads) - Archive repositories in background worker. - Import GitHub, Bitbucket or GitLab.com projects owned by authenticated user into current namespace. - Project labels are now available over the API under the "tag_list" field (Cristian Medina) @@ -3701,7 +3701,7 @@ ## 7.9.4 -- Security: Fix project import URL regex to prevent arbitary local repos from being imported +- Security: Fix project import URL regex to prevent arbitrary local repos from being imported - Fixed issue where only 25 commits would load in file listings - Fix LDAP identities after config update @@ -4199,7 +4199,7 @@ - Only masters can rewrite/remove git tags - Add X-Frame-Options SAMEORIGIN to Nginx config so Sidekiq admin is visible - UI improvements -- Case-insensetive search for issues +- Case-insensitive search for issues - Update to rails 4.1 - Improve performance of application for projects and groups with a lot of members - Formally support Ruby 2.1 @@ -4358,7 +4358,7 @@ - Group avatar - Pygments.rb replaced with highlight.js - Improve Merge request diff store logic -- Improve render performnace for MR show page +- Improve render performances for MR show page - Fixed Assembla hardcoded project name - Jira integration documentation - Refactored app/services diff --git a/doc/development/gitaly.md b/doc/development/gitaly.md index 4ef20d5fd74..c8beb808a54 100644 --- a/doc/development/gitaly.md +++ b/doc/development/gitaly.md @@ -245,7 +245,7 @@ Here are the steps to gate a new feature in Gitaly behind a feature flag. // go implementation } else { findAllTagsRequests.WithLabelValues("ruby").Inc() - // ruby impelmentation + // ruby implementation } ``` diff --git a/doc/development/testing_guide/best_practices.md b/doc/development/testing_guide/best_practices.md index 82439c94c5a..71e3b7740cb 100644 --- a/doc/development/testing_guide/best_practices.md +++ b/doc/development/testing_guide/best_practices.md @@ -17,7 +17,7 @@ our test design. We can find some helpful heuristics documented in the Handbook ## Run tests against MySQL -By default, tests are only run againts PostgreSQL, but you can run them on +By default, tests are only run against PostgreSQL, but you can run them on demand against MySQL by following one of the following conventions: | Convention | Valid example | diff --git a/doc/development/testing_guide/end_to_end/quick_start_guide.md b/doc/development/testing_guide/end_to_end/quick_start_guide.md index afe76acf9c9..9f43f4ebd1c 100644 --- a/doc/development/testing_guide/end_to_end/quick_start_guide.md +++ b/doc/development/testing_guide/end_to_end/quick_start_guide.md @@ -557,7 +557,7 @@ The code should look like this: `filter_output = search_field_tag search_id, nil > Classes starting with `qa-` are used for testing purposes only, and by defining such classes in the elements we add **testability** in the application. -> When defining a class like `qa-labels-block`, it is transformed into `:labels_block` for usage in the Page Objects. So, `qa-edit-link-labels` is tranformed into `:edit_link_labels`, `qa-dropdown-menu-labels` is transformed into `:dropdown_menu_labels`, and `qa-dropdown-input-field` is transformed into `:dropdown_input_field`. Also, we use a [sanity test](https://gitlab.com/gitlab-org/gitlab-ce/tree/master/qa/qa/page#how-did-we-solve-fragile-tests-problem) to check that defined elements have their respective `qa-` selectors in the specified views. +> When defining a class like `qa-labels-block`, it is transformed into `:labels_block` for usage in the Page Objects. So, `qa-edit-link-labels` is transformed into `:edit_link_labels`, `qa-dropdown-menu-labels` is transformed into `:dropdown_menu_labels`, and `qa-dropdown-input-field` is transformed into `:dropdown_input_field`. Also, we use a [sanity test](https://gitlab.com/gitlab-org/gitlab-ce/tree/master/qa/qa/page#how-did-we-solve-fragile-tests-problem) to check that defined elements have their respective `qa-` selectors in the specified views. > We did not define the `qa-labels-block` class in the `app/views/shared/issuable/_sidebar.html.haml` file because it was already there to be used. diff --git a/doc/user/group/index.md b/doc/user/group/index.md index b123a2b917b..97d309caf7c 100644 --- a/doc/user/group/index.md +++ b/doc/user/group/index.md @@ -232,8 +232,8 @@ to explore data such as: From GitLab 10.5, you can transfer groups in the following ways: - Transfer a subgroup to a new parent group. -- Convert a top-level group into a subgroup by transfering it to the desired group. -- Convert a subgroup into a top-level group by transfering it out of its current group. +- Convert a top-level group into a subgroup by transferring it to the desired group. +- Convert a subgroup into a top-level group by transferring it out of its current group. When transferring groups, note: |