diff options
| -rw-r--r-- | app/models/project_services/gitlab_ci_service.rb | 2 | ||||
| -rw-r--r-- | spec/features/admin/admin_users_spec.rb | 5 | ||||
| -rw-r--r-- | spec/services/issues/close_service_spec.rb | 4 | ||||
| -rw-r--r-- | spec/services/issues/update_service_spec.rb | 5 | ||||
| -rw-r--r-- | spec/services/merge_requests/close_service_spec.rb | 4 | ||||
| -rw-r--r-- | spec/services/merge_requests/merge_service_spec.rb | 5 | ||||
| -rw-r--r-- | spec/services/merge_requests/reopen_service_spec.rb | 4 | ||||
| -rw-r--r-- | spec/services/merge_requests/update_service_spec.rb | 6 | 
8 files changed, 25 insertions, 10 deletions
| diff --git a/app/models/project_services/gitlab_ci_service.rb b/app/models/project_services/gitlab_ci_service.rb index c5657b5070e..234e8e8b580 100644 --- a/app/models/project_services/gitlab_ci_service.rb +++ b/app/models/project_services/gitlab_ci_service.rb @@ -55,7 +55,7 @@ class GitlabCiService < CiService    end    def get_ci_commit(sha, ref) -    Ci::Project.find(project.gitlab_ci_project).commits.find_by_sha!(sha) +    Ci::Project.find(project.gitlab_ci_project.id).commits.find_by_sha!(sha)    end    def commit_status(sha, ref) diff --git a/spec/features/admin/admin_users_spec.rb b/spec/features/admin/admin_users_spec.rb index c6b6ac58acb..86f01faffb4 100644 --- a/spec/features/admin/admin_users_spec.rb +++ b/spec/features/admin/admin_users_spec.rb @@ -93,7 +93,10 @@ describe "Admin::Users", feature: true  do      end      it "should send valid email to user with email & password" do -      click_button "Create user" +      perform_enqueued_jobs do +        click_button "Create user" +      end +        user = User.find_by(username: 'bang')        email = ActionMailer::Base.deliveries.last        expect(email.subject).to have_content('Account was created') diff --git a/spec/services/issues/close_service_spec.rb b/spec/services/issues/close_service_spec.rb index db547ce0d50..d711e3da104 100644 --- a/spec/services/issues/close_service_spec.rb +++ b/spec/services/issues/close_service_spec.rb @@ -14,7 +14,9 @@ describe Issues::CloseService do    describe :execute do      context "valid params" do        before do -        @issue = Issues::CloseService.new(project, user, {}).execute(issue) +        perform_enqueued_jobs do +          @issue = Issues::CloseService.new(project, user, {}).execute(issue) +        end        end        it { expect(@issue).to be_valid } diff --git a/spec/services/issues/update_service_spec.rb b/spec/services/issues/update_service_spec.rb index cc3e6483261..73d0b7f7abe 100644 --- a/spec/services/issues/update_service_spec.rb +++ b/spec/services/issues/update_service_spec.rb @@ -36,7 +36,10 @@ describe Issues::UpdateService do            label_ids: [label.id]          } -        @issue = Issues::UpdateService.new(project, user, opts).execute(issue) +        perform_enqueued_jobs do +          @issue = Issues::UpdateService.new(project, user, opts).execute(issue) +        end +          @issue.reload        end diff --git a/spec/services/merge_requests/close_service_spec.rb b/spec/services/merge_requests/close_service_spec.rb index b3cbfd4b5b8..272f3897938 100644 --- a/spec/services/merge_requests/close_service_spec.rb +++ b/spec/services/merge_requests/close_service_spec.rb @@ -18,7 +18,9 @@ describe MergeRequests::CloseService do        before do          allow(service).to receive(:execute_hooks) -        @merge_request = service.execute(merge_request) +        perform_enqueued_jobs do +          @merge_request = service.execute(merge_request) +        end        end        it { expect(@merge_request).to be_valid } diff --git a/spec/services/merge_requests/merge_service_spec.rb b/spec/services/merge_requests/merge_service_spec.rb index 7483f51de03..c0961ceb11e 100644 --- a/spec/services/merge_requests/merge_service_spec.rb +++ b/spec/services/merge_requests/merge_service_spec.rb @@ -17,8 +17,9 @@ describe MergeRequests::MergeService do        before do          allow(service).to receive(:execute_hooks) - -        service.execute(merge_request, 'Awesome message') +        perform_enqueued_jobs do +          service.execute(merge_request, 'Awesome message') +        end        end        it { expect(merge_request).to be_valid } diff --git a/spec/services/merge_requests/reopen_service_spec.rb b/spec/services/merge_requests/reopen_service_spec.rb index 9401bc3b558..05146bf43f4 100644 --- a/spec/services/merge_requests/reopen_service_spec.rb +++ b/spec/services/merge_requests/reopen_service_spec.rb @@ -19,7 +19,9 @@ describe MergeRequests::ReopenService do          allow(service).to receive(:execute_hooks)          merge_request.state = :closed -        service.execute(merge_request) +        perform_enqueued_jobs do +          service.execute(merge_request) +        end        end        it { expect(merge_request).to be_valid } diff --git a/spec/services/merge_requests/update_service_spec.rb b/spec/services/merge_requests/update_service_spec.rb index 97f5c009aec..d899b1f01d1 100644 --- a/spec/services/merge_requests/update_service_spec.rb +++ b/spec/services/merge_requests/update_service_spec.rb @@ -42,8 +42,10 @@ describe MergeRequests::UpdateService do        before do          allow(service).to receive(:execute_hooks) -        @merge_request = service.execute(merge_request) -        @merge_request.reload +        perform_enqueued_jobs do +          @merge_request = service.execute(merge_request) +          @merge_request.reload +        end        end        it { expect(@merge_request).to be_valid } | 
