diff options
Diffstat (limited to 'app/assets/javascripts/experimentation/utils.js')
-rw-r--r-- | app/assets/javascripts/experimentation/utils.js | 23 |
1 files changed, 18 insertions, 5 deletions
diff --git a/app/assets/javascripts/experimentation/utils.js b/app/assets/javascripts/experimentation/utils.js index 624a04fd7c2..dcb6a8e20a3 100644 --- a/app/assets/javascripts/experimentation/utils.js +++ b/app/assets/javascripts/experimentation/utils.js @@ -3,11 +3,24 @@ import { get } from 'lodash'; import { DEFAULT_VARIANT, CANDIDATE_VARIANT, TRACKING_CONTEXT_SCHEMA } from './constants'; function getExperimentsData() { - return get(window, ['gon', 'experiment'], {}); + // Pull from deprecated window.gon.experiment + const experimentsFromGon = get(window, ['gon', 'experiment'], {}); + // Pull from preferred window.gl.experiments + const experimentsFromGl = get(window, ['gl', 'experiments'], {}); + + return { ...experimentsFromGon, ...experimentsFromGl }; } function convertExperimentDataToExperimentContext(experimentData) { - return { schema: TRACKING_CONTEXT_SCHEMA, data: experimentData }; + // Bandaid to allow-list only the properties which the current gitlab_experiment context schema suppports. + // See TRACKING_CONTEXT_SCHEMA for current version (1-0-0) + // https://gitlab.com/gitlab-org/iglu/-/blob/master/public/schemas/com.gitlab/gitlab_experiment/jsonschema/1-0-0 + const { experiment: experimentName, key, variant, migration_keys } = experimentData; + + return { + schema: TRACKING_CONTEXT_SCHEMA, + data: { experiment: experimentName, key, variant, migration_keys }, + }; } export function getExperimentData(experimentName) { @@ -26,14 +39,14 @@ export function getExperimentVariant(experimentName) { return getExperimentData(experimentName)?.variant || DEFAULT_VARIANT; } -export function experiment(experimentName, variants) { +export function experiment(experimentName, { use, control, candidate, ...variants }) { const variant = getExperimentVariant(experimentName); switch (variant) { case DEFAULT_VARIANT: - return variants.use.call(); + return (use || control).call(); case CANDIDATE_VARIANT: - return variants.try.call(); + return (variants.try || candidate).call(); default: return variants[variant].call(); } |