summaryrefslogtreecommitdiff
path: root/app/helpers/defer_script_tag_helper.rb
diff options
context:
space:
mode:
Diffstat (limited to 'app/helpers/defer_script_tag_helper.rb')
-rw-r--r--app/helpers/defer_script_tag_helper.rb4
1 files changed, 3 insertions, 1 deletions
diff --git a/app/helpers/defer_script_tag_helper.rb b/app/helpers/defer_script_tag_helper.rb
index d91c6d52683..be927c67aaa 100644
--- a/app/helpers/defer_script_tag_helper.rb
+++ b/app/helpers/defer_script_tag_helper.rb
@@ -1,7 +1,9 @@
# frozen_string_literal: true
module DeferScriptTagHelper
- # Override the default ActionView `javascript_include_tag` helper to support page specific deferred loading
+ # Override the default ActionView `javascript_include_tag` helper to support page specific deferred loading.
+ # PLEASE NOTE: `defer` is also critical so that we don't run JavaScript entrypoints before the DOM is ready.
+ # Please see https://gitlab.com/groups/gitlab-org/-/epics/4538#note_432159769.
def javascript_include_tag(*sources)
super(*sources, defer: true)
end