diff options
Diffstat (limited to 'app/models/diff_discussion.rb')
-rw-r--r-- | app/models/diff_discussion.rb | 19 |
1 files changed, 14 insertions, 5 deletions
diff --git a/app/models/diff_discussion.rb b/app/models/diff_discussion.rb index 4a65738214b..758a26d3c70 100644 --- a/app/models/diff_discussion.rb +++ b/app/models/diff_discussion.rb @@ -22,12 +22,10 @@ class DiffDiscussion < Discussion def merge_request_version_params return unless for_merge_request? - return {} if active? - if on_merge_request_commit? - { commit_id: commit_id } - else - noteable.version_params_for(position.diff_refs) + version_params do |params| + params[:commit_id] = commit_id if on_merge_request_commit? + params end end @@ -37,4 +35,15 @@ class DiffDiscussion < Discussion position: position.to_json ) end + + private + + def version_params + params = if active? + {} + else + noteable.version_params_for(position.diff_refs) + end + yield params + end end |