diff options
Diffstat (limited to 'lib/gitlab/ci/parsers/junit_parser.rb')
| -rw-r--r-- | lib/gitlab/ci/parsers/junit_parser.rb | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/lib/gitlab/ci/parsers/junit_parser.rb b/lib/gitlab/ci/parsers/junit_parser.rb index 0ead2121aab..08c10e89c6c 100644 --- a/lib/gitlab/ci/parsers/junit_parser.rb +++ b/lib/gitlab/ci/parsers/junit_parser.rb @@ -12,11 +12,12 @@ module Gitlab each_suite do |testcases, _| testcases.each do |testcase| test_case = create_test_case(testcase) - test_suite.add_result(test_case) + test_suite.add_test_case(test_case) end end - rescue + rescue => e Rails.logger.error "Failed to parse Junit file" # Since xml_data is user-generated contents, parser could fail if they include corrupted-data + raise e # TODO: Remove end private @@ -31,10 +32,10 @@ module Gitlab def create_test_case(data) if data['failure'] - status = ::Gitlab::Ci::Reports::TestCase::FAILED + result = ::Gitlab::Ci::Reports::TestCase::RESULT_FAILURE failure_reason = data['failure'] else - status = ::Gitlab::Ci::Reports::TestCase::SUCCESS + result = ::Gitlab::Ci::Reports::TestCase::RESULT_PASS failure_reason = nil end @@ -43,7 +44,7 @@ module Gitlab name: data['name'], file: data['file'], time: data['time'], - status: status, + result: result, failure_reason: failure_reason ) end |