summaryrefslogtreecommitdiff
path: root/lib/gitlab/database/partitioning/sliding_list_strategy.rb
diff options
context:
space:
mode:
Diffstat (limited to 'lib/gitlab/database/partitioning/sliding_list_strategy.rb')
-rw-r--r--lib/gitlab/database/partitioning/sliding_list_strategy.rb53
1 files changed, 50 insertions, 3 deletions
diff --git a/lib/gitlab/database/partitioning/sliding_list_strategy.rb b/lib/gitlab/database/partitioning/sliding_list_strategy.rb
index e9865fb91d6..5cf32d3272c 100644
--- a/lib/gitlab/database/partitioning/sliding_list_strategy.rb
+++ b/lib/gitlab/database/partitioning/sliding_list_strategy.rb
@@ -48,9 +48,12 @@ module Gitlab
default_value = current_default_value
if extra.any? { |p| p.value == default_value }
- Gitlab::AppLogger.error(message: "Inconsistent partition detected: partition with value #{current_default_value} should not be deleted because it's used as the default value.",
- partition_number: current_default_value,
- table_name: model.table_name)
+ Gitlab::AppLogger.error(
+ message: "Inconsistent partition detected: partition with value #{current_default_value} should " \
+ "not be deleted because it's used as the default value.",
+ partition_number: current_default_value,
+ table_name: model.table_name
+ )
extra = extra.reject { |p| p.value == default_value }
end
@@ -73,6 +76,42 @@ module Gitlab
current_partitions.empty?
end
+ def validate_and_fix
+ return unless Feature.enabled?(:fix_sliding_list_partitioning)
+ return if no_partitions_exist?
+
+ old_default_value = current_default_value
+ expected_default_value = active_partition.value
+
+ if old_default_value != expected_default_value
+ with_lock_retries do
+ model.connection.execute("LOCK TABLE #{model.table_name} IN ACCESS EXCLUSIVE MODE")
+
+ old_default_value = current_default_value
+ expected_default_value = active_partition.value
+
+ if old_default_value == expected_default_value
+ Gitlab::AppLogger.warn(
+ message: "Table partitions or partition key default value have been changed by another process",
+ table_name: table_name,
+ default_value: expected_default_value
+ )
+ raise ActiveRecord::Rollback
+ end
+
+ model.connection.change_column_default(model.table_name, partitioning_key, expected_default_value)
+ Gitlab::AppLogger.warn(
+ message: "Fixed default value of sliding_list_strategy partitioning_key",
+ column: partitioning_key,
+ table_name: table_name,
+ connection_name: model.connection.pool.db_config.name,
+ old_value: old_default_value,
+ new_value: expected_default_value
+ )
+ end
+ end
+ end
+
private
def current_default_value
@@ -95,6 +134,14 @@ module Gitlab
raise "Add #{partitioning_key} to #{model.name}.ignored_columns to use it with SlidingListStrategy"
end
end
+
+ def with_lock_retries(&block)
+ Gitlab::Database::WithLockRetries.new(
+ klass: self.class,
+ logger: Gitlab::AppLogger,
+ connection: model.connection
+ ).run(&block)
+ end
end
end
end