diff options
Diffstat (limited to 'rubocop/cop/gitlab/except.rb')
-rw-r--r-- | rubocop/cop/gitlab/except.rb | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/rubocop/cop/gitlab/except.rb b/rubocop/cop/gitlab/except.rb new file mode 100644 index 00000000000..24da6962457 --- /dev/null +++ b/rubocop/cop/gitlab/except.rb @@ -0,0 +1,23 @@ +# frozen_string_literal: true + +module RuboCop + module Cop + module Gitlab + # Cop that disallows the use of `Gitlab::SQL::Except`, in favour of using + # the `FromExcept` module. + class Except < RuboCop::Cop::Cop + MSG = 'Use the `FromExcept` concern, instead of using `Gitlab::SQL::Except` directly' + + def_node_matcher :raw_except?, <<~PATTERN + (send (const (const (const nil? :Gitlab) :SQL) :Except) :new ...) + PATTERN + + def on_send(node) + return unless raw_except?(node) + + add_offense(node, location: :expression) + end + end + end + end +end |