summaryrefslogtreecommitdiff
path: root/spec/controllers/admin/runners_controller_spec.rb
diff options
context:
space:
mode:
Diffstat (limited to 'spec/controllers/admin/runners_controller_spec.rb')
-rw-r--r--spec/controllers/admin/runners_controller_spec.rb33
1 files changed, 1 insertions, 32 deletions
diff --git a/spec/controllers/admin/runners_controller_spec.rb b/spec/controllers/admin/runners_controller_spec.rb
index b5e7af2c012..8e57b4f03a7 100644
--- a/spec/controllers/admin/runners_controller_spec.rb
+++ b/spec/controllers/admin/runners_controller_spec.rb
@@ -12,42 +12,11 @@ RSpec.describe Admin::RunnersController do
describe '#index' do
render_views
- before do
- stub_feature_flags(runner_list_view_vue_ui: false)
- end
-
it 'lists all runners' do
get :index
expect(response).to have_gitlab_http_status(:ok)
- end
-
- it 'avoids N+1 queries', :request_store do
- get :index
-
- control_count = ActiveRecord::QueryRecorder.new { get :index }.count
-
- create_list(:ci_runner, 5, :tagged_only)
-
- # There is still an N+1 query for `runner.builds.count`
- # We also need to add 1 because it takes 2 queries to preload tags
- # also looking for token nonce requires database queries
- expect { get :index }.not_to exceed_query_limit(control_count + 16)
-
- expect(response).to have_gitlab_http_status(:ok)
- expect(response.body).to have_content('tag1')
- expect(response.body).to have_content('tag2')
- end
-
- it 'paginates runners' do
- stub_const("Admin::RunnersController::NUMBER_OF_RUNNERS_PER_PAGE", 1)
-
- create(:ci_runner)
-
- get :index
-
- expect(response).to have_gitlab_http_status(:ok)
- expect(assigns(:runners).count).to be(1)
+ expect(response).to render_template(:index)
end
end