summaryrefslogtreecommitdiff
path: root/spec/features/dashboard/group_dashboard_with_external_authorization_service_spec.rb
diff options
context:
space:
mode:
Diffstat (limited to 'spec/features/dashboard/group_dashboard_with_external_authorization_service_spec.rb')
-rw-r--r--spec/features/dashboard/group_dashboard_with_external_authorization_service_spec.rb19
1 files changed, 8 insertions, 11 deletions
diff --git a/spec/features/dashboard/group_dashboard_with_external_authorization_service_spec.rb b/spec/features/dashboard/group_dashboard_with_external_authorization_service_spec.rb
index 0620f819332..3dd993b4bb5 100644
--- a/spec/features/dashboard/group_dashboard_with_external_authorization_service_spec.rb
+++ b/spec/features/dashboard/group_dashboard_with_external_authorization_service_spec.rb
@@ -4,6 +4,7 @@ require 'spec_helper'
RSpec.describe 'The group dashboard' do
include ExternalAuthorizationServiceHelpers
+ include Spec::Support::Helpers::Features::TopNavSpecHelpers
let(:user) { create(:user) }
@@ -14,11 +15,11 @@ RSpec.describe 'The group dashboard' do
describe 'The top navigation' do
it 'has all the expected links' do
- pending_on_combined_menu_flag
-
visit dashboard_groups_path
- within('.navbar') do
+ open_top_nav
+
+ within_top_nav do
expect(page).to have_button('Projects')
expect(page).to have_button('Groups')
expect(page).to have_link('Activity')
@@ -28,12 +29,12 @@ RSpec.describe 'The group dashboard' do
end
it 'hides some links when an external authorization service is enabled' do
- pending_on_combined_menu_flag
-
enable_external_authorization_service_check
visit dashboard_groups_path
- within('.navbar') do
+ open_top_nav
+
+ within_top_nav do
expect(page).to have_button('Projects')
expect(page).to have_button('Groups')
expect(page).not_to have_link('Activity')
@@ -44,7 +45,7 @@ RSpec.describe 'The group dashboard' do
end
end
- context 'with combined_menu: feature flag on' do
+ context 'with combined_menu feature flag on', :js do
let(:needs_rewrite_for_combined_menu_flag_on) { true }
before do
@@ -63,8 +64,4 @@ RSpec.describe 'The group dashboard' do
it_behaves_like 'combined_menu: feature flag examples'
end
-
- def pending_on_combined_menu_flag
- pending 'https://gitlab.com/gitlab-org/gitlab/-/merge_requests/56587' if needs_rewrite_for_combined_menu_flag_on
- end
end