1 files changed, 81 insertions, 110 deletions
diff --git a/spec/features/projects/clusters/gcp_spec.rb b/spec/features/projects/clusters/gcp_spec.rb
index a8a627d8806..c85b82b2090 100644
--- a/spec/features/projects/clusters/gcp_spec.rb
+++ b/spec/features/projects/clusters/gcp_spec.rb
@@ -22,152 +22,123 @@ feature 'Gcp Cluster', :js do
         .to receive(:expires_at_in_session).and_return(1.hour.since.to_i.to_s)
     end
 
-    context 'when user has a GCP project with billing enabled' do
+    context 'when user does not have a cluster and visits cluster index page' do
       before do
-        allow_any_instance_of(Projects::Clusters::GcpController).to receive(:authorize_google_project_billing)
-        allow_any_instance_of(Projects::Clusters::GcpController).to receive(:google_project_billing_status).and_return(true)
-      end
-
-      context 'when user does not have a cluster and visits cluster index page' do
-        before do
-          visit project_clusters_path(project)
-
-          click_link 'Add Kubernetes cluster'
-          click_link 'Create on Google Kubernetes Engine'
-        end
-
-        context 'when user filled form with valid parameters' do
-          before do
-            allow_any_instance_of(GoogleApi::CloudPlatform::Client)
-              .to receive(:projects_zones_clusters_create) do
-              OpenStruct.new(
-                self_link: 'projects/gcp-project-12345/zones/us-central1-a/operations/ope-123',
-                status: 'RUNNING'
-              )
-            end
-
-            allow(WaitForClusterCreationWorker).to receive(:perform_in).and_return(nil)
-
-            fill_in 'cluster_provider_gcp_attributes_gcp_project_id', with: 'gcp-project-123'
-            fill_in 'cluster_name', with: 'dev-cluster'
-            click_button 'Create Kubernetes cluster'
-          end
+        visit project_clusters_path(project)
 
-          it 'user sees a cluster details page and creation status' do
-            expect(page).to have_content('Kubernetes cluster is being created on Google Kubernetes Engine...')
+        click_link 'Add Kubernetes cluster'
+        click_link 'Create on Google Kubernetes Engine'
+      end
 
-            Clusters::Cluster.last.provider.make_created!
+      context 'when user filled form with valid parameters' do
+        subject { click_button 'Create Kubernetes cluster' }
 
-            expect(page).to have_content('Kubernetes cluster was successfully created on Google Kubernetes Engine')
+        before do
+          allow_any_instance_of(GoogleApi::CloudPlatform::Client)
+            .to receive(:projects_zones_clusters_create) do
+            OpenStruct.new(
+              self_link: 'projects/gcp-project-12345/zones/us-central1-a/operations/ope-123',
+              status: 'RUNNING'
+            )
           end
 
-          it 'user sees a error if something worng during creation' do
-            expect(page).to have_content('Kubernetes cluster is being created on Google Kubernetes Engine...')
+          allow(WaitForClusterCreationWorker).to receive(:perform_in).and_return(nil)
 
-            Clusters::Cluster.last.provider.make_errored!('Something wrong!')
+          execute_script('document.querySelector(".js-gke-cluster-creation-submit").removeAttribute("disabled")')
+          sleep 2 # wait for ajax
+          execute_script('document.querySelector(".js-gcp-project-id-dropdown input").setAttribute("type", "text")')
+          execute_script('document.querySelector(".js-gcp-zone-dropdown input").setAttribute("type", "text")')
+          execute_script('document.querySelector(".js-gcp-machine-type-dropdown input").setAttribute("type", "text")')
 
-            expect(page).to have_content('Something wrong!')
-          end
+          fill_in 'cluster[name]', with: 'dev-cluster'
+          fill_in 'cluster[provider_gcp_attributes][gcp_project_id]', with: 'gcp-project-123'
+          fill_in 'cluster[provider_gcp_attributes][zone]', with: 'us-central1-a'
+          fill_in 'cluster[provider_gcp_attributes][machine_type]', with: 'n1-standard-2'
         end
 
-        context 'when user filled form with invalid parameters' do
-          before do
-            click_button 'Create Kubernetes cluster'
-          end
-
-          it 'user sees a validation error' do
-            expect(page).to have_css('#error_explanation')
-          end
+        it 'users sees a form with the GCP token' do
+          expect(page).to have_selector(:css, 'form[data-token="token"]')
         end
-      end
 
-      context 'when user does have a cluster and visits cluster page' do
-        let(:cluster) { create(:cluster, :provided_by_gcp, projects: [project]) }
+        it 'user sees a cluster details page and creation status' do
+          subject
 
-        before do
-          visit project_cluster_path(project, cluster)
-        end
+          expect(page).to have_content('Kubernetes cluster is being created on Google Kubernetes Engine...')
+
+          Clusters::Cluster.last.provider.make_created!
 
-        it 'user sees a cluster details page' do
-          expect(page).to have_button('Save changes')
-          expect(page.find(:css, '.cluster-name').value).to eq(cluster.name)
+          expect(page).to have_content('Kubernetes cluster was successfully created on Google Kubernetes Engine')
         end
 
-        context 'when user disables the cluster' do
-          before do
-            page.find(:css, '.js-cluster-enable-toggle-area .js-project-feature-toggle').click
-            page.within('#cluster-integration') { click_button 'Save changes' }
-          end
+        it 'user sees a error if something wrong during creation' do
+          subject
 
-          it 'user sees the successful message' do
-            expect(page).to have_content('Kubernetes cluster was successfully updated.')
-          end
-        end
+          expect(page).to have_content('Kubernetes cluster is being created on Google Kubernetes Engine...')
 
-        context 'when user changes cluster parameters' do
-          before do
-            fill_in 'cluster_platform_kubernetes_attributes_namespace', with: 'my-namespace'
-            page.within('#js-cluster-details') { click_button 'Save changes' }
-          end
+          Clusters::Cluster.last.provider.make_errored!('Something wrong!')
 
-          it 'user sees the successful message' do
-            expect(page).to have_content('Kubernetes cluster was successfully updated.')
-            expect(cluster.reload.platform_kubernetes.namespace).to eq('my-namespace')
-          end
+          expect(page).to have_content('Something wrong!')
         end
+      end
 
-        context 'when user destroy the cluster' do
-          before do
-            page.accept_confirm do
-              click_link 'Remove integration'
-            end
-          end
+      context 'when user filled form with invalid parameters' do
+        before do
+          execute_script('document.querySelector(".js-gke-cluster-creation-submit").removeAttribute("disabled")')
+          click_button 'Create Kubernetes cluster'
+        end
 
-          it 'user sees creation form with the successful message' do
-            expect(page).to have_content('Kubernetes cluster integration was successfully removed.')
-            expect(page).to have_link('Add Kubernetes cluster')
-          end
+        it 'user sees a validation error' do
+          expect(page).to have_css('#error_explanation')
         end
       end
     end
 
-    context 'when user does not have a GCP project with billing enabled' do
-      before do
-        allow_any_instance_of(Projects::Clusters::GcpController).to receive(:authorize_google_project_billing)
-        allow_any_instance_of(Projects::Clusters::GcpController).to receive(:google_project_billing_status).and_return(false)
-
-        visit project_clusters_path(project)
-
-        click_link 'Add Kubernetes cluster'
-        click_link 'Create on Google Kubernetes Engine'
+    context 'when user does have a cluster and visits cluster page' do
+      let(:cluster) { create(:cluster, :provided_by_gcp, projects: [project]) }
 
-        fill_in 'cluster_provider_gcp_attributes_gcp_project_id', with: 'gcp-project-123'
-        fill_in 'cluster_name', with: 'dev-cluster'
-        click_button 'Create Kubernetes cluster'
+      before do
+        visit project_cluster_path(project, cluster)
       end
 
-      it 'user sees form with error' do
-        expect(page).to have_content('Please enable billing for one of your projects to be able to create a Kubernetes cluster, then try again.')
+      it 'user sees a cluster details page' do
+        expect(page).to have_button('Save changes')
+        expect(page.find(:css, '.cluster-name').value).to eq(cluster.name)
       end
-    end
 
-    context 'when gcp billing status is not in redis' do
-      before do
-        allow_any_instance_of(Projects::Clusters::GcpController).to receive(:authorize_google_project_billing)
-        allow_any_instance_of(Projects::Clusters::GcpController).to receive(:google_project_billing_status).and_return(nil)
+      context 'when user disables the cluster' do
+        before do
+          page.find(:css, '.js-cluster-enable-toggle-area .js-project-feature-toggle').click
+          page.within('#cluster-integration') { click_button 'Save changes' }
+        end
 
-        visit project_clusters_path(project)
+        it 'user sees the successful message' do
+          expect(page).to have_content('Kubernetes cluster was successfully updated.')
+        end
+      end
 
-        click_link 'Add Kubernetes cluster'
-        click_link 'Create on Google Kubernetes Engine'
+      context 'when user changes cluster parameters' do
+        before do
+          fill_in 'cluster_platform_kubernetes_attributes_namespace', with: 'my-namespace'
+          page.within('#js-cluster-details') { click_button 'Save changes' }
+        end
 
-        fill_in 'cluster_provider_gcp_attributes_gcp_project_id', with: 'gcp-project-123'
-        fill_in 'cluster_name', with: 'dev-cluster'
-        click_button 'Create Kubernetes cluster'
+        it 'user sees the successful message' do
+          expect(page).to have_content('Kubernetes cluster was successfully updated.')
+          expect(cluster.reload.platform_kubernetes.namespace).to eq('my-namespace')
+        end
       end
 
-      it 'user sees form with error' do
-        expect(page).to have_content('We could not verify that one of your projects on GCP has billing enabled. Please try again.')
+      context 'when user destroy the cluster' do
+        before do
+          page.accept_confirm do
+            click_link 'Remove integration'
+          end
+        end
+
+        it 'user sees creation form with the successful message' do
+          expect(page).to have_content('Kubernetes cluster integration was successfully removed.')
+          expect(page).to have_link('Add Kubernetes cluster')
+        end
       end
     end
   end