diff options
Diffstat (limited to 'spec/finders/members_finder_spec.rb')
| -rw-r--r-- | spec/finders/members_finder_spec.rb | 306 |
1 files changed, 159 insertions, 147 deletions
diff --git a/spec/finders/members_finder_spec.rb b/spec/finders/members_finder_spec.rb index aa7d32e51ac..c48a0271471 100644 --- a/spec/finders/members_finder_spec.rb +++ b/spec/finders/members_finder_spec.rb @@ -2,205 +2,217 @@ require 'spec_helper' -RSpec.describe MembersFinder, '#execute' do - let_it_be(:group) { create(:group) } - let_it_be(:nested_group) { create(:group, parent: group) } - let_it_be(:project, reload: true) { create(:project, namespace: nested_group) } - let_it_be(:user1) { create(:user) } - let_it_be(:user2) { create(:user) } - let_it_be(:user3) { create(:user) } - let_it_be(:user4) { create(:user) } - let_it_be(:blocked_user) { create(:user, :blocked) } - - it 'returns members for project and parent groups' do - nested_group.request_access(user1) - member1 = group.add_maintainer(user2) - member2 = nested_group.add_maintainer(user3) - member3 = project.add_maintainer(user4) - blocked_member = project.add_maintainer(blocked_user) - - result = described_class.new(project, user2).execute - - expect(result).to contain_exactly(member1, member2, member3, blocked_member) - end +RSpec.describe MembersFinder, feature_category: :subgroups do + shared_examples '#execute' do + let_it_be(:group) { create(:group) } + let_it_be(:nested_group) { create(:group, parent: group) } + let_it_be(:project, reload: true) { create(:project, namespace: nested_group) } + let_it_be(:user1) { create(:user) } + let_it_be(:user2) { create(:user) } + let_it_be(:user3) { create(:user) } + let_it_be(:user4) { create(:user) } + let_it_be(:blocked_user) { create(:user, :blocked) } + + it 'returns members for project and parent groups' do + nested_group.request_access(user1) + member1 = group.add_maintainer(user2) + member2 = nested_group.add_maintainer(user3) + member3 = project.add_maintainer(user4) + blocked_member = project.add_maintainer(blocked_user) + + result = described_class.new(project, user2).execute + + expect(result).to contain_exactly(member1, member2, member3, blocked_member) + end - it 'returns owners and maintainers' do - member1 = group.add_owner(user1) - group.add_developer(user2) - member3 = project.add_maintainer(user3) - project.add_developer(user4) + it 'returns owners and maintainers' do + member1 = group.add_owner(user1) + group.add_developer(user2) + member3 = project.add_maintainer(user3) + project.add_developer(user4) - result = described_class.new(project, user2, params: { owners_and_maintainers: true }).execute + result = described_class.new(project, user2, params: { owners_and_maintainers: true }).execute - expect(result).to contain_exactly(member1, member3) - end + expect(result).to contain_exactly(member1, member3) + end - it 'returns active users and excludes invited users' do - member1 = project.add_maintainer(user2) - create(:project_member, :invited, project: project, invite_email: create(:user).email) - project.add_maintainer(blocked_user) + it 'returns active users and excludes invited users' do + member1 = project.add_maintainer(user2) + create(:project_member, :invited, project: project, invite_email: create(:user).email) + project.add_maintainer(blocked_user) - result = described_class.new(project, user2, params: { active_without_invites_and_requests: true }).execute + result = described_class.new(project, user2, params: { active_without_invites_and_requests: true }).execute - expect(result).to contain_exactly(member1) - end + expect(result).to contain_exactly(member1) + end - it 'does not return members of parent group with minimal access' do - nested_group.request_access(user1) - member1 = group.add_maintainer(user2) - member2 = nested_group.add_maintainer(user3) - member3 = project.add_maintainer(user4) - create(:group_member, :minimal_access, user: create(:user), source: group) + it 'does not return members of parent group with minimal access' do + nested_group.request_access(user1) + member1 = group.add_maintainer(user2) + member2 = nested_group.add_maintainer(user3) + member3 = project.add_maintainer(user4) + create(:group_member, :minimal_access, user: create(:user), source: group) - result = described_class.new(project, user2).execute + result = described_class.new(project, user2).execute - expect(result).to contain_exactly(member1, member2, member3) - end + expect(result).to contain_exactly(member1, member2, member3) + end - it 'includes only non-invite members if user do not have amdin permissions on project' do - create(:project_member, :invited, project: project, invite_email: create(:user).email) - member1 = project.add_maintainer(user1) - member2 = project.add_developer(user2) + it 'includes only non-invite members if user do not have amdin permissions on project' do + create(:project_member, :invited, project: project, invite_email: create(:user).email) + member1 = project.add_maintainer(user1) + member2 = project.add_developer(user2) - result = described_class.new(project, user2).execute(include_relations: [:direct]) + result = described_class.new(project, user2).execute(include_relations: [:direct]) - expect(result).to contain_exactly(member1, member2) - end + expect(result).to contain_exactly(member1, member2) + end - it 'includes invited members if user have admin permissions on project' do - member_invite = create(:project_member, :invited, project: project, invite_email: create(:user).email) - member1 = project.add_maintainer(user1) - member2 = project.add_maintainer(user2) + it 'includes invited members if user have admin permissions on project' do + member_invite = create(:project_member, :invited, project: project, invite_email: create(:user).email) + member1 = project.add_maintainer(user1) + member2 = project.add_maintainer(user2) - result = described_class.new(project, user2).execute(include_relations: [:direct]) + result = described_class.new(project, user2).execute(include_relations: [:direct]) - expect(result).to contain_exactly(member1, member2, member_invite) - end + expect(result).to contain_exactly(member1, member2, member_invite) + end - it 'includes nested group members if asked', :nested_groups do - nested_group.request_access(user1) - member1 = group.add_maintainer(user2) - member2 = nested_group.add_maintainer(user3) - member3 = project.add_maintainer(user4) + it 'includes nested group members if asked', :nested_groups do + nested_group.request_access(user1) + member1 = group.add_maintainer(user2) + member2 = nested_group.add_maintainer(user3) + member3 = project.add_maintainer(user4) - result = described_class.new(project, user2).execute(include_relations: [:direct, :descendants]) + result = described_class.new(project, user2).execute(include_relations: [:direct, :descendants]) - expect(result).to contain_exactly(member1, member2, member3) - end + expect(result).to contain_exactly(member1, member2, member3) + end - it 'returns only members of project if asked' do - nested_group.request_access(user1) - group.add_maintainer(user2) - nested_group.add_maintainer(user3) - member4 = project.add_maintainer(user4) + it 'returns only members of project if asked' do + nested_group.request_access(user1) + group.add_maintainer(user2) + nested_group.add_maintainer(user3) + member4 = project.add_maintainer(user4) - result = described_class.new(project, user2).execute(include_relations: [:direct]) + result = described_class.new(project, user2).execute(include_relations: [:direct]) - expect(result).to contain_exactly(member4) - end + expect(result).to contain_exactly(member4) + end - it 'returns only inherited members of project if asked' do - nested_group.request_access(user1) - member2 = group.add_maintainer(user2) - member3 = nested_group.add_maintainer(user3) - project.add_maintainer(user4) + it 'returns only inherited members of project if asked' do + nested_group.request_access(user1) + member2 = group.add_maintainer(user2) + member3 = nested_group.add_maintainer(user3) + project.add_maintainer(user4) - result = described_class.new(project, user2).execute(include_relations: [:inherited]) + result = described_class.new(project, user2).execute(include_relations: [:inherited]) - expect(result).to contain_exactly(member2, member3) - end + expect(result).to contain_exactly(member2, member3) + end - it 'returns only inherited members of a personal project' do - project = create(:project, namespace: user1.namespace) - member = project.members.first + it 'returns only inherited members of a personal project' do + project = create(:project, namespace: user1.namespace) + member = project.members.first - result = described_class.new(project, user1).execute(include_relations: [:inherited]) + result = described_class.new(project, user1).execute(include_relations: [:inherited]) - expect(result).to contain_exactly(member) - end + expect(result).to contain_exactly(member) + end - it 'returns the members.access_level when the user is invited', :nested_groups do - member_invite = create(:project_member, :invited, project: project, invite_email: create(:user).email) - member1 = group.add_maintainer(user2) + it 'returns the members.access_level when the user is invited', :nested_groups do + member_invite = create(:project_member, :invited, project: project, invite_email: create(:user).email) + member1 = group.add_maintainer(user2) - result = described_class.new(project, user2).execute(include_relations: [:direct, :descendants]) + result = described_class.new(project, user2).execute(include_relations: [:direct, :descendants]) - expect(result).to contain_exactly(member1, member_invite) - expect(result.last.access_level).to eq(member_invite.access_level) - end + expect(result).to contain_exactly(member1, member_invite) + expect(result.last.access_level).to eq(member_invite.access_level) + end - it 'returns the highest access_level for the user', :nested_groups do - member1 = project.add_guest(user1) - group.add_developer(user1) - nested_group.add_reporter(user1) + it 'returns the highest access_level for the user', :nested_groups do + member1 = project.add_guest(user1) + group.add_developer(user1) + nested_group.add_reporter(user1) - result = described_class.new(project, user1).execute(include_relations: [:direct, :descendants]) + result = described_class.new(project, user1).execute(include_relations: [:direct, :descendants]) - expect(result).to contain_exactly(member1) - expect(result.first.access_level).to eq(Gitlab::Access::DEVELOPER) - end + expect(result).to contain_exactly(member1) + expect(result.first.access_level).to eq(Gitlab::Access::DEVELOPER) + end - it 'returns searched members if requested' do - project.add_maintainer(user2) - project.add_maintainer(user3) - member3 = project.add_maintainer(user4) + it 'returns searched members if requested' do + project.add_maintainer(user2) + project.add_maintainer(user3) + member3 = project.add_maintainer(user4) - result = described_class.new(project, user2, params: { search: user4.name }).execute + result = described_class.new(project, user2, params: { search: user4.name }).execute - expect(result).to contain_exactly(member3) - end + expect(result).to contain_exactly(member3) + end - it 'returns members sorted by id_desc' do - member1 = project.add_maintainer(user2) - member2 = project.add_maintainer(user3) - member3 = project.add_maintainer(user4) + it 'returns members sorted by id_desc' do + member1 = project.add_maintainer(user2) + member2 = project.add_maintainer(user3) + member3 = project.add_maintainer(user4) - result = described_class.new(project, user2, params: { sort: 'id_desc' }).execute + result = described_class.new(project, user2, params: { sort: 'id_desc' }).execute - expect(result).to eq([member3, member2, member1]) - end + expect(result).to eq([member3, member2, member1]) + end - context 'when :invited_groups is passed' do - shared_examples 'with invited_groups param' do - subject { described_class.new(project, user2).execute(include_relations: [:inherited, :direct, :invited_groups]) } + context 'when :invited_groups is passed' do + shared_examples 'with invited_groups param' do + subject { described_class.new(project, user2).execute(include_relations: [:inherited, :direct, :invited_groups]) } - let_it_be(:linked_group) { create(:group, :public) } - let_it_be(:nested_linked_group) { create(:group, parent: linked_group) } - let_it_be(:linked_group_member) { linked_group.add_guest(user1) } - let_it_be(:nested_linked_group_member) { nested_linked_group.add_guest(user2) } + let_it_be(:linked_group) { create(:group, :public) } + let_it_be(:nested_linked_group) { create(:group, parent: linked_group) } + let_it_be(:linked_group_member) { linked_group.add_guest(user1) } + let_it_be(:nested_linked_group_member) { nested_linked_group.add_guest(user2) } - it 'includes all the invited_groups members including members inherited from ancestor groups' do - create(:project_group_link, project: project, group: nested_linked_group) + it 'includes all the invited_groups members including members inherited from ancestor groups' do + create(:project_group_link, project: project, group: nested_linked_group) - expect(subject).to contain_exactly(linked_group_member, nested_linked_group_member) - end + expect(subject).to contain_exactly(linked_group_member, nested_linked_group_member) + end - it 'includes all the invited_groups members' do - create(:project_group_link, project: project, group: linked_group) + it 'includes all the invited_groups members' do + create(:project_group_link, project: project, group: linked_group) - expect(subject).to contain_exactly(linked_group_member) - end + expect(subject).to contain_exactly(linked_group_member) + end - it 'excludes group_members not visible to the user' do - create(:project_group_link, project: project, group: linked_group) - private_linked_group = create(:group, :private) - private_linked_group.add_developer(user3) - create(:project_group_link, project: project, group: private_linked_group) + it 'excludes group_members not visible to the user' do + create(:project_group_link, project: project, group: linked_group) + private_linked_group = create(:group, :private) + private_linked_group.add_developer(user3) + create(:project_group_link, project: project, group: private_linked_group) - expect(subject).to contain_exactly(linked_group_member) - end + expect(subject).to contain_exactly(linked_group_member) + end - context 'when the user is a member of invited group and ancestor groups' do - it 'returns the highest access_level for the user limited by project_group_link.group_access', :nested_groups do - create(:project_group_link, project: project, group: nested_linked_group, group_access: Gitlab::Access::REPORTER) - nested_linked_group.add_developer(user1) + context 'when the user is a member of invited group and ancestor groups' do + it 'returns the highest access_level for the user limited by project_group_link.group_access', :nested_groups do + create(:project_group_link, project: project, group: nested_linked_group, group_access: Gitlab::Access::REPORTER) + nested_linked_group.add_developer(user1) - expect(subject.map(&:user)).to contain_exactly(user1, user2) - expect(subject.max_by(&:access_level).access_level).to eq(Gitlab::Access::REPORTER) + expect(subject.map(&:user)).to contain_exactly(user1, user2) + expect(subject.max_by(&:access_level).access_level).to eq(Gitlab::Access::REPORTER) + end end end + + it_behaves_like 'with invited_groups param' + end + end + + it_behaves_like '#execute' + + context 'when project_members_index_by_project_namespace feature flag is disabled' do + before do + stub_feature_flags(project_members_index_by_project_namespace: false) end - it_behaves_like 'with invited_groups param' + it_behaves_like '#execute' end end |