diff options
Diffstat (limited to 'spec/frontend/diffs/store/actions_spec.js')
-rw-r--r-- | spec/frontend/diffs/store/actions_spec.js | 51 |
1 files changed, 35 insertions, 16 deletions
diff --git a/spec/frontend/diffs/store/actions_spec.js b/spec/frontend/diffs/store/actions_spec.js index 85734e05aeb..b5003a54917 100644 --- a/spec/frontend/diffs/store/actions_spec.js +++ b/spec/frontend/diffs/store/actions_spec.js @@ -99,6 +99,10 @@ describe('DiffsStoreActions', () => { const projectPath = '/root/project'; const dismissEndpoint = '/-/user_callouts'; const showSuggestPopover = false; + const mrReviews = { + a: ['z', 'hash:a'], + b: ['y', 'hash:a'], + }; testAction( setBaseConfig, @@ -110,6 +114,7 @@ describe('DiffsStoreActions', () => { projectPath, dismissEndpoint, showSuggestPopover, + mrReviews, }, { endpoint: '', @@ -131,8 +136,21 @@ describe('DiffsStoreActions', () => { projectPath, dismissEndpoint, showSuggestPopover, + mrReviews, }, }, + { + type: types.SET_DIFF_FILE_VIEWED, + payload: { id: 'z', seen: true }, + }, + { + type: types.SET_DIFF_FILE_VIEWED, + payload: { id: 'a', seen: true }, + }, + { + type: types.SET_DIFF_FILE_VIEWED, + payload: { id: 'y', seen: true }, + }, ], [], done, @@ -190,10 +208,10 @@ describe('DiffsStoreActions', () => { { type: types.SET_RETRIEVING_BATCHES, payload: true }, { type: types.SET_DIFF_DATA_BATCH, payload: { diff_files: res1.diff_files } }, { type: types.SET_BATCH_LOADING_STATE, payload: 'loaded' }, - { type: types.VIEW_DIFF_FILE, payload: 'test' }, + { type: types.SET_CURRENT_DIFF_FILE, payload: 'test' }, { type: types.SET_DIFF_DATA_BATCH, payload: { diff_files: res2.diff_files } }, { type: types.SET_BATCH_LOADING_STATE, payload: 'loaded' }, - { type: types.VIEW_DIFF_FILE, payload: 'test2' }, + { type: types.SET_CURRENT_DIFF_FILE, payload: 'test2' }, { type: types.SET_RETRIEVING_BATCHES, payload: false }, { type: types.SET_BATCH_LOADING_STATE, payload: 'error' }, ], @@ -307,7 +325,7 @@ describe('DiffsStoreActions', () => { it('should mark currently selected diff and set lineHash and fileHash of highlightedRow', () => { testAction(setHighlightedRow, 'ABC_123', {}, [ { type: types.SET_HIGHLIGHTED_ROW, payload: 'ABC_123' }, - { type: types.VIEW_DIFF_FILE, payload: 'ABC' }, + { type: types.SET_CURRENT_DIFF_FILE, payload: 'ABC' }, ]); }); }); @@ -890,12 +908,12 @@ describe('DiffsStoreActions', () => { }, }; - scrollToFile({ state, commit, getters }, 'path'); + scrollToFile({ state, commit, getters }, { path: 'path' }); expect(document.location.hash).toBe('#test'); }); - it('commits VIEW_DIFF_FILE', () => { + it('commits SET_CURRENT_DIFF_FILE', () => { const state = { treeEntries: { path: { @@ -904,9 +922,9 @@ describe('DiffsStoreActions', () => { }, }; - scrollToFile({ state, commit, getters }, 'path'); + scrollToFile({ state, commit, getters }, { path: 'path' }); - expect(commit).toHaveBeenCalledWith(types.VIEW_DIFF_FILE, 'test'); + expect(commit).toHaveBeenCalledWith(types.SET_CURRENT_DIFF_FILE, 'test'); }); }); @@ -1428,7 +1446,7 @@ describe('DiffsStoreActions', () => { }); describe('setCurrentDiffFileIdFromNote', () => { - it('commits VIEW_DIFF_FILE', () => { + it('commits SET_CURRENT_DIFF_FILE', () => { const commit = jest.fn(); const state = { diffFiles: [{ file_hash: '123' }] }; const rootGetters = { @@ -1438,10 +1456,10 @@ describe('DiffsStoreActions', () => { setCurrentDiffFileIdFromNote({ commit, state, rootGetters }, '1'); - expect(commit).toHaveBeenCalledWith(types.VIEW_DIFF_FILE, '123'); + expect(commit).toHaveBeenCalledWith(types.SET_CURRENT_DIFF_FILE, '123'); }); - it('does not commit VIEW_DIFF_FILE when discussion has no diff_file', () => { + it('does not commit SET_CURRENT_DIFF_FILE when discussion has no diff_file', () => { const commit = jest.fn(); const state = { diffFiles: [{ file_hash: '123' }] }; const rootGetters = { @@ -1454,7 +1472,7 @@ describe('DiffsStoreActions', () => { expect(commit).not.toHaveBeenCalled(); }); - it('does not commit VIEW_DIFF_FILE when diff file does not exist', () => { + it('does not commit SET_CURRENT_DIFF_FILE when diff file does not exist', () => { const commit = jest.fn(); const state = { diffFiles: [{ file_hash: '123' }] }; const rootGetters = { @@ -1469,12 +1487,12 @@ describe('DiffsStoreActions', () => { }); describe('navigateToDiffFileIndex', () => { - it('commits VIEW_DIFF_FILE', (done) => { + it('commits SET_CURRENT_DIFF_FILE', (done) => { testAction( navigateToDiffFileIndex, 0, { diffFiles: [{ file_hash: '123' }] }, - [{ type: types.VIEW_DIFF_FILE, payload: '123' }], + [{ type: types.SET_CURRENT_DIFF_FILE, payload: '123' }], [], done, ); @@ -1523,13 +1541,14 @@ describe('DiffsStoreActions', () => { describe('reviewFile', () => { const file = { id: '123', + file_hash: 'xyz', file_identifier_hash: 'abc', load_collapsed_diff_url: 'gitlab-org/gitlab-test/-/merge_requests/1/diffs', }; it.each` - reviews | diffFile | reviewed - ${{ abc: ['123'] }} | ${file} | ${true} - ${{}} | ${file} | ${false} + reviews | diffFile | reviewed + ${{ abc: ['123', 'hash:xyz'] }} | ${file} | ${true} + ${{}} | ${file} | ${false} `( 'sets reviews ($reviews) to localStorage and state for file $file if it is marked reviewed=$reviewed', ({ reviews, diffFile, reviewed }) => { |