diff options
Diffstat (limited to 'spec/frontend/releases/components/release_block_milestone_info_spec.js')
-rw-r--r-- | spec/frontend/releases/components/release_block_milestone_info_spec.js | 32 |
1 files changed, 9 insertions, 23 deletions
diff --git a/spec/frontend/releases/components/release_block_milestone_info_spec.js b/spec/frontend/releases/components/release_block_milestone_info_spec.js index bb34693c757..4eb15e9da12 100644 --- a/spec/frontend/releases/components/release_block_milestone_info_spec.js +++ b/spec/frontend/releases/components/release_block_milestone_info_spec.js @@ -12,7 +12,7 @@ describe('Release block milestone info', () => { let wrapper; let milestones; - const factory = props => { + const factory = (props) => { wrapper = mount(ReleaseBlockMilestoneInfo, { propsData: props, }); @@ -54,22 +54,10 @@ describe('Release block milestone info', () => { }); it('renders a list of links to all associated milestones', () => { - // The API currently returns the milestones in a non-deterministic order, - // which causes the frontend fixture used by this test to return the - // milestones in one order locally and a different order in the CI pipeline. - // This is a bug and is tracked here: https://gitlab.com/gitlab-org/gitlab/-/issues/259012 - // When this bug is fixed this expectation should be updated to - // assert the expected order. - const containerText = trimText(milestoneListContainer().text()); - expect( - containerText.includes('Milestones 12.4 • 12.3') || - containerText.includes('Milestones 12.3 • 12.4'), - ).toBe(true); + expect(milestoneListContainer().text()).toMatchInterpolatedText('Milestones 12.3 • 12.4'); milestones.forEach((m, i) => { - const milestoneLink = milestoneListContainer() - .findAll(GlLink) - .at(i); + const milestoneLink = milestoneListContainer().findAll(GlLink).at(i); expect(milestoneLink.text()).toBe(m.title); expect(milestoneLink.attributes('href')).toBe(m.webUrl); @@ -108,19 +96,17 @@ describe('Release block milestone info', () => { }); } - fullListString = lotsOfMilestones.map(m => m.title).join(' • '); + fullListString = lotsOfMilestones.map((m) => m.title).join(' • '); abbreviatedListString = lotsOfMilestones .slice(0, MAX_MILESTONES_TO_DISPLAY) - .map(m => m.title) + .map((m) => m.title) .join(' • '); return factory({ milestones: lotsOfMilestones }); }); const clickShowMoreFewerButton = () => { - milestoneListContainer() - .find(GlButton) - .trigger('click'); + milestoneListContainer().find(GlButton).trigger('click'); return wrapper.vm.$nextTick(); }; @@ -161,7 +147,7 @@ describe('Release block milestone info', () => { /** Ensures we don't have any issues with dividing by zero when computing percentages */ describe('when all issue counts are zero', () => { beforeEach(() => { - milestones = milestones.map(m => ({ + milestones = milestones.map((m) => ({ ...m, issueStats: { ...m.issueStats, @@ -178,7 +164,7 @@ describe('Release block milestone info', () => { describe('if the API response is missing the "issue_stats" property', () => { beforeEach(() => { - milestones = milestones.map(m => ({ + milestones = milestones.map((m) => ({ ...m, issueStats: undefined, })); @@ -199,7 +185,7 @@ describe('Release block milestone info', () => { describe('if the API response includes the "mr_stats" property', () => { beforeEach(() => { - milestones = milestones.map(m => ({ + milestones = milestones.map((m) => ({ ...m, mrStats: { total: 15, |