diff options
Diffstat (limited to 'spec/graphql/mutations')
19 files changed, 202 insertions, 20 deletions
diff --git a/spec/graphql/mutations/alert_management/alerts/set_assignees_spec.rb b/spec/graphql/mutations/alert_management/alerts/set_assignees_spec.rb index a025b3d344a..f8b61c5064a 100644 --- a/spec/graphql/mutations/alert_management/alerts/set_assignees_spec.rb +++ b/spec/graphql/mutations/alert_management/alerts/set_assignees_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::AlertManagement::Alerts::SetAssignees do +RSpec.describe Mutations::AlertManagement::Alerts::SetAssignees do let_it_be(:starting_assignee) { create(:user) } let_it_be(:unassigned_user) { create(:user) } let_it_be(:alert) { create(:alert_management_alert, assignees: [starting_assignee]) } diff --git a/spec/graphql/mutations/alert_management/alerts/todo/create_spec.rb b/spec/graphql/mutations/alert_management/alerts/todo/create_spec.rb new file mode 100644 index 00000000000..11ee40a4c7e --- /dev/null +++ b/spec/graphql/mutations/alert_management/alerts/todo/create_spec.rb @@ -0,0 +1,58 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Mutations::AlertManagement::Alerts::Todo::Create do + subject(:mutation) { described_class.new(object: project, context: { current_user: current_user }, field: nil) } + + let_it_be(:alert) { create(:alert_management_alert) } + let_it_be(:project) { alert.project } + let(:current_user) { project.owner } + + let(:args) { { project_path: project.full_path, iid: alert.iid } } + + specify { expect(described_class).to require_graphql_authorizations(:update_alert_management_alert) } + + describe '#resolve' do + subject(:resolve) { mutation.resolve(args) } + + context 'when user does not have permissions' do + let(:current_user) { nil } + + specify { expect { resolve }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable) } + end + + context 'when project is invalid' do + let(:args) { { project_path: 'bunk/path', iid: alert.iid } } + + specify { expect { resolve }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable) } + end + + context 'when alert is invalid' do + let(:args) { { project_path: project.full_path, iid: "-1" } } + + specify { expect { resolve }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable) } + end + + context 'when the create service yields errors' do + let(:error_response) { double(error?: true, message: 'error', payload: { alert: {} }) } + + before do + allow_next_instance_of(::AlertManagement::Alerts::Todo::CreateService) do |service| + allow(service).to receive(:execute).and_return(error_response) + end + end + + specify { expect { resolve }.not_to change(Todo, :count) } + specify { expect(resolve[:errors]).to eq([error_response.message]) } + end + + context 'with valid inputs' do + it 'creates a new todo' do + expect { resolve }.to change { Todo.where(user: current_user, action: Todo::MARKED).count }.by(1) + end + + it { is_expected.to eq(alert: alert, todo: Todo.last, errors: []) } + end + end +end diff --git a/spec/graphql/mutations/alert_management/update_alert_status_spec.rb b/spec/graphql/mutations/alert_management/update_alert_status_spec.rb index 68513c02040..a224b564de9 100644 --- a/spec/graphql/mutations/alert_management/update_alert_status_spec.rb +++ b/spec/graphql/mutations/alert_management/update_alert_status_spec.rb @@ -39,7 +39,7 @@ RSpec.describe Mutations::AlertManagement::UpdateAlertStatus do allow(alert).to receive(:save).and_return(false) allow(alert).to receive(:errors).and_return( - double(full_messages: %w(foo bar)) + double(full_messages: %w(foo bar), :[] => nil) ) expect(resolve).to eq( alert: alert, diff --git a/spec/graphql/mutations/concerns/mutations/resolves_issuable_spec.rb b/spec/graphql/mutations/concerns/mutations/resolves_issuable_spec.rb index 706a54931ea..8af3868ba98 100644 --- a/spec/graphql/mutations/concerns/mutations/resolves_issuable_spec.rb +++ b/spec/graphql/mutations/concerns/mutations/resolves_issuable_spec.rb @@ -3,26 +3,31 @@ require 'spec_helper' RSpec.describe Mutations::ResolvesIssuable do + include GraphqlHelpers + let_it_be(:mutation_class) do Class.new(Mutations::BaseMutation) do include Mutations::ResolvesIssuable end end - let_it_be(:project) { create(:project) } + let_it_be(:project) { create(:project, :empty_repo) } let_it_be(:user) { create(:user) } let_it_be(:context) { { current_user: user } } - let_it_be(:mutation) { mutation_class.new(object: nil, context: context, field: nil) } + let(:mutation) { mutation_class.new(object: nil, context: context, field: nil) } let(:parent) { issuable.project } + let_it_be(:issue) { create(:issue, project: project) } + let_it_be(:merge_request) { create(:merge_request, source_project: project) } + context 'with issues' do - let(:issuable) { create(:issue, project: project) } + let(:issuable) { issue } it_behaves_like 'resolving an issuable in GraphQL', :issue end context 'with merge requests' do - let(:issuable) { create(:merge_request, source_project: project) } + let(:issuable) { merge_request } it_behaves_like 'resolving an issuable in GraphQL', :merge_request end diff --git a/spec/graphql/mutations/container_expiration_policies/update_spec.rb b/spec/graphql/mutations/container_expiration_policies/update_spec.rb index fc90f437576..6aedaab3b53 100644 --- a/spec/graphql/mutations/container_expiration_policies/update_spec.rb +++ b/spec/graphql/mutations/container_expiration_policies/update_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::ContainerExpirationPolicies::Update do +RSpec.describe Mutations::ContainerExpirationPolicies::Update do using RSpec::Parameterized::TableSyntax let_it_be(:project, reload: true) { create(:project) } diff --git a/spec/graphql/mutations/issues/set_locked_spec.rb b/spec/graphql/mutations/issues/set_locked_spec.rb new file mode 100644 index 00000000000..10438226c17 --- /dev/null +++ b/spec/graphql/mutations/issues/set_locked_spec.rb @@ -0,0 +1,46 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Mutations::Issues::SetLocked do + let_it_be(:issue) { create(:issue) } + let_it_be(:user) { create(:user) } + + subject(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) } + + specify { expect(described_class).to require_graphql_authorizations(:update_issue) } + + describe '#resolve' do + let(:locked) { true } + + subject { mutation.resolve(project_path: issue.project.full_path, iid: issue.iid, locked: locked) } + + it 'raises an error if the resource is not accessible to the user' do + expect { subject }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable) + end + + context 'when the user can update the issue' do + let(:mutated_issue) { subject[:issue] } + + before do + issue.project.add_developer(user) + end + + it 'returns the issue as discussion locked' do + expect(mutated_issue).to eq(issue) + expect(mutated_issue).to be_discussion_locked + expect(subject[:errors]).to be_empty + end + + context 'when passing locked as false' do + let(:locked) { false } + + it 'unlocks the discussion' do + issue.update!(discussion_locked: true) + + expect(mutated_issue).not_to be_discussion_locked + end + end + end + end +end diff --git a/spec/graphql/mutations/issues/update_spec.rb b/spec/graphql/mutations/issues/update_spec.rb index 8c3d01918fd..9a847476e2e 100644 --- a/spec/graphql/mutations/issues/update_spec.rb +++ b/spec/graphql/mutations/issues/update_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::Issues::Update do +RSpec.describe Mutations::Issues::Update do let(:issue) { create(:issue) } let(:user) { create(:user) } let(:expected_attributes) do diff --git a/spec/graphql/mutations/merge_requests/create_spec.rb b/spec/graphql/mutations/merge_requests/create_spec.rb index 88acd3ed5b6..ae31790f1f9 100644 --- a/spec/graphql/mutations/merge_requests/create_spec.rb +++ b/spec/graphql/mutations/merge_requests/create_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::MergeRequests::Create do +RSpec.describe Mutations::MergeRequests::Create do subject(:mutation) { described_class.new(object: nil, context: context, field: nil) } let_it_be(:project) { create(:project, :public, :repository) } diff --git a/spec/graphql/mutations/merge_requests/set_assignees_spec.rb b/spec/graphql/mutations/merge_requests/set_assignees_spec.rb index d88c5db05c9..0e7abb849c4 100644 --- a/spec/graphql/mutations/merge_requests/set_assignees_spec.rb +++ b/spec/graphql/mutations/merge_requests/set_assignees_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::MergeRequests::SetAssignees do +RSpec.describe Mutations::MergeRequests::SetAssignees do let(:merge_request) { create(:merge_request) } let(:user) { create(:user) } diff --git a/spec/graphql/mutations/merge_requests/set_labels_spec.rb b/spec/graphql/mutations/merge_requests/set_labels_spec.rb index 0fd2c20a5c8..62a7f650f84 100644 --- a/spec/graphql/mutations/merge_requests/set_labels_spec.rb +++ b/spec/graphql/mutations/merge_requests/set_labels_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::MergeRequests::SetLabels do +RSpec.describe Mutations::MergeRequests::SetLabels do let(:merge_request) { create(:merge_request) } let(:user) { create(:user) } diff --git a/spec/graphql/mutations/merge_requests/set_locked_spec.rb b/spec/graphql/mutations/merge_requests/set_locked_spec.rb index d5219c781fd..aca7df5445f 100644 --- a/spec/graphql/mutations/merge_requests/set_locked_spec.rb +++ b/spec/graphql/mutations/merge_requests/set_locked_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::MergeRequests::SetLocked do +RSpec.describe Mutations::MergeRequests::SetLocked do let(:merge_request) { create(:merge_request) } let(:user) { create(:user) } diff --git a/spec/graphql/mutations/merge_requests/set_milestone_spec.rb b/spec/graphql/mutations/merge_requests/set_milestone_spec.rb index d77ec4de4d0..1c0d655ee83 100644 --- a/spec/graphql/mutations/merge_requests/set_milestone_spec.rb +++ b/spec/graphql/mutations/merge_requests/set_milestone_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::MergeRequests::SetMilestone do +RSpec.describe Mutations::MergeRequests::SetMilestone do let(:merge_request) { create(:merge_request) } let(:user) { create(:user) } diff --git a/spec/graphql/mutations/merge_requests/set_subscription_spec.rb b/spec/graphql/mutations/merge_requests/set_subscription_spec.rb index cf569a74aa9..20cfed9dd3d 100644 --- a/spec/graphql/mutations/merge_requests/set_subscription_spec.rb +++ b/spec/graphql/mutations/merge_requests/set_subscription_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::MergeRequests::SetSubscription do +RSpec.describe Mutations::MergeRequests::SetSubscription do let(:merge_request) { create(:merge_request) } let(:project) { merge_request.project } let(:user) { create(:user) } diff --git a/spec/graphql/mutations/merge_requests/set_wip_spec.rb b/spec/graphql/mutations/merge_requests/set_wip_spec.rb index 7255d0fe7d7..b6cb49724fa 100644 --- a/spec/graphql/mutations/merge_requests/set_wip_spec.rb +++ b/spec/graphql/mutations/merge_requests/set_wip_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::MergeRequests::SetWip do +RSpec.describe Mutations::MergeRequests::SetWip do let(:merge_request) { create(:merge_request) } let(:user) { create(:user) } diff --git a/spec/graphql/mutations/merge_requests/update_spec.rb b/spec/graphql/mutations/merge_requests/update_spec.rb new file mode 100644 index 00000000000..4a1fdf6e74b --- /dev/null +++ b/spec/graphql/mutations/merge_requests/update_spec.rb @@ -0,0 +1,68 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe Mutations::MergeRequests::Update do + let(:merge_request) { create(:merge_request) } + let(:user) { create(:user) } + + subject(:mutation) { described_class.new(object: nil, context: { current_user: user }, field: nil) } + + specify { expect(described_class).to require_graphql_authorizations(:update_merge_request) } + + describe '#resolve' do + let(:attributes) { { title: 'new title', description: 'new description', target_branch: 'new-branch' } } + let(:mutated_merge_request) { subject[:merge_request] } + + subject do + mutation.resolve(project_path: merge_request.project.full_path, iid: merge_request.iid, **attributes) + end + + it 'raises an error if the resource is not accessible to the user' do + expect { subject }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable) + end + + context 'when the user can update the merge request' do + before do + merge_request.project.add_developer(user) + end + + it 'applies all attributes' do + expect(mutated_merge_request).to eq(merge_request) + expect(mutated_merge_request).to have_attributes(attributes) + expect(subject[:errors]).to be_empty + end + + context 'the merge request is invalid' do + before do + merge_request.allow_broken = true + merge_request.update!(source_project: nil) + end + + it 'returns error information, and changes were not applied' do + expect(mutated_merge_request).not_to have_attributes(attributes) + expect(subject[:errors]).not_to be_empty + end + end + + context 'our change is invalid' do + let(:attributes) { { target_branch: 'this is not a branch' } } + + it 'returns error information, and changes were not applied' do + expect(mutated_merge_request).not_to have_attributes(attributes) + expect(subject[:errors]).not_to be_empty + end + end + + context 'when passing subset of attributes' do + let(:attributes) { { title: 'no, this title' } } + + it 'only changes the mentioned attributes' do + expect { subject }.not_to change { merge_request.reset.description } + + expect(mutated_merge_request).to have_attributes(attributes) + end + end + end + end +end diff --git a/spec/graphql/mutations/todos/mark_all_done_spec.rb b/spec/graphql/mutations/todos/mark_all_done_spec.rb index 4af00307969..2f167164050 100644 --- a/spec/graphql/mutations/todos/mark_all_done_spec.rb +++ b/spec/graphql/mutations/todos/mark_all_done_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::Todos::MarkAllDone do +RSpec.describe Mutations::Todos::MarkAllDone do include GraphqlHelpers let_it_be(:current_user) { create(:user) } @@ -21,7 +21,7 @@ describe Mutations::Todos::MarkAllDone do describe '#resolve' do it 'marks all pending todos as done' do - updated_todo_ids = mutation_for(current_user).resolve.dig(:updated_ids) + updated_todo_ids, todos = mutation_for(current_user).resolve.values_at(:updated_ids, :todos) expect(todo1.reload.state).to eq('done') expect(todo2.reload.state).to eq('done') @@ -29,6 +29,7 @@ describe Mutations::Todos::MarkAllDone do expect(other_user_todo.reload.state).to eq('pending') expect(updated_todo_ids).to contain_exactly(global_id_of(todo1), global_id_of(todo3)) + expect(todos).to contain_exactly(todo1, todo3) end it 'behaves as expected if there are no todos for the requesting user' do diff --git a/spec/graphql/mutations/todos/mark_done_spec.rb b/spec/graphql/mutations/todos/mark_done_spec.rb index 44065f83f74..51ad3e1a5d7 100644 --- a/spec/graphql/mutations/todos/mark_done_spec.rb +++ b/spec/graphql/mutations/todos/mark_done_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::Todos::MarkDone do +RSpec.describe Mutations::Todos::MarkDone do include GraphqlHelpers let_it_be(:current_user) { create(:user) } diff --git a/spec/graphql/mutations/todos/restore_many_spec.rb b/spec/graphql/mutations/todos/restore_many_spec.rb index 8f4a8985f9e..b3b3e057745 100644 --- a/spec/graphql/mutations/todos/restore_many_spec.rb +++ b/spec/graphql/mutations/todos/restore_many_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::Todos::RestoreMany do +RSpec.describe Mutations::Todos::RestoreMany do let_it_be(:current_user) { create(:user) } let_it_be(:author) { create(:user) } let_it_be(:other_user) { create(:user) } @@ -25,6 +25,8 @@ describe Mutations::Todos::RestoreMany do todo_ids = result[:updated_ids] expect(todo_ids.size).to eq(1) expect(todo_ids.first).to eq(todo1.to_global_id.to_s) + + expect(result[:todos]).to contain_exactly(todo1) end it 'handles a todo which is already pending as expected' do @@ -33,6 +35,7 @@ describe Mutations::Todos::RestoreMany do expect_states_were_not_changed expect(result[:updated_ids]).to eq([]) + expect(result[:todos]).to be_empty end it 'ignores requests for todos which do not belong to the current user' do @@ -56,6 +59,7 @@ describe Mutations::Todos::RestoreMany do returned_todo_ids = result[:updated_ids] expect(returned_todo_ids).to contain_exactly(todo1.to_global_id.to_s, todo4.to_global_id.to_s) + expect(result[:todos]).to contain_exactly(todo1, todo4) expect(todo1.reload.state).to eq('pending') expect(todo2.reload.state).to eq('pending') diff --git a/spec/graphql/mutations/todos/restore_spec.rb b/spec/graphql/mutations/todos/restore_spec.rb index 949ab6a164b..9043d7a44a8 100644 --- a/spec/graphql/mutations/todos/restore_spec.rb +++ b/spec/graphql/mutations/todos/restore_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Mutations::Todos::Restore do +RSpec.describe Mutations::Todos::Restore do let_it_be(:current_user) { create(:user) } let_it_be(:author) { create(:user) } let_it_be(:other_user) { create(:user) } |