1 files changed, 10 insertions, 13 deletions
diff --git a/spec/helpers/wiki_helper_spec.rb b/spec/helpers/wiki_helper_spec.rb
index 75128d758f9..59624dc0682 100644
--- a/spec/helpers/wiki_helper_spec.rb
+++ b/spec/helpers/wiki_helper_spec.rb
@@ -75,41 +75,38 @@ RSpec.describe WikiHelper do
 
   describe '#wiki_sort_controls' do
     let(:wiki) { create(:project_wiki) }
-    let(:wiki_link) { helper.wiki_sort_controls(wiki, sort, direction) }
+    let(:wiki_link) { helper.wiki_sort_controls(wiki, direction) }
     let(:classes) { "gl-button btn btn-default btn-icon has-tooltip reverse-sort-btn qa-reverse-sort rspec-reverse-sort" }
 
-    def expected_link(sort, direction, icon_class)
-      path = "/#{wiki.project.full_path}/-/wikis/pages?direction=#{direction}&sort=#{sort}"
-
-      helper.link_to(path, type: 'button', class: classes, title: 'Sort direction') do
+    def expected_link(direction, icon_class)
+      path = "/#{wiki.project.full_path}/-/wikis/pages?direction=#{direction}"
+      title = direction == 'desc' ? _('Sort direction: Ascending') : _('Sort direction: Descending')
+      helper.link_to(path, type: 'button', class: classes, title: title) do
         helper.sprite_icon("sort-#{icon_class}")
       end
     end
 
     context 'initial call' do
-      let(:sort) { nil }
       let(:direction) { nil }
 
       it 'renders with default values' do
-        expect(wiki_link).to eq(expected_link('title', 'desc', 'lowest'))
+        expect(wiki_link).to eq(expected_link('desc', 'lowest'))
       end
     end
 
-    context 'sort by title' do
-      let(:sort) { 'title' }
+    context 'sort by asc order' do
       let(:direction) { 'asc' }
 
       it 'renders a link with opposite direction' do
-        expect(wiki_link).to eq(expected_link('title', 'desc', 'lowest'))
+        expect(wiki_link).to eq(expected_link('desc', 'lowest'))
       end
     end
 
-    context 'sort by created_at' do
-      let(:sort) { 'created_at' }
+    context 'sort by desc order' do
       let(:direction) { 'desc' }
 
       it 'renders a link with opposite direction' do
-        expect(wiki_link).to eq(expected_link('created_at', 'asc', 'highest'))
+        expect(wiki_link).to eq(expected_link('asc', 'highest'))
       end
     end
   end