diff options
Diffstat (limited to 'spec/lib/api/helpers')
-rw-r--r-- | spec/lib/api/helpers/project_stats_refresh_conflicts_helpers_spec.rb | 49 | ||||
-rw-r--r-- | spec/lib/api/helpers/sse_helpers_spec.rb | 44 |
2 files changed, 49 insertions, 44 deletions
diff --git a/spec/lib/api/helpers/project_stats_refresh_conflicts_helpers_spec.rb b/spec/lib/api/helpers/project_stats_refresh_conflicts_helpers_spec.rb new file mode 100644 index 00000000000..ae5c21e01c3 --- /dev/null +++ b/spec/lib/api/helpers/project_stats_refresh_conflicts_helpers_spec.rb @@ -0,0 +1,49 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe API::Helpers::ProjectStatsRefreshConflictsHelpers do + let_it_be(:project) { create(:project) } + + let(:api_class) do + Class.new do + include API::Helpers::ProjectStatsRefreshConflictsHelpers + end + end + + let(:api_controller) { api_class.new } + + describe '#reject_if_build_artifacts_size_refreshing!' do + let(:entrypoint) { '/some/thing' } + + before do + allow(project).to receive(:refreshing_build_artifacts_size?).and_return(refreshing) + allow(api_controller).to receive_message_chain(:request, :path).and_return(entrypoint) + end + + context 'when project is undergoing stats refresh' do + let(:refreshing) { true } + + it 'logs and returns a 409 conflict error' do + expect(Gitlab::ProjectStatsRefreshConflictsLogger) + .to receive(:warn_request_rejected_during_stats_refresh) + .with(project.id) + + expect(api_controller).to receive(:conflict!) + + api_controller.reject_if_build_artifacts_size_refreshing!(project) + end + end + + context 'when project is not undergoing stats refresh' do + let(:refreshing) { false } + + it 'does nothing' do + expect(Gitlab::ProjectStatsRefreshConflictsLogger).not_to receive(:warn_request_rejected_during_stats_refresh) + expect(api_controller).not_to receive(:conflict) + + api_controller.reject_if_build_artifacts_size_refreshing!(project) + end + end + end +end diff --git a/spec/lib/api/helpers/sse_helpers_spec.rb b/spec/lib/api/helpers/sse_helpers_spec.rb deleted file mode 100644 index 397051d9142..00000000000 --- a/spec/lib/api/helpers/sse_helpers_spec.rb +++ /dev/null @@ -1,44 +0,0 @@ -# frozen_string_literal: true - -require 'spec_helper' - -RSpec.describe API::Helpers::SSEHelpers do - include Gitlab::Routing - - let_it_be(:project) { create(:project) } - - subject { Class.new.include(described_class).new } - - describe '#request_from_sse?' do - before do - allow(subject).to receive(:request).and_return(request) - end - - context 'when referer is nil' do - let(:request) { double(referer: nil)} - - it 'returns false' do - expect(URI).not_to receive(:parse) - expect(subject.request_from_sse?(project)).to eq false - end - end - - context 'when referer is not from SSE' do - let(:request) { double(referer: 'https://gitlab.com')} - - it 'returns false' do - expect(URI).to receive(:parse).and_call_original - expect(subject.request_from_sse?(project)).to eq false - end - end - - context 'when referer is from SSE' do - let(:request) { double(referer: project_show_sse_path(project, 'master/README.md'))} - - it 'returns true' do - expect(URI).to receive(:parse).and_call_original - expect(subject.request_from_sse?(project)).to eq true - end - end - end -end |